* [PATCH] HID: i2c-hid: Report wakeup events
@ 2021-11-02 18:40 Matthias Kaehlcke
2021-11-02 18:58 ` Hans de Goede
2021-11-19 14:50 ` Jiri Kosina
0 siblings, 2 replies; 3+ messages in thread
From: Matthias Kaehlcke @ 2021-11-02 18:40 UTC (permalink / raw)
To: Jiri Kosina, Benjamin Tissoires
Cc: linux-kernel, linux-input, Douglas Anderson, Matthias Kaehlcke,
Arnd Bergmann, Hans de Goede, Jim Broadus, Johnny Chuang,
Nathan Chancellor
The i2c-hid driver generally supports wakeup, bit it currently
doesn't report wakeup events to the PM subsystem. Change that.
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
drivers/hid/i2c-hid/i2c-hid-core.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/hid/i2c-hid/i2c-hid-core.c b/drivers/hid/i2c-hid/i2c-hid-core.c
index 517141138b00..68d9a089e3e8 100644
--- a/drivers/hid/i2c-hid/i2c-hid-core.c
+++ b/drivers/hid/i2c-hid/i2c-hid-core.c
@@ -522,9 +522,12 @@ static void i2c_hid_get_input(struct i2c_hid *ihid)
i2c_hid_dbg(ihid, "input: %*ph\n", ret_size, ihid->inbuf);
- if (test_bit(I2C_HID_STARTED, &ihid->flags))
+ if (test_bit(I2C_HID_STARTED, &ihid->flags)) {
+ pm_wakeup_event(&ihid->client->dev, 0);
+
hid_input_report(ihid->hid, HID_INPUT_REPORT, ihid->inbuf + 2,
ret_size - 2, 1);
+ }
return;
}
--
2.33.1.1089.g2158813163f-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] HID: i2c-hid: Report wakeup events
2021-11-02 18:40 [PATCH] HID: i2c-hid: Report wakeup events Matthias Kaehlcke
@ 2021-11-02 18:58 ` Hans de Goede
2021-11-19 14:50 ` Jiri Kosina
1 sibling, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2021-11-02 18:58 UTC (permalink / raw)
To: Matthias Kaehlcke, Jiri Kosina, Benjamin Tissoires
Cc: linux-kernel, linux-input, Douglas Anderson, Arnd Bergmann,
Jim Broadus, Johnny Chuang, Nathan Chancellor
Hi,
On 11/2/21 19:40, Matthias Kaehlcke wrote:
> The i2c-hid driver generally supports wakeup, bit it currently
> doesn't report wakeup events to the PM subsystem. Change that.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Thanks, this looks reasonable to me:
Acked-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
>
> drivers/hid/i2c-hid/i2c-hid-core.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hid/i2c-hid/i2c-hid-core.c b/drivers/hid/i2c-hid/i2c-hid-core.c
> index 517141138b00..68d9a089e3e8 100644
> --- a/drivers/hid/i2c-hid/i2c-hid-core.c
> +++ b/drivers/hid/i2c-hid/i2c-hid-core.c
> @@ -522,9 +522,12 @@ static void i2c_hid_get_input(struct i2c_hid *ihid)
>
> i2c_hid_dbg(ihid, "input: %*ph\n", ret_size, ihid->inbuf);
>
> - if (test_bit(I2C_HID_STARTED, &ihid->flags))
> + if (test_bit(I2C_HID_STARTED, &ihid->flags)) {
> + pm_wakeup_event(&ihid->client->dev, 0);
> +
> hid_input_report(ihid->hid, HID_INPUT_REPORT, ihid->inbuf + 2,
> ret_size - 2, 1);
> + }
>
> return;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] HID: i2c-hid: Report wakeup events
2021-11-02 18:40 [PATCH] HID: i2c-hid: Report wakeup events Matthias Kaehlcke
2021-11-02 18:58 ` Hans de Goede
@ 2021-11-19 14:50 ` Jiri Kosina
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Kosina @ 2021-11-19 14:50 UTC (permalink / raw)
To: Matthias Kaehlcke
Cc: Benjamin Tissoires, linux-kernel, linux-input, Douglas Anderson,
Arnd Bergmann, Hans de Goede, Jim Broadus, Johnny Chuang,
Nathan Chancellor
On Tue, 2 Nov 2021, Matthias Kaehlcke wrote:
> The i2c-hid driver generally supports wakeup, bit it currently
> doesn't report wakeup events to the PM subsystem. Change that.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Goot catch. Applied, thanks.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-19 14:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-02 18:40 [PATCH] HID: i2c-hid: Report wakeup events Matthias Kaehlcke
2021-11-02 18:58 ` Hans de Goede
2021-11-19 14:50 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).