From: Jia-Ju Bai <baijiaju1990@gmail.com>
To: "Bruno Prémont" <bonbons@linux-vserver.org>
Cc: jikos@kernel.org, benjamin.tissoires@redhat.com,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hid: hid-picolcd: fix possible sleep-in-atomic-context bug
Date: Wed, 18 Dec 2019 20:11:47 +0800 [thread overview]
Message-ID: <e36ad913-c498-4d5a-0a5a-bec016d49a16@gmail.com> (raw)
In-Reply-To: <20191218094141.785d8e31@pluto.restena.lu>
Thanks for the reply.
On 2019/12/18 16:41, Bruno Prémont wrote:
> Hi Jia-Ju,
>
> Your checker has been looking at fallback implementation for
> the might-sleep hid_alloc_report_buf(GFP_KERNEL).
>
> Did you have a look at the low-lever bus-driver implementations:
> hdev->ll_driver->request
> ^^^^^^^
>
> Are those all sleeping as well or maybe they don't sleep?\
In fact, I find that a function possibly-related to this function
pointer can sleep:
drivers/hid/intel-ish-hid/ishtp-hid.c, 97:
kzalloc(GFP_KERNEL) in ishtp_hid_request
But I am not quite sure whether this function is really referenced by
the function pointer, so I did not report it.
Best wishes,
Jia-Ju Bai
next prev parent reply other threads:[~2019-12-18 12:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 8:02 [PATCH] hid: hid-picolcd: fix possible sleep-in-atomic-context bug Jia-Ju Bai
2019-12-18 8:41 ` Bruno Prémont
2019-12-18 12:11 ` Jia-Ju Bai [this message]
2019-12-22 18:37 ` Bruno Prémont
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e36ad913-c498-4d5a-0a5a-bec016d49a16@gmail.com \
--to=baijiaju1990@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=bonbons@linux-vserver.org \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).