linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: linux-input@vger.kernel.org, Nathan Chancellor <nathan@kernel.org>
Subject: Re: [bug report] Input: ads7846 - add dummy command register clearing cycle
Date: Tue, 12 Nov 2024 20:49:45 +0100	[thread overview]
Message-ID: <e3beaa5f-c347-4dac-9f76-cd32e41fa493@denx.de> (raw)
In-Reply-To: <43cbfdfb-766b-4640-997e-2e731c8f6875@stanley.mountain>

On 11/12/24 10:08 AM, Dan Carpenter wrote:
> Hello Marek Vasut,
> 
> Commit 781a07da9bb9 ("Input: ads7846 - add dummy command register
> clearing cycle") from Mar 20, 2024 (linux-next), leads to the
> following Smatch static checker warning:
> 
> drivers/input/touchscreen/ads7846.c:412 ads7846_read12_ser() error: buffer overflow 'req->xfer' 6 <= 6
> drivers/input/touchscreen/ads7846.c:413 ads7846_read12_ser() error: buffer overflow 'req->xfer' 6 <= 6
> drivers/input/touchscreen/ads7846.c:416 ads7846_read12_ser() error: buffer overflow 'req->xfer' 6 <= 7
> drivers/input/touchscreen/ads7846.c:417 ads7846_read12_ser() error: buffer overflow 'req->xfer' 6 <= 7
> drivers/input/touchscreen/ads7846.c:418 ads7846_read12_ser() error: buffer overflow 'req->xfer' 6 <= 7
> drivers/input/touchscreen/ads7846.c:418 ads7846_read12_ser() error: buffer overflow 'req->xfer' 6 <= 7
> drivers/input/touchscreen/ads7846.c:419 ads7846_read12_ser() error: buffer overflow 'req->xfer' 6 <= 7
A fix for that was already posted by Nathan:

[PATCH] Input: ads7846 - Increase xfer array size in 'struct ser_req'

Sorry for the inconvenience.

      reply	other threads:[~2024-11-12 21:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-12  9:08 [bug report] Input: ads7846 - add dummy command register clearing cycle Dan Carpenter
2024-11-12 19:49 ` Marek Vasut [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e3beaa5f-c347-4dac-9f76-cd32e41fa493@denx.de \
    --to=marex@denx.de \
    --cc=dan.carpenter@linaro.org \
    --cc=linux-input@vger.kernel.org \
    --cc=nathan@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).