linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: devicetree@vger.kernel.org, Lee Jones <lee@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	linux-arm-msm@vger.kernel.org,
	Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	linux-iio@vger.kernel.org,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-input@vger.kernel.org, Pavel Machek <pavel@ucw.cz>,
	linux-leds@vger.kernel.org
Subject: Re: [PATCH v4 03/38] dt-bindings: mfd: qcom-pm8xxx: allow using interrupts-extended
Date: Sun, 27 Aug 2023 14:00:09 +0200	[thread overview]
Message-ID: <e6340d20-40f3-be5c-b4fc-33da59799d91@linaro.org> (raw)
In-Reply-To: <CAA8EJpoWvoNfomMg34cL=h+qBLHQq3bZO2X-02Pcz6oLiKRxWA@mail.gmail.com>

On 27/08/2023 13:48, Dmitry Baryshkov wrote:
> On Sun, 27 Aug 2023 at 14:12, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 27/08/2023 12:42, Dmitry Baryshkov wrote:
>>> On Sun, 27 Aug 2023 at 11:35, Krzysztof Kozlowski
>>> <krzysztof.kozlowski@linaro.org> wrote:
>>>>
>>>> On 27/08/2023 02:58, Dmitry Baryshkov wrote:
>>>>> Allow using interrupts-extended, which is a preferred form of interrupts
>>>>> specification compared to the interrupt-parrent + interrupts pair.
>>>>>
>>>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>>>>> ---
>>>>>  Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml | 10 +++++++++-
>>>>>  1 file changed, 9 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml b/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml
>>>>> index 7fe3875a5996..33d9615e63c8 100644
>>>>> --- a/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml
>>>>> +++ b/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml
>>>>> @@ -37,6 +37,9 @@ properties:
>>>>>    interrupts:
>>>>>      maxItems: 1
>>>>>
>>>>> +  interrupts-extended:
>>>>> +    maxItems: 1
>>>>
>>>> The entire patch is not needed. At least should not be needed. What
>>>> problem are you trying to solve here?
>>>
>>> The main problem is the next chunk, which (currently) explicitly
>>> requires `interrupts' property. My goal is to allow
>>> `interrupts-extended' in addition to `interrupts'.
>>
>> They are allowed. Why do you think they aren't? That's why I don't
>> understand what real problem is here.
> 
> qcom-pm8xxx.yaml lists `interrupts' property under the `required'
> clause. So I can not simply replace it with `interrupts-extended'

Since when? So again: The entire patch is not needed.


Best regards,
Krzysztof


  reply	other threads:[~2023-08-27 12:00 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-27  0:58 [PATCH v4 00/38] ARM: dts: qcom: cleanup PMIC usage Dmitry Baryshkov
2023-08-27  0:58 ` [PATCH v4 01/38] dt-bindings: input: qcom,pm8921-keypad: convert to YAML format Dmitry Baryshkov
2023-08-27  0:58 ` [PATCH v4 02/38] dt-bindings: mfd: qcom-pm8xxx: add missing child nodes Dmitry Baryshkov
2023-08-27  0:58 ` [PATCH v4 03/38] dt-bindings: mfd: qcom-pm8xxx: allow using interrupts-extended Dmitry Baryshkov
2023-08-27  8:35   ` Krzysztof Kozlowski
2023-08-27 10:42     ` Dmitry Baryshkov
2023-08-27 11:12       ` Krzysztof Kozlowski
2023-08-27 11:48         ` Dmitry Baryshkov
2023-08-27 12:00           ` Krzysztof Kozlowski [this message]
2023-08-27 12:57             ` Dmitry Baryshkov
2023-08-27 18:05               ` Krzysztof Kozlowski
2023-08-27  0:58 ` [PATCH v4 04/38] ARM: dts: qcom: apq8064: correct XOADC register address Dmitry Baryshkov
2023-08-27  0:58 ` [PATCH v4 05/38] ARM: dts: qcom: msm8960: introduce label for PMIC keypad Dmitry Baryshkov
2023-08-27  0:58 ` [PATCH v4 06/38] ARM: dts: qcom: msm8660-surf: use keypad label directly Dmitry Baryshkov
2023-08-27  0:58 ` [PATCH v4 07/38] ARM: dts: qcom: apq8064-nexus7: move sdcc1 node to proper place Dmitry Baryshkov
2023-08-27  0:58 ` [PATCH v4 08/38] ARM: dts: qcom: mdm9615-wp8548-mangoh-green: group include clauses Dmitry Baryshkov
2023-08-27  0:58 ` [PATCH v4 09/38] ARM: dts: qcom: strip prefix from PMIC files Dmitry Baryshkov
2023-08-27  0:58 ` [PATCH v4 10/38] ARM: dts: qcom: apq8064: fix PMIC node labels Dmitry Baryshkov
2023-08-27  0:58 ` [PATCH v4 11/38] ARM: dts: qcom: mdm9615: " Dmitry Baryshkov
2023-08-27  0:58 ` [PATCH v4 12/38] ARM: dts: qcom: msm8660: " Dmitry Baryshkov
2023-08-27  0:58 ` [PATCH v4 13/38] ARM: dts: qcom: msm8960: " Dmitry Baryshkov
2023-08-27  0:58 ` [PATCH v4 14/38] ARM: dts: qcom: apq8064: move PMIC interrupts to the board files Dmitry Baryshkov
2023-08-27  0:58 ` [PATCH v4 15/38] ARM: dts: qcom: mdm9615: " Dmitry Baryshkov
2023-08-27  0:58 ` [PATCH v4 16/38] ARM: dts: qcom: msm8660: " Dmitry Baryshkov
2023-08-27  0:58 ` [PATCH v4 17/38] ARM: dts: qcom: msm8960: " Dmitry Baryshkov
2023-08-27  0:59 ` [PATCH v4 18/38] ARM: dts: qcom: msm8960: split PMIC to separate dtsi files Dmitry Baryshkov
2023-08-27  0:59 ` [PATCH v4 19/38] ARM: dts: qcom: apq8064: split PMICs " Dmitry Baryshkov
2023-08-27  0:59 ` [PATCH v4 20/38] ARM: dts: qcom: mdm9615: split PMIC " Dmitry Baryshkov
2023-08-27  0:59 ` [PATCH v4 21/38] ARM: dts: qcom: msm8660: " Dmitry Baryshkov
2023-08-27  0:59 ` [PATCH v4 22/38] ARM: dts: qcom: pm8058: reorder nodes Dmitry Baryshkov
2023-08-27  0:59 ` [PATCH v4 23/38] ARM: dts: qcom: pm8921: " Dmitry Baryshkov
2023-08-27  0:59 ` [PATCH v4 24/38] ARM: dts: qcom: pm8018: move reg property Dmitry Baryshkov
2023-08-27  0:59 ` [PATCH v4 25/38] ARM: dts: qcom: pm8921: " Dmitry Baryshkov
2023-08-27  0:59 ` [PATCH v4 26/38] ARM: dts: qcom: pm8058: use defined IRQ flags Dmitry Baryshkov
2023-08-27  0:59 ` [PATCH v4 27/38] ARM: dts: qcom: pm8921: switch to interrupts-extended Dmitry Baryshkov
2023-08-27  0:59 ` [PATCH v4 28/38] ARM: dts: qcom: pm8018: " Dmitry Baryshkov
2023-08-27  0:59 ` [PATCH v4 29/38] ARM: dts: qcom: pm8058: " Dmitry Baryshkov
2023-08-27  0:59 ` [PATCH v4 30/38] ARM: dts: qcom: apq8064: move RPM regulators to board files Dmitry Baryshkov
2023-08-27  0:59 ` [PATCH v4 31/38] ARM: dts: qcom: mdm9615: " Dmitry Baryshkov
2023-08-27  0:59 ` [PATCH v4 32/38] ARM: dts: qcom: msm8660: " Dmitry Baryshkov
2023-08-27  0:59 ` [PATCH v4 33/38] ARM: dts: qcom: msm8960: drop useless rpm regulators node Dmitry Baryshkov
2023-08-27  0:59 ` [PATCH v4 34/38] ARM: dts: qcom: msm8974: move regulators to board files Dmitry Baryshkov
2023-08-27  0:59 ` [PATCH v4 35/38] ARM: dts: qcom: pm8921: Disable keypad by default Dmitry Baryshkov
2023-08-27  0:59 ` [PATCH v4 36/38] ARM: dts: qcom: apq8060-dragonboard: rename mpp ADC channels to adc-channel Dmitry Baryshkov
2023-08-27  0:59 ` [PATCH v4 37/38] ARM: dts: qcom: ipq8064: drop qcom, prefix from SSBI node name Dmitry Baryshkov
2023-08-27  0:59 ` [PATCH v4 38/38] ARM: dts: qcom: mdm9615: " Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e6340d20-40f3-be5c-b4fc-33da59799d91@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jic23@kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lars@metafoo.de \
    --cc=lee@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).