public inbox for linux-input@vger.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Svyatoslav Ryhel <clamor95@gmail.com>
Cc: "Lee Jones" <lee@kernel.org>, "Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	"Pavel Machek" <pavel@kernel.org>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Sebastian Reichel" <sre@kernel.org>,
	"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
	"Ion Agorria" <ion@agorria.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-input@vger.kernel.org, linux-leds@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: Re: [PATCH v2 1/9] dt-bindings: misc: document ASUS Transformers EC DockRAM
Date: Tue, 10 Feb 2026 11:50:33 +0100	[thread overview]
Message-ID: <e73d6634-7f31-4dcf-87dd-c8192e7e66c1@kernel.org> (raw)
In-Reply-To: <CAPVz0n3Pzvzt+LmOH_peCtpx8DP2-GiRv--6-ppQUaa51AXRFw@mail.gmail.com>

On 10/02/2026 10:42, Svyatoslav Ryhel wrote:
> вт, 10 лют. 2026 р. о 11:25 Krzysztof Kozlowski <krzk@kernel.org> пише:
>>
>> On Mon, Feb 09, 2026 at 12:43:59PM +0200, Svyatoslav Ryhel wrote:
>>> Documenting an I2C device used in conjunction with the EC on ASUS
>>> Transformers. The main function of DockRAM (the name used by downstream
>>> ASUS sources) is to provide power-related functions, such as battery and
>>> charger communication. The device is exposed as an individual entity
>>> because multiple embedded controllers can utilize the same DockRAM
>>> instance.
>>>
>>> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
>>> ---
>>>  .../bindings/misc/asus,dockram.yaml           | 40 +++++++++++++++++++
>>>  1 file changed, 40 insertions(+)
>>>  create mode 100644 Documentation/devicetree/bindings/misc/asus,dockram.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/misc/asus,dockram.yaml b/Documentation/devicetree/bindings/misc/asus,dockram.yaml
>>> new file mode 100644
>>> index 000000000000..0cfde619ba01
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/misc/asus,dockram.yaml
>>
>> Not a misc device. Find appropriate place, e.g. for EC or docking or
>> laptop devices or power-related.
>>
> 
> Why not misc? be more specific pls where you want it to be.

Because there is no such device as "misc". Otherwise explain me what
sort of device is "misc".

I already wrote where I want it to be placed. You keep bouncing
questions pointlessly, even when given exact request.



> 
>>> @@ -0,0 +1,40 @@
>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/misc/asus,dockram.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Asus Transformer EC DockRAM
>>> +
>>> +maintainers:
>>> +  - Svyatoslav Ryhel <clamor95@gmail.com>
>>> +
>>> +description:
>>> +  Dedicated i2c device used to provide power related functions of the
>>> +  embedded controller used in ASUS Transformer device family.
>>> +
>>> +properties:
>>> +  compatible:
>>> +    const: asus,dockram
>>
>> Way too generic compatible. You are not documenting here all ASUS
>> laptops/devices dockram. For example this implies dockram is also on
>> ASUS Vivobook... or on any other asus device.
>>
> 
> Asus were not so generous to provide more specific data, they call
> this device dockram in their sources.



> 
>>> +
>>> +  reg:
>>> +    maxItems: 1
>>> +
>>> +required:
>>> +  - compatible
>>> +  - reg
>>> +
>>
>> Device looks weirdly empty. Probably you have it only to instantiate I2C
>> handle, so what you really wanted is i2c-parent. This is not a real
>> device.
>>
> 
> WDYM? it is a real physical i2c device located on a i2c bus and probed
> by i2c driver just fine. Maybe you will deny RTC being a real device

Driver does not matter here.

> like it was done for example for max77663 which now causes a massive
> issues since it can occupy different i2c addresses?

Then describe what is the device here. So far it looks exactly like
"ec-dock" for which you already have a binding.

Best regards,
Krzysztof

  reply	other threads:[~2026-02-10 10:50 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-09 10:43 [PATCH v2 0/9] mfd: Add support for Asus Transformer embedded controller Svyatoslav Ryhel
2026-02-09 10:43 ` [PATCH v2 1/9] dt-bindings: misc: document ASUS Transformers EC DockRAM Svyatoslav Ryhel
2026-02-10  9:25   ` Krzysztof Kozlowski
2026-02-10  9:42     ` Svyatoslav Ryhel
2026-02-10 10:50       ` Krzysztof Kozlowski [this message]
2026-02-10 11:08         ` Svyatoslav Ryhel
2026-02-09 10:44 ` [PATCH v2 2/9] misc: Support Asus Transformer's EC access device Svyatoslav Ryhel
2026-02-09 10:44 ` [PATCH v2 3/9] dt-bindings: mfd: document ASUS Transformer EC Svyatoslav Ryhel
2026-02-10  9:22   ` Krzysztof Kozlowski
2026-02-10  9:37     ` Svyatoslav Ryhel
2026-02-10 10:48       ` Krzysztof Kozlowski
2026-02-10 10:59         ` Svyatoslav Ryhel
2026-02-10 11:04           ` Krzysztof Kozlowski
2026-02-10 11:14             ` Svyatoslav Ryhel
2026-02-10 11:24               ` Krzysztof Kozlowski
2026-02-10 11:40                 ` Svyatoslav Ryhel
2026-02-10 11:54                   ` Krzysztof Kozlowski
2026-02-10 12:48                     ` Krzysztof Kozlowski
2026-02-11 10:48                       ` Svyatoslav Ryhel
2026-02-09 10:44 ` [PATCH v2 4/9] mfd: Add driver for Asus Transformer embedded controller Svyatoslav Ryhel
2026-03-06  9:18   ` Lee Jones
2026-03-06 12:36     ` Svyatoslav Ryhel
2026-02-09 10:44 ` [PATCH v2 5/9] input: serio: Add driver for Asus Transformer dock keyboard and touchpad Svyatoslav Ryhel
2026-02-09 10:44 ` [PATCH v2 6/9] input: keyboard: Add driver for Asus Transformer dock multimedia keys Svyatoslav Ryhel
2026-02-09 10:44 ` [PATCH v2 7/9] leds: Add driver for Asus Transformer LEDs Svyatoslav Ryhel
2026-03-06 10:04   ` Lee Jones
2026-03-06 12:45     ` Svyatoslav Ryhel
2026-03-09 19:04       ` Lee Jones
2026-02-09 10:44 ` [PATCH v2 8/9] power: supply: Add driver for Asus Transformer battery Svyatoslav Ryhel
2026-02-09 10:44 ` [PATCH v2 9/9] power: supply: Add charger driver for Asus Transformers Svyatoslav Ryhel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e73d6634-7f31-4dcf-87dd-c8192e7e66c1@kernel.org \
    --to=krzk@kernel.org \
    --cc=arnd@arndb.de \
    --cc=clamor95@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=ion@agorria.com \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mirq-linux@rere.qmqm.pl \
    --cc=pavel@kernel.org \
    --cc=robh@kernel.org \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox