From: Basavaraj Natikar <bnatikar@amd.com>
To: Yue Haibing <yuehaibing@huawei.com>,
basavaraj.natikar@amd.com, jikos@kernel.org,
benjamin.tissoires@redhat.com
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH -next] HID: amd_sfh: Remove unused declarations
Date: Mon, 21 Aug 2023 13:13:16 +0530 [thread overview]
Message-ID: <e88ebf93-d191-b2ca-57ab-a352ca842178@amd.com> (raw)
In-Reply-To: <20230817135127.36372-1-yuehaibing@huawei.com>
On 8/17/2023 7:21 PM, Yue Haibing wrote:
> Commit 4b2c53d93a4b ("SFH:Transport Driver to add support of AMD Sensor
> Fusion Hub (SFH)") declared but never implemented them.
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
> drivers/hid/amd-sfh-hid/amd_sfh_hid.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/hid/amd-sfh-hid/amd_sfh_hid.h b/drivers/hid/amd-sfh-hid/amd_sfh_hid.h
> index 97296f587bc7..1c91be8daedd 100644
> --- a/drivers/hid/amd-sfh-hid/amd_sfh_hid.h
> +++ b/drivers/hid/amd-sfh-hid/amd_sfh_hid.h
> @@ -73,8 +73,6 @@ struct amdtp_hid_data {
> };
>
> /* Interface functions between HID LL driver and AMD SFH client */
> -void hid_amdtp_set_feature(struct hid_device *hid, char *buf, u32 len, int report_id);
> -void hid_amdtp_get_report(struct hid_device *hid, int report_id, int report_type);
> int amdtp_hid_probe(u32 cur_hid_dev, struct amdtp_cl_data *cli_data);
> void amdtp_hid_remove(struct amdtp_cl_data *cli_data);
> int amd_sfh_get_report(struct hid_device *hid, int report_id, int report_type);
Acked-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
Thanks,
--
Basavaraj
prev parent reply other threads:[~2023-08-21 7:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 13:51 [PATCH -next] HID: amd_sfh: Remove unused declarations Yue Haibing
2023-08-21 7:43 ` Basavaraj Natikar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e88ebf93-d191-b2ca-57ab-a352ca842178@amd.com \
--to=bnatikar@amd.com \
--cc=basavaraj.natikar@amd.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox