From: Markus Elfring <Markus.Elfring@web.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jeff LaBundy <jeff@labundy.com>,
linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org
Cc: "Mattijs Korpershoek" <mkorpershoek@baylibre.com>,
"Rob Herring" <robh@kernel.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"ye xingchen" <ye.xingchen@zte.com.cn>,
LKML <linux-kernel@vger.kernel.org>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>
Subject: Re: [v2] Input: iqs269a - Use scope-based resource management in iqs269_parse_chan()
Date: Mon, 4 Mar 2024 18:48:58 +0100 [thread overview]
Message-ID: <ea3b033a-7a50-4276-9839-f6335b754c30@web.de> (raw)
In-Reply-To: <ZeYBTUQRAp2u3bXX@google.com>
> The extra curly braces are absolutely not needed. The for loop's body
> already defines scope, __cleanup()s should be called at the end of the body.
I present an other development opinion here.
I got the impression that the required scope should be smaller for
the adjusted local variable “ev_node” (according to the previous function implementation).
Otherwise:
How do you think about to move any source code part from the loop
into a separate function?
Regards,
Markus
next prev parent reply other threads:[~2024-03-04 17:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-02 8:24 [PATCH] Input: iqs269a - Use common error handling code in iqs269_parse_chan() Markus Elfring
2024-03-03 22:31 ` Dmitry Torokhov
2024-03-04 9:55 ` [PATCH v2] Input: iqs269a - Use scope-based resource management " Markus Elfring
2024-03-04 17:10 ` Jeff LaBundy
2024-03-04 17:13 ` Dmitry Torokhov
2024-03-04 17:48 ` Markus Elfring [this message]
2024-03-04 18:59 ` [v2] " Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea3b033a-7a50-4276-9839-f6335b754c30@web.de \
--to=markus.elfring@web.de \
--cc=Jonathan.Cameron@huawei.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jeff@labundy.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkorpershoek@baylibre.com \
--cc=robh@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=ye.xingchen@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox