From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14A9EC4332F for ; Tue, 4 Oct 2022 08:55:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230175AbiJDIz1 (ORCPT ); Tue, 4 Oct 2022 04:55:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230348AbiJDIzY (ORCPT ); Tue, 4 Oct 2022 04:55:24 -0400 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD7E224BC2 for ; Tue, 4 Oct 2022 01:55:21 -0700 (PDT) Received: by mail-lj1-x234.google.com with SMTP id p5so14529413ljc.13 for ; Tue, 04 Oct 2022 01:55:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=qgfEsS672LrTseyT5QbF4DwYJHWOIb63rkhuEqwbjJM=; b=E8bWQMQT79SGtgHMxCL9c+8KbUuB/XACTRzEyE1Ux9ePZ+5nsdXejeNuAaAmq4aRl4 NyRUgtPNnBv/r5byYrhTxfIBAE81sJNpTDr26fBU7Ni4fm0lwBjUo9ckAYaulRMxHcgH dqio3I9I2wHo3QmIK9Y+a4ZourAChNmNjLCh8aw9YAgW2gWg664OkuUKCJNSFtjBm8j/ ID/P2h91gNI1C7uUUj/SjPH4B8thi1LlpzrwNa8XiZuvwjAx/t7N6tGo7uPOf3uJeabF XJ1/s2CPoauimJYM+jd35jSeDwLT/CbkE2BWaRmNR9k7ahKCTlNvLP0QTQHs43tCEEA+ yeEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=qgfEsS672LrTseyT5QbF4DwYJHWOIb63rkhuEqwbjJM=; b=nhSf2shKHNfBSN+cKbcBbYJ52bklMdqK2Ipm5Ln4QfZsQ1wlCF6lhQJx77PhNnedD3 2M9Xhig+cOf0vymivnYPoqA34f1UtWuk4xzJC8gYD7yO75uIsm7CTKzlNij9f+Eos4Lp OYFxugPC074jKjQmaTpK8WhFJhNORiiKI5/eWyCcEnI7XjmZf2e+5XytVFzvauht3QUa iexNCeiWh9RjUha62r4GNFCs1+MfCrYhq+4rBhX0HcrdqCkFHdrW+wuOAZk7hhSxet56 xzYoHErjeVZ7uOlPTtjSKShT7B7z38PLO1UrpY0NWTwksRyp4O+QHsUvKrGEc4YtORgi ayYw== X-Gm-Message-State: ACrzQf2iWqIjtNWDwuSoAk3/nqgOP0iDYbDbaNArkipg3yFjmOwSOBoC GqpfccAOA9JOcMvjh39+Aer7kg== X-Google-Smtp-Source: AMsMyM7dY1q8NLmh5vfQzABOZZLANjj+1U9eLHWkGp3cg6nlBf7WgHHYrTrntPcDNffRplrUO0Oyag== X-Received: by 2002:a2e:b4ad:0:b0:26c:24f:b260 with SMTP id q13-20020a2eb4ad000000b0026c024fb260mr7296151ljm.173.1664873720292; Tue, 04 Oct 2022 01:55:20 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id a37-20020a05651c212500b0026dc7b59d8esm1012399ljq.22.2022.10.04.01.55.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Oct 2022 01:55:19 -0700 (PDT) Message-ID: Date: Tue, 4 Oct 2022 10:55:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v2 05/11] dt-bindings: mfd: qcom-pm8xxx: document qcom,pm8921 as fallback of qcom,pm8018 Content-Language: en-US To: Neil Armstrong , Krzysztof Kozlowski , Bjorn Andersson , Satya Priya , Andy Gross , Alexandre Belloni , Rob Herring , Konrad Dybcio , Lee Jones , Dmitry Torokhov , Alessandro Zummo Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-input@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-rtc@vger.kernel.org References: <20220928-mdm9615-dt-schema-fixes-v2-0-87fbeb4ae053@linaro.org> <20220928-mdm9615-dt-schema-fixes-v2-5-87fbeb4ae053@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20220928-mdm9615-dt-schema-fixes-v2-5-87fbeb4ae053@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On 04/10/2022 10:08, Neil Armstrong wrote: > The PM8018 is used as compatible with PM8921 on the MDM9615, document this situation, > and an example section to validate this change. > > Signed-off-by: Neil Armstrong > > diff --git a/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml b/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml > index 61bd0b3ce02f..24d71918ff8a 100644 > --- a/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml > +++ b/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml > @@ -15,11 +15,15 @@ description: | > > properties: > compatible: > - enum: > - - qcom,pm8018 > - - qcom,pm8058 > - - qcom,pm8821 > - - qcom,pm8921 > + oneOf: > + - enum: > + - qcom,pm8058 > + - qcom,pm8821 > + - qcom,pm8921 > + - items: > + - enum: > + - qcom,pm8018 > + - const: qcom,pm8921 > > reg: > maxItems: 1 > @@ -52,4 +56,35 @@ required: > - interrupt-controller > > additionalProperties: false > + > +examples: > + - | > + #include > + ssbi { > + #address-cells = <1>; > + #size-cells = <0>; > + pmic@0 { > + compatible = "qcom,pm8921"; > + reg = <0>; > + #address-cells = <1>; > + #size-cells = <0>; > + interrupt-controller; > + #interrupt-cells = <2>; > + > + interrupt-parent = <&tlmm>; > + interrupts = <32 IRQ_TYPE_EDGE_RISING>; > + }; > + > + pmic@1 { > + compatible = "qcom,pm8018", "qcom,pm8921"; > + reg = <1>; > + #address-cells = <1>; > + #size-cells = <0>; > + interrupt-controller; > + #interrupt-cells = <2>; > + > + interrupt-parent = <&tlmm>; > + interrupts = <33 IRQ_TYPE_EDGE_RISING>; > + }; These two pmics are exactly the same (except compatible), so just keep one example... unless both are coming from the same, real DTS? Best regards, Krzysztof