From: Jarrah <kernel@undef.tools>
To: Jan Jasper de Kroon <jajadekroon@gmail.com>
Cc: linux-input@vger.kernel.org, megi@xff.cz
Subject: Re: [PATCH v2] input: touchscreen: goodix: Hold controller in reset during suspend
Date: Mon, 13 Mar 2023 11:44:08 +1100 [thread overview]
Message-ID: <ec69989c-3fba-cf82-5238-476b85c49aa9@undef.tools> (raw)
In-Reply-To: <20230311131534.484700-1-jajadekroon@gmail.com>
On 3/12/23 00:15, Jan Jasper de Kroon wrote:
> From: Ondřej Jirman <megi@xff.cz>
>
> The Goodix touchscreen controller used in PinePhone is not properly
> suspended during system sleep, leading to high power consumption. This
> commit modifies the driver to hold the controller in reset during
> system sleep, reducing power consumption by around 40mW.
>
> The original patch also disabled the regulators during system sleep, but
> this could cause issues with other peripherals attached to the same power
> supplies. Hence, this commit only holds the controller in reset during
> system sleep and does not attempt to power it off.
>
> A separate commit adds a new device tree property "hold-in-reset-in-suspend"
> to control the hold-in-reset behavior of the controller during system sleep.
>
> Signed-off-by: Ondrej Jirman <megi@xff.cz>
> Signed-off-by: Jan Jasper de Kroon <jajadekroon@gmail.com>
Tested-by: Jarrah Gosbell <kernel@undef.tools>
Thank you for upstreaming these,
Jarrah.
next prev parent reply other threads:[~2023-03-13 0:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 17:00 [PATCH] input: goodix: Add option to power off the controller during suspend Jan Jasper de Kroon
2023-03-10 21:19 ` Ondřej Jirman
2023-03-11 13:15 ` [PATCH v2] input: touchscreen: goodix: Hold controller in reset " Jan Jasper de Kroon
2023-03-12 18:40 ` [PATCH v3 2/2] " Jan Jasper de Kroon
2023-03-12 18:59 ` Hans de Goede
2023-03-13 0:44 ` Jarrah [this message]
2023-03-16 15:22 ` [PATCH v4 " Jan Jasper de Kroon
2023-03-16 17:25 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec69989c-3fba-cf82-5238-476b85c49aa9@undef.tools \
--to=kernel@undef.tools \
--cc=jajadekroon@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=megi@xff.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).