From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06510C6FD1F for ; Mon, 13 Mar 2023 00:44:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229814AbjCMAol (ORCPT ); Sun, 12 Mar 2023 20:44:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229821AbjCMAok (ORCPT ); Sun, 12 Mar 2023 20:44:40 -0400 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97BCD24BC3 for ; Sun, 12 Mar 2023 17:44:38 -0700 (PDT) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id E26F6320027A; Sun, 12 Mar 2023 20:44:35 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sun, 12 Mar 2023 20:44:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=undef.tools; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1678668275; x=1678754675; bh=Uw7OnYkfDUMV30FRwyoXt3ygKUIdUif73ri 2WYK6kkY=; b=e/SGDv9xBcrz+7CylSL5Wx4v0x4vbHsK7BpcQvA0JCSOOCjhvBK xRO5P3LBc04lxpzwVvOE8yOYMEk5mcSIUhDdJ+uebEQZpZbTDvECRvT6uy+YlcYG 8FOc4LLuNRNc8gGsmLk5EC494WMiMwKRDvRehTeyQ+Y1aCXqwjOkuZWYBuw55Z5e SSuVwQgSjAVE/IhXvpbOCntMQT92kogIHnjKkWmkzWn2NEVMWhBlh3npwi3f17c9 b5/nDm2PCUZA7fZ30+TptX4cpxf/JrBLqHGfsAZKyb4byGl8V7Ejo9e7DinOenky ETOZ2ELqAae/xE96+KNJ8ZwgKCrwoTqT+FA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1678668275; x=1678754675; bh=Uw7OnYkfDUMV30FRwyoXt3ygKUIdUif73ri 2WYK6kkY=; b=mR9wfnB27ecs40F7ISX8ma1InUDwjBr2C3Ni1G5m/Jm+mMKgQvA AKv9SaVOS0dBxfyy9RArlYSG5lgo1+qGwqEErLD1VKjpIh7PCkmdIAyY+Gp6K+iJ Y+0QEZrfTYn+FDfcCS0w3Flp67Co0hGfZHsD1B86XDScyQHp4H+iFfU75vDBF1sE jM79KurF2G7gOk4gMdTwZhJ8xPDzy9Xu+sJXvbAMj0sKOXE0s2Aboq4lx4A0NsBZ qYkWrigSf405r88FOAegis0+5pVtuCTnpIasBiEQwvyNPe4cr0CpZnycyOH+b6Rp RR8MTw6AoVrg0XaxMNQ0GtwTRRjuYcIIxBQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvddvfedgvdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpeflrghr rhgrhhcuoehkvghrnhgvlhesuhhnuggvfhdrthhoohhlsheqnecuggftrfgrthhtvghrnh epteelhfeiudegfeejgfekleeghffguefgkefgleekkeejtedufffgieekudekfeeinecu vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepkhgvrhhnvg hlsehunhguvghfrdhtohholhhs X-ME-Proxy: Feedback-ID: id76147eb:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 12 Mar 2023 20:44:33 -0400 (EDT) Message-ID: Date: Mon, 13 Mar 2023 11:44:08 +1100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2] input: touchscreen: goodix: Hold controller in reset during suspend Content-Language: en-US To: Jan Jasper de Kroon Cc: linux-input@vger.kernel.org, megi@xff.cz References: <20230310170026.415739-1-jajadekroon@gmail.com> <20230311131534.484700-1-jajadekroon@gmail.com> From: Jarrah In-Reply-To: <20230311131534.484700-1-jajadekroon@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On 3/12/23 00:15, Jan Jasper de Kroon wrote: > From: Ondřej Jirman > > The Goodix touchscreen controller used in PinePhone is not properly > suspended during system sleep, leading to high power consumption. This > commit modifies the driver to hold the controller in reset during > system sleep, reducing power consumption by around 40mW. > > The original patch also disabled the regulators during system sleep, but > this could cause issues with other peripherals attached to the same power > supplies. Hence, this commit only holds the controller in reset during > system sleep and does not attempt to power it off. > > A separate commit adds a new device tree property "hold-in-reset-in-suspend" > to control the hold-in-reset behavior of the controller during system sleep. > > Signed-off-by: Ondrej Jirman > Signed-off-by: Jan Jasper de Kroon Tested-by: Jarrah Gosbell Thank you for upstreaming these, Jarrah.