[RESEND] - HID: add support for force feedback in 'Thrustmaster F430 Force Feedback' steering wheel

[RESEND] - HID: add support for force feedback in 'Thrustmaster F430 Force Feedback' steering wheel

[simon]

[-- Attachment #1: Type: text/plain, Size: 306 bytes --]

Doesn't look like this was picked up by anybody... at least there was no
'ack'.

On behalf of Antonio, please find attached a git-ized version of the patch.

This just add the USB ID's. Builds OK against Linus' git tree, but I don't
have the wheel to test.

Cheers,
Simon Wood.
http://www.speed-dreams.org

[-- Attachment #2: 0001-This-patch-add-supports-for-force-feedback-Thrustmas.patch --]
[-- Type: application/octet-stream, Size: 1729 bytes --]

From 7492b6b93ccb990448b9eda3a1d8277819c81abd Mon Sep 17 00:00:00 2001
From: Simon Wood <simon@mungewell.org>
Date: Wed, 17 Nov 2010 18:37:05 -0700
Subject: [PATCH] This patch add supports for force feedback Thrustmaster "F430 Force
 Feedback" steering wheel.

Reported by: "Antonio Orefice" <aorefice77@gmail.com>
---
 drivers/hid/hid-core.c |    1 +
 drivers/hid/hid-tmff.c |    2 ++
 2 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 515345b..88cb04e 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -1386,6 +1386,7 @@ static const struct hid_device_id hid_blacklist[] = {
 	{ HID_USB_DEVICE(USB_VENDOR_ID_THRUSTMASTER, 0xb651) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_THRUSTMASTER, 0xb653) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_THRUSTMASTER, 0xb654) },
+	{ HID_USB_DEVICE(USB_VENDOR_ID_THRUSTMASTER, 0xb65a) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_TOPSEED, USB_DEVICE_ID_TOPSEED_CYBERLINK) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_TOPSEED2, USB_DEVICE_ID_TOPSEED2_RF_COMBO) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_TWINHAN, USB_DEVICE_ID_TWINHAN_IR_REMOTE) },
diff --git a/drivers/hid/hid-tmff.c b/drivers/hid/hid-tmff.c
index 15434c8..25be4e1 100644
--- a/drivers/hid/hid-tmff.c
+++ b/drivers/hid/hid-tmff.c
@@ -256,6 +256,8 @@ static const struct hid_device_id tm_devices[] = {
 		.driver_data = (unsigned long)ff_joystick },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_THRUSTMASTER, 0xb654),	/* FGT Force Feedback Wheel */
 		.driver_data = (unsigned long)ff_joystick },
+	{ HID_USB_DEVICE(USB_VENDOR_ID_THRUSTMASTER, 0xb65a),	/* F430 Force Feedback Wheel */
+		.driver_data = (unsigned long)ff_joystick },
 	{ }
 };
 MODULE_DEVICE_TABLE(hid, tm_devices);
-- 
1.7.0.4

Re: [RESEND] - HID: add support for force feedback in 'Thrustmaster F430 Force Feedback' steering wheel

[Antonio Ospite]

[-- Attachment #1: Type: text/plain, Size: 1458 bytes --]

On Tue, 23 Nov 2010 15:21:05 -0500
simon@mungewell.org wrote:

> Doesn't look like this was picked up by anybody... at least there was no
> 'ack'.
> 

missing [PATCH] prefix (maybe [PATCH v2] ot v3 for the next round?), and
it was sent as attachment, while this list prefers patches in
the email body, with out-of-patch comments after the '---' separator.

> On behalf of Antonio, please find attached a git-ized version of the patch.
>

The commit short description is too long, limit it to 72 chars, and if
needed add a longer description in the commit message body.

Also the Signed-off-by line is missing, if you are the author, then it
would need your sign off Simon, if Antonio Orefice is the author, then
use his, with no need of the Reported-by.

The procedure may look tedious but the collaboration is based all on
that, and on the other hand if you have interest to have the
patch submitted, you have the motivation to conform to it; check out
Documentation/SubmittingPatches in the kernel dir.

> This just add the USB ID's. Builds OK against Linus' git tree, but I don't
> have the wheel to test.
> 
> Cheers,
> Simon Wood.
> http://www.speed-dreams.org

Regards,
   Antonio

-- 
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]