From: "Limonciello, Mario" <mario.limonciello@amd.com>
To: David Laight <David.Laight@ACULAB.COM>,
'Alan Stern' <stern@rowland.harvard.edu>,
Greg KH <gregkh@linuxfoundation.org>
Cc: Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
"open list:USB HID/HIDBP DRIVERS [USB KEYBOARDS, MICE,
REM..." <linux-usb@vger.kernel.org>,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Richard Gong <richard.gong@amd.com>
Subject: Re: [PATCH v2] HID: usbhid: set mouse as a wakeup resource
Date: Fri, 17 Jun 2022 11:06:05 -0500 [thread overview]
Message-ID: <ed0379a0-1360-4271-16bd-cde2e4b3372b@amd.com> (raw)
In-Reply-To: <419f8edc2a7744ecbfaa0728227db180@AcuMS.aculab.com>
On 6/17/2022 10:39, David Laight wrote:
> From: Alan Stern
>> Sent: 17 June 2022 16:05
> ...
>> Another issue is whether wakeup for a mouse means pressing a button or
>> just moving the mouse. For a mouse that uses LEDs to sense motion,
>> moving it won't generate a wakeup request -- USB suspend does not allow
>> the mouse to use enough current to keep the LEDs illuminated. On the
>> other hand, there's no reason why wakeup by pressing a button shouldn't
>> always work.
>
At least one of the Logitech wireless mice I have here works to wake
either by clicking the buttons or moving the mouse, presumably because
the mouse is battery powered. One of my wired ones works only by
clicking (which is as you describe).
I don't believe there is going to be a way to have granularity of which
type of event will wake the system; it will be hardware dependent.
> I'm not even sure I want a system to wake up because it's mouse
> gets knocked.
> I guess a mouse could include accelerometers so that you can shake it!
>
I'm completely opposite. As soon as I sit down at my desk which has a a
closed docked laptop, the first thing I do is use the mouse which will
wake the system.
And if you take a step further and consider desktops if you *don't* do
this you'll have to find your power button or use the keyboard.
> I've an idea that one of my systems manages to boot if the mouse
> is knocked (and it was last shutdown from windows).
> At least, that it why I think it is sometimes booting up.
>
It was probably hibernated from Windows rather than shutdown. Windows
tends to make this "invisible" to the user. Some systems can wake from
S4 on certain devices, and I would expect some registers on your system
have been programmed to work that way.
next prev parent reply other threads:[~2022-06-17 16:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 18:31 [PATCH v2] HID: usbhid: set mouse as a wakeup resource Mario Limonciello
2022-06-16 21:28 ` Greg KH
2022-06-16 21:47 ` Limonciello, Mario
2022-06-17 15:05 ` Alan Stern
2022-06-17 15:39 ` David Laight
2022-06-17 16:06 ` Limonciello, Mario [this message]
2022-06-17 17:39 ` 'Alan Stern'
2022-06-17 17:44 ` Limonciello, Mario
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed0379a0-1360-4271-16bd-cde2e4b3372b@amd.com \
--to=mario.limonciello@amd.com \
--cc=David.Laight@ACULAB.COM \
--cc=benjamin.tissoires@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=richard.gong@amd.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox