From: Hans de Goede <hdegoede@redhat.com>
To: Nerijus Baliunas <nerijus@users.sourceforge.net>,
linux-input@vger.kernel.org, platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] Add touchscreen platform data for the Onda oBook 20 Plus tablet.
Date: Mon, 11 Dec 2017 11:24:27 +0100 [thread overview]
Message-ID: <ed1b12aa-c8e8-de6d-fdd0-fbd2636a8d54@redhat.com> (raw)
In-Reply-To: <20171210220213.19290-1-nerijus@users.sourceforge.net>
Hi,
On 10-12-17 23:02, Nerijus Baliunas wrote:
> Signed-off-by: Nerijus Baliūnas <nerijus@users.sourceforge.net>
Looks good to me:
Acked-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/platform/x86/silead_dmi.c | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/drivers/platform/x86/silead_dmi.c b/drivers/platform/x86/silead_dmi.c
> index 266535c2a72f..414293e8c448 100644
> --- a/drivers/platform/x86/silead_dmi.c
> +++ b/drivers/platform/x86/silead_dmi.c
> @@ -171,6 +171,23 @@ static const struct silead_ts_dmi_data digma_citi_e200_data = {
> .properties = digma_citi_e200_props,
> };
>
> +static const struct property_entry onda_obook_20_plus_props[] = {
> + PROPERTY_ENTRY_U32("touchscreen-size-x", 1728),
> + PROPERTY_ENTRY_U32("touchscreen-size-y", 1148),
> + PROPERTY_ENTRY_BOOL("touchscreen-inverted-x"),
> + PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"),
> + PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"),
> + PROPERTY_ENTRY_STRING("firmware-name", "gsl3676-onda-obook-20-plus.fw"),
> + PROPERTY_ENTRY_U32("silead,max-fingers", 10),
> + PROPERTY_ENTRY_BOOL("silead,home-button"),
> + { }
> +};
> +
> +static const struct silead_ts_dmi_data onda_obook_20_plus_data = {
> + .acpi_name = "MSSL1680:00",
> + .properties = onda_obook_20_plus_props,
> +};
> +
> static const struct dmi_system_id silead_ts_dmi_table[] = {
> {
> /* CUBE iwork8 Air */
> @@ -271,6 +288,14 @@ static const struct dmi_system_id silead_ts_dmi_table[] = {
> DMI_MATCH(DMI_BOARD_NAME, "Cherry Trail CR"),
> },
> },
> + {
> + /* Onda oBook 20 Plus */
> + .driver_data = (void *)&onda_obook_20_plus_data,
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "ONDA"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "OBOOK 20 PLUS"),
> + },
> + },
> { },
> };
>
>
next prev parent reply other threads:[~2017-12-11 10:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-10 22:02 [PATCH] Add touchscreen platform data for the Onda oBook 20 Plus tablet Nerijus Baliunas
2017-12-11 10:24 ` Hans de Goede [this message]
2017-12-11 18:25 ` Gregor Riepl
2017-12-12 1:11 ` Nerijus Baliunas
2017-12-18 12:41 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed1b12aa-c8e8-de6d-fdd0-fbd2636a8d54@redhat.com \
--to=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=nerijus@users.sourceforge.net \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).