From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sekhar Nori Subject: Re: [PATCH v2 3/3] tps6507x-ts: add DT bindings description Date: Fri, 10 Mar 2017 12:11:08 +0530 Message-ID: References: <1489069869-3849-1-git-send-email-yegorslists@googlemail.com> <1489069869-3849-4-git-send-email-yegorslists@googlemail.com> <20170309175530.GC20077@dtor-ws> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: Received: from fllnx210.ext.ti.com ([198.47.19.17]:23225 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750806AbdCJGlV (ORCPT ); Fri, 10 Mar 2017 01:41:21 -0500 In-Reply-To: <20170309175530.GC20077@dtor-ws> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Dmitry Torokhov , Yegor Yefremov Cc: Rob Herring , "linux-input@vger.kernel.org" , Lee Jones , Mark Rutland , Andrey Skvortsov , Kevin Hilman On Thursday 09 March 2017 11:25 PM, Dmitry Torokhov wrote: > On Thu, Mar 09, 2017 at 04:18:40PM +0100, Yegor Yefremov wrote: >> On Thu, Mar 9, 2017 at 3:49 PM, Rob Herring wrote: >>> On Thu, Mar 9, 2017 at 8:31 AM, wrote: >>>> From: Yegor Yefremov >>> >>> This needs to go to DT list. >> >> Will do. >> >>>> >>>> Provide description for following properties: >>>> >>>> - ti,poll-period >>>> - ti,min-pressure >>>> >>>> Signed-off-by: Yegor Yefremov >>>> --- >>>> Documentation/devicetree/bindings/mfd/tps6507x.txt | 16 ++++++++++++++-- >>>> 1 file changed, 14 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/mfd/tps6507x.txt b/Documentation/devicetree/bindings/mfd/tps6507x.txt >>>> index 8fffa3c..8875662 100644 >>>> --- a/Documentation/devicetree/bindings/mfd/tps6507x.txt >>>> +++ b/Documentation/devicetree/bindings/mfd/tps6507x.txt >>>> @@ -1,4 +1,8 @@ >>>> -TPS6507x Power Management Integrated Circuit >>>> +TPS6507x Multifunctional Device. >>>> + >>>> +Features provided by TPS6507x: >>>> + 1. Power Management Integrated Circuit. >>>> + 2. Touch-Screen. >>>> >>>> Required properties: >>>> - compatible: "ti,tps6507x" >>>> @@ -30,6 +34,12 @@ Regulator Optional properties: >>>> 1: If defdcdc pin of DCDC2/DCDC3 is driven HIGH. >>>> If this property is not defined, it defaults to 0 (not enabled). >>>> >>>> +Touchscreen Optional properties: >>>> +- ti,poll-period: Time at which touch input is getting sampled in ms. >>>> + Default value: 30 ms. >>> >>> Isn't there a standard property for this? >> >> Such a value will be already used in [1]. I've looked at [2], but it >> doesn't have such a field. >> >> [1] Documentation/devicetree/bindings/input/touchscreen/tsc2007.txt >> [2] Documentation/devicetree/bindings/input/touchscreen/touchscreen.txt > > I think the bigger question (since we are adding this to DT I assume it > is not longer "toy" driver) can we convert it to a proper > interrupt-driven scheme? Polling for real shipping devices is not > efficient, I do not think we should even try to allow this mode in DTS > bindings (note that tsc2007 use is different: it allows to specify > sampling interval once touch is detected). Unfortunately, the only current user of tps6507x in kernel (da850-evm) does not have the touch interrupt connected to the processor. So if we dont support polled mode in when using device-tree, da850-evm.dts wont be able to use this driver. Thanks, Sekhar