[PATCH 1/2] dt-bindings: HID: i2c-hid: elan: Introduce FocalTech FT8112

[PATCH 1/2] dt-bindings: HID: i2c-hid: elan: Introduce FocalTech FT8112

[daniel_peng]

From: Daniel Peng <Daniel_Peng@pegatron.corp-partner.google.com>

The FocalTech FT8112 touch screen chip same as Ilitek ili2901 controller
has a reset gpio. The difference is that they have different
post_gpio_reset_on_delay_ms.
FocalTech FT8112 also uses 3.3V power supply.

Signed-off-by: Daniel Peng <Daniel_Peng@pegatron.corp-partner.google.com>
---

 .../bindings/input/focaltech,ft8112.yaml      | 66 +++++++++++++++++++
 MAINTAINERS                                   |  1 +
 2 files changed, 67 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/input/focaltech,ft8112.yaml

diff --git a/Documentation/devicetree/bindings/input/focaltech,ft8112.yaml b/Documentation/devicetree/bindings/input/focaltech,ft8112.yaml
new file mode 100644
index 000000000000..391825b24fcb
--- /dev/null
+++ b/Documentation/devicetree/bindings/input/focaltech,ft8112.yaml
@@ -0,0 +1,66 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/input/focaltech,ft8112.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: FocalTech FT8112 touchscreen controller
+
+maintainers:
+  - Dmitry Torokhov <dmitry.torokhov@gmail.com>
+
+description:
+  Supports the FocalTech FT8112 touchscreen controller.
+  This touchscreen controller uses the i2c-hid protocol with a reset GPIO.
+
+allOf:
+  - $ref: /schemas/input/touchscreen/touchscreen.yaml#
+
+properties:
+  compatible:
+    enum:
+      - focaltech,ft8112
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  panel: true
+
+  reset-gpios:
+    maxItems: 1
+
+  vcc33-supply: true
+
+  vccio-supply: true
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - vcc33-supply
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+    #include <dt-bindings/interrupt-controller/irq.h>
+
+    i2c {
+      #address-cells = <1>;
+      #size-cells = <0>;
+
+      touchscreen@38 {
+        compatible = "focaltech,ft8112";
+        reg = <0x38>;
+
+        interrupt-parent = <&pio>;
+        interrupts = <15 IRQ_TYPE_LEVEL_LOW>>;
+
+        reset-gpios = <&pio 126 GPIO_ACTIVE_LOW>;
+        vcc33-supply = <&pp3300_tchscr_x>;
+      };
+    };
diff --git a/MAINTAINERS b/MAINTAINERS
index ddecf1ef3bed..69f54515fe98 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -12326,6 +12326,7 @@ T:	git git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git
 F:	Documentation/devicetree/bindings/input/
 F:	Documentation/devicetree/bindings/serio/
 F:	Documentation/input/
+F:	drivers/hid/
 F:	drivers/input/
 F:	include/dt-bindings/input/
 F:	include/linux/gameport.h
-- 
2.34.1

[PATCH 2/2] HID: i2c-hid: Add new FocalTech Touchscreen Chip

[daniel_peng]

From: Daniel Peng <Daniel_Peng@pegatron.corp-partner.google.com>

Information for touchscreen model HKO/RB116AS01-2 as below:
- HID :FTSC1000
- slave address:0X38
- Interface:HID over I2C
- Touch control lC:FT8112
- I2C ID: PNP0C50

Signed-off-by: Daniel Peng <Daniel_Peng@pegatron.corp-partner.google.com>
---

 drivers/hid/i2c-hid/i2c-hid-of-elan.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/hid/i2c-hid/i2c-hid-of-elan.c b/drivers/hid/i2c-hid/i2c-hid-of-elan.c
index 0215f217f6d8..b81fcc6ff49e 100644
--- a/drivers/hid/i2c-hid/i2c-hid-of-elan.c
+++ b/drivers/hid/i2c-hid/i2c-hid-of-elan.c
@@ -168,6 +168,13 @@ static const struct elan_i2c_hid_chip_data elan_ekth6a12nay_chip_data = {
 	.power_after_backlight = true,
 };
 
+static const struct elan_i2c_hid_chip_data focaltech_ft8112_chip_data = {
+	.post_power_delay_ms = 10,
+	.post_gpio_reset_on_delay_ms = 150,
+	.hid_descriptor_address = 0x0001,
+	.main_supply_name = "vcc33",
+};
+
 static const struct elan_i2c_hid_chip_data ilitek_ili9882t_chip_data = {
 	.post_power_delay_ms = 1,
 	.post_gpio_reset_on_delay_ms = 200,
@@ -191,6 +198,7 @@ static const struct elan_i2c_hid_chip_data ilitek_ili2901_chip_data = {
 static const struct of_device_id elan_i2c_hid_of_match[] = {
 	{ .compatible = "elan,ekth6915", .data = &elan_ekth6915_chip_data },
 	{ .compatible = "elan,ekth6a12nay", .data = &elan_ekth6a12nay_chip_data },
+	{ .compatible = "focaltech,ft8112", .data = &focaltech_ft8112_chip_data },
 	{ .compatible = "ilitek,ili9882t", .data = &ilitek_ili9882t_chip_data },
 	{ .compatible = "ilitek,ili2901", .data = &ilitek_ili2901_chip_data },
 	{ }
-- 
2.34.1

Re: [PATCH 1/2] dt-bindings: HID: i2c-hid: elan: Introduce FocalTech FT8112

[Rob Herring (Arm)]

On Tue, 11 Nov 2025 09:34:57 +0800, daniel_peng@pegatron.corp-partner.google.com wrote:
> From: Daniel Peng <Daniel_Peng@pegatron.corp-partner.google.com>
> 
> The FocalTech FT8112 touch screen chip same as Ilitek ili2901 controller
> has a reset gpio. The difference is that they have different
> post_gpio_reset_on_delay_ms.
> FocalTech FT8112 also uses 3.3V power supply.
> 
> Signed-off-by: Daniel Peng <Daniel_Peng@pegatron.corp-partner.google.com>
> ---
> 
>  .../bindings/input/focaltech,ft8112.yaml      | 66 +++++++++++++++++++
>  MAINTAINERS                                   |  1 +
>  2 files changed, 67 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/input/focaltech,ft8112.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/input/focaltech,ft8112.example.dts:36.31-33 syntax error
FATAL ERROR: Unable to parse input tree
make[2]: *** [scripts/Makefile.dtbs:132: Documentation/devicetree/bindings/input/focaltech,ft8112.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1547: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20251111093426.1.I76ee34ac45e1469dbeb11de0d1e47d794af7dc88@changeid

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.

Re: [PATCH 1/2] dt-bindings: HID: i2c-hid: elan: Introduce FocalTech FT8112

[Pin-yen Lin]

Hi Daniel,

On Tue, Nov 11, 2025 at 9:34 AM
<daniel_peng@pegatron.corp-partner.google.com> wrote:
>
> From: Daniel Peng <Daniel_Peng@pegatron.corp-partner.google.com>
>
> The FocalTech FT8112 touch screen chip same as Ilitek ili2901 controller
> has a reset gpio. The difference is that they have different
> post_gpio_reset_on_delay_ms.
> FocalTech FT8112 also uses 3.3V power supply.
>
> Signed-off-by: Daniel Peng <Daniel_Peng@pegatron.corp-partner.google.com>
> ---
>
>  .../bindings/input/focaltech,ft8112.yaml      | 66 +++++++++++++++++++
>  MAINTAINERS                                   |  1 +
>  2 files changed, 67 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/input/focaltech,ft8112.yaml
>
> diff --git a/Documentation/devicetree/bindings/input/focaltech,ft8112.yaml b/Documentation/devicetree/bindings/input/focaltech,ft8112.yaml
> new file mode 100644
> index 000000000000..391825b24fcb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/focaltech,ft8112.yaml
> @@ -0,0 +1,66 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/focaltech,ft8112.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: FocalTech FT8112 touchscreen controller
> +
> +maintainers:
> +  - Dmitry Torokhov <dmitry.torokhov@gmail.com>

List yourself as the maintainer of this binding file instead of the
subsystem maintainer.
> +
> +description:
> +  Supports the FocalTech FT8112 touchscreen controller.
> +  This touchscreen controller uses the i2c-hid protocol with a reset GPIO.
> +
> +allOf:
> +  - $ref: /schemas/input/touchscreen/touchscreen.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - focaltech,ft8112
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  panel: true
> +
> +  reset-gpios:
> +    maxItems: 1
> +
> +  vcc33-supply: true
> +
> +  vccio-supply: true
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - vcc33-supply
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    i2c {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      touchscreen@38 {
> +        compatible = "focaltech,ft8112";
> +        reg = <0x38>;
> +
> +        interrupt-parent = <&pio>;
> +        interrupts = <15 IRQ_TYPE_LEVEL_LOW>>;

You have an extra '>' here. This should be caught by `make
dt_binding_check`. Please check [1] and [2], and make sure the patches
are tested before you send them out.

[1]: https://www.kernel.org/doc/Documentation/devicetree/writing-schema.md
[2]: https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> +
> +        reset-gpios = <&pio 126 GPIO_ACTIVE_LOW>;
> +        vcc33-supply = <&pp3300_tchscr_x>;
> +      };
> +    };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ddecf1ef3bed..69f54515fe98 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -12326,6 +12326,7 @@ T:      git git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git
>  F:     Documentation/devicetree/bindings/input/
>  F:     Documentation/devicetree/bindings/serio/
>  F:     Documentation/input/
> +F:     drivers/hid/

Why did you add this?

>  F:     drivers/input/
>  F:     include/dt-bindings/input/
>  F:     include/linux/gameport.h

Regards,
Pin-yen

Re: [PATCH 1/2] dt-bindings: HID: i2c-hid: elan: Introduce FocalTech FT8112

[Krzysztof Kozlowski]

On 11/11/2025 03:31, Rob Herring (Arm) wrote:
> 
> On Tue, 11 Nov 2025 09:34:57 +0800, daniel_peng@pegatron.corp-partner.google.com wrote:
>> From: Daniel Peng <Daniel_Peng@pegatron.corp-partner.google.com>
>>
>> The FocalTech FT8112 touch screen chip same as Ilitek ili2901 controller
>> has a reset gpio. The difference is that they have different
>> post_gpio_reset_on_delay_ms.
>> FocalTech FT8112 also uses 3.3V power supply.
>>
>> Signed-off-by: Daniel Peng <Daniel_Peng@pegatron.corp-partner.google.com>
>> ---
>>
>>  .../bindings/input/focaltech,ft8112.yaml      | 66 +++++++++++++++++++
>>  MAINTAINERS                                   |  1 +
>>  2 files changed, 67 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/input/focaltech,ft8112.yaml
>>
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> yamllint warnings/errors:

This patch has multiple issues already, but what is worth noting - it
never reached me, most like because it bounced when marked as spam.

You need to fix you SMTP in Google, so Google (oh that's so fair!) will
not mark your stuff as spam.

Also, completely messed up or missing threading.

Best regards,
Krzysztof

RE: [PATCH 1/2] dt-bindings: HID: i2c-hid: elan: Introduce FocalTech FT8112

[Daniel Peng(彭博煜_Pegatron)]

[-- Attachment #1: Type: text/plain, Size: 6264 bytes --]

Hi Pin-yen,

I had re-submitted the 2 CLs to upstream. Please refer the attachments.

> +maintainers:
> +  - Dmitry Torokhov <dmitry.torokhov@gmail.com>

List yourself as the maintainer of this binding file instead of the subsystem maintainer.
[Daniel] What your mean is maintainers in this file should be Me right?(as below)
> +maintainers:
> +  - Daniel Peng <Daniel_Peng@pegatron.corp-partner.google.com>

You have an extra '>' here. This should be caught by `make dt_binding_check`. Please check [1] and [2], and make sure the patches are tested before you send them out.
[Daniel] Yes. I had re-upload the patch again to remove the extra '>' in focaltech,ft8112.yaml.
Moreover, I confirm no error for focaltech,ft8112.yaml after running command "make dt_binding_check".


> +F:     drivers/hid/

Why did you add this?
[Daniel] If not added this, the command ./scripts/checkpatch.pl 0001-dt-bindings-input-i2c-hid-Introduce-FocalTech-FT8112.patch would had 1 warning.
And the WARNING as below:
WARNING: added, moved or deleted files(s_, does MAINTAINERS need updating?
#21:
new file mode 100644


Thanks.

Best Regards.
Daniel

-----Original Message-----
From: daniel_peng+caf_=Daniel_Peng=pegatroncorp.com@pegatron.corp-partner.google.com <daniel_peng+caf_=Daniel_Peng=pegatroncorp.com@pegatron.corp-partner.google.com>
Sent: Tuesday, November 11, 2025 3:18 PM
To: daniel_peng@pegatron.corp-partner.google.com
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>; linux-input@vger.kernel.org; LKML <linux-kernel@vger.kernel.org>; Conor Dooley <conor+dt@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; Rob Herring <robh@kernel.org>; devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: HID: i2c-hid: elan: Introduce FocalTech FT8112

Hi Daniel,

On Tue, Nov 11, 2025 at 9:34 AM
<daniel_peng@pegatron.corp-partner.google.com> wrote:
>
> From: Daniel Peng <Daniel_Peng@pegatron.corp-partner.google.com>
>
> The FocalTech FT8112 touch screen chip same as Ilitek ili2901
> controller has a reset gpio. The difference is that they have
> different post_gpio_reset_on_delay_ms.
> FocalTech FT8112 also uses 3.3V power supply.
>
> Signed-off-by: Daniel Peng
> <Daniel_Peng@pegatron.corp-partner.google.com>
> ---
>
>  .../bindings/input/focaltech,ft8112.yaml      | 66 +++++++++++++++++++
>  MAINTAINERS                                   |  1 +
>  2 files changed, 67 insertions(+)
>  create mode 100644
> Documentation/devicetree/bindings/input/focaltech,ft8112.yaml
>
> diff --git
> a/Documentation/devicetree/bindings/input/focaltech,ft8112.yaml
> b/Documentation/devicetree/bindings/input/focaltech,ft8112.yaml
> new file mode 100644
> index 000000000000..391825b24fcb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/focaltech,ft8112.yaml
> @@ -0,0 +1,66 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/focaltech,ft8112.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: FocalTech FT8112 touchscreen controller
> +
> +maintainers:
> +  - Dmitry Torokhov <dmitry.torokhov@gmail.com>

List yourself as the maintainer of this binding file instead of the subsystem maintainer.
> +
> +description:
> +  Supports the FocalTech FT8112 touchscreen controller.
> +  This touchscreen controller uses the i2c-hid protocol with a reset GPIO.
> +
> +allOf:
> +  - $ref: /schemas/input/touchscreen/touchscreen.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - focaltech,ft8112
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  panel: true
> +
> +  reset-gpios:
> +    maxItems: 1
> +
> +  vcc33-supply: true
> +
> +  vccio-supply: true
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - vcc33-supply
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    i2c {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      touchscreen@38 {
> +        compatible = "focaltech,ft8112";
> +        reg = <0x38>;
> +
> +        interrupt-parent = <&pio>;
> +        interrupts = <15 IRQ_TYPE_LEVEL_LOW>>;

You have an extra '>' here. This should be caught by `make dt_binding_check`. Please check [1] and [2], and make sure the patches are tested before you send them out.

[1]: https://www.kernel.org/doc/Documentation/devicetree/writing-schema.md
[2]: https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> +
> +        reset-gpios = <&pio 126 GPIO_ACTIVE_LOW>;
> +        vcc33-supply = <&pp3300_tchscr_x>;
> +      };
> +    };
> diff --git a/MAINTAINERS b/MAINTAINERS index
> ddecf1ef3bed..69f54515fe98 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -12326,6 +12326,7 @@ T:      git git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git
>  F:     Documentation/devicetree/bindings/input/
>  F:     Documentation/devicetree/bindings/serio/
>  F:     Documentation/input/
> +F:     drivers/hid/

Why did you add this?

>  F:     drivers/input/
>  F:     include/dt-bindings/input/
>  F:     include/linux/gameport.h

Regards,
Pin-yen


This e-mail and its attachment may contain information that is confidential or privileged, and are solely for the use of the individual to whom this e-mail is addressed. If you are not the intended recipient or have received it accidentally, please immediately notify the sender by reply e-mail and destroy all copies of this email and its attachment. Please be advised that any unauthorized use, disclosure, distribution or copying of this email or its attachment is strictly prohibited.

本電子郵件及其附件可能含有機密或依法受特殊管制之資訊，僅供本電子郵件之受文者使用。台端如非本電子郵件之受文者或誤收本電子郵件，請立即回覆郵件通知寄件人，並銷毀本電子郵件之所有複本及附件。任何未經授權而使用、揭露、散佈或複製本電子郵件或其附件之行為，皆嚴格禁止 。


[-- Attachment #2: Type: message/rfc822, Size: 20509 bytes --]

From: "daniel_peng+caf_=Daniel_Peng=pegatroncorp.com@pegatron.corp-partner.google.com" <daniel_peng+caf_=Daniel_Peng=pegatroncorp.com@pegatron.corp-partner.google.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>, "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Daniel Peng <Daniel_Peng@pegatron.corp-partner.google.com>, Conor Dooley <conor+dt@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>, Rob Herring <robh@kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: [PATCH 1/2] dt-bindings: input: i2c-hid: Introduce FocalTech FT8112
Date: Tue, 11 Nov 2025 06:38:59 +0000
Message-ID: <20251111143853.1.I76ee34ac45e1469dbeb11de0d1e47d794af7dc88@changeid>

From: Daniel Peng <Daniel_Peng@pegatron.corp-partner.google.com>

The FocalTech FT8112 touch screen chip same as Ilitek ili2901 controller
has a reset gpio. The difference is that they have different
post_gpio_reset_on_delay_ms.
FocalTech FT8112 also uses 3.3V power supply.

Signed-off-by: Daniel Peng <Daniel_Peng@pegatron.corp-partner.google.com>
---

 .../bindings/input/focaltech,ft8112.yaml      | 66 +++++++++++++++++++
 MAINTAINERS                                   |  1 +
 2 files changed, 67 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/input/focaltech,ft8112.yaml

diff --git a/Documentation/devicetree/bindings/input/focaltech,ft8112.yaml b/Documentation/devicetree/bindings/input/focaltech,ft8112.yaml
new file mode 100644
index 000000000000..114288787c98
--- /dev/null
+++ b/Documentation/devicetree/bindings/input/focaltech,ft8112.yaml
@@ -0,0 +1,66 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/input/focaltech,ft8112.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: FocalTech FT8112 touchscreen controller
+
+maintainers:
+  - Dmitry Torokhov <dmitry.torokhov@gmail.com>
+
+description:
+  Supports the FocalTech FT8112 touchscreen controller.
+  This touchscreen controller uses the i2c-hid protocol with a reset GPIO.
+
+allOf:
+  - $ref: /schemas/input/touchscreen/touchscreen.yaml#
+
+properties:
+  compatible:
+    enum:
+      - focaltech,ft8112
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  panel: true
+
+  reset-gpios:
+    maxItems: 1
+
+  vcc33-supply: true
+
+  vccio-supply: true
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - vcc33-supply
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+    #include <dt-bindings/interrupt-controller/irq.h>
+
+    i2c {
+      #address-cells = <1>;
+      #size-cells = <0>;
+
+      touchscreen@38 {
+        compatible = "focaltech,ft8112";
+        reg = <0x38>;
+
+        interrupt-parent = <&pio>;
+        interrupts = <15 IRQ_TYPE_LEVEL_LOW>;
+
+        reset-gpios = <&pio 126 GPIO_ACTIVE_LOW>;
+        vcc33-supply = <&pp3300_tchscr_x>;
+      };
+    };
diff --git a/MAINTAINERS b/MAINTAINERS
index ddecf1ef3bed..69f54515fe98 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -12326,6 +12326,7 @@ T:      git git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git
 F:     Documentation/devicetree/bindings/input/
 F:     Documentation/devicetree/bindings/serio/
 F:     Documentation/input/
+F:     drivers/hid/
 F:     drivers/input/
 F:     include/dt-bindings/input/
 F:     include/linux/gameport.h
--
2.34.1


[-- Attachment #3: Type: message/rfc822, Size: 19265 bytes --]

From: "daniel_peng+caf_=Daniel_Peng=pegatroncorp.com@pegatron.corp-partner.google.com" <daniel_peng+caf_=Daniel_Peng=pegatroncorp.com@pegatron.corp-partner.google.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>, "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Daniel Peng <Daniel_Peng@pegatron.corp-partner.google.com>, Benjamin Tissoires <bentiss@kernel.org>, Douglas Anderson <dianders@chromium.org>, Jiri Kosina <jikos@kernel.org>, Pin-yen Lin <treapking@chromium.org>
Subject: [PATCH 2/2] HID: i2c-hid: Add new FocalTech Touchscreen Chip
Date: Tue, 11 Nov 2025 06:39:00 +0000
Message-ID: <20251111143853.2.Iad6f93df7a4436f6a84ed7b7493fc468c56ab750@changeid>

From: Daniel Peng <Daniel_Peng@pegatron.corp-partner.google.com>

Information for touchscreen model HKO/RB116AS01-2 as below:
- HID :FTSC1000
- slave address:0X38
- Interface:HID over I2C
- Touch control lC:FT8112
- I2C ID: PNP0C50

Signed-off-by: Daniel Peng <Daniel_Peng@pegatron.corp-partner.google.com>
---

 drivers/hid/i2c-hid/i2c-hid-of-elan.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/hid/i2c-hid/i2c-hid-of-elan.c b/drivers/hid/i2c-hid/i2c-hid-of-elan.c
index 0215f217f6d8..b81fcc6ff49e 100644
--- a/drivers/hid/i2c-hid/i2c-hid-of-elan.c
+++ b/drivers/hid/i2c-hid/i2c-hid-of-elan.c
@@ -168,6 +168,13 @@ static const struct elan_i2c_hid_chip_data elan_ekth6a12nay_chip_data = {
        .power_after_backlight = true,
 };

+static const struct elan_i2c_hid_chip_data focaltech_ft8112_chip_data = {
+       .post_power_delay_ms = 10,
+       .post_gpio_reset_on_delay_ms = 150,
+       .hid_descriptor_address = 0x0001,
+       .main_supply_name = "vcc33",
+};
+
 static const struct elan_i2c_hid_chip_data ilitek_ili9882t_chip_data = {
        .post_power_delay_ms = 1,
        .post_gpio_reset_on_delay_ms = 200,
@@ -191,6 +198,7 @@ static const struct elan_i2c_hid_chip_data ilitek_ili2901_chip_data = {
 static const struct of_device_id elan_i2c_hid_of_match[] = {
        { .compatible = "elan,ekth6915", .data = &elan_ekth6915_chip_data },
        { .compatible = "elan,ekth6a12nay", .data = &elan_ekth6a12nay_chip_data },
+       { .compatible = "focaltech,ft8112", .data = &focaltech_ft8112_chip_data },
        { .compatible = "ilitek,ili9882t", .data = &ilitek_ili9882t_chip_data },
        { .compatible = "ilitek,ili2901", .data = &ilitek_ili2901_chip_data },
        { }
--
2.34.1

Re: [PATCH 1/2] dt-bindings: HID: i2c-hid: elan: Introduce FocalTech FT8112

[Krzysztof Kozlowski]

On 11/11/2025 08:50, Daniel Peng(彭博煜_Pegatron) wrote:
> Hi Pin-yen,
> 
> I had re-submitted the 2 CLs to upstream. Please refer the attachments.

No, you duplicated them.

Please version your patches correctly.



> 
>> +maintainers:
>> +  - Dmitry Torokhov <dmitry.torokhov@gmail.com>
> 
> List yourself as the maintainer of this binding file instead of the subsystem maintainer.
> [Daniel] What your mean is maintainers in this file should be Me right?(as below)

I don't understand what is the quote here and what is your response.

This is unreadable.

Please use STANDARD EMAIL format, not some odd Outlook style. We don't
accept here Outlook or other crappy webclients.

> 
> 
> This e-mail and its attachment may contain information that is confidential or privileged, and are solely for the use of the individual to whom this e-mail is addressed. If you are not the intended recipient or have received it accidentally, please immediately notify the sender by reply e-mail and destroy all copies of this email and its attachment. Please be advised that any unauthorized use, disclosure, distribution or copying of this email or its attachment is strictly prohibited.

Don't ever send such confidential disclaimers. This means we should be
ignoring your messages. Are you sure you want that?


Best regards,
Krzysztof

RE: [PATCH 1/2] dt-bindings: HID: i2c-hid: elan: Introduce FocalTech FT8112

[Daniel Peng(彭博煜_Pegatron)]

Remove added members.

Sorry to send duplicated them. This is my first time to process the upstream.
Could you help to confirm how to version my patches correctly?


Thanks.

Best Regards.
Daniel

-----Original Message-----
From: krzk@kernel.org <krzk@kernel.org> 
Sent: Tuesday, November 11, 2025 4:22 PM
To: Daniel Peng(彭博煜_Pegatron) <Daniel_Peng@pegatroncorp.com>; treapking@chromium.org
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>; linux-input@vger.kernel.org; LKML <linux-kernel@vger.kernel.org>; Conor Dooley <conor+dt@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; Rob Herring <robh@kernel.org>; devicetree@vger.kernel.org; Asher Huang(黃進南_Pegatron) <Asher_Huang@pegatroncorp.com>; daniel_peng@pegatron.corp-partner.google.com
Subject: Re: [PATCH 1/2] dt-bindings: HID: i2c-hid: elan: Introduce FocalTech FT8112

On 11/11/2025 08:50, Daniel Peng(彭博煜_Pegatron) wrote:
> Hi Pin-yen,
> 
> I had re-submitted the 2 CLs to upstream. Please refer the attachments.

No, you duplicated them.

Please version your patches correctly.



> 
>> +maintainers:
>> +  - Dmitry Torokhov <dmitry.torokhov@gmail.com>
> 
> List yourself as the maintainer of this binding file instead of the subsystem maintainer.
> [Daniel] What your mean is maintainers in this file should be Me 
> right?(as below)

I don't understand what is the quote here and what is your response.

This is unreadable.

Please use STANDARD EMAIL format, not some odd Outlook style. We don't accept here Outlook or other crappy webclients.

> 
> 
> This e-mail and its attachment may contain information that is confidential or privileged, and are solely for the use of the individual to whom this e-mail is addressed. If you are not the intended recipient or have received it accidentally, please immediately notify the sender by reply e-mail and destroy all copies of this email and its attachment. Please be advised that any unauthorized use, disclosure, distribution or copying of this email or its attachment is strictly prohibited.

Don't ever send such confidential disclaimers. This means we should be ignoring your messages. Are you sure you want that?


Best regards,
Krzysztof

Re: [PATCH 1/2] dt-bindings: HID: i2c-hid: elan: Introduce FocalTech FT8112

[Krzysztof Kozlowski]

On 11/11/2025 09:35, Daniel Peng(彭博煜_Pegatron) wrote:
> Remove added members.
> 
> Sorry to send duplicated them. This is my first time to process the upstream.
> Could you help to confirm how to version my patches correctly?

And kernel docs don't explain that? There are multiple guidelines in
internet, multiple talks describing it, so I don't think that me
repeating the same again is needed.

Please version your patches correctly, e.g. use b4 or git format-patch
-vX, and add changelog in cover letter or under '---' of individual
patches describing changes from previous version.

Best regards,
Krzysztof

Re: [PATCH 2/2] HID: i2c-hid: Add new FocalTech Touchscreen Chip

[Doug Anderson]

Hi,

On Mon, Nov 10, 2025 at 5:35 PM
<daniel_peng@pegatron.corp-partner.google.com> wrote:
>
> From: Daniel Peng <Daniel_Peng@pegatron.corp-partner.google.com>
>
> Information for touchscreen model HKO/RB116AS01-2 as below:
> - HID :FTSC1000
> - slave address:0X38
> - Interface:HID over I2C
> - Touch control lC:FT8112
> - I2C ID: PNP0C50
>
> Signed-off-by: Daniel Peng <Daniel_Peng@pegatron.corp-partner.google.com>
> ---
>
>  drivers/hid/i2c-hid/i2c-hid-of-elan.c | 8 ++++++++
>  1 file changed, 8 insertions(+)

The subject of your patch should probably be a little less generic and
include the ID of the chip you're adding support for. Like:

HID: i2c-hid: Add Focaltech FT8112

Other than that, this patch looks fine to me assuming the problems
with your bindings patch get worked out. You may also want to consider
using a different email address for sending since your bindings patch
showed up in my spam folder.

Reviewed-by: Douglas Anderson <dianders@chromium.org>