From: "eric miao" <eric.y.miao@gmail.com>
To: linux-input@vger.kernel.org
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: [PATCH 2/12] pxa: remove the pin configuration from the keypad driver
Date: Wed, 23 Jan 2008 15:17:17 +0800 [thread overview]
Message-ID: <f17812d70801222317k641d55fy8f94c436770a8b0a@mail.gmail.com> (raw)
>From dbd62bced0f789765d1823f66af792933c6b46a1 Mon Sep 17 00:00:00 2001
From: eric miao <eric.miao@marvell.com>
Date: Tue, 22 Jan 2008 16:34:12 +0800
Subject: [PATCH] pxa: remove the pin configuration from the keypad driver
The pin configurations will slowly be moved to the board specific code
at initialization thus to make the driver more generic.
Signed-off-by: eric miao <eric.miao@marvell.com>
---
drivers/input/keyboard/pxa27x_keypad.c | 4 ----
include/asm-arm/arch-pxa/pxa27x_keypad.h | 1 -
2 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/drivers/input/keyboard/pxa27x_keypad.c
b/drivers/input/keyboard/pxa27x_keypad.c
index 06c1d5a..43fb63d 100644
--- a/drivers/input/keyboard/pxa27x_keypad.c
+++ b/drivers/input/keyboard/pxa27x_keypad.c
@@ -208,10 +208,6 @@ static int __devinit pxa27x_keypad_probe(struct
platform_device *pdev)
if (error)
goto err_free_irq;
- /* Setup GPIOs. */
- for (i = 0; i < pdata->nr_rows + pdata->nr_cols; i++)
- pxa_gpio_mode(pdata->gpio_modes[i]);
-
/*
* Store rows/cols info into keyboard registers.
*/
diff --git a/include/asm-arm/arch-pxa/pxa27x_keypad.h
b/include/asm-arm/arch-pxa/pxa27x_keypad.h
index f19f74a..ef17db6 100644
--- a/include/asm-arm/arch-pxa/pxa27x_keypad.h
+++ b/include/asm-arm/arch-pxa/pxa27x_keypad.h
@@ -4,7 +4,6 @@
struct pxa27x_keypad_platform_data {
int nr_rows, nr_cols;
int keycodes[PXAKBD_MAXROW][PXAKBD_MAXCOL];
- int gpio_modes[PXAKBD_MAXROW + PXAKBD_MAXCOL];
#ifdef CONFIG_PM
u32 reg_kpc;
--
1.5.2.5.GIT
--
Cheers
- eric
next reply other threads:[~2008-01-23 7:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-23 7:17 eric miao [this message]
2008-01-29 6:24 ` [PATCH 2/12] pxa: remove the pin configuration from the keypad driver Dmitry Torokhov
2008-01-29 6:51 ` eric miao
2008-01-29 7:21 ` Dmitry Torokhov
2008-01-29 11:54 ` Dmitry Baryshkov
2008-01-30 0:13 ` eric miao
2008-01-30 0:52 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f17812d70801222317k641d55fy8f94c436770a8b0a@mail.gmail.com \
--to=eric.y.miao@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).