From: "eric miao" <eric.y.miao@gmail.com>
To: Dmitry Torokhov <dtor@insightbb.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH 1/12] pxa: rename the pxa27x_keyboard to pxa27x_keypad
Date: Tue, 29 Jan 2008 14:57:41 +0800 [thread overview]
Message-ID: <f17812d70801282257x573f2aehd808589344f13f9d@mail.gmail.com> (raw)
In-Reply-To: <200801290126.01530.dtor@insightbb.com>
On Jan 29, 2008 2:26 PM, Dmitry Torokhov <dtor@insightbb.com> wrote:
> Hi Eric,
>
> On Wednesday 23 January 2008 02:16, eric miao wrote:
> > Subject: [PATCH] pxa: rename the pxa27x_keyboard to pxa27x_keypad
> >
> > The controller should really be called keypad, and also align
> > the naming of functions and structures to use "pxa27x_keypad"
> > as prefix, instead of "pxakbd".
>
> Not sure what the difference is... Seems to be a gratuous renaming.
>
Yeah, though I used git-mv, the result of git-format-patch still looks horrible.
Anyway, this is just a naming issue. While other pxa drivers are slowly
transitioning to a more standard naming convention (if you take a look at
recent [arch/arm/mach-pxa/devices.c] in Linus's recent tree) I first update
this to later patches could be more specific.
Another reason I don't like pxa27x_keyboard is it's too long, really not
suitable as a prefix, and "pxakbd" reads a bit awkward.
> --
> Dmitry
>
--
Cheers
- eric
next prev parent reply other threads:[~2008-01-29 6:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-23 7:16 [PATCH 1/12] pxa: rename the pxa27x_keyboard to pxa27x_keypad eric miao
2008-01-29 6:26 ` Dmitry Torokhov
2008-01-29 6:57 ` eric miao [this message]
2008-01-29 7:22 ` Dmitry Torokhov
2008-01-31 3:31 ` eric miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f17812d70801282257x573f2aehd808589344f13f9d@mail.gmail.com \
--to=eric.y.miao@gmail.com \
--cc=dtor@insightbb.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).