From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Miao Subject: Re: sharp c-3000 aka spitz: fix warn_on introduced in 2.6.32-rc1 Date: Thu, 7 Jan 2010 15:33:46 +0800 Message-ID: References: <20100106071026.GD1382@ucw.cz> <20100107065230.GA1303@ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-qy0-f194.google.com ([209.85.221.194]:36358 "EHLO mail-qy0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756265Ab0AGHeH (ORCPT ); Thu, 7 Jan 2010 02:34:07 -0500 In-Reply-To: <20100107065230.GA1303@ucw.cz> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Pavel Machek Cc: dtor@mail.ru, linux-input@vger.kernel.org, rpurdie@rpsys.net, lenz@cs.wisc.edu, kernel list , Dirk@opfer-online.de, arminlitzel@web.de, Cyril Hrubis , thommycheck@gmail.com, linux-arm-kernel , dbaryshkov@gmail.com, omegamoon@gmail.com, utx@penguin.cz, zaurus-devel@lists.linuxtogo.org, "Rafael J. Wysocki" , Andrew Morton On Thu, Jan 7, 2010 at 2:52 PM, Pavel Machek wrote: > On Wed 2010-01-06 15:17:39, Eric Miao wrote: >> On Wed, Jan 6, 2010 at 3:10 PM, Pavel Machek wrote: >> > >> > Sharp-SL code uses strange, complex grouping of gpios for wakeups >> > toggling. Fortunately, it is unneeded in recent kernels (and actually >> > provokes WARN_ONs during resume). Remove it. >> > >> > Signed-off-by: Pavel Machek >> >> Pavel, >> >> The code to be removed below is used to support pxa27x_keypad >> to be able to resume from sleep. What's the exact reason to remove >> this on spitz? > > Well, otherwise I get this during resume: (2.6.32 regression) > > (and similar for matrix-keypad, but dmitry worked around that > already). > > Problem is that gpio-keys and matrix-keypad want to set_wake for each > gpio individually, hw can do that, but pxa27x.c breaks it. > > I don't get it; what is pxa27x_keypad used on? It looks like > matrix-keypad subset. > pxa27x has its own specific keypad controller. And since we now use enable_irq_wake, and the keypad controller has only one such IRQ_KEYPAD, will have to setup the keypad GPIO wakeup as a whole.