From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Miao Subject: Re: gpio_keys and how PXA27x sets gpio_set_wake() (was Re: sharp c-3000 aka spitz: fix warn_on introduced in 2.6.32-rc1) Date: Tue, 26 Jan 2010 19:39:40 +0800 Message-ID: References: <20100106071026.GD1382@ucw.cz> <20100107065230.GA1303@ucw.cz> <1264275669.9100.11.camel@utx.utx.cz> <1264286611.11766.49.camel@utx.utx.cz> <1264500824.4480.79.camel@utx.utx.cz> <1264502668.4480.97.camel@utx.utx.cz> Reply-To: Zaurus PDA developers list Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1264502668.4480.97.camel-VKpoJ9vcIcXrBKCeMvbIDA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: zaurus-devel-bounces-cunTk1MwBs/k6gDgw6ADrEB+6BGkLq7r@public.gmane.org Errors-To: zaurus-devel-bounces-cunTk1MwBs/k6gDgw6ADrEB+6BGkLq7r@public.gmane.org To: Stanislav Brabec Cc: Andrew Morton , thommycheck-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, dtor-JGs/UdohzUI@public.gmane.org, arminlitzel-S0/GAf8tV78@public.gmane.org, kernel list , Cyril Hrubis , Dirk-ngtJ1GK09nrbFfAX06+HdQ@public.gmane.org, "Rafael J. Wysocki" , lenz-hcNo3dDEHLuVc3sceRu5cw@public.gmane.org, Vojtech Pavlik , rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org, linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, zaurus-devel-cunTk1MwBs/k6gDgw6ADrEB+6BGkLq7r@public.gmane.org, linux-arm-kernel List-Id: linux-input@vger.kernel.org 2010/1/26 Stanislav Brabec : > Eric Miao wrote: >> 2010/1/26 Stanislav Brabec : > >> > Handling platform specific edge/level wake setup would only complicate >> > the code. (In fact, even the PXA270 platform code does not exist yet - >> > arch/arm/mach-pxa/mfp-pxa2xx.c:__mfp_config_gpio() is not capable to >> > configure Power Manager Keyboard Wake-Up Enable Register (PKWR).) >> That's why WAKEUP_ON_EDGE_* is introduced, no need for gpio-keys >> to know this. > > But WAKEUP_ON_EDGE_* is impossible for GPIO 95, > enable_irq_wake()/gpio_set_wake() returns EINVAL and disable_irq_wake() > complains on "Unbalanced IRQ 191". > Now I see, but I don't know why disable_irq_wake() will complains about unbalance since it should really manage it well. A quick dirty solution would be the platform to call keypad_set_wake() directly somewhere. Otherwise we have to let gpio_set_wake() to handle those keypad GPIOs and to live together with keypad_set_wake() happily, which is really difficult. > In case of Zaurus, gpio_keys.c have to live with wakeup on level (PKWR) > when using enable/disable_irq_wake(). > >> > The problem affects gpio_keys: It is a driver implementing "one key per >> > gpio". It now handles On/Off and lid switches on Zaurus. Lid switches >> > are on "normal" GPIOs, On/Off switch is wired to PKWR capable GPIO. >> Ain't On/Off switch one of the matrix key? And so SPITZ_GPIO_KEY_INT >> could be used to handle that? > > No. On/Off is connected directly to GPIO 95. Other keys use strobe/sense > matrix keypad. > > SPITZ_GPIO_KEY_INT is a bit unspecific. I think it means: Charger was > inserted or key was pressed or On/Off was pressed. > > > > ________________________________________________________________________ > Stanislav Brabec > http://www.penguin.cz/~utx/zaurus > >