* GeneralTouch USB Touchscreen Support
@ 2007-10-08 10:05 if
2007-10-08 13:23 ` Dmitry Torokhov
0 siblings, 1 reply; 6+ messages in thread
From: if @ 2007-10-08 10:05 UTC (permalink / raw)
To: dmitry.torokhov; +Cc: linux-input
Hello!
Sending patch as told to.
Formal notes:
Patch made against 2.6.22.9 sources.
Marketing is lying, quick google for model ( TL6B17S) shows they say
it has 4096x4096 sensitivity, while device itself do not report more
than 0x0470 (i set 0x0500 as max), so with monitors greater than 1024
pixels special calibration is needed.
I wrote mail to manufacturer asking for linux drivers but got no
response, so i had no way but to sniff the usb bus and figure out how
to make the device work, and reversing is not illegal in my country.
I agree with GPL of course, the following patch can be used according to it ;-)
hope that's all
regards,
Ilya Frolov
======== lsusb -v for this device ===========
Bus 003 Device 002: ID 0dfc:0001 GeneralTouch Technology Co., Ltd Touchscreen
Device Descriptor:
bLength 18
bDescriptorType 1
bcdUSB 1.10
bDeviceClass 0 (Defined at Interface level)
bDeviceSubClass 0
bDeviceProtocol 0
bMaxPacketSize0 8
idVendor 0x0dfc GeneralTouch Technology Co., Ltd
idProduct 0x0001 Touchscreen
bcdDevice 0.01
iManufacturer 1 General Touch Co. Ltd.
iProduct 2 GeneralTouch USB Touchscreen
iSerial 0
bNumConfigurations 1
Configuration Descriptor:
bLength 9
bDescriptorType 2
wTotalLength 34
bNumInterfaces 1
bConfigurationValue 1
iConfiguration 4 HID Touchscreen
bmAttributes 0x60
(Missing must-be-set bit!)
Self Powered
Remote Wakeup
MaxPower 100mA
Interface Descriptor:
bLength 9
bDescriptorType 4
bInterfaceNumber 0
bAlternateSetting 0
bNumEndpoints 1
bInterfaceClass 3 Human Interface Devices
bInterfaceSubClass 0 No Subclass
bInterfaceProtocol 2 Mouse
iInterface 0
HID Device Descriptor:
bLength 9
bDescriptorType 33
bcdHID 1.10
bCountryCode 0 Not supported
bNumDescriptors 1
bDescriptorType 34 Report
wDescriptorLength 85
Report Descriptors:
** UNAVAILABLE **
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x81 EP 1 IN
bmAttributes 3
Transfer Type Interrupt
Synch Type None
Usage Type Data
wMaxPacketSize 0x0007 1x 7 bytes
bInterval 10
Device Status: 0x0000
(Bus Powered)
========= REST IS PATCH =============
diff -uprN -X linux-2.6.22.9-vanilla/Documentation/dontdiff
linux-2.6.22.9-vanilla/drivers/hid/usbhid/hid-quirks.c
linux-2.6.22.9.my/drivers/hid/usbhid/hid-quirks.c
--- linux-2.6.22.9-vanilla/drivers/hid/usbhid/hid-quirks.c 2007-09-26
22:03:01.000000000 +0400
+++ linux-2.6.22.9.my/drivers/hid/usbhid/hid-quirks.c 2007-10-04
13:36:52.000000000 +0400
@@ -217,6 +217,8 @@
#define USB_VENDOR_ID_PANJIT 0x134c
+#define USB_VENDOR_ID_GENERAL_TOUCH 0x0dfc
+
#define USB_VENDOR_ID_PANTHERLORD 0x0810
#define USB_DEVICE_ID_PANTHERLORD_TWIN_USB_JOYSTICK 0x0001
@@ -284,7 +286,7 @@ static const struct hid_blacklist {
{ USB_VENDOR_ID_NEC, USB_DEVICE_ID_NEC_USB_GAME_PAD, HID_QUIRK_BADPAD },
{ USB_VENDOR_ID_SAITEK, USB_DEVICE_ID_SAITEK_RUMBLEPAD, HID_QUIRK_BADPAD },
{ USB_VENDOR_ID_TOPMAX, USB_DEVICE_ID_TOPMAX_COBRAPAD, HID_QUIRK_BADPAD },
-
+
{ USB_VENDOR_ID_CHERRY, USB_DEVICE_ID_CHERRY_CYMOTION, HID_QUIRK_CYMOTION },
{ USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_DINOVO_EDGE,
HID_QUIRK_DUPLICATE_USAGES },
@@ -397,6 +399,10 @@ static const struct hid_blacklist {
{ USB_VENDOR_ID_PANJIT, 0x0002, HID_QUIRK_IGNORE },
{ USB_VENDOR_ID_PANJIT, 0x0003, HID_QUIRK_IGNORE },
{ USB_VENDOR_ID_PANJIT, 0x0004, HID_QUIRK_IGNORE },
+ { USB_VENDOR_ID_GENERAL_TOUCH, 0x0001, HID_QUIRK_IGNORE },
+ { USB_VENDOR_ID_GENERAL_TOUCH, 0x0002, HID_QUIRK_IGNORE },
+ { USB_VENDOR_ID_GENERAL_TOUCH, 0x0003, HID_QUIRK_IGNORE },
+ { USB_VENDOR_ID_GENERAL_TOUCH, 0x0004, HID_QUIRK_IGNORE },
{ USB_VENDOR_ID_VERNIER, USB_DEVICE_ID_VERNIER_LABPRO, HID_QUIRK_IGNORE },
{ USB_VENDOR_ID_VERNIER, USB_DEVICE_ID_VERNIER_GOTEMP, HID_QUIRK_IGNORE },
{ USB_VENDOR_ID_VERNIER, USB_DEVICE_ID_VERNIER_SKIP, HID_QUIRK_IGNORE },
@@ -581,7 +587,7 @@ static void usbhid_remove_all_dquirks(vo
}
-/**
+/**
* usbhid_quirks_init: apply USB HID quirks specified at module load time
*/
int usbhid_quirks_init(char **quirks_param)
@@ -644,7 +650,7 @@ static const struct hid_blacklist *usbhi
if (bl_entry != NULL)
dbg("Found squirk 0x%x for USB HID vendor 0x%hx prod 0x%hx\n",
- bl_entry->quirks, bl_entry->idVendor,
+ bl_entry->quirks, bl_entry->idVendor,
bl_entry->idProduct);
return bl_entry;
}
diff -uprN -X linux-2.6.22.9-vanilla/Documentation/dontdiff
linux-2.6.22.9-vanilla/drivers/input/touchscreen/Kconfig
linux-2.6.22.9.my/drivers/input/touchscreen/Kconfig
--- linux-2.6.22.9-vanilla/drivers/input/touchscreen/Kconfig 2007-09-26
22:03:01.000000000 +0400
+++ linux-2.6.22.9.my/drivers/input/touchscreen/Kconfig 2007-10-04
12:58:16.000000000 +0400
@@ -219,4 +219,9 @@ config TOUCHSCREEN_USB_DMC_TSC10
bool "DMC TSC-10/25 device support" if EMBEDDED
depends on TOUCHSCREEN_USB_COMPOSITE
+config TOUCHSCREEN_USB_GENERAL_TOUCH
+ default y
+ bool "GeneralTouch Touchscreen device support" if EMBEDDED
+ depends on TOUCHSCREEN_USB_COMPOSITE
+
endif
diff -uprN -X linux-2.6.22.9-vanilla/Documentation/dontdiff
linux-2.6.22.9-vanilla/drivers/input/touchscreen/usbtouchscreen.c
linux-2.6.22.9.my/drivers/input/touchscreen/usbtouchscreen.c
--- linux-2.6.22.9-vanilla/drivers/input/touchscreen/usbtouchscreen.c 2007-09-26
22:03:01.000000000 +0400
+++ linux-2.6.22.9.my/drivers/input/touchscreen/usbtouchscreen.c 2007-10-05
11:40:36.000000000 +0400
@@ -110,6 +110,7 @@ enum {
DEVTYPE_ETURBO,
DEVTYPE_GUNZE,
DEVTYPE_DMC_TSC10,
+ DEVTYPE_GENERAL_TOUCH,
};
static struct usb_device_id usbtouch_devices[] = {
@@ -150,6 +151,10 @@ static struct usb_device_id usbtouch_dev
{USB_DEVICE(0x0afa, 0x03e8), .driver_info = DEVTYPE_DMC_TSC10},
#endif
+#ifdef CONFIG_TOUCHSCREEN_USB_GENERAL_TOUCH
+ {USB_DEVICE(0x0dfc, 0x0001), .driver_info = DEVTYPE_GENERAL_TOUCH},
+#endif
+
{}
};
@@ -414,6 +419,20 @@ static int dmc_tsc10_read_data(struct us
}
#endif
+/*****************************************************************************
+ * General Touch Part
+ */
+#ifdef CONFIG_TOUCHSCREEN_USB_GENERAL_TOUCH
+static int general_touch_read_data(struct usbtouch_usb *dev, unsigned
char *pkt)
+{
+ dev->x = ((pkt[2] & 0x0F) << 8) | pkt[1] ;
+ dev->y = ((pkt[4] & 0x0F) << 8) | pkt[3] ;
+ dev->press = pkt[5] & 0xff;
+ dev->touch = pkt[0] & 0x01;
+
+ return 1;
+}
+#endif
/*****************************************************************************
* the different device descriptors
@@ -504,6 +523,18 @@ static struct usbtouch_device_info usbto
.read_data = dmc_tsc10_read_data,
},
#endif
+
+#ifdef CONFIG_TOUCHSCREEN_USB_GENERAL_TOUCH
+ [DEVTYPE_GENERAL_TOUCH] = {
+ .min_xc = 0x0,
+ .max_xc = 0x0500,
+ .min_yc = 0x0,
+ .max_yc = 0x0500,
+ .rept_size = 7,
+ .read_data = general_touch_read_data,
+ }
+#endif
+
};
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: GeneralTouch USB Touchscreen Support
2007-10-08 10:05 GeneralTouch USB Touchscreen Support if
@ 2007-10-08 13:23 ` Dmitry Torokhov
2007-10-08 14:36 ` Jiri Kosina
0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Torokhov @ 2007-10-08 13:23 UTC (permalink / raw)
To: zeylienospam; +Cc: linux-input
Hi Ilya,
On 10/8/07, if <zeylie@gmail.com> wrote:
> Hello!
>
> Sending patch as told to.
> Formal notes:
> Patch made against 2.6.22.9 sources.
> Marketing is lying, quick google for model ( TL6B17S) shows they say
> it has 4096x4096 sensitivity, while device itself do not report more
> than 0x0470 (i set 0x0500 as max), so with monitors greater than 1024
> pixels special calibration is needed.
> I wrote mail to manufacturer asking for linux drivers but got no
> response, so i had no way but to sniff the usb bus and figure out how
> to make the device work, and reversing is not illegal in my country.
> I agree with GPL of course, the following patch can be used according to it ;-)
>
The patch looks good, thanks a lot.
Can I please have your "Signed-off-by:" so I can apply it? Thanks!
--
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: GeneralTouch USB Touchscreen Support
2007-10-08 13:23 ` Dmitry Torokhov
@ 2007-10-08 14:36 ` Jiri Kosina
2007-10-08 18:04 ` if
2007-10-11 12:02 ` Dmitry Torokhov
0 siblings, 2 replies; 6+ messages in thread
From: Jiri Kosina @ 2007-10-08 14:36 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: zeylienospam, linux-input
On Mon, 8 Oct 2007, Dmitry Torokhov wrote:
> The patch looks good, thanks a lot. Can I please have your
> "Signed-off-by:" so I can apply it? Thanks!
Hi,
my only concern with this patch is -- could we please keep the entries in
hid_blacklist[] properly sorted? (i.e. first by quirk type, then by vendor
name).
Also, patch to hid-quirks seem to contain some whitespace changes, I'd
like to do this separately if possible.
Besides that, I am fine with that and you can add
Signed-off-by: Jiri Koisna <jkosina@suse.cz>
for the HID part of the patch if you want to.
Thanks,
--
Jiri Kosina
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: GeneralTouch USB Touchscreen Support
2007-10-08 14:36 ` Jiri Kosina
@ 2007-10-08 18:04 ` if
2007-10-11 12:02 ` Dmitry Torokhov
1 sibling, 0 replies; 6+ messages in thread
From: if @ 2007-10-08 18:04 UTC (permalink / raw)
To: dmitry.torokhov; +Cc: linux-input
Hello!
Thanks for correcting me (my vim automatically strips leading whitespace)
Below is the correct patch, without whitespace difference and with
hid-quirks entry sorted.
Signed-off-by: Ilya Frolov <zeylie@gmail.com>
regards,
Ilya
========== REST IS PATCH ===================
diff -uprNb -X linux-2.6.22.9-vanilla/Documentation/dontdiff
linux-2.6.22.9-vanilla/drivers/hid/usbhid/hid-quirks.c
linux-2.6.22.9.my/drivers/hid/usbhid/hid-quirks.c
--- linux-2.6.22.9-vanilla/drivers/hid/usbhid/hid-quirks.c 2007-09-26
22:03:01.000000000 +0400
+++ linux-2.6.22.9.my/drivers/hid/usbhid/hid-quirks.c 2007-10-08
21:55:50.000000000 +0400
@@ -105,6 +105,8 @@
#define USB_VENDOR_ID_ESSENTIAL_REALITY 0x0d7f
#define USB_DEVICE_ID_ESSENTIAL_REALITY_P5 0x0100
+#define USB_VENDOR_ID_GENERAL_TOUCH 0x0dfc
+
#define USB_VENDOR_ID_GLAB 0x06c2
#define USB_DEVICE_ID_4_PHIDGETSERVO_30 0x0038
#define USB_DEVICE_ID_1_PHIDGETSERVO_30 0x0039
@@ -308,6 +310,10 @@ static const struct hid_blacklist {
{ USB_VENDOR_ID_DELORME, USB_DEVICE_ID_DELORME_EARTHMATE, HID_QUIRK_IGNORE },
{ USB_VENDOR_ID_DELORME, USB_DEVICE_ID_DELORME_EM_LT20, HID_QUIRK_IGNORE },
{ USB_VENDOR_ID_ESSENTIAL_REALITY,
USB_DEVICE_ID_ESSENTIAL_REALITY_P5, HID_QUIRK_IGNORE },
+ { USB_VENDOR_ID_GENERAL_TOUCH, 0x0001, HID_QUIRK_IGNORE },
+ { USB_VENDOR_ID_GENERAL_TOUCH, 0x0002, HID_QUIRK_IGNORE },
+ { USB_VENDOR_ID_GENERAL_TOUCH, 0x0003, HID_QUIRK_IGNORE },
+ { USB_VENDOR_ID_GENERAL_TOUCH, 0x0004, HID_QUIRK_IGNORE },
{ USB_VENDOR_ID_GLAB, USB_DEVICE_ID_4_PHIDGETSERVO_30, HID_QUIRK_IGNORE },
{ USB_VENDOR_ID_GLAB, USB_DEVICE_ID_1_PHIDGETSERVO_30, HID_QUIRK_IGNORE },
{ USB_VENDOR_ID_GLAB, USB_DEVICE_ID_0_0_4_IF_KIT, HID_QUIRK_IGNORE },
diff -uprNb -X linux-2.6.22.9-vanilla/Documentation/dontdiff
linux-2.6.22.9-vanilla/drivers/input/touchscreen/Kconfig
linux-2.6.22.9.my/drivers/input/touchscreen/Kconfig
--- linux-2.6.22.9-vanilla/drivers/input/touchscreen/Kconfig 2007-09-26
22:03:01.000000000 +0400
+++ linux-2.6.22.9.my/drivers/input/touchscreen/Kconfig 2007-10-04
12:58:16.000000000 +0400
@@ -219,4 +219,9 @@ config TOUCHSCREEN_USB_DMC_TSC10
bool "DMC TSC-10/25 device support" if EMBEDDED
depends on TOUCHSCREEN_USB_COMPOSITE
+config TOUCHSCREEN_USB_GENERAL_TOUCH
+ default y
+ bool "GeneralTouch Touchscreen device support" if EMBEDDED
+ depends on TOUCHSCREEN_USB_COMPOSITE
+
endif
diff -uprNb -X linux-2.6.22.9-vanilla/Documentation/dontdiff
linux-2.6.22.9-vanilla/drivers/input/touchscreen/usbtouchscreen.c
linux-2.6.22.9.my/drivers/input/touchscreen/usbtouchscreen.c
--- linux-2.6.22.9-vanilla/drivers/input/touchscreen/usbtouchscreen.c 2007-09-26
22:03:01.000000000 +0400
+++ linux-2.6.22.9.my/drivers/input/touchscreen/usbtouchscreen.c 2007-10-08
21:42:35.000000000 +0400
@@ -110,6 +110,7 @@ enum {
DEVTYPE_ETURBO,
DEVTYPE_GUNZE,
DEVTYPE_DMC_TSC10,
+ DEVTYPE_GENERAL_TOUCH,
};
static struct usb_device_id usbtouch_devices[] = {
@@ -150,6 +151,10 @@ static struct usb_device_id usbtouch_dev
{USB_DEVICE(0x0afa, 0x03e8), .driver_info = DEVTYPE_DMC_TSC10},
#endif
+#ifdef CONFIG_TOUCHSCREEN_USB_GENERAL_TOUCH
+ {USB_DEVICE(0x0dfc, 0x0001), .driver_info = DEVTYPE_GENERAL_TOUCH},
+#endif
+
{}
};
@@ -414,6 +419,20 @@ static int dmc_tsc10_read_data(struct us
}
#endif
+/*****************************************************************************
+ * General Touch Part
+ */
+#ifdef CONFIG_TOUCHSCREEN_USB_GENERAL_TOUCH
+static int general_touch_read_data(struct usbtouch_usb *dev, unsigned
char *pkt)
+{
+ dev->x = ((pkt[2] & 0x0F) << 8) | pkt[1] ;
+ dev->y = ((pkt[4] & 0x0F) << 8) | pkt[3] ;
+ dev->press = pkt[5] & 0xff;
+ dev->touch = pkt[0] & 0x01;
+
+ return 1;
+}
+#endif
/*****************************************************************************
* the different device descriptors
@@ -504,6 +523,18 @@ static struct usbtouch_device_info usbto
.read_data = dmc_tsc10_read_data,
},
#endif
+
+#ifdef CONFIG_TOUCHSCREEN_USB_GENERAL_TOUCH
+ [DEVTYPE_GENERAL_TOUCH] = {
+ .min_xc = 0x0,
+ .max_xc = 0x0500,
+ .min_yc = 0x0,
+ .max_yc = 0x0500,
+ .rept_size = 7,
+ .read_data = general_touch_read_data,
+ }
+#endif
+
};
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: GeneralTouch USB Touchscreen Support
2007-10-08 14:36 ` Jiri Kosina
2007-10-08 18:04 ` if
@ 2007-10-11 12:02 ` Dmitry Torokhov
2007-10-11 12:05 ` Jiri Kosina
1 sibling, 1 reply; 6+ messages in thread
From: Dmitry Torokhov @ 2007-10-11 12:02 UTC (permalink / raw)
To: Jiri Kosina; +Cc: zeylienospam, linux-input
Hi Jiri,
On Monday 08 October 2007, Jiri Kosina wrote:
> On Mon, 8 Oct 2007, Dmitry Torokhov wrote:
>
> > The patch looks good, thanks a lot. Can I please have your
> > "Signed-off-by:" so I can apply it? Thanks!
>
> Hi,
>
> my only concern with this patch is -- could we please keep the entries in
> hid_blacklist[] properly sorted? (i.e. first by quirk type, then by vendor
> name).
>
> Also, patch to hid-quirks seem to contain some whitespace changes, I'd
> like to do this separately if possible.
>
> Besides that, I am fine with that and you can add
>
> Signed-off-by: Jiri Koisna <jkosina@suse.cz>
>
> for the HID part of the patch if you want to.
>
I'd rather HID part go through your tree. Here is is split out.
--
Dmitry
--------------------------------------------------------------------
Subject: HID: Add GeneralTouch touchscreen to the blacklist
From: Ilya Frolov <zeylie@gmail.com>
GeneralTouch touchscreens are handled by usbtouchscreen driver,
make sure HID ignores them.
Signed-off-by: Ilya Frolov <zeylie@gmail.com>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
---
drivers/hid/usbhid/hid-quirks.c | 6 ++++++
1 file changed, 6 insertions(+)
Index: work/drivers/hid/usbhid/hid-quirks.c
===================================================================
--- work.orig/drivers/hid/usbhid/hid-quirks.c
+++ work/drivers/hid/usbhid/hid-quirks.c
@@ -110,6 +110,8 @@
#define USB_VENDOR_ID_GAMERON 0x0810
#define USB_DEVICE_ID_GAMERON_DUAL_PSX_ADAPTOR 0x0001
+#define USB_VENDOR_ID_GENERAL_TOUCH 0x0dfc
+
#define USB_VENDOR_ID_GLAB 0x06c2
#define USB_DEVICE_ID_4_PHIDGETSERVO_30 0x0038
#define USB_DEVICE_ID_1_PHIDGETSERVO_30 0x0039
@@ -392,6 +394,10 @@ static const struct hid_blacklist {
{ USB_VENDOR_ID_DELORME, USB_DEVICE_ID_DELORME_EARTHMATE, HID_QUIRK_IGNORE },
{ USB_VENDOR_ID_DELORME, USB_DEVICE_ID_DELORME_EM_LT20, HID_QUIRK_IGNORE },
{ USB_VENDOR_ID_ESSENTIAL_REALITY, USB_DEVICE_ID_ESSENTIAL_REALITY_P5, HID_QUIRK_IGNORE },
+ { USB_VENDOR_ID_GENERAL_TOUCH, 0x0001, HID_QUIRK_IGNORE },
+ { USB_VENDOR_ID_GENERAL_TOUCH, 0x0002, HID_QUIRK_IGNORE },
+ { USB_VENDOR_ID_GENERAL_TOUCH, 0x0003, HID_QUIRK_IGNORE },
+ { USB_VENDOR_ID_GENERAL_TOUCH, 0x0004, HID_QUIRK_IGNORE },
{ USB_VENDOR_ID_GLAB, USB_DEVICE_ID_4_PHIDGETSERVO_30, HID_QUIRK_IGNORE },
{ USB_VENDOR_ID_GLAB, USB_DEVICE_ID_1_PHIDGETSERVO_30, HID_QUIRK_IGNORE },
{ USB_VENDOR_ID_GLAB, USB_DEVICE_ID_0_0_4_IF_KIT, HID_QUIRK_IGNORE },
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: GeneralTouch USB Touchscreen Support
2007-10-11 12:02 ` Dmitry Torokhov
@ 2007-10-11 12:05 ` Jiri Kosina
0 siblings, 0 replies; 6+ messages in thread
From: Jiri Kosina @ 2007-10-11 12:05 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: zeylienospam, linux-input
On Thu, 11 Oct 2007, Dmitry Torokhov wrote:
> I'd rather HID part go through your tree. Here is is split out.
Hi Dmitry,
thanks, I will take this through my tree. I am planning to send the pull
request to Linus by the end of this week.
--
Jiri Kosina
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2007-10-11 12:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-08 10:05 GeneralTouch USB Touchscreen Support if
2007-10-08 13:23 ` Dmitry Torokhov
2007-10-08 14:36 ` Jiri Kosina
2007-10-08 18:04 ` if
2007-10-11 12:02 ` Dmitry Torokhov
2007-10-11 12:05 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).