linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Pablo Ceballos <pceballos@google.com>,
	Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH] HID: Add driver for Google Hangouts Meet Speakermic
Date: Mon, 28 Mar 2022 17:46:27 -0700	[thread overview]
Message-ID: <f4932722-c577-f03c-8296-c49a8dd8b14f@infradead.org> (raw)
In-Reply-To: <20220328185704.1.I7a855580ce9f43fc2f598bdccf088c978d4af822@changeid>

Hi--

On 3/28/22 16:03, Pablo Ceballos wrote:
> This driver works around a problem with the HID usage sent by this
> device for the mute button. It prevents key events from being generated
> for that HID usage since they would be incorrect.
> 
> Signed-off-by: Pablo Ceballos <pceballos@google.com>
> ---
> 
>  drivers/hid/Kconfig            | 12 ++++++++
>  drivers/hid/Makefile           |  1 +
>  drivers/hid/hid-google-atrus.c | 55 ++++++++++++++++++++++++++++++++++
>  drivers/hid/hid-ids.h          |  1 +
>  4 files changed, 69 insertions(+)
>  create mode 100644 drivers/hid/hid-google-atrus.c
> 
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index f5544157576c..dc6ae9970054 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -403,6 +403,18 @@ config HOLTEK_FF
>  	  Say Y here if you have a Holtek On Line Grip based game controller
>  	  and want to have force feedback support for it.
>  
> +config HID_GOOGLE_ATRUS
> +	tristate "Google Hangouts Meet Speakermic"
> +	depends on USB_HID
> +	---help---

Just	help

The ---help--- form is no longer used.

> +	This selects a driver for the Google Hangouts Meet Speakermic.
> +
> +	This driver works around a problem with the HID usage sent by this
> +	device for the mute button. It prevents key events from being generated
> +	for that HID usage since they would be incorrect.
> +
> +	Say Y here if you have a Google Hangouts Meet Speakermic.
> +
>  config HID_GOOGLE_HAMMER
>  	tristate "Google Hammer Keyboard"
>  	depends on USB_HID && LEDS_CLASS && CROS_EC


-- 
~Randy

  reply	other threads:[~2022-03-29  0:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-28 23:03 [PATCH] HID: Add driver for Google Hangouts Meet Speakermic Pablo Ceballos
2022-03-29  0:46 ` Randy Dunlap [this message]
2022-03-29  1:16   ` [PATCH v2] " Pablo Ceballos
2022-03-29  2:35 ` [PATCH] " kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2022-02-23 22:09 Pablo Ceballos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f4932722-c577-f03c-8296-c49a8dd8b14f@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=benjamin.tissoires@redhat.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pceballos@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).