From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christopher Heiny Subject: Re: [PATCH 1/2] Input: synaptics-rmi4 - clear irqs before set irqs Date: Tue, 2 Apr 2019 16:16:13 +0000 Message-ID: References: <20190220164200.31044-1-aaron.ma@canonical.com> <17cd420ea32a9787c56ba25e36e7661541c2f65f.camel@synaptics.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US Content-ID: <2CBB9A7432A4B94191621205712F8E59@namprd03.prod.outlook.com> Sender: linux-kernel-owner@vger.kernel.org To: Aaron Ma , "dmitry.torokhov@gmail.com" , "linux-input@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Andrew Duggan , "benjamin.tissoires@redhat.com" List-Id: linux-input@vger.kernel.org T24gVGh1LCAyMDE5LTAzLTI4IGF0IDE0OjAyICswODAwLCBBYXJvbiBNYSB3cm90ZToNCj4gSGkg RG1pdHJ5IGFuZCBDaGlyaXN0b3BoZXI6DQo+IA0KPiBEbyB5b3UgaGF2ZSBhbnkgc3VnZ2VzdGlv biBhYm91dCB0aGVzZSAyIHBhdGNoZXM/DQo+IA0KPiBNYW55IHVzZXJzIGNvbmZpcm1lZCB0aGF0 IHRoZXkgZml4ZWQgaXNzdWVzIG9mIFRyYWNrcG9pbnQvVG91Y2hwYWQNCj4gYWZ0ZXIgUzMuDQo+ IA0KPiBXaWxsIHlvdSBjb25zaWRlciB0aGVtIGJlIGFjY2VwdGVkPw0KDQpIaSBBYXJvbiwNCg0K U29ycnkgLSBJIHRob3VnaHQgSSdkIHJlcGxpZWQgb24gdGhlIE5PIFNMRUVQIHBvcnRpb24gb2Yg dGhlc2UgcGF0Y2hlcywNCmJ1dCBsb29raW5nIGJhY2sgSSBkb24ndCBmaW5kIHRoZSBkcmFmdCBv ciB0aGUgc2VudCBlbWFpbC4gIFNvcnJ5IGFib3V0DQp0aGF0LiAgSSdsbCBzdW1tYXJpemUgaGVy ZSB3aGF0IEkgd3JvdGUgbGFzdCBtb250aC4NCg0KVGhpcyBpc24ndCBzbyBtdWNoIGEgImZpeCIg YXMgYSAiaGFja3kgd29ya2Fyb3VuZCIgZm9yIHRoZSBpc3N1ZS4gIEZyb20NCnRoZSBkZXNjcmlw dGlvbnMgaW4gdGhlIGJ1ZyB5b3UgbGlua2VkIGluIHlvdXIgb3JpZ2luYWwgcGF0Y2gNCnN1Ym1p c3Npb24sIGl0IGFwcGVhcnMgdGhhdCB0aGUgcm9vdCBjYXVzZSBpcyBzb21ld2hlcmUgaW4gU01C dXMgc3lzdGVtDQooY291bGQgYmUgU01CdXMgZHJpdmVyLCBTTUJ1cyBoYXJkd2FyZSwgb3IgdGhl IGRldmljZXMgb24gdGhlIFNNQnVzDQoodG91Y2ggZGV2aWNlcyBvciBvdGhlciBkZXZpY2VzKSAt IGl0J3MgaGFyZCB0byB0ZWxsIHdpdGggdGhlIGluZm8NCmF2YWlsYWJsZSksIHdoZXJlIHRoZSBT TUJ1cyBpcyBmYWlsaW5nIHRvIGNvbWUgb25saW5lIGNvcnJlY3RseSBjb21pbmcNCm91dCBvZiBT MyBzdGF0ZS4gIEFueXdheSwgdGhpcyBwYXRjaCBkb2Vzbid0IGZpeCB0aGUgcm9vdCBjYXVzZSwg YnV0DQptZXJlbHkgd29ya3MgYXJvdW5kIGl0Lg0KDQpTZXR0aW5nIHRoZSBOTyBTTEVFUCBiaXQg d2lsbCBmb3JjZSB0aGUgdG91Y2ggc2Vuc29yIHRvIHJlbWFpbiBpbiBhDQpoaWdoIHBvd2VyIGNv bnN1bXB0aW9uIHN0YXRlIHdoaWxlIHRoZSByZXN0IG9mIHRoZSBzeXN0ZW0gaXMgaW4gUzMuIA0K V2hpbGUgbm90IGEgbG90IG9mIHBvd2VyIGNvbXBhcmVkIHRvIHRoaW5ncyBsaWtlIHRoZSBDUFUs IGRpc3BsYXksIGFuZA0Kb3RoZXJzLCBpdCBpcyBzdGlsbCBub24tdHJpdmlhbCBhbmQgd2lsbCBy ZXN1bHQgaW4gc2hvcnRlciB0aW1lLW9uLQ0KYmF0dGVyeSBjYXBhYmlsaXR5Lg0KDQpJZiB5b3Ug aGF2ZSBhY2Nlc3MgdG8gdGhlIHBvd2VyIHBpbihzKSBmb3IgdGhlIHRvdWNoIHNlbnNvcihzKS9z dHlrKHMpLA0KaXQgbWlnaHQgYmUgaW50ZXJlc3RpbmcgdG8gdHJ5IHR1cm5pbmcgcG93ZXIgb2Zm IG9uIGVudGVyaW5nIFMzLCBhbmQNCnJlc3RvcmluZyBpdCBvbiBleGl0LiAgVGhhdCdzIHZlcnkg aGFja3ksIGFuZCBoYXMgdGhlIHNpZGUgZWZmZWN0IG9mDQpzbGlnaHRseSBkZWxheWluZyB0b3Vj aHBhZCByZWFkaW5lc3Mgb24gZXhpdCBmcm9tIFMzLiAgUGx1cyB5b3UnbGwgbmVlZA0KdG8gcmVz dG9yZSB0b3VjaCBzZW5zb3IgY29uZmlndXJhdGlvbiBzZXR0aW5ncyBvbiBleGl0LiAgQnV0IGl0 DQpkZWZpbml0ZWx5IHJlZHVjZXMgcG93ZXIgY29uc3VtcHRpb24uDQoNCg0KU2VwYXJhdGVseSwg SSBhbSBzdGlsbCBjb25jZXJuZWQgYWJvdXQgdGhlIHBvc3NpYmlsaXR5IG9mIGRyb3BwZWQgdG91 Y2gNCmV2ZW50cyBpbiB0aGUgSVJRIGNsZWFyaW5nLiAgSSdtIG5vdCBjb252aW5jZWQgdGhhdCB0 aGUgY29kZSBpcyBzYWZlDQooYXMgeW91IG1lbnRpb25lZCBpbiB5b3VyIHJlcGx5IHRvIG15IGVh cmxpZXIgY29tbWVudCksIHNvIEknbGwgaGF2ZSB0bw0Kc3R1ZHkgdGhlIGltcGxlbWVudGF0aW9u IG1vcmUgY2FyZWZ1bGx5Lg0KDQoJCQkJCUNoZWVycywNCgkJCQkJCUNocmlzDQoNCg0KDQo+IA0K PiBUaGFua3MsDQo+IEFhcm9uDQoNCg0K