From: Denis Benato <benato.denis96@gmail.com>
To: Antheas Kapenekakis <lkml@antheas.dev>,
platform-driver-x86@vger.kernel.org, linux-input@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, "Jiri Kosina" <jikos@kernel.org>,
"Benjamin Tissoires" <bentiss@kernel.org>,
"Corentin Chary" <corentin.chary@gmail.com>,
"Luke D . Jones" <luke@ljones.dev>,
"Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: Re: [PATCH v10 09/11] platform/x86: asus-wmi: remove unused keyboard backlight quirk
Date: Wed, 26 Nov 2025 21:19:37 +0100 [thread overview]
Message-ID: <f5220043-f685-4778-9fc7-9c3585c01fb3@gmail.com> (raw)
In-Reply-To: <20251122110032.4274-10-lkml@antheas.dev>
On 11/22/25 12:00, Antheas Kapenekakis wrote:
> The quirk for selecting whether keyboard backlight should be controlled
> by HID or WMI is not needed anymore, so remove the file containing it.
Reviewed-by: Denis Benato <benato.denis96@gmail.com>
> Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
> ---
> .../platform_data/x86/asus-wmi-leds-ids.h | 50 -------------------
> 1 file changed, 50 deletions(-)
> delete mode 100644 include/linux/platform_data/x86/asus-wmi-leds-ids.h
>
> diff --git a/include/linux/platform_data/x86/asus-wmi-leds-ids.h b/include/linux/platform_data/x86/asus-wmi-leds-ids.h
> deleted file mode 100644
> index 034a039c4e37..000000000000
> --- a/include/linux/platform_data/x86/asus-wmi-leds-ids.h
> +++ /dev/null
> @@ -1,50 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0 */
> -#ifndef __PLATFORM_DATA_X86_ASUS_WMI_LEDS_IDS_H
> -#define __PLATFORM_DATA_X86_ASUS_WMI_LEDS_IDS_H
> -
> -#include <linux/dmi.h>
> -#include <linux/types.h>
> -
> -/* To be used by both hid-asus and asus-wmi to determine which controls kbd_brightness */
> -#if IS_REACHABLE(CONFIG_ASUS_WMI) || IS_REACHABLE(CONFIG_HID_ASUS)
> -static const struct dmi_system_id asus_use_hid_led_dmi_ids[] = {
> - {
> - .matches = {
> - DMI_MATCH(DMI_PRODUCT_FAMILY, "ROG Zephyrus"),
> - },
> - },
> - {
> - .matches = {
> - DMI_MATCH(DMI_PRODUCT_FAMILY, "ROG Strix"),
> - },
> - },
> - {
> - .matches = {
> - DMI_MATCH(DMI_PRODUCT_FAMILY, "ROG Flow"),
> - },
> - },
> - {
> - .matches = {
> - DMI_MATCH(DMI_PRODUCT_FAMILY, "ProArt P16"),
> - },
> - },
> - {
> - .matches = {
> - DMI_MATCH(DMI_BOARD_NAME, "GA403U"),
> - },
> - },
> - {
> - .matches = {
> - DMI_MATCH(DMI_BOARD_NAME, "GU605M"),
> - },
> - },
> - {
> - .matches = {
> - DMI_MATCH(DMI_BOARD_NAME, "RC71L"),
> - },
> - },
> - { },
> -};
> -#endif
> -
> -#endif /* __PLATFORM_DATA_X86_ASUS_WMI_LEDS_IDS_H */
next prev parent reply other threads:[~2025-11-26 20:19 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-22 11:00 [PATCH v10 00/11] HID: asus: Fix ASUS ROG Laptop's Keyboard backlight handling Antheas Kapenekakis
2025-11-22 11:00 ` [PATCH v10 01/11] HID: asus: simplify RGB init sequence Antheas Kapenekakis
2025-11-22 11:00 ` [PATCH v10 02/11] HID: asus: initialize additional endpoints only for legacy devices Antheas Kapenekakis
2025-11-26 20:27 ` Denis Benato
2025-11-22 11:00 ` [PATCH v10 03/11] HID: asus: use same report_id in response Antheas Kapenekakis
2025-11-22 11:00 ` [PATCH v10 04/11] HID: asus: fortify keyboard handshake Antheas Kapenekakis
2025-11-22 13:13 ` Denis Benato
2025-11-26 20:09 ` Denis Benato
2025-12-02 11:17 ` Benjamin Tissoires
2025-11-22 11:00 ` [PATCH v10 05/11] HID: asus: move vendor initialization to probe Antheas Kapenekakis
2025-12-08 17:11 ` Ilpo Järvinen
2025-12-09 9:12 ` Antheas Kapenekakis
2025-12-09 9:14 ` Ilpo Järvinen
2025-11-22 11:00 ` [PATCH v10 06/11] HID: asus: early return for ROG devices Antheas Kapenekakis
2025-11-22 11:00 ` [PATCH v10 07/11] platform/x86: asus-wmi: Add support for multiple kbd led handlers Antheas Kapenekakis
2025-12-08 17:09 ` Ilpo Järvinen
2025-11-22 11:00 ` [PATCH v10 08/11] HID: asus: listen to the asus-wmi brightness device instead of creating one Antheas Kapenekakis
2025-11-26 20:19 ` Denis Benato
2025-12-02 11:23 ` Benjamin Tissoires
2025-11-22 11:00 ` [PATCH v10 09/11] platform/x86: asus-wmi: remove unused keyboard backlight quirk Antheas Kapenekakis
2025-11-26 20:19 ` Denis Benato [this message]
2025-11-22 11:00 ` [PATCH v10 10/11] platform/x86: asus-wmi: add keyboard brightness event handler Antheas Kapenekakis
2025-11-26 20:23 ` Denis Benato
2025-11-26 20:39 ` Antheas Kapenekakis
2025-12-01 8:58 ` Antheas Kapenekakis
2025-12-01 9:52 ` Ilpo Järvinen
2025-12-01 11:44 ` Antheas Kapenekakis
2025-12-02 11:26 ` Benjamin Tissoires
2025-11-22 11:00 ` [PATCH v10 11/11] HID: asus: add support for the asus-wmi brightness handler Antheas Kapenekakis
2025-11-26 13:37 ` [PATCH v10 00/11] HID: asus: Fix ASUS ROG Laptop's Keyboard backlight handling Antheas Kapenekakis
2025-11-26 15:23 ` Ilpo Järvinen
2025-11-26 15:28 ` Antheas Kapenekakis
2025-11-26 15:29 ` Antheas Kapenekakis
2025-11-26 15:31 ` Ilpo Järvinen
2025-11-26 19:58 ` Denis Benato
2025-11-26 17:34 ` Hans de Goede
2025-11-26 19:57 ` Denis Benato
2025-12-02 11:28 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5220043-f685-4778-9fc7-9c3585c01fb3@gmail.com \
--to=benato.denis96@gmail.com \
--cc=bentiss@kernel.org \
--cc=corentin.chary@gmail.com \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml@antheas.dev \
--cc=luke@ljones.dev \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).