From: srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
To: Basavaraj Natikar <Basavaraj.Natikar@amd.com>,
jikos@kernel.org, benjamin.tissoires@redhat.com,
jic23@kernel.org, lars@metafoo.de, linux-input@vger.kernel.org,
linux-iio@vger.kernel.org
Subject: Re: [PATCH v2 3/9] iio: hid-sensor-als: Add light color temperature support
Date: Wed, 20 Sep 2023 10:00:52 -0700 [thread overview]
Message-ID: <f708fb6479ed75f4a326b471478eae79fdfba317.camel@linux.intel.com> (raw)
In-Reply-To: <20230919081054.2050714-4-Basavaraj.Natikar@amd.com>
On Tue, 2023-09-19 at 13:40 +0530, Basavaraj Natikar wrote:
> In most cases, ambient color sensors also support light color
> temperature.
> As a result, add support of light color temperature.
>
> Signed-off-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
Acked-by: Srinivas Pandruvada<srinivas.pandruvada@linux.intel.com>
> ---
> drivers/iio/light/hid-sensor-als.c | 37
> ++++++++++++++++++++++++++++--
> include/linux/hid-sensor-ids.h | 1 +
> 2 files changed, 36 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/light/hid-sensor-als.c
> b/drivers/iio/light/hid-sensor-als.c
> index efb1f8862b28..16a3f1941c27 100644
> --- a/drivers/iio/light/hid-sensor-als.c
> +++ b/drivers/iio/light/hid-sensor-als.c
> @@ -14,8 +14,9 @@
> #include "../common/hid-sensors/hid-sensor-trigger.h"
>
> enum {
> - CHANNEL_SCAN_INDEX_INTENSITY = 0,
> - CHANNEL_SCAN_INDEX_ILLUM = 1,
> + CHANNEL_SCAN_INDEX_INTENSITY,
> + CHANNEL_SCAN_INDEX_ILLUM,
> + CHANNEL_SCAN_INDEX_COLOR_TEMP,
> CHANNEL_SCAN_INDEX_MAX
> };
>
> @@ -65,6 +66,16 @@ static const struct iio_chan_spec als_channels[] =
> {
> BIT(IIO_CHAN_INFO_HYSTERESIS_RELATIVE),
> .scan_index = CHANNEL_SCAN_INDEX_ILLUM,
> },
> + {
> + .type = IIO_COLORTEMP,
> + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW),
> + .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_OFFSET)
> |
> + BIT(IIO_CHAN_INFO_SCALE) |
> + BIT(IIO_CHAN_INFO_SAMP_FREQ) |
> + BIT(IIO_CHAN_INFO_HYSTERESIS) |
> + BIT(IIO_CHAN_INFO_HYSTERESIS_RELATIVE),
> + .scan_index = CHANNEL_SCAN_INDEX_COLOR_TEMP,
> + },
> IIO_CHAN_SOFT_TIMESTAMP(CHANNEL_SCAN_INDEX_TIMESTAMP)
> };
>
> @@ -103,6 +114,11 @@ static int als_read_raw(struct iio_dev
> *indio_dev,
> min = als_state->als[chan-
> >scan_index].logical_minimum;
> address = HID_USAGE_SENSOR_LIGHT_ILLUM;
> break;
> + case CHANNEL_SCAN_INDEX_COLOR_TEMP:
> + report_id = als_state->als[chan-
> >scan_index].report_id;
> + min = als_state->als[chan-
> >scan_index].logical_minimum;
> + address =
> HID_USAGE_SENSOR_LIGHT_COLOR_TEMPERATURE;
> + break;
> default:
> report_id = -1;
> break;
> @@ -223,6 +239,10 @@ static int als_capture_sample(struct
> hid_sensor_hub_device *hsdev,
> als_state->scan.illum[CHANNEL_SCAN_INDEX_ILLUM] =
> sample_data;
> ret = 0;
> break;
> + case HID_USAGE_SENSOR_LIGHT_COLOR_TEMPERATURE:
> + als_state->scan.illum[CHANNEL_SCAN_INDEX_COLOR_TEMP]
> = sample_data;
> + ret = 0;
> + break;
> case HID_USAGE_SENSOR_TIME_TIMESTAMP:
> als_state->timestamp =
> hid_sensor_convert_timestamp(&als_state->common_attributes,
>
> *(s64 *)raw_data);
> @@ -258,6 +278,19 @@ static int als_parse_report(struct
> platform_device *pdev,
> st->als[i].report_id);
> }
>
> + ret = sensor_hub_input_get_attribute_info(hsdev,
> HID_INPUT_REPORT,
> + usage_id,
> + HID_USAGE_SENSOR_LIGHT_COLOR_TEMPERAT
> URE,
> + &st-
> >als[CHANNEL_SCAN_INDEX_COLOR_TEMP]);
> + if (ret < 0)
> + return ret;
> + als_adjust_channel_bit_mask(channels,
> CHANNEL_SCAN_INDEX_COLOR_TEMP,
> + st-
> >als[CHANNEL_SCAN_INDEX_COLOR_TEMP].size);
> +
> + dev_dbg(&pdev->dev, "als %x:%x\n",
> + st->als[CHANNEL_SCAN_INDEX_COLOR_TEMP].index,
> + st->als[CHANNEL_SCAN_INDEX_COLOR_TEMP].report_id);
> +
> st->scale_precision = hid_sensor_format_scale(usage_id,
> &st-
> >als[CHANNEL_SCAN_INDEX_INTENSITY],
> &st->scale_pre_decml, &st-
> >scale_post_decml);
> diff --git a/include/linux/hid-sensor-ids.h b/include/linux/hid-
> sensor-ids.h
> index 13b1e65fbdcc..8af4fb3e0254 100644
> --- a/include/linux/hid-sensor-ids.h
> +++ b/include/linux/hid-sensor-ids.h
> @@ -21,6 +21,7 @@
> #define
> HID_USAGE_SENSOR_ALS 0x200041
> #define
> HID_USAGE_SENSOR_DATA_LIGHT 0x2004d0
> #define
> HID_USAGE_SENSOR_LIGHT_ILLUM 0x2004d1
> +#define
> HID_USAGE_SENSOR_LIGHT_COLOR_TEMPERATURE 0x2004d2
>
> /* PROX (200011) */
> #define HID_USAGE_SENSOR_PROX
> 0x200011
next prev parent reply other threads:[~2023-09-20 17:01 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 8:10 [PATCH v2 0/9] Support light color temperature and chromaticity Basavaraj Natikar
2023-09-19 8:10 ` [PATCH v2 1/9] iio: hid-sensor-als: Use channel index to support more hub attributes Basavaraj Natikar
2023-09-20 16:59 ` srinivas pandruvada
2023-09-19 8:10 ` [PATCH v2 2/9] iio: Add channel type light color temperature Basavaraj Natikar
2023-09-19 8:10 ` [PATCH v2 3/9] iio: hid-sensor-als: Add light color temperature support Basavaraj Natikar
2023-09-20 17:00 ` srinivas pandruvada [this message]
2023-09-19 8:10 ` [PATCH v2 4/9] HID: amd_sfh: Add support for light color temperature Basavaraj Natikar
2023-09-20 15:25 ` Jiri Kosina
2023-09-19 8:10 ` [PATCH v2 5/9] HID: amd_sfh: Add support for SFH1.1 " Basavaraj Natikar
2023-09-20 15:25 ` Jiri Kosina
2023-09-19 8:10 ` [PATCH v2 6/9] iio: Add channel type for chromaticity Basavaraj Natikar
2023-09-24 12:31 ` Jonathan Cameron
2023-09-19 8:10 ` [PATCH v2 7/9] iio: hid-sensor-als: Add light chromaticity support Basavaraj Natikar
2023-09-20 17:10 ` srinivas pandruvada
2023-09-19 8:10 ` [PATCH v2 8/9] HID: amd_sfh: " Basavaraj Natikar
2023-09-20 15:25 ` Jiri Kosina
2023-09-19 8:10 ` [PATCH v2 9/9] HID: amd_sfh: Add light chromaticity for SFH1.1 Basavaraj Natikar
2023-09-20 15:26 ` Jiri Kosina
2023-09-20 14:13 ` [PATCH v2 0/9] Support light color temperature and chromaticity Jiri Kosina
2023-09-20 15:23 ` Basavaraj Natikar
2023-09-24 12:42 ` Jonathan Cameron
2023-09-24 14:20 ` Basavaraj Natikar
2023-12-06 23:39 ` Thomas Weißschuh
2023-12-10 11:07 ` Jonathan Cameron
2023-12-15 10:04 ` Linux regression tracking (Thorsten Leemhuis)
2023-12-15 17:33 ` srinivas pandruvada
2023-12-23 8:14 ` Linux regression tracking #update (Thorsten Leemhuis)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f708fb6479ed75f4a326b471478eae79fdfba317.camel@linux.intel.com \
--to=srinivas.pandruvada@linux.intel.com \
--cc=Basavaraj.Natikar@amd.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jic23@kernel.org \
--cc=jikos@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).