From: Bastien Nocera <hadess@hadess.net>
To: Edward Matijevic <motolav@gmail.com>
Cc: benjamin.tissoires@redhat.com, jikos@kernel.org,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
svv@google.com
Subject: Re: [PATCH v3] Add rumble support to latest xbox controllers
Date: Tue, 25 Apr 2023 18:07:00 +0200 [thread overview]
Message-ID: <f82bdf01743b11e92873c5c9937ae253bd1c8bb3.camel@hadess.net> (raw)
In-Reply-To: <254bb806-c5ac-371e-4e25-1cfa5c8ce388@gmail.com>
On Tue, 2023-04-25 at 10:46 -0500, Edward Matijevic wrote:
> > > +#define USB_DEVICE_ID_MS_XBOX_CONTROLLER_MODEL_1708 0x02fd
> > > +#define
> > > USB_DEVICE_ID_MS_XBOX_CONTROLLER_MODEL_1708_BLE 0x0b20
> > The 1708 model uses Bluetooth Classic, not Bluetooth LE.
>
> The new firmware adds Bluetooth LE support to the 1708
> and prioritizes BLE over Classic which necessitates the change
> The controllers are broken without the "new firmware" IDs which are
> for BLE
Oh! I completely missed that. So both the 1708 and 1797 used Bluetooth
Classic with the old firmware, and support Bluetooth LE with the new
one. Am I understanding this correctly?
If that's right, looks like I might need to update Wikipedia ;)
Seeing as you will be updating the patch for that comment style
problem, you could probably add a reference to this article in the
commit message, it seems authoritative enough:
https://news.xbox.com/en-us/2021/09/08/xbox-controller-firmware-update-rolling-out-to-insiders-starting-today/
next prev parent reply other threads:[~2023-04-25 16:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 1:06 [PATCH v3] Add rumble support to latest xbox controllers Siarhei Vishniakou
2023-04-25 8:26 ` Bastien Nocera
[not found] ` <254bb806-c5ac-371e-4e25-1cfa5c8ce388@gmail.com>
2023-04-25 16:07 ` Bastien Nocera [this message]
2023-04-25 16:40 ` Siarhei Vishniakou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f82bdf01743b11e92873c5c9937ae253bd1c8bb3.camel@hadess.net \
--to=hadess@hadess.net \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=motolav@gmail.com \
--cc=svv@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).