From: Krzysztof Kozlowski <krzk@kernel.org>
To: xiazhengqiao <xiazhengqiao@huaqin.corp-partner.google.com>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: dmitry.torokhov@gmail.com, robh+dt@kernel.org, jikos@kernel.org,
benjamin.tissoires@redhat.com, dianders@chromium.org
Subject: Re: [v1 1/2] dt-bindings: HID: i2c-hid: elan: Introduce bindings for Ilitek ili2901
Date: Mon, 25 Dec 2023 14:27:46 +0100 [thread overview]
Message-ID: <f924d22a-56e7-4560-bea2-f00484de93bd@kernel.org> (raw)
In-Reply-To: <20231225092843.5993-2-xiazhengqiao@huaqin.corp-partner.google.com>
On 25/12/2023 10:28, xiazhengqiao wrote:
> Because ilitek, ili2901 needs to use reset to pull down the time for 10ms,
> so we need to control the reset, use this drive control.
>
> Signed-off-by: xiazhengqiao <xiazhengqiao@huaqin.corp-partner.google.com>
> ---
> Documentation/devicetree/bindings/input/elan,ekth6915.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml b/Documentation/devicetree/bindings/input/elan,ekth6915.yaml
> index 3e2d216c6432..b9e51432b9e8 100644
> --- a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml
> +++ b/Documentation/devicetree/bindings/input/elan,ekth6915.yaml
> @@ -20,6 +20,7 @@ properties:
> compatible:
> items:
> - const: elan,ekth6915
> + - const: ilitek,ili2901
1. You are adding fallback which was not explained in commit msg.
2. What's more, this was not tested. Please test your code before sending...
3. Plus you did not Cc maintainers, so I suspect you work on some
ancient tree...
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-12-25 13:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-25 9:28 [v1 0/2] HID: i2c-hid: elan: Add ili2901 timing xiazhengqiao
2023-12-25 9:28 ` [v1 1/2] dt-bindings: HID: i2c-hid: elan: Introduce bindings for Ilitek ili2901 xiazhengqiao
2023-12-25 10:13 ` Rob Herring
2023-12-25 13:27 ` Krzysztof Kozlowski [this message]
[not found] ` <CADYyEwTO0XDhM_5PLSiGUdugNx8jzCFpA6s2p1ATUpEVH4KzCg@mail.gmail.com>
2023-12-25 13:40 ` Krzysztof Kozlowski
2023-12-25 9:28 ` [v1 2/2] HID: i2c-hid: elan: Add ili2901 timing xiazhengqiao
2023-12-26 21:22 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f924d22a-56e7-4560-bea2-f00484de93bd@kernel.org \
--to=krzk@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=xiazhengqiao@huaqin.corp-partner.google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox