From: Lyude Paul <lyude@redhat.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Sebastian Wick <sebastian.wick@redhat.com>,
Aman Dhoot <amandhoot12@gmail.com>,
Mark Pearson <markpearson@lenovo.com>,
Raul Rangel <rrangel@chromium.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Andrew Duggan <aduggan@synaptics.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "Input: synaptics - enable InterTouch for the ThinkPad P1 G3"
Date: Tue, 08 Aug 2023 18:08:45 -0400 [thread overview]
Message-ID: <f9452c1fa9081ae44bb76eec48c6debd81ee0db7.camel@redhat.com> (raw)
In-Reply-To: <ZNK8aG/y4ol7MXVp@google.com>
On Tue, 2023-08-08 at 15:06 -0700, Dmitry Torokhov wrote:
> On Tue, Aug 08, 2023 at 05:49:23PM -0400, Lyude Paul wrote:
> > Hm, This looks fine to me (if not as a final fix, certainly as a workaround)
> >
> > Reviewed-by: Lyude Paul <lyude@redhat.com>
> >
> > However, this is definitely something we probably should try to fix at some
> > point - as I imagine this must be happening because something regarding how
> > clicks are reported must have changed again. Andrew, do you have any idea?
>
> I would like to understand more about this. Is this with newer/older
> BIOS, or another hardware revision of the product, or something else?
oops, somehow when typing that response I totally forgot I was responding to a
revert ._., which changes everything
so yes - we should definitely look into this a bit more, I still have access
to this machine so I'll try to take a look tomorrow and see what's up
>
> Lyude, do you still have access to the unit you originally developed
> the original change for? Is the behavior broken there as well?
>
> Thanks.
>
--
Cheers,
Lyude Paul (she/her)
Software Engineer at Red Hat
next prev parent reply other threads:[~2023-08-08 22:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 15:28 [PATCH] Revert "Input: synaptics - enable InterTouch for the ThinkPad P1 G3" Sebastian Wick
2023-08-08 21:49 ` Lyude Paul
2023-08-08 22:06 ` Dmitry Torokhov
2023-08-08 22:08 ` Lyude Paul [this message]
2023-08-09 11:55 ` Sebastian Wick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9452c1fa9081ae44bb76eec48c6debd81ee0db7.camel@redhat.com \
--to=lyude@redhat.com \
--cc=aduggan@synaptics.com \
--cc=amandhoot12@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markpearson@lenovo.com \
--cc=rrangel@chromium.org \
--cc=sebastian.wick@redhat.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).