From: "Karl Pickett" <karl.pickett@gmail.com>
To: linux-kernel@vger.kernel.org,
linux-input@atrey.karlin.mff.cuni.cz, dmitry.torokhov@gmail.com
Subject: [PATCH] Make ati_remote button repeat sensitivity soft-configurable
Date: Tue, 3 Apr 2007 20:34:17 -0400 [thread overview]
Message-ID: <f9be06770704031734k11ec894fpdf1afe385108aece@mail.gmail.com> (raw)
The ati_remote driver is a little too sensitive for my wife... if you
do anything but barely tap the button you can get multiple events
reported. We prefer a more conservative no-repeat setting. This is a
pretty trivial patch which just makes one hard coded value soft
configurable and does not change the default.
--- linux-source-2.6.20/drivers/usb/input/ati_remote.c.kjp
2006-12-07 22:50:56.000000000 -0500
+++ linux-source-2.6.20/drivers/usb/input/ati_remote.c 2007-04-03
20:19:24.000000000 -0400
@@ -119,7 +119,9 @@
* and we have to take this into account for an accurate repeat
* behaviour.
*/
-#define FILTER_TIME 60 /* msec */
+#define FILTER_TIME 60 /* millisec between each repeat */
+
+#define FILTER_MAX 5 /* number of repeats to ignore */
static unsigned long channel_mask;
module_param(channel_mask, ulong, 0644);
@@ -133,6 +135,11 @@
module_param(repeat_filter, int, 0644);
MODULE_PARM_DESC(repeat_filter, "Repeat filter time, default = 60 msec");
+static int repeat_filter_max = FILTER_MAX;
+module_param(repeat_filter_max, int, 0644);
+MODULE_PARM_DESC(repeat_filter_max,
+ "Number of repeats to ignore, default = 5");
+
#define dbginfo(dev, format, arg...) do { if (debug) dev_info(dev ,
format , ## arg); } while (0)
#undef err
#define err(format, arg...) printk(KERN_ERR format , ## arg)
@@ -515,7 +522,7 @@
ati_remote->old_jiffies = jiffies;
if (ati_remote->repeat_count > 0 &&
- ati_remote->repeat_count < 5)
+ ati_remote->repeat_count < repeat_filter_max)
return;
--
Karl Pickett
The most wasted of all days is one without laughter.—E.E. Cummings
next reply other threads:[~2007-04-04 0:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-04 0:34 Karl Pickett [this message]
2007-04-04 2:51 ` [PATCH] Make ati_remote button repeat sensitivity soft-configurable Dmitry Torokhov
2007-04-04 7:46 ` Éric Piel
2007-04-04 8:45 ` Vincent Vanackere
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9be06770704031734k11ec894fpdf1afe385108aece@mail.gmail.com \
--to=karl.pickett@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).