From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Chris Morgan <macromorgan@hotmail.com>
Cc: Chris Morgan <macroalpha82@gmail.com>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
rydberg@bitmath.org, krzysztof.kozlowski+dt@linaro.org,
robh+dt@kernel.org, dmitry.torokhov@gmail.com
Subject: Re: [PATCH 2/3] dt-bindings: input: touchscreen: Add Hynitron cstxxx bindings
Date: Fri, 30 Sep 2022 18:32:13 +0200 [thread overview]
Message-ID: <f9eb873a-91b5-1bca-ac7b-109adc3372ae@linaro.org> (raw)
In-Reply-To: <SN6PR06MB5342305DA33462161BC7020DA5569@SN6PR06MB5342.namprd06.prod.outlook.com>
On 30/09/2022 17:21, Chris Morgan wrote:
>>> +maintainers:
>>> + - Chris Morgan <macromorgan@hotmail.com>
>>> +
>>> +allOf:
>>> + - $ref: touchscreen.yaml#
>>> +
>>> +properties:
>>> + compatible:
>>> + enum:
>>> + - hynitron,cst3xx
>>
>> Isn't the panel CST3240? No wildcards in compatibles.
>>
>
> The controller IC I'm using is CST348. This driver SHOULD
> also work with a CST340 and a CST356 (untested though).
>
Whether drivers works or not is rather orthogonal question. What if
FreeBSD driver does not work with CST356? What if U-boot driver works
with all three and few more?
> Should I just have 3 compatible strings then, one for each IC?
> I could also just have cst340 as the compatible and note it
> should work for the 3 ICs listed.
Choose either:
1. The only the one compatible for which you have datasheet or hardware.
2. Choose all three separate compatibles which you believe should have
same hardware properties thus one binding fits them (based on
experience, datasheet, other drivers).
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-09-30 16:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 21:48 [PATCH 0/3] Add Hynitron cstxxx Touchscreen Chris Morgan
2022-09-28 21:48 ` [PATCH 1/3] dt-bindings: vendor-prefixes: add Hynitron vendor prefix Chris Morgan
2022-09-30 10:51 ` Krzysztof Kozlowski
2022-09-28 21:48 ` [PATCH 2/3] dt-bindings: input: touchscreen: Add Hynitron cstxxx bindings Chris Morgan
2022-09-30 10:54 ` Krzysztof Kozlowski
2022-09-30 15:21 ` Chris Morgan
2022-09-30 16:32 ` Krzysztof Kozlowski [this message]
2022-09-28 21:48 ` [PATCH 3/3] input/touchscreen: Add Hynitron cstxxx touchscreen Chris Morgan
2022-09-29 16:24 ` Dmitry Torokhov
2022-09-30 15:34 ` Chris Morgan
2022-09-30 15:38 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9eb873a-91b5-1bca-ac7b-109adc3372ae@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=macroalpha82@gmail.com \
--cc=macromorgan@hotmail.com \
--cc=robh+dt@kernel.org \
--cc=rydberg@bitmath.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).