From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DCC22989BC; Sun, 11 Jan 2026 21:30:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768167018; cv=none; b=iK3ifnNSpWWmnPE6Wf7cfZQA+zGe3qEyMKCsjI0gqhMj3YOC/NU1Igi/CSSA06w0iJcUw3/jijHz2PxcWzI2TLWNknaoCyZkhcSo9xhaikqr6/GV9O0tLJnjqBAxy7Etbsx0WC6NmA3nMMot2n1q7aQvOmfCpzM5t25InunovXE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768167018; c=relaxed/simple; bh=Nhn+4CZ3BXagipIh3ggb+a1T739lbYQCkhwe4Rm7njU=; h=Content-Type:Message-ID:Date:MIME-Version:Subject:To:References: From:In-Reply-To; b=EOidVHwDLqF9M6BFohWE3E2FPv5RNQwitkXt5LT/VLKXsHNEKV523dKZDcQXr4CO46s/+RzxQPZV7Ngf4wdsZ4H3f/2fItm+sKQO/msk2pCjBZBMAMnPlP6IyKZApdbYWNe0pTHsoCMHIRtF+9CL4WrsfdbPd93bJGFtaEOY9jw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=t+2VqL8+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="t+2VqL8+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10598C4CEF7; Sun, 11 Jan 2026 21:30:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768167017; bh=Nhn+4CZ3BXagipIh3ggb+a1T739lbYQCkhwe4Rm7njU=; h=Date:Subject:To:References:From:In-Reply-To:From; b=t+2VqL8+9mBb966C5tDxNx+KdapD5Nkg3wDnFphBR8oXvWS52de38NcCY0x9b6LoA b7hQMci/ngEowoPPaRzJUam0BWjCgDEEfvM1QTAJXBOe9HzefsNMffjo+vKNlAkB5v 0gpQ0RMq5N8kk/Ik4Moo3mzM65lrWP2Jq3TjZg5Ug5mJkVV0W3o/Ah0D0MVHsfDp7P I8/VMIBDPrLpiusf3sA5NTXOKB53RiXAUHwu5PF9mB1KU/QuCEjbcDjku+/aAyz83w XVvAy2AOEywQPzUFFZifb3M0mw6RSi7LNmWEqjzqfCIUd6Wt6xX+fL1pYuPW0gvvw5 mwI2C41FQzPUg== Content-Type: multipart/mixed; boundary="------------CE8zu18edU5p5RrkYwRW03Z3" Message-ID: Date: Sun, 11 Jan 2026 22:30:14 +0100 Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Input: goodix - fix inverted Y coordinate on SUPI S10 To: Yajat Kumar , Dmitry Torokhov , "open list:GOODIX TOUCHSCREEN" , open list References: <20251230221639.582406-1-yajatapps3@gmail.com> From: Hans de Goede Content-Language: en-US, nl In-Reply-To: <20251230221639.582406-1-yajatapps3@gmail.com> This is a multi-part message in MIME format. --------------CE8zu18edU5p5RrkYwRW03Z3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Yajat, On 30-Dec-25 23:16, Yajat Kumar wrote: > The touchscreen on the SUPI S10 reports inverted Y coordinates, causing > touch input to be mirrored vertically relative to the display. > > Add a DMI-based quirk to invert the Y coordinate on this device so that > touch input matches the display orientation. > > Tested on SUPI S10 tablet with Goodix touchscreen controller. > > Signed-off-by: Yajat Kumar Thank you for your patch. This kind of quirks really belong in drivers/platform/x86/touchscreen_dmi.c instead of in individual touchscreen drivers. The inverted_x_screen[] DMI quirk is a left-over from before we moved these quirks to touchscreen_dmi.c and unfortunately we cannot move this because we've not been able to find someone to test this. I've attached a patch which should fix the issue using touchscreen_dmi.c . Note you may need to change the GDIX1001 in the patch to GDIX1002, see "ls /sys/bus/i2c/devices" to see which ACPI HID your touchscreen is using. Can you please test the attached patch ? Regards, Hans > --- > drivers/input/touchscreen/goodix.c | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c > index f8798d11ec03..d675a85a9312 100644 > --- a/drivers/input/touchscreen/goodix.c > +++ b/drivers/input/touchscreen/goodix.c > @@ -160,6 +160,22 @@ static const struct dmi_system_id inverted_x_screen[] = { > {} > }; > > +/* > + * Those tablets have their y coordinate inverted > + */ > +static const struct dmi_system_id inverted_y_screen[] = { > +#if defined(CONFIG_DMI) && defined(CONFIG_X86) > + { > + .ident = "SUPI S10", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "SUPI"), > + DMI_MATCH(DMI_PRODUCT_NAME, "S10") > + }, > + }, > +#endif > + {} > +}; > + > /** > * goodix_i2c_read - read data from a register of the i2c slave device. > * > @@ -1212,6 +1228,12 @@ static int goodix_configure_dev(struct goodix_ts_data *ts) > "Applying 'inverted x screen' quirk\n"); > } > > + if (dmi_check_system(inverted_y_screen)) { > + ts->prop.invert_y = true; > + dev_dbg(&ts->client->dev, > + "Applying 'inverted y screen' quirk\n"); > + } > + > error = input_mt_init_slots(ts->input_dev, ts->max_touch_num, > INPUT_MT_DIRECT | INPUT_MT_DROP_UNUSED); > if (error) { --------------CE8zu18edU5p5RrkYwRW03Z3 Content-Type: text/x-patch; charset=UTF-8; name="0001-platform-x86-touchscreen_dmi-Add-quirk-for-y-inverte.patch" Content-Disposition: attachment; filename*0="0001-platform-x86-touchscreen_dmi-Add-quirk-for-y-inverte.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA1ZGY5ZDg5NWRiMmZmM2IzZWM1OGE2YjBjOWMzYTA5ZDNjODUyYjI5IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBIYW5zIGRlIEdvZWRlIDxqb2hhbm5lcy5nb2VkZUBv c3MucXVhbGNvbW0uY29tPgpEYXRlOiBTdW4sIDExIEphbiAyMDI2IDIyOjI1OjU4ICswMTAw ClN1YmplY3Q6IFtQQVRDSF0gcGxhdGZvcm0veDg2OiB0b3VjaHNjcmVlbl9kbWk6IEFkZCBx dWlyayBmb3IgeS1pbnZlcnRlZAogR29vZGl4IHRvdWNoc2NyZWVuIG9uIFNVUEkgUzEwCgpU aGUgdG91Y2hzY3JlZW4gb24gdGhlIFNVUEkgUzEwIHRhYmxldCByZXBvcnRzIGludmVydGVk IFkgY29vcmRpbmF0ZXMsCmNhdXNpbmcgdG91Y2ggaW5wdXQgdG8gYmUgbWlycm9yZWQgdmVy dGljYWxseSByZWxhdGl2ZSB0byB0aGUgZGlzcGxheS4KCkFkZCBhIHF1aXJrIHRvIHNldCB0 aGUgInRvdWNoc2NyZWVuLWludmVydGVkLXkiIGJvb2xlYW4gZGV2aWNlLXByb3BlcnR5Cm9u IHRoZSB0b3VjaHNjcmVlbiBkZXZpY2UsIHNvIHRoYXQgdGhlIGdvb2RpeF90cyBkcml2ZXIg d2lsbCBmaXh1cAp0aGUgY29vcmRpbmF0ZXMuCgpSZXBvcnRlZC1ieTogWWFqYXQgS3VtYXIg PHlhamF0YXBwczNAZ21haWwuY29tPgpDbG9zZXM6IGh0dHBzOi8vbG9yZS5rZXJuZWwub3Jn L2xpbnV4LWlucHV0LzIwMjUxMjMwMjIxNjM5LjU4MjQwNi0xLXlhamF0YXBwczNAZ21haWwu Y29tLwpTaWduZWQtb2ZmLWJ5OiBIYW5zIGRlIEdvZWRlIDxqb2hhbm5lcy5nb2VkZUBvc3Mu cXVhbGNvbW0uY29tPgotLS0KIGRyaXZlcnMvcGxhdGZvcm0veDg2L3RvdWNoc2NyZWVuX2Rt aS5jIHwgMTggKysrKysrKysrKysrKysrKysrCiAxIGZpbGUgY2hhbmdlZCwgMTggaW5zZXJ0 aW9ucygrKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGxhdGZvcm0veDg2L3RvdWNoc2NyZWVu X2RtaS5jIGIvZHJpdmVycy9wbGF0Zm9ybS94ODYvdG91Y2hzY3JlZW5fZG1pLmMKaW5kZXgg YmRjMTljZDhkM2VkLi5kODNjMzg3ODIxZWEgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvcGxhdGZv cm0veDg2L3RvdWNoc2NyZWVuX2RtaS5jCisrKyBiL2RyaXZlcnMvcGxhdGZvcm0veDg2L3Rv dWNoc2NyZWVuX2RtaS5jCkBAIC00MTAsNiArNDEwLDE2IEBAIHN0YXRpYyBjb25zdCBzdHJ1 Y3QgdHNfZG1pX2RhdGEgZ2RpeDEwMDJfdXBzaWRlX2Rvd25fZGF0YSA9IHsKIAkucHJvcGVy dGllcwk9IGdkaXgxMDAxX3Vwc2lkZV9kb3duX3Byb3BzLAogfTsKIAorc3RhdGljIGNvbnN0 IHN0cnVjdCBwcm9wZXJ0eV9lbnRyeSBnZGl4MTAwMV95X2ludmVydGVkX3Byb3BzW10gPSB7 CisJUFJPUEVSVFlfRU5UUllfQk9PTCgidG91Y2hzY3JlZW4taW52ZXJ0ZWQteSIpLAorCXsg fQorfTsKKworc3RhdGljIGNvbnN0IHN0cnVjdCB0c19kbWlfZGF0YSBnZGl4MTAwMV95X2lu dmVydGVkX2RhdGEgPSB7CisJLmFjcGlfbmFtZQk9ICJHRElYMTAwMSIsCisJLnByb3BlcnRp ZXMJPSBnZGl4MTAwMV95X2ludmVydGVkX3Byb3BzLAorfTsKKwogc3RhdGljIGNvbnN0IHN0 cnVjdCBwcm9wZXJ0eV9lbnRyeSBncF9lbGVjdHJvbmljX3Q3MDFfcHJvcHNbXSA9IHsKIAlQ Uk9QRVJUWV9FTlRSWV9VMzIoInRvdWNoc2NyZWVuLXNpemUteCIsIDk2MCksCiAJUFJPUEVS VFlfRU5UUllfVTMyKCJ0b3VjaHNjcmVlbi1zaXplLXkiLCA2NDApLApAQCAtMTY1OCw2ICsx NjY4LDE0IEBAIGNvbnN0IHN0cnVjdCBkbWlfc3lzdGVtX2lkIHRvdWNoc2NyZWVuX2RtaV90 YWJsZVtdID0gewogCQkJRE1JX01BVENIKERNSV9QUk9EVUNUX1NLVSwgIlBOMjAxNzA0MTM0 ODgiKSwKIAkJfSwKIAl9LAorCXsKKwkJLyogU1VQSSBTMTAgKi8KKwkJLmRyaXZlcl9kYXRh ID0gKHZvaWQgKikmZ2RpeDEwMDFfeV9pbnZlcnRlZF9kYXRhLAorCQkubWF0Y2hlcyA9IHsK KwkJCURNSV9NQVRDSChETUlfU1lTX1ZFTkRPUiwgIlNVUEkiKSwKKwkJCURNSV9NQVRDSChE TUlfUFJPRFVDVF9OQU1FLCAiUzEwIiksCisJCX0sCisJfSwKIAl7CiAJCS8qIFRlY2hiaXRl IEFyYyAxMS42ICovCiAJCS5kcml2ZXJfZGF0YSA9ICh2b2lkICopJnRlY2hiaXRlX2FyY18x MV82X2RhdGEsCi0tIAoyLjUyLjAKCg== --------------CE8zu18edU5p5RrkYwRW03Z3--