* [PATCH] HID: remove superfluous (and wrong) Makefile entry for CONFIG_INTEL_ISH_FIRMWARE_DOWNLOADER
@ 2025-03-12 8:08 Jiri Kosina
2025-03-12 15:38 ` srinivas pandruvada
0 siblings, 1 reply; 2+ messages in thread
From: Jiri Kosina @ 2025-03-12 8:08 UTC (permalink / raw)
To: Benjamin Tissoires, Srinivas Pandruvada, Nick Crews, Jett Rink
Cc: Jiri Slaby, linux-kernel, linux-input
From: Jiri Kosina <jkosina@suse.com>
The line
obj-$(INTEL_ISH_FIRMWARE_DOWNLOADER) += intel-ish-hid/
in top-level HID Makefile is both superfluous (as CONFIG_INTEL_ISH_FIRMWARE_DOWNLOADER
depends on CONFIG_INTEL_ISH_HID, which contains intel-ish-hid/ already) and wrong (as it's
missing the CONFIG_ prefix).
Just remove it.
Reported-by: Jiri Slaby <jirislaby@kernel.org>
Fixes: 91b228107da3e ("HID: intel-ish-hid: ISH firmware loader client driver")
Signed-off-by: Jiri Kosina <jkosina@suse.com>
---
drivers/hid/Makefile | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/hid/Makefile b/drivers/hid/Makefile
index 482b096eea28..0abfe51704a0 100644
--- a/drivers/hid/Makefile
+++ b/drivers/hid/Makefile
@@ -166,7 +166,6 @@ obj-$(CONFIG_USB_KBD) += usbhid/
obj-$(CONFIG_I2C_HID_CORE) += i2c-hid/
obj-$(CONFIG_INTEL_ISH_HID) += intel-ish-hid/
-obj-$(INTEL_ISH_FIRMWARE_DOWNLOADER) += intel-ish-hid/
obj-$(CONFIG_AMD_SFH_HID) += amd-sfh-hid/
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] HID: remove superfluous (and wrong) Makefile entry for CONFIG_INTEL_ISH_FIRMWARE_DOWNLOADER
2025-03-12 8:08 [PATCH] HID: remove superfluous (and wrong) Makefile entry for CONFIG_INTEL_ISH_FIRMWARE_DOWNLOADER Jiri Kosina
@ 2025-03-12 15:38 ` srinivas pandruvada
0 siblings, 0 replies; 2+ messages in thread
From: srinivas pandruvada @ 2025-03-12 15:38 UTC (permalink / raw)
To: Jiri Kosina, Benjamin Tissoires, Nick Crews, Jett Rink
Cc: Jiri Slaby, linux-kernel, linux-input
On Wed, 2025-03-12 at 09:08 +0100, Jiri Kosina wrote:
> From: Jiri Kosina <jkosina@suse.com>
>
> The line
>
> obj-$(INTEL_ISH_FIRMWARE_DOWNLOADER) += intel-ish-hid/
>
> in top-level HID Makefile is both superfluous (as
> CONFIG_INTEL_ISH_FIRMWARE_DOWNLOADER
> depends on CONFIG_INTEL_ISH_HID, which contains intel-ish-hid/
> already) and wrong (as it's
> missing the CONFIG_ prefix).
>
> Just remove it.
>
> Reported-by: Jiri Slaby <jirislaby@kernel.org>
> Fixes: 91b228107da3e ("HID: intel-ish-hid: ISH firmware loader client
> driver")
> Signed-off-by: Jiri Kosina <jkosina@suse.com>
Good one
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Thanks,
Srinivas
> ---
> drivers/hid/Makefile | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/hid/Makefile b/drivers/hid/Makefile
> index 482b096eea28..0abfe51704a0 100644
> --- a/drivers/hid/Makefile
> +++ b/drivers/hid/Makefile
> @@ -166,7 +166,6 @@ obj-$(CONFIG_USB_KBD) += usbhid/
> obj-$(CONFIG_I2C_HID_CORE) += i2c-hid/
>
> obj-$(CONFIG_INTEL_ISH_HID) += intel-ish-hid/
> -obj-$(INTEL_ISH_FIRMWARE_DOWNLOADER) += intel-ish-hid/
>
> obj-$(CONFIG_AMD_SFH_HID) += amd-sfh-hid/
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-03-12 15:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-12 8:08 [PATCH] HID: remove superfluous (and wrong) Makefile entry for CONFIG_INTEL_ISH_FIRMWARE_DOWNLOADER Jiri Kosina
2025-03-12 15:38 ` srinivas pandruvada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).