From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Cameron Subject: Re: [PATCH 7/8] iio: adc: ti_am335x_adc: use variable names for sizeof() operator Date: Fri, 3 Jun 2016 13:15:04 +0100 Message-ID: References: <20160531170013.2649-1-afd@ti.com> <20160531170013.2649-8-afd@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160531170013.2649-8-afd@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: "Andrew F. Davis" , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Dmitry Torokhov , Lee Jones , Dave Gerlach Cc: linux-iio@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-input@vger.kernel.org On 31/05/16 18:00, Andrew F. Davis wrote: > Fix the code formatting to use the kernel preferred style > of using the actual variables to determize the size using > the sizeof() operator. > > Signed-off-by: Andrew F. Davis Applied - thanks, Jonathan > --- > drivers/iio/adc/ti_am335x_adc.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c > index 18af71d..8a36875 100644 > --- a/drivers/iio/adc/ti_am335x_adc.c > +++ b/drivers/iio/adc/ti_am335x_adc.c > @@ -326,8 +326,7 @@ static int tiadc_channel_init(struct iio_dev *indio_dev, int channels) > int i; > > indio_dev->num_channels = channels; > - chan_array = kcalloc(channels, > - sizeof(struct iio_chan_spec), GFP_KERNEL); > + chan_array = kcalloc(channels, sizeof(*chan_array), GFP_KERNEL); > if (chan_array == NULL) > return -ENOMEM; > > @@ -467,8 +466,7 @@ static int tiadc_probe(struct platform_device *pdev) > return -EINVAL; > } > > - indio_dev = devm_iio_device_alloc(&pdev->dev, > - sizeof(struct tiadc_device)); > + indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(*indio_dev)); > if (indio_dev == NULL) { > dev_err(&pdev->dev, "failed to allocate iio device\n"); > return -ENOMEM; >