From: Hans de Goede <hdegoede@redhat.com>
To: Bastien Nocera <hadess@hadess.net>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, Dmitry Mastykin <mastichi@gmail.com>
Subject: Re: [PATCH resend 04/10] Input: goodix - Add support for getting IRQ + reset GPIOs on Cherry Trail devices
Date: Mon, 2 Mar 2020 17:23:22 +0100 [thread overview]
Message-ID: <fc75931c-743b-460e-c292-da6bf4a598b9@redhat.com> (raw)
In-Reply-To: <156a1f5fb89ccb8108d54376b45de6af93525368.camel@hadess.net>
Hi,
On 3/2/20 4:44 PM, Bastien Nocera wrote:
> On Mon, 2020-03-02 at 16:40 +0100, Hans de Goede wrote:
>>> Does this mean we retry at most once?
>>
>>
>> Yes, we are not really "retrying", we are doing a 2 step
>>
>> probe:
>>
>>
>>
>> 1) First try to get the GPIOs without having done our heuristics and
>>
>> without having called devm_acpi_dev_add_driver_gpios(). This is for
>>
>> ACPI platforms extra GPIO info (including names) using the special
>>
>> ACPI "daffd814-6eba-4d8c-8a91-bc9bbf4aa301" UUID method.
>>
>>
>>
>> 2) If this fails then we add our own name to index mappings and
>>
>> get the GPIOs using those.
>
> Is there a better way to communicate that? Using a separate function
> for that piece of code,
The code adding our own mappings already is in a separate function, that
is what the goodix_add_acpi_gpio_mappings function is for.
> and maybe some comments to clarify what it's
> doing.
I will add a comment above the goodix_add_acpi_gpio_mappings function
explaining that it is used to add our own mappings if the ACPI
tables do not contain GPIO-name to ACPI resource index mappings.
Regards,
Hans
next prev parent reply other threads:[~2020-03-02 16:23 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 16:47 [PATCH resend 01/10] Input: goodix - Refactor IRQ pin GPIO accesses Hans de Goede
2020-02-21 16:47 ` [PATCH resend 02/10] Input: goodix - Make loading the config from disk independent from the GPIO setup Hans de Goede
2020-03-02 11:12 ` Bastien Nocera
2020-02-21 16:47 ` [PATCH resend 03/10] Input: goodix - Make resetting the controller at probe " Hans de Goede
2020-03-02 11:14 ` Bastien Nocera
2020-02-21 16:47 ` [PATCH resend 04/10] Input: goodix - Add support for getting IRQ + reset GPIOs on Cherry Trail devices Hans de Goede
2020-03-02 11:23 ` Bastien Nocera
2020-03-02 15:40 ` Hans de Goede
2020-03-02 15:44 ` Bastien Nocera
2020-03-02 16:23 ` Hans de Goede [this message]
2020-02-21 16:47 ` [PATCH resend 05/10] Input: goodix - Add support for getting IRQ + reset GPIOs on Bay " Hans de Goede
2020-03-02 11:24 ` Bastien Nocera
2020-02-21 16:47 ` [PATCH resend 06/10] Input: goodix - Add support for controlling the IRQ pin through ACPI methods Hans de Goede
2020-03-02 11:25 ` Bastien Nocera
2020-02-21 16:47 ` [PATCH resend 07/10] Input: goodix - Move defines to above struct goodix_ts_data declaration Hans de Goede
2020-03-02 11:25 ` Bastien Nocera
2020-02-21 16:47 ` [PATCH resend 08/10] Input: goodix - Save a copy of the config from goodix_read_config() Hans de Goede
2020-03-02 11:30 ` Bastien Nocera
2020-03-02 18:36 ` Hans de Goede
2020-02-21 16:47 ` [PATCH resend 09/10] Input: goodix - Make goodix_send_cfg() take a raw buffer as argument Hans de Goede
2020-03-02 11:33 ` Bastien Nocera
2020-03-02 18:53 ` Hans de Goede
2020-02-21 16:47 ` [PATCH resend 10/10] Input: goodix - Restore config on resume if necessary Hans de Goede
2020-03-02 11:35 ` Bastien Nocera
2020-03-02 19:08 ` Hans de Goede
2020-03-02 11:09 ` [PATCH resend 01/10] Input: goodix - Refactor IRQ pin GPIO accesses Bastien Nocera
2020-03-02 13:23 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc75931c-743b-460e-c292-da6bf4a598b9@redhat.com \
--to=hdegoede@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hadess@hadess.net \
--cc=linux-input@vger.kernel.org \
--cc=mastichi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).