From: Neil Armstrong <neil.armstrong@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Satya Priya <quic_c_skakit@quicinc.com>,
Andy Gross <agross@kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Rob Herring <robh+dt@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Lee Jones <lee@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Alessandro Zummo <a.zummo@towertech.it>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-input@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-rtc@vger.kernel.org
Subject: Re: [PATCH v2 08/11] mfd: qcom-pm8xxx: drop unused PM8018 compatible
Date: Tue, 4 Oct 2022 11:42:01 +0200 [thread overview]
Message-ID: <fccda8a1-5a40-d840-bd3f-ec44b87bb575@linaro.org> (raw)
In-Reply-To: <48fba67d-20f3-7e53-8b5f-01f07452b4c7@linaro.org>
On 04/10/2022 11:02, Krzysztof Kozlowski wrote:
> On 04/10/2022 10:08, Neil Armstrong wrote:
>> The PM8921 compatible is used as fallback when PM8018 is available,
>> then remove PM8018 compatible.
>
> s/then/so/
>
> But it's a bit confusing because PM8018 is not "available". It is
> "present" or "is" instead, so rather:
> "The PM8018 compatible is always used with PM8921 fallback, so PM8018
> compatible can be safely removed from device ID table".
Thx for the suggestion, will use this wording, same in patch 9.
>
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Best regards,
> Krzysztof
>
Thanks,
Neil
next prev parent reply other threads:[~2022-10-04 9:45 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 8:08 [PATCH v2 00/11] arm: qcom: mdm9615: first round of bindings and DT fixes Neil Armstrong
2022-10-04 8:08 ` [PATCH v2 01/11] dt-bindings: arm: qcom: move swir,mangoh-green-wp8548 board documentation to qcom.yaml Neil Armstrong
2022-10-04 8:51 ` Krzysztof Kozlowski
2022-10-04 8:08 ` [PATCH v2 02/11] arm: dts: qcom: mdm9615*: add SPDX-License-Identifier Neil Armstrong
2022-10-04 8:52 ` Krzysztof Kozlowski
2022-10-04 8:08 ` [PATCH v2 03/11] arm: dts: qcom: mdm9615: add missing reg in cpu@0 node Neil Armstrong
2022-10-04 8:53 ` Krzysztof Kozlowski
2022-10-04 8:08 ` [PATCH v2 04/11] arm: dts: qcom: mdm9615: remove invalid spi-max-frequency gsbi3_spi node Neil Armstrong
2022-10-04 8:08 ` [PATCH v2 05/11] dt-bindings: mfd: qcom-pm8xxx: document qcom,pm8921 as fallback of qcom,pm8018 Neil Armstrong
2022-10-04 8:55 ` Krzysztof Kozlowski
2022-10-04 9:38 ` Neil Armstrong
2022-10-04 10:03 ` Krzysztof Kozlowski
2022-10-04 8:08 ` [PATCH v2 06/11] dt-bindings: input: qcom,pm8921-pwrkey: convert to dt-schema Neil Armstrong
2022-10-04 8:59 ` Krzysztof Kozlowski
2022-10-04 9:41 ` Neil Armstrong
2022-10-04 8:08 ` [PATCH v2 07/11] dt-bindings: rtc: qcom-pm8xxx: document qcom,pm8921-rtc as fallback of qcom,pm8018-rtc Neil Armstrong
2022-10-04 9:00 ` Krzysztof Kozlowski
2022-10-04 8:08 ` [PATCH v2 08/11] mfd: qcom-pm8xxx: drop unused PM8018 compatible Neil Armstrong
2022-10-04 9:02 ` Krzysztof Kozlowski
2022-10-04 9:42 ` Neil Armstrong [this message]
2022-10-04 8:08 ` [PATCH v2 09/11] rtc: pm8xxx: drop unused pm8018 compatible Neil Armstrong
2022-10-04 9:02 ` Krzysztof Kozlowski
2022-10-04 8:08 ` [PATCH v2 10/11] arm: dts: qcom: mdm9615: remove invalid interrupt-names from pl18x mmc nodes Neil Armstrong
2022-10-04 8:08 ` [PATCH v2 11/11] arm: dts: qcom: mdm9615: remove useless amba subnode Neil Armstrong
2022-10-04 9:03 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fccda8a1-5a40-d840-bd3f-ec44b87bb575@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=a.zummo@towertech.it \
--cc=agross@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=quic_c_skakit@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).