From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Subject: Re: Input-gameport: Replace some printk() calls by pr_info() in joydump_connect() Date: Sat, 24 Sep 2016 21:50:54 +0200 Message-ID: References: <1474733610.23838.2.camel@perches.com> <8164eb48-e3fa-fa9d-6351-f14b595a6dc3@users.sourceforge.net> <1474735656.23838.6.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from mout.web.de ([217.72.192.78]:64378 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965050AbcIXTvD (ORCPT ); Sat, 24 Sep 2016 15:51:03 -0400 In-Reply-To: <1474735656.23838.6.camel@perches.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Joe Perches Cc: linux-input@vger.kernel.org, Dmitry Torokhov , LKML , kernel-janitors@vger.kernel.org, Julia Lawall >> Should the desired output be the same when the relevant data are passed by a single function call >> (instead of three as before)? > > Adding a singleton for a pr_fmt #define constant string and > updating the printk subsystem to prepend that constant string > to each use of a pr_ at runtime would be an improvement > as it could reduce constant data used by the format strings. Thanks for for this constructive feedback. > That would be a _real_ improvement. This sounds interesting for me too. > Please try to implement something like that before submitting > more of these incorrect patches. Nice wish! Did any other software developer try to implement such enhanced logging functionality already? Regards, Markus