From: Henrik Rydberg <rydberg@bitmath.org>
To: Wei-Ning Huang <wnhuang@chromium.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux Input <linux-input@vger.kernel.org>
Cc: Dmitry Torokhov <dtor@chromium.org>,
Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Peter Hutterer <peter.hutterer@who-t.net>,
Wei-Ning Huang <wnhuang@google.com>,
dmitry.torokhov@gmail.com, corbet@lwn.net,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v5] HID: hid-multitouch: support fine-grain orientation reporting
Date: Wed, 29 Nov 2017 23:33:58 +0100 [thread overview]
Message-ID: <fe447cdd-767e-0211-f20c-f1ce74a0841b@bitmath.org> (raw)
In-Reply-To: <20171012062143.39785-1-wnhuang@google.com>
On 10/12/2017 08:21 AM, Wei-Ning Huang wrote:
> From: Wei-Ning Huang <wnhuang@chromium.org>
>
> The current hid-multitouch driver only allow the report of two
> orientations, vertical and horizontal. We use the Azimuth orientation
> usage 0x3F under the Digitizer usage page to report orientation if the
> device supports it.
>
> Changelog:
> v1 -> v2:
> - Fix commit message.
> - Remove resolution reporting for ABS_MT_ORIENTATION.
> v2 -> v3:
> - Fix commit message.
> v3 -> v4:
> - Fix ABS_MT_ORIENTATION ABS param range.
> - Don't set ABS_MT_ORIENTATION in ABS_DG_HEIGHT when it is already
> set by ABS_DG_AZIMUTH.
> v4 -> v5:
> - Improve multi-touch-protocol.rst documentation.
>
> Signed-off-by: Wei-Ning Huang <wnhuang@chromium.org>
> Signed-off-by: Wei-Ning Huang <wnhuang@google.com>
> Reviewed-by: Dmitry Torokhov <dtor@chromium.org>
> ---
> Documentation/input/multi-touch-protocol.rst | 9 ++---
> drivers/hid/hid-multitouch.c | 52 +++++++++++++++++++++++++---
> include/linux/hid.h | 1 +
> 3 files changed, 54 insertions(+), 8 deletions(-)
Reviewed-by: Henrik Rydberg <rydberg@bitmath.org>
Thank you, Wei-Ning, and sorry for the delay. Dmitry, did you plan to
add this to your pull request already?
Henrik
next prev parent reply other threads:[~2017-11-29 22:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 6:21 [PATCH v5] HID: hid-multitouch: support fine-grain orientation reporting Wei-Ning Huang
2017-10-12 6:30 ` Wei-Ning Huang
2017-11-29 22:33 ` Henrik Rydberg [this message]
2017-11-29 22:39 ` Dmitry Torokhov
2017-12-01 9:01 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe447cdd-767e-0211-f20c-f1ce74a0841b@bitmath.org \
--to=rydberg@bitmath.org \
--cc=benjamin.tissoires@redhat.com \
--cc=corbet@lwn.net \
--cc=dmitry.torokhov@gmail.com \
--cc=dtor@chromium.org \
--cc=jikos@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.hutterer@who-t.net \
--cc=wnhuang@chromium.org \
--cc=wnhuang@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).