From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B69437C91E; Fri, 6 Mar 2026 10:44:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772793851; cv=none; b=YVDlX49pjGix2kfhUm3McWpshPJ5qkKnMcwOop2fOMo9qFkdRC84ZormorfNYtL9xnbvB4yt24qXbKpmr5LXs3A2+5vXUdIBxkpvx6FXz4aPsZKIezOUJC7j6qpWPFYJc5c431slXxDMFuKUzIJ9rGHU2209U3KnYf59TLophgQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772793851; c=relaxed/simple; bh=LDQtb7Z/V7TGdHgOAXjL8465Y35w6L3DlU01n/+cPFw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fl1jyVfGVwIK93WDjEkY1PgOREqjwSEK5rdaVhVmuqrMCilD2qBIk6ZZwBodZCDVe7qrLQbyMMrssClUEFrj6VLX14qZYS49ItybVID1GijKXNJ1NGe4h3wh20BS2ZbZZ7QMRCxZz1RU4/WB03AQ2ihsmgrcaHv842M1KpmeGe0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kassbQb5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kassbQb5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81EB2C4CEF7; Fri, 6 Mar 2026 10:44:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772793850; bh=LDQtb7Z/V7TGdHgOAXjL8465Y35w6L3DlU01n/+cPFw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=kassbQb5eYDn4EYFfgGXtQbbiTR6QqeQGRWu31YXg1vKio2J6c+nqbx/R96Zyh4CN O0QrVwdgN9XwyX9NxZIqjoFiPMCTDUyevWiMwFdz3J1gwMPPfwCNO+vUpRGME3xDVg T9v7WvgJF0Wyg0EUa6i7t/ioCHrJ+RzaU0AxEHrzWa6Lk70E4yxn75luE2+tvwjxXS 31AeqTfvAZAXJZCqctqRFIman1NXzIO/L86gpbs6tDzzURIwqIpmGuihvvikT2atZP XHnFAnUKHUMcWrfJdUXi0p5EoChQ6FMda5ugS/U8Jl0MwIfCuiEwiucBXCnGs2rc4T Hhbn4hKBt/9kA== Message-ID: Date: Fri, 6 Mar 2026 11:44:05 +0100 Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/3] input: touchscreen: st1232: add system wakeup support To: phucduc.bui@gmail.com, Dmitry Torokhov Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Wolfram Sang , Jeff LaBundy , Bastian Hecht , Javier Carrasco , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260305113512.227269-1-phucduc.bui@gmail.com> <20260306104025.43970-1-phucduc.bui@gmail.com> <20260306104025.43970-4-phucduc.bui@gmail.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <20260306104025.43970-4-phucduc.bui@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 06/03/2026 11:40, phucduc.bui@gmail.com wrote: > From: bui duc phuc > > The ST1232 touchscreen controller can generate an interrupt when the > panel is touched, which may be used as a wakeup source for the system. > > Add support for system wakeup by initializing the device wakeup > capability in probe() based on the "wakeup-source" device property. > When wakeup is enabled, the driver enables IRQ wake during suspend > so that touch events can wake the system. > > Additionally, report wakeup events from the interrupt handler when > the device is allowed to wake the system. This allows the PM core to > track touch-generated wakeup events and helps avoid potential races > with system suspend. > > If wakeup is not enabled, the driver retains the existing behavior of > disabling the IRQ and powering down the controller during suspend. > > Signed-off-by: bui duc phuc > --- > drivers/input/touchscreen/st1232.c | 27 ++++++++++++++++++++++----- > 1 file changed, 22 insertions(+), 5 deletions(-) > > diff --git a/drivers/input/touchscreen/st1232.c b/drivers/input/touchscreen/st1232.c > index 9b3901eec0a5..2bab06cf099b 100644 > --- a/drivers/input/touchscreen/st1232.c > +++ b/drivers/input/touchscreen/st1232.c > @@ -183,6 +183,9 @@ static irqreturn_t st1232_ts_irq_handler(int irq, void *dev_id) > int count; > int error; > > + if (device_may_wakeup(&ts->client->dev)) > + pm_wakeup_event(&ts->client->dev, 0); > + > error = st1232_ts_read_data(ts, REG_XY_COORDINATES, ts->read_buf_len); > if (error) > goto out; > @@ -356,6 +359,9 @@ static int st1232_ts_probe(struct i2c_client *client) > > i2c_set_clientdata(client, ts); > > + device_init_wakeup(&client->dev, > + device_property_read_bool(&client->dev, "wakeup-source")); > + > return 0; > } > > @@ -363,11 +369,20 @@ static int st1232_ts_suspend(struct device *dev) > { > struct i2c_client *client = to_i2c_client(dev); > struct st1232_ts_data *ts = i2c_get_clientdata(client); > + int ret; > > - disable_irq(client->irq); > + dev_info(dev, "st1232: suspend called\n"); > + dev_info(dev, "st1232: irq=%d wakeup=%d\n", client->irq, device_may_wakeup(dev)); No, there is no need to add success messages. > > - if (!device_may_wakeup(&client->dev)) > + if (device_may_wakeup(dev)) { > + ret = enable_irq_wake(client->irq); > + dev_info(dev, "st1232: Supend use wakeup\n"); > + dev_info(dev, "enable_irq_wake ret=%d\n", ret); Drop both > + } else { > + dev_info(dev, "st1232: Suspend Don't use wakeup\n"); Drop Best regards, Krzysztof