From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Baryshkov Subject: Re: [PATCH] Tosa keyboard support Date: Fri, 11 Jan 2008 16:38:02 +0000 (UTC) Message-ID: References: <20071223232914.GA28932@doriath.ww600.siemens.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Return-path: Received: from main.gmane.org ([80.91.229.2]:47474 "EHLO ciao.gmane.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752577AbYAKQiO (ORCPT ); Fri, 11 Jan 2008 11:38:14 -0500 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1JDMtU-0000uU-MR for linux-input@vger.kernel.org; Fri, 11 Jan 2008 16:38:08 +0000 Received: from iap-pxy-mow1.siemens.ru ([212.248.25.26]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 11 Jan 2008 16:38:08 +0000 Received: from dbaryshkov by iap-pxy-mow1.siemens.ru with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 11 Jan 2008 16:38:08 +0000 Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: linux-input@vger.kernel.org Cc: linux-arm-kernel@lists.arm.linux.org.uk Hi, Dmitry Torokhov wrote: > Hi, > > On Jan 3, 2008 6:01 PM, Dmitry Baryshkov wrote: >> >> >> > Also, I'd put these defines rigth in tosakbd.c. >> >> The TOSA_KEY_RECORD and SYNC are used inside arch/arm/mach-pxa/tosa.c >> (for gpio-keys declaration). So I would prefer to place all such >> defines here. When the Kdrive would be fixed, I would drop KEY_RECORD >> and happily move that defines to tosakbd.c >> >> > Ok, fair enough. Because driver touches arch-specific arm parts it does > not apply cleanly to my tree. I think the best way would be to merge it > through arm side, this will minimize merge efforts Feel free to add: Strange. The patch is against 2.6.24-rc7 and applies cleanly to both for-linus and master branches of .../dtor/input.git > Acked-by: Dmitry Torokhov Russell, do I need to resent patch? -- With best wishes Dmitry