From: "pascal@pabr.org" <pascal@pabr.org>
To: linux-input@vger.kernel.org
Subject: Re: hidp_output_raw_report, HID_OUTPUT_REPORT and Sixaxis
Date: Tue, 30 Nov 2010 18:40:03 +0100 [thread overview]
Message-ID: <id3cua$12v$2@dough.gmane.org> (raw)
In-Reply-To: <20101130145405.d8142bc3.ospite@studenti.unina.it>
Antonio Ospite wrote:
> +++ b/net/bluetooth/hidp/core.c
> case HID_OUTPUT_REPORT:
> - report_type = HIDP_TRANS_DATA | HIDP_DATA_RTYPE_OUPUT;
> + report_type = HIDP_TRANS_SET_REPORT | HIDP_DATA_RTYPE_OUPUT;
> Is it only the Sixaxis which needs the output report as a SET_REPORT
> operation, or the change above is an actual fix?
My understanding of the Bluetooth HID Profile specification [1],
section 7.4.9, is that on the control channel DATA is only for
responding to an incoming GET_REPORT. Since Linux is the HID
Host, it will probably never need to reply to a GET_REPORT.
So your patch looks good.
Note that usbhid_output_raw_report() seems to send OUTPUT
reports as USB interrupt messages and FEATURE reports as
USB SET_REPORT control messages, which makes sense too.
It would be nice if hidraw behaved the same over USB and
over Bluetooth. Unfortunately I don't think you can drive
the sixaxis leds with DATA on the Bluetooth interrupt channel.
Pascal
[1] http://www.bluetooth.com/Specification%20Documents/HID_SPEC_V10.pdf
next prev parent reply other threads:[~2010-11-30 17:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-30 13:54 hidp_output_raw_report, HID_OUTPUT_REPORT and Sixaxis Antonio Ospite
2010-11-30 14:06 ` Antonio Ospite
2010-11-30 17:40 ` pascal [this message]
2010-12-01 21:06 ` Antonio Ospite
2010-12-01 22:40 ` pascal
2011-02-17 14:19 ` Antonio Ospite
[not found] ` <20110217151931.d7ee7e29.ospite-aNJ+ML1ZbiP93QAQaVx+gl6hYfS7NtTn@public.gmane.org>
2011-02-18 8:45 ` Jiri Kosina
2011-02-20 17:26 ` [PATCH 0/2] Fix sending Output reports to the Sony Sixaxis Antonio Ospite
2011-02-20 17:26 ` [PATCH 1/2] hid-sony.c: Fix sending Output reports to the Sixaxis Antonio Ospite
2011-02-21 12:49 ` Jiri Kosina
2011-02-20 17:26 ` [PATCH 2/2] bt hidp: send Output reports using SET_REPORT on the Control channel Antonio Ospite
[not found] ` <1298222806-19433-3-git-send-email-ospite-aNJ+ML1ZbiP93QAQaVx+gl6hYfS7NtTn@public.gmane.org>
2011-02-21 3:45 ` Alan Ott
2011-02-21 12:50 ` Jiri Kosina
2011-02-21 21:09 ` Gustavo F. Padovan
2011-02-22 10:09 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='id3cua$12v$2@dough.gmane.org' \
--to=pascal@pabr.org \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).