* [PATCH 5/5] HID: hid-lenovo-tpkbd, remove doubled hid_get_drvdata
[not found] <1365107532-32721-1-git-send-email-jslaby@suse.cz>
@ 2013-04-04 20:32 ` Jiri Slaby
2013-04-04 22:37 ` Jiri Kosina
2013-04-04 23:05 ` Nikola Pajkovsky
0 siblings, 2 replies; 3+ messages in thread
From: Jiri Slaby @ 2013-04-04 20:32 UTC (permalink / raw)
To: jirislaby; +Cc: linux-kernel, Jiri Kosina, linux-input
In pointer_press_speed_show, we do
data_pointer = hid_get_drvdata(hdev);
twice in a row. Remove one of those.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Jiri Kosina <jkosina@suse.cz>
Cc: linux-input@vger.kernel.org
---
drivers/hid/hid-lenovo-tpkbd.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/hid/hid-lenovo-tpkbd.c b/drivers/hid/hid-lenovo-tpkbd.c
index a0535fd..07837f5 100644
--- a/drivers/hid/hid-lenovo-tpkbd.c
+++ b/drivers/hid/hid-lenovo-tpkbd.c
@@ -228,8 +228,6 @@ static ssize_t pointer_press_speed_show(struct device *dev,
struct hid_device *hdev = container_of(dev, struct hid_device, dev);
struct tpkbd_data_pointer *data_pointer = hid_get_drvdata(hdev);
- data_pointer = hid_get_drvdata(hdev);
-
return snprintf(buf, PAGE_SIZE, "%u\n",
data_pointer->press_speed);
}
--
1.8.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 5/5] HID: hid-lenovo-tpkbd, remove doubled hid_get_drvdata
2013-04-04 20:32 ` [PATCH 5/5] HID: hid-lenovo-tpkbd, remove doubled hid_get_drvdata Jiri Slaby
@ 2013-04-04 22:37 ` Jiri Kosina
2013-04-04 23:05 ` Nikola Pajkovsky
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Kosina @ 2013-04-04 22:37 UTC (permalink / raw)
To: Jiri Slaby; +Cc: jirislaby, linux-kernel, linux-input
On Thu, 4 Apr 2013, Jiri Slaby wrote:
> In pointer_press_speed_show, we do
> data_pointer = hid_get_drvdata(hdev);
> twice in a row. Remove one of those.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Jiri Kosina <jkosina@suse.cz>
> Cc: linux-input@vger.kernel.org
> ---
> drivers/hid/hid-lenovo-tpkbd.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/hid/hid-lenovo-tpkbd.c b/drivers/hid/hid-lenovo-tpkbd.c
> index a0535fd..07837f5 100644
> --- a/drivers/hid/hid-lenovo-tpkbd.c
> +++ b/drivers/hid/hid-lenovo-tpkbd.c
> @@ -228,8 +228,6 @@ static ssize_t pointer_press_speed_show(struct device *dev,
> struct hid_device *hdev = container_of(dev, struct hid_device, dev);
> struct tpkbd_data_pointer *data_pointer = hid_get_drvdata(hdev);
>
> - data_pointer = hid_get_drvdata(hdev);
> -
Applied, thanks.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 5/5] HID: hid-lenovo-tpkbd, remove doubled hid_get_drvdata
2013-04-04 20:32 ` [PATCH 5/5] HID: hid-lenovo-tpkbd, remove doubled hid_get_drvdata Jiri Slaby
2013-04-04 22:37 ` Jiri Kosina
@ 2013-04-04 23:05 ` Nikola Pajkovsky
1 sibling, 0 replies; 3+ messages in thread
From: Nikola Pajkovsky @ 2013-04-04 23:05 UTC (permalink / raw)
To: Jiri Slaby; +Cc: jirislaby, linux-kernel, Jiri Kosina, linux-input
Jiri Slaby <jslaby@suse.cz> writes:
> In pointer_press_speed_show, we do
> data_pointer = hid_get_drvdata(hdev);
> twice in a row. Remove one of those.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Jiri Kosina <jkosina@suse.cz>
> Cc: linux-input@vger.kernel.org
> ---
> drivers/hid/hid-lenovo-tpkbd.c | 2 --
> 1 file changed, 2 deletions(-)
Acked-by: Nikola Pajkovsky <npajkovs@redhat.com>
--
Nikola
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-04-04 23:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1365107532-32721-1-git-send-email-jslaby@suse.cz>
2013-04-04 20:32 ` [PATCH 5/5] HID: hid-lenovo-tpkbd, remove doubled hid_get_drvdata Jiri Slaby
2013-04-04 22:37 ` Jiri Kosina
2013-04-04 23:05 ` Nikola Pajkovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).