From: Chris Ball <cjb@laptop.org>
To: Jiri Slaby <jslaby@suse.cz>
Cc: Jiri Kosina <jkosina@suse.cz>,
linux-input@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Dan Carpenter <error27@gmail.com>
Subject: Re: HIDDEV: potential NULL dereference
Date: Sat, 04 Sep 2010 12:39:27 -0400 [thread overview]
Message-ID: <m38w3hqx8g.fsf@pullcord.laptop.org> (raw)
In-Reply-To: <4C82419C.3050903@suse.cz> (Jiri Slaby's message of "Sat, 04 Sep 2010 14:54:52 +0200")
Hi Jiri,
> If hid was ever NULL at this phase, the check couldn't improve
> anything due to hid->driver_data dereference being still before
> the check. So again my question, how this could change anything?
>
> Above that, it just makes the window shorter, but the bug is
> still there, isn't it? Is the following scenario reasonable?
You're right -- I'd missed the other dereference, sorry. It's
surprising that we have two reports from users saying that the
patch got rid of a reproducible oops for them.
Dan Carpenter has commented on this too:
http://www.spinics.net/lists/linux-input/msg10541.html
As he says, it looks like the code's overdue for some real locking.
Thanks,
- Chris.
--
Chris Ball <cjb@laptop.org>
One Laptop Per Child
next prev parent reply other threads:[~2010-09-04 16:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-04 12:54 HIDDEV: potential NULL dereference Jiri Slaby
2010-09-04 16:39 ` Chris Ball [this message]
2010-09-06 5:33 ` Amit Nagal
[not found] ` <AANLkTikyW6q3tufYwwX4QEAkV0JGCWcvGr4EJyNGJOpk@mail.gmail.com>
[not found] ` <AANLkTik0hZzwKU6QokgA5B7GzWtTDQWxhfog902ZS9XZ@mail.gmail.com>
2010-09-13 15:02 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m38w3hqx8g.fsf@pullcord.laptop.org \
--to=cjb@laptop.org \
--cc=error27@gmail.com \
--cc=jkosina@suse.cz \
--cc=jslaby@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).