From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Halasa Subject: Re: [RFC] Should we create a raw input interface for IR's ? - Was: Re: [PATCH 1/3 v2] lirc core device driver infrastructure Date: Thu, 26 Nov 2009 21:33:01 +0100 Message-ID: References: <200910200956.33391.jarod@redhat.com> <200910200958.50574.jarod@redhat.com> <4B0A765F.7010204@redhat.com> <4B0A81BF.4090203@redhat.com> <4B0AC65C.806@redhat.com> <4B0E765C.2080806@redhat.com> <4B0ED238.6060306@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: In-Reply-To: <4B0ED238.6060306@redhat.com> (Mauro Carvalho Chehab's message of "Thu, 26 Nov 2009 17:08:40 -0200") Sender: linux-kernel-owner@vger.kernel.org To: Mauro Carvalho Chehab Cc: Jarod Wilson , Dmitry Torokhov , linux-kernel@vger.kernel.org, Mario Limonciello , linux-input@vger.kernel.org, linux-media@vger.kernel.org, Janne Grunau , Christoph Bartelmus List-Id: linux-input@vger.kernel.org Mauro Carvalho Chehab writes: > see include/linux/input.h: > > struct input_event { > struct timeval time; > __u16 type; > __u16 code; > __s32 value; > }; > > extending the value to more than 32 bits require some changes at the > input layer, probably breaking kernel API. Yeah, but that's a "key" space, not "raw code" space. Keys via input and raw codes via lirc and there is no problem. The mapping tables for input layer need to have variable code widths, depending on the protocol, sure. >> I don't think so. We can pass the space/mark data to all (configured, >> i.e. with active mapping) protocol handlers at once. Should a check >> fail, we ignore the data. Perhaps another protocol will make some sense >> out of it. > > What happens if it succeeds on two protocol handlers? We signal both and hope it isn't self-destruct button. We can't fix it no matter how hard we try. -- Krzysztof Halasa