* Re: [PATCH 1/5] arm: dts: sun8i: a83t: Add I2C0 node
From: Chen-Yu Tsai @ 2017-12-11 8:31 UTC (permalink / raw)
To: Maxime Ripard
Cc: Mylène Josserand, Rob Herring, Mark Rutland, Russell King,
Chen-Yu Tsai, Dmitry Torokhov,
linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
simon.budig-t93Ne7XHvje5bSeCtf/tX7NAH6kLmebB, linux-kernel,
devicetree, linux-arm-kernel, Thomas Petazzoni
In-Reply-To: <20171211071513.xgni3t6ihmeeebre-ZC1Zs529Oq4@public.gmane.org>
On Mon, Dec 11, 2017 at 3:15 PM, Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
> Hi,
>
> On Fri, Dec 08, 2017 at 10:54:15PM +0100, Mylène Josserand wrote:
>> Add I2C0 node for A83T.
>>
>> Signed-off-by: Mylène Josserand <mylene.josserand-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
>> ---
>> arch/arm/boot/dts/sun8i-a83t.dtsi | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi
>> index 19acae1b4089..848cf3f19962 100644
>> --- a/arch/arm/boot/dts/sun8i-a83t.dtsi
>> +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi
>> @@ -177,6 +177,17 @@
>> #dma-cells = <1>;
>> };
>>
>> + i2c0: i2c@01c2ac00 {
>
> Drop the leading 0, it generates a warning in dtc.
>
>> + compatible = "allwinner,sun6i-a31-i2c";
>
> Can you add a SoC-specific compatible there please?
>
>> + reg = <0x01c2ac00 0x400>;
>
> And you should order your nodes by physical address.
I have a similar patch in my A83T I2S branch:
https://github.com/wens/linux/commit/8b76a3e555b39a06f3f8182e4ff5645de4c4cbc3
ChenYu
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH 1/3] Input: twl4030-vibra: fix sibling-node lookup
From: Johan Hovold @ 2017-12-11 10:21 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: linux-input, linux-kernel, Johan Hovold, stable, Peter Ujfalusi,
Marek Belisko
In-Reply-To: <20171111154339.16875-1-johan@kernel.org>
On Sat, Nov 11, 2017 at 04:43:37PM +0100, Johan Hovold wrote:
> A helper purported to look up a child node based on its name was using
> the wrong of-helper and ended up prematurely freeing the parent of-node
> while searching the whole device tree depth-first starting at the parent
> node.
>
> Fixes: 64b9e4d803b1 ("input: twl4030-vibra: Support for DT booted kernel")
> Fixes: e661d0a04462 ("Input: twl4030-vibra - fix ERROR: Bad of_node_put() warning")
> Cc: stable <stable@vger.kernel.org> # 3.7
> Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Cc: Marek Belisko <marek@goldelico.com>
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
Just wanted to send a reminder about this series. I believe these bugs
need to be fixes regardless of whether MFD-core eventually provides some
means of avoiding such lookups in cell drivers (i.e. the discussion
which appears to have stalled).
Thanks,
Johan
^ permalink raw reply
* Re: [PATCH] Add touchscreen platform data for the Onda oBook 20 Plus tablet.
From: Hans de Goede @ 2017-12-11 10:24 UTC (permalink / raw)
To: Nerijus Baliunas, linux-input, platform-driver-x86
In-Reply-To: <20171210220213.19290-1-nerijus@users.sourceforge.net>
Hi,
On 10-12-17 23:02, Nerijus Baliunas wrote:
> Signed-off-by: Nerijus Baliūnas <nerijus@users.sourceforge.net>
Looks good to me:
Acked-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/platform/x86/silead_dmi.c | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/drivers/platform/x86/silead_dmi.c b/drivers/platform/x86/silead_dmi.c
> index 266535c2a72f..414293e8c448 100644
> --- a/drivers/platform/x86/silead_dmi.c
> +++ b/drivers/platform/x86/silead_dmi.c
> @@ -171,6 +171,23 @@ static const struct silead_ts_dmi_data digma_citi_e200_data = {
> .properties = digma_citi_e200_props,
> };
>
> +static const struct property_entry onda_obook_20_plus_props[] = {
> + PROPERTY_ENTRY_U32("touchscreen-size-x", 1728),
> + PROPERTY_ENTRY_U32("touchscreen-size-y", 1148),
> + PROPERTY_ENTRY_BOOL("touchscreen-inverted-x"),
> + PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"),
> + PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"),
> + PROPERTY_ENTRY_STRING("firmware-name", "gsl3676-onda-obook-20-plus.fw"),
> + PROPERTY_ENTRY_U32("silead,max-fingers", 10),
> + PROPERTY_ENTRY_BOOL("silead,home-button"),
> + { }
> +};
> +
> +static const struct silead_ts_dmi_data onda_obook_20_plus_data = {
> + .acpi_name = "MSSL1680:00",
> + .properties = onda_obook_20_plus_props,
> +};
> +
> static const struct dmi_system_id silead_ts_dmi_table[] = {
> {
> /* CUBE iwork8 Air */
> @@ -271,6 +288,14 @@ static const struct dmi_system_id silead_ts_dmi_table[] = {
> DMI_MATCH(DMI_BOARD_NAME, "Cherry Trail CR"),
> },
> },
> + {
> + /* Onda oBook 20 Plus */
> + .driver_data = (void *)&onda_obook_20_plus_data,
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "ONDA"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "OBOOK 20 PLUS"),
> + },
> + },
> { },
> };
>
>
^ permalink raw reply
* Re: [PATCH] HID: elecom: rewrite report fixup for EX-G and future mice
From: Jiri Kosina @ 2017-12-11 10:28 UTC (permalink / raw)
To: Tomasz Kramkowski
Cc: Benjamin Tissoires, Yuxuan Shui, Diego Elio Pettenò,
Alex Manoussakis, linux-input, linux-kernel
In-Reply-To: <20171209172311.GA5570@gaia.local>
On Sat, 9 Dec 2017, Tomasz Kramkowski wrote:
> Alright, that's fine. Anything else to change before I send a v2?
Not from my side, I think we're good to go.
> Also, would you like v2 in-reply-to the root of this thread or as its
> own thread?
Feel free to send it as a followup here. Thanks,
--
Jiri Kosina
SUSE Labs
^ permalink raw reply
* [PATCH v1] HID: sony: Print reversed MAC address via %pMR
From: Andy Shevchenko @ 2017-12-11 13:06 UTC (permalink / raw)
To: Jiri Kosina, Benjamin Tissoires, linux-input,
Roderick Colenbrander
Cc: Andy Shevchenko
Reversed MAC addresses can be printed directly using %pMR specifier.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/hid/hid-sony.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
index b9dc3ac4d4aa..138fd44d3c91 100644
--- a/drivers/hid/hid-sony.c
+++ b/drivers/hid/hid-sony.c
@@ -2399,10 +2399,7 @@ static int sony_check_add(struct sony_sc *sc)
memcpy(sc->mac_address, &buf[1], sizeof(sc->mac_address));
snprintf(sc->hdev->uniq, sizeof(sc->hdev->uniq),
- "%02hhx:%02hhx:%02hhx:%02hhx:%02hhx:%02hhx",
- sc->mac_address[5], sc->mac_address[4],
- sc->mac_address[3], sc->mac_address[2],
- sc->mac_address[1], sc->mac_address[0]);
+ "%pMR", sc->mac_address);
} else if ((sc->quirks & SIXAXIS_CONTROLLER_USB) ||
(sc->quirks & NAVIGATION_CONTROLLER_USB)) {
buf = kmalloc(SIXAXIS_REPORT_0xF2_SIZE, GFP_KERNEL);
@@ -2432,10 +2429,7 @@ static int sony_check_add(struct sony_sc *sc)
sc->mac_address[5-n] = buf[4+n];
snprintf(sc->hdev->uniq, sizeof(sc->hdev->uniq),
- "%02hhx:%02hhx:%02hhx:%02hhx:%02hhx:%02hhx",
- sc->mac_address[5], sc->mac_address[4],
- sc->mac_address[3], sc->mac_address[2],
- sc->mac_address[1], sc->mac_address[0]);
+ "%pMR", sc->mac_address);
} else {
return 0;
}
--
2.15.0
^ permalink raw reply related
* Re: [PATCH] HID: elecom: rewrite report fixup for EX-G and future mice
From: Alex Manoussakis @ 2017-12-11 17:31 UTC (permalink / raw)
To: Jiri Kosina, Tomasz Kramkowski
Cc: Benjamin Tissoires, Yuxuan Shui, Diego Elio Pettenò,
linux-input, linux-kernel
In-Reply-To: <nycvar.YFH.7.76.1712111128080.3572@cbobk.fhfr.pm>
Tomasz please add the wireless version in your next patch, a web search
shows it's called M-XT3DRBK and the USB ID is 0x00fc.
Thanks,
Alex
On Mon, Dec 11, 2017 at 11:28:37AM +0100, Jiri Kosina wrote:
> On Sat, 9 Dec 2017, Tomasz Kramkowski wrote:
>
> > Alright, that's fine. Anything else to change before I send a v2?
>
> Not from my side, I think we're good to go.
>
> > Also, would you like v2 in-reply-to the root of this thread or as its
> > own thread?
>
> Feel free to send it as a followup here. Thanks,
>
> --
> Jiri Kosina
> SUSE Labs
>
^ permalink raw reply
* Re: Lenovo Active Pen 2 and wacom tablet on yoga 920
From: Jason Gerecke @ 2017-12-11 18:19 UTC (permalink / raw)
To: Kevin Fenzi; +Cc: Linux Input
In-Reply-To: <2c3db740-8afa-2c35-f4b8-fe38253ff6fc@scrye.com>
[-- Attachment #1: Type: text/plain, Size: 2830 bytes --]
On Fri, Dec 8, 2017 at 2:24 PM, Kevin Fenzi <kevin@scrye.com> wrote:
> On 12/08/2017 01:24 PM, Jason Gerecke wrote:
>> Sorry about the delay in getting back to you on this issue. It looks
>
> No problem at all. Thanks for looking into it!
>
>> like there are several different reasons that we could be getting
>> EREMOTEIO from the lower levels. Would you mind running the sysinfo.sh
>> script described at [1] and filing a bug to the project with the
>> output attached?
>
> Done:
> https://github.com/linuxwacom/wacom-hid-descriptors/issues/9
>
>> This should give me an idea of what kind of hardware
>> is present in your 920. You might also try doing the following to see
>> if anything interesting gets printed to the dmesg log:
>>
>> # echo "file drivers/i2c/*.c +p" > /sys/kernel/debug/dynamic_debug/control
>> # modprobe -r wacom
>> # modprobe wacom
>
> Seems to say:
>
> # echo "file drivers/i2c/*.c +p" > /sys/kernel/debug/dynamic_debug/control
> -bash: /sys/kernel/debug/dynamic_debug/control: Operation not permitted
>
>>
>> Some of the I2C modules (which I suspect your sensor is using) log
>> debug messages prior to returning EREMOTEIO. The above will cause
>> these debug messages to be printed to dmesg and then reload the wacom
>> module. With luck, we might gain a little more information about
>> what's triggering the error.
>
> Sadly not... but I will poke and it and see if I can figure out why it's
> not working.
>
> kevin
>
Thanks for the sysinfo output :) It looks like your system has the
sensor connected through a designware I2C controller. The only place I
see EREMOTEIO used within the designware driver is to signal that it
got a NAK at some point during the transfer. It is supposed to print
out additional details using dev_dbg, but that won't be useful until
the "Operation not permitted" error is overcome.
Some NAK conditions are transient, so its possible that our driver
just needs to retry the command. Please read the page at [1] for
instructions to compile out out-of-tree version of the wacom driver.
In place of the "Download" instructions on that page, use the
"Development" instructions. Once you're set, apply the attached patch
by running `git am /path/to/file.patch` from within the input-wacom
directory. Compile the driver and then load it in place of the system
driver by running `sudo modprobe -r wacom && sudo insmod
4.5/wacom.ko`. Check to see if there's any interesting dmesg output
and if the pen works.
[1]: http://linuxwacom.sourceforge.net/wiki/index.php/Input-wacom
Jason
---
Now instead of four in the eights place /
you’ve got three, ‘Cause you added one /
(That is to say, eight) to the two, /
But you can’t take seven from three, /
So you look at the sixty-fours....
[-- Attachment #2: 0001-TEST-Always-retry-in-get-set-report.patch --]
[-- Type: text/x-patch, Size: 1140 bytes --]
From 1f846c7d78034b1946080cc9ffb6672f5cfe638c Mon Sep 17 00:00:00 2001
From: Jason Gerecke <killertofu@gmail.com>
Date: Mon, 11 Dec 2017 10:16:11 -0800
Subject: [PATCH input-wacom] TEST: Always retry in get/set report
---
4.5/wacom_sys.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/4.5/wacom_sys.c b/4.5/wacom_sys.c
index 39aaab0..036b5bb 100644
--- a/4.5/wacom_sys.c
+++ b/4.5/wacom_sys.c
@@ -52,7 +52,7 @@ static int wacom_get_report(struct hid_device *hdev, u8 type, u8 *buf,
do {
retval = hid_hw_raw_request(hdev, buf[0], buf, size, type,
HID_REQ_GET_REPORT);
- } while ((retval == -ETIMEDOUT || retval == -EAGAIN) && --retries);
+ } while (--retries);
if (retval < 0)
hid_err(hdev, "wacom_get_report: ran out of retries "
@@ -69,7 +69,7 @@ static int wacom_set_report(struct hid_device *hdev, u8 type, u8 *buf,
do {
retval = hid_hw_raw_request(hdev, buf[0], buf, size, type,
HID_REQ_SET_REPORT);
- } while ((retval == -ETIMEDOUT || retval == -EAGAIN) && --retries);
+ } while (--retries);
if (retval < 0)
hid_err(hdev, "wacom_set_report: ran out of retries "
--
2.15.1
^ permalink raw reply related
* Re: [PATCH] Add touchscreen platform data for the Onda oBook 20 Plus tablet.
From: Gregor Riepl @ 2017-12-11 18:25 UTC (permalink / raw)
To: Nerijus Baliunas, Hans de Goede, linux-input, platform-driver-x86
In-Reply-To: <20171210220213.19290-1-nerijus@users.sourceforge.net>
Thanks!
> + PROPERTY_ENTRY_STRING("firmware-name", "gsl3676-onda-obook-20-plus.fw"),
Firmware for this is available here:
https://github.com/onitake/gsl-firmware/blob/master/firmware/linux/silead/gsl3676-onda-obook-20-plus.fw
^ permalink raw reply
* Re: Lenovo Active Pen 2 and wacom tablet on yoga 920
From: Kevin Fenzi @ 2017-12-11 21:03 UTC (permalink / raw)
To: Jason Gerecke; +Cc: Linux Input
In-Reply-To: <CANRwn3SWMhrodDbgDn3WzzwEZcgvdo_vWndesD=O87JiEBWAyg@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 2324 bytes --]
On 12/11/2017 10:19 AM, Jason Gerecke wrote:
>
> Thanks for the sysinfo output :) It looks like your system has the
> sensor connected through a designware I2C controller. The only place I
> see EREMOTEIO used within the designware driver is to signal that it
> got a NAK at some point during the transfer. It is supposed to print
> out additional details using dev_dbg, but that won't be useful until
> the "Operation not permitted" error is overcome.
>
> Some NAK conditions are transient, so its possible that our driver
> just needs to retry the command. Please read the page at [1] for
> instructions to compile out out-of-tree version of the wacom driver.
> In place of the "Download" instructions on that page, use the
> "Development" instructions. Once you're set, apply the attached patch
> by running `git am /path/to/file.patch` from within the input-wacom
> directory. Compile the driver and then load it in place of the system
> driver by running `sudo modprobe -r wacom && sudo insmod
> 4.5/wacom.ko`. Check to see if there's any interesting dmesg output
> and if the pen works.
>
> [1]: http://linuxwacom.sourceforge.net/wiki/index.php/Input-wacom
So, not much change in dmesg:
[Mon Dec 11 12:38:16 2017] wacom: loading out-of-tree module taints kernel.
[Mon Dec 11 12:38:16 2017] wacom: module verification failed: signature and/or required key missing - tainting kernel
[Mon Dec 11 12:38:18 2017] input: Wacom HID 5110 Pen as /devices/pci0000:00/0000:00:15.0/i2c_designware.0/i2c-6/i2c-WCOM5110:00/0018:056A:5110.0003/input/input24
[Mon Dec 11 12:38:18 2017] input: Wacom HID 5110 Finger as /devices/pci0000:00/0000:00:15.0/i2c_designware.0/i2c-6/i2c-WCOM5110:00/0018:056A:5110.0003/input/input25
[Mon Dec 11 12:38:18 2017] wacom 0018:056A:5110.0003: hidraw3: I2C HID v1.00 Mouse [WCOM5110:00 056A:5110] on i2c-WCOM5110:00
[Mon Dec 11 12:38:20 2017] i2c_hid i2c-WCOM5110:00: failed to set a report to device.
[Mon Dec 11 12:38:20 2017] wacom 0018:056A:5110.0003: wacom_set_report: ran out of retries (last error = -121)
[Mon Dec 11 12:38:20 2017] i2c_hid i2c-WCOM5110:00: failed to set a report to device.
However, the pen now works. ;)
The tablet/stylus doesn't show up in gnome prefs oddly, but that could be
a problem in the stack somewhere. ;(
kevin
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply
* Re: Lenovo Active Pen 2 and wacom tablet on yoga 920
From: Jason Gerecke @ 2017-12-11 23:23 UTC (permalink / raw)
To: Kevin Fenzi; +Cc: Linux Input
In-Reply-To: <20350601-a07b-aab8-f16e-6d25344efb22@scrye.com>
On Mon, Dec 11, 2017 at 1:03 PM, Kevin Fenzi <kevin@scrye.com> wrote:
> On 12/11/2017 10:19 AM, Jason Gerecke wrote:
>>
>> Thanks for the sysinfo output :) It looks like your system has the
>> sensor connected through a designware I2C controller. The only place I
>> see EREMOTEIO used within the designware driver is to signal that it
>> got a NAK at some point during the transfer. It is supposed to print
>> out additional details using dev_dbg, but that won't be useful until
>> the "Operation not permitted" error is overcome.
>>
>> Some NAK conditions are transient, so its possible that our driver
>> just needs to retry the command. Please read the page at [1] for
>> instructions to compile out out-of-tree version of the wacom driver.
>> In place of the "Download" instructions on that page, use the
>> "Development" instructions. Once you're set, apply the attached patch
>> by running `git am /path/to/file.patch` from within the input-wacom
>> directory. Compile the driver and then load it in place of the system
>> driver by running `sudo modprobe -r wacom && sudo insmod
>> 4.5/wacom.ko`. Check to see if there's any interesting dmesg output
>> and if the pen works.
>>
>> [1]: http://linuxwacom.sourceforge.net/wiki/index.php/Input-wacom
>
> So, not much change in dmesg:
>
> [Mon Dec 11 12:38:16 2017] wacom: loading out-of-tree module taints kernel.
> [Mon Dec 11 12:38:16 2017] wacom: module verification failed: signature and/or required key missing - tainting kernel
> [Mon Dec 11 12:38:18 2017] input: Wacom HID 5110 Pen as /devices/pci0000:00/0000:00:15.0/i2c_designware.0/i2c-6/i2c-WCOM5110:00/0018:056A:5110.0003/input/input24
> [Mon Dec 11 12:38:18 2017] input: Wacom HID 5110 Finger as /devices/pci0000:00/0000:00:15.0/i2c_designware.0/i2c-6/i2c-WCOM5110:00/0018:056A:5110.0003/input/input25
> [Mon Dec 11 12:38:18 2017] wacom 0018:056A:5110.0003: hidraw3: I2C HID v1.00 Mouse [WCOM5110:00 056A:5110] on i2c-WCOM5110:00
> [Mon Dec 11 12:38:20 2017] i2c_hid i2c-WCOM5110:00: failed to set a report to device.
> [Mon Dec 11 12:38:20 2017] wacom 0018:056A:5110.0003: wacom_set_report: ran out of retries (last error = -121)
> [Mon Dec 11 12:38:20 2017] i2c_hid i2c-WCOM5110:00: failed to set a report to device.
>
> However, the pen now works. ;)
>
\o/
Guess I'll have to add EREMOTEIO to our whitelist of "things to retry on"...
> The tablet/stylus doesn't show up in gnome prefs oddly, but that could be
> a problem in the stack somewhere. ;(
>
> kevin
>
>
GNOME only shows devices that have a libwacom entry, so we'll need to
add one for your device. The sysinfo output you gave should be enough
for me to whip one up. Go ahead and file a bug at
https://github.com/linuxwacom/libwacom/issues with a link to your
wacom-hid-descriptors bug in case somebody else gets to it before me.
If I don't get to it myself in the next few days, please do poke me :)
Jason
---
Now instead of four in the eights place /
you’ve got three, ‘Cause you added one /
(That is to say, eight) to the two, /
But you can’t take seven from three, /
So you look at the sixty-fours....
^ permalink raw reply
* Re: [PATCH] Add touchscreen platform data for the Onda oBook 20 Plus tablet.
From: Nerijus Baliunas @ 2017-12-12 1:11 UTC (permalink / raw)
To: Gregor Riepl, Hans de Goede, linux-input, platform-driver-x86
In-Reply-To: <17392159-0968-89f6-d716-137d006a0d80@gmail.com>
On Mon, 11 Dec 2017 19:25:40 +0100 Gregor Riepl <onitake@gmail.com> wrote:
> > + PROPERTY_ENTRY_STRING("firmware-name", "gsl3676-onda-obook-20-plus.fw"),
>
> Firmware for this is available here:
> https://github.com/onitake/gsl-firmware/blob/master/firmware/linux/silead/gsl3676-onda-obook-20-plus.fw
BTW, what could be done with these firmware files? Is it possible to include them in linux-firmware?
Regards,
Nerijus
^ permalink raw reply
* Re: [PATCH v2] Input: Add support for PDP Xbox One controllers
From: Cameron Gutman @ 2017-12-12 5:42 UTC (permalink / raw)
To: Mark Furneaux (by way of Mark Furneaux <mark@furneaux.ca>),
linux-input, Dmitry Torokhov
In-Reply-To: <20171210185208.08d7e52c@volta>
On 12/10/2017 03:52 PM, Mark Furneaux (by way of Mark Furneaux <mark@furneaux.ca>) wrote:
> Input: Add support for PDP Xbox One controllers
>
> Adds support for the current lineup of Xbox One controllers from PDP
> (Performance Designed Products). These controllers are very picky with
> their initialization sequence and require an additional 2 packets before
> they send any input reports.
>
> Signed-off-by: Mark Furneaux <mark@furneaux.ca>
>
> ---
> Changes in v2:
>
> - Zeroed the sequence numbers and removed the redundant quirk entry.
> - Corrected mangled formatting from my email client.
>
Thanks, LGTM.
Reviewed-by: Cameron Gutman <aicommander@gmail.com>
^ permalink raw reply
* [PATCH] Input: stmfts,s6sy671 - add SPDX identifier
From: Andi Shyti @ 2017-12-12 7:41 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: linux-input, linux-kernel, Andi Shyti, Andi Shyti
In-Reply-To: <CGME20171212074156epcas2p4fefff65c3316ec1aa9b3d7797aaca550@epcas2p4.samsung.com>
Replace the original license statement with the SPDX identifier.
Update also the copyright owner adding myself as co-owner of the
copyright.
Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
---
drivers/input/touchscreen/s6sy761.c | 15 +++++----------
drivers/input/touchscreen/stmfts.c | 15 +++++----------
2 files changed, 10 insertions(+), 20 deletions(-)
diff --git a/drivers/input/touchscreen/s6sy761.c b/drivers/input/touchscreen/s6sy761.c
index 26b1cb8a88ec..675efa93d444 100644
--- a/drivers/input/touchscreen/s6sy761.c
+++ b/drivers/input/touchscreen/s6sy761.c
@@ -1,13 +1,8 @@
-/*
- * Copyright (c) 2017 Samsung Electronics Co., Ltd.
- * Author: Andi Shyti <andi.shyti@samsung.com>
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
- *
- * Samsung S6SY761 Touchscreen device driver
- */
+// SPDX-License-Identifier: GPL-2.0
+// Samsung S6SY761 Touchscreen device driver
+//
+// Copyright (c) 2017 Samsung Electronics Co., Ltd.
+// Copyright (c) 2017 Andi Shyti <andi.shyti@samsung.com>
#include <asm/unaligned.h>
#include <linux/delay.h>
diff --git a/drivers/input/touchscreen/stmfts.c b/drivers/input/touchscreen/stmfts.c
index c12d01899939..2a123e20a42e 100644
--- a/drivers/input/touchscreen/stmfts.c
+++ b/drivers/input/touchscreen/stmfts.c
@@ -1,13 +1,8 @@
-/*
- * Copyright (c) 2017 Samsung Electronics Co., Ltd.
- * Author: Andi Shyti <andi.shyti@samsung.com>
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
- *
- * STMicroelectronics FTS Touchscreen device driver
- */
+// SPDX-License-Identifier: GPL-2.0
+// STMicroelectronics FTS Touchscreen device driver
+//
+// Copyright (c) 2017 Samsung Electronics Co., Ltd.
+// Copyright (c) 2017 Andi Shyti <andi.shyti@samsung.com>
#include <linux/delay.h>
#include <linux/i2c.h>
--
2.15.1
^ permalink raw reply related
* [BUG] drivers/input/misc/pcap: a possible sleep-in-atomic bug in pcap_keys_handler
From: Jia-Ju Bai @ 2017-12-12 8:32 UTC (permalink / raw)
To: dmitry.torokhov, ilya.muromec; +Cc: linux-input, linux-kernel
According to drivers/input/misc/pcap_keys.c, the kernel module may sleep
in the interrupt handler.
The function call path is:
pcap_keys_handler (interrupt handler)
ezx_pcap_read
mutex_lock --> may sleep
I do not find a good way to fix it, so I only report.
This possible bug is found by my static analysis tool (DSAC) and checked
by my code review.
Thanks,
Jia-Ju Bai
^ permalink raw reply
* [PATCH] drivers/input/misc: fix max dup length for kstrndup
From: Ma Shimiao @ 2017-12-12 9:33 UTC (permalink / raw)
To: linux-input; +Cc: linux-kernel, o2g.org.ru, mitr, Henk.Vergonet, Ma Shimiao
If source string longer than max, kstrndup will alloc max+1 space.
So, we should make sure the result will not over limit.
Signed-off-by: Ma Shimiao <mashimiao.fnst@cn.fujitsu.com>
---
drivers/input/misc/uinput.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/input/misc/uinput.c b/drivers/input/misc/uinput.c
index 39ddd9a73feb..f94c6a452025 100644
--- a/drivers/input/misc/uinput.c
+++ b/drivers/input/misc/uinput.c
@@ -468,7 +468,7 @@ static int uinput_dev_setup(struct uinput_device *udev,
udev->ff_effects_max = setup.ff_effects_max;
kfree(dev->name);
- dev->name = kstrndup(setup.name, UINPUT_MAX_NAME_SIZE, GFP_KERNEL);
+ dev->name = kstrndup(setup.name, UINPUT_MAX_NAME_SIZE - 1, GFP_KERNEL);
if (!dev->name)
return -ENOMEM;
@@ -543,7 +543,7 @@ static int uinput_setup_device_legacy(struct uinput_device *udev,
}
kfree(dev->name);
- dev->name = kstrndup(user_dev->name, UINPUT_MAX_NAME_SIZE,
+ dev->name = kstrndup(user_dev->name, UINPUT_MAX_NAME_SIZE - 1,
GFP_KERNEL);
if (!dev->name) {
retval = -ENOMEM;
--
2.13.6
^ permalink raw reply related
* Re: [PATCH] HID: sony: Fix up nyko core controller
From: Roderick Colenbrander @ 2017-12-13 0:24 UTC (permalink / raw)
To: Scott Moreau; +Cc: linux-input
In-Reply-To: <1512960708-23379-1-git-send-email-oreaus@gmail.com>
Hi Scott,
Thanks for your patch. A few additional questions from personal mail
(work mail doesn't do plain text well). In general the patch looks
fine, just curious to what extension you need some of the no output /
skip output quirks. Some are needed apparently for ds3 due to bugs in
our devices. Not sure if the Nyko controller is affected. If not then
there is no need for some of these workarounds. Just something to
sanity check.
Thanks,
Roderick
On Sun, Dec 10, 2017 at 6:51 PM, Scott Moreau <oreaus@gmail.com> wrote:
> This fixes missing d-pad axis broken since e19a267b99. The axis mapping for
> the nyko controller has the d-pad as axis 0x39 instead of d-pad as buttons.
> This is handled by the default hid mapping so we return 0 in sony_mapping.
> This controller also has no accelerometer so avoid initializing it with
> a condition in sony_input_configured() to setup these controllers.
> ---
> drivers/hid/hid-sony.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
> index b9dc3ac..e703024 100644
> --- a/drivers/hid/hid-sony.c
> +++ b/drivers/hid/hid-sony.c
> @@ -1225,6 +1225,9 @@ static int sony_mapping(struct hid_device *hdev, struct hid_input *hi,
> if (sc->quirks & NAVIGATION_CONTROLLER)
> return navigation_mapping(hdev, hi, field, usage, bit, max);
>
> + if (sc->quirks & SINO_LITE_CONTROLLER)
> + return 0;
> +
> if (sc->quirks & SIXAXIS_CONTROLLER)
> return sixaxis_mapping(hdev, hi, field, usage, bit, max);
>
> @@ -2566,6 +2569,12 @@ static int sony_input_configured(struct hid_device *hdev,
> }
>
> sony_init_output_report(sc, sixaxis_send_output_report);
> + } else if (sc->quirks & SINO_LITE_CONTROLLER) {
> + hdev->quirks |= HID_QUIRK_NO_OUTPUT_REPORTS_ON_INTR_EP;
> + hdev->quirks |= HID_QUIRK_SKIP_OUTPUT_REPORT_ID;
> + sc->defer_initialization = 1;
> +
> + sony_init_output_report(sc, sixaxis_send_output_report);
> } else if (sc->quirks & SIXAXIS_CONTROLLER_USB) {
> /*
> * The Sony Sixaxis does not handle HID Output Reports on the
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* [PATCH] HID: sony: Fix up nyko core controller
From: Scott Moreau @ 2017-12-13 0:54 UTC (permalink / raw)
To: linux-input; +Cc: Scott Moreau
This fixes missing d-pad axis broken since e19a267b99. The axis mapping for
the nyko controller has the d-pad as axis 0x39 instead of d-pad as buttons.
This is handled by the default hid mapping so we return 0 in sony_mapping.
This controller also has no accelerometer so avoid initializing it with
a condition in sony_input_configured() to setup these controllers.
---
drivers/hid/hid-sony.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
index b9dc3ac..1be0a35 100644
--- a/drivers/hid/hid-sony.c
+++ b/drivers/hid/hid-sony.c
@@ -1225,6 +1225,9 @@ static int sony_mapping(struct hid_device *hdev, struct hid_input *hi,
if (sc->quirks & NAVIGATION_CONTROLLER)
return navigation_mapping(hdev, hi, field, usage, bit, max);
+ if (sc->quirks & SINO_LITE_CONTROLLER)
+ return 0;
+
if (sc->quirks & SIXAXIS_CONTROLLER)
return sixaxis_mapping(hdev, hi, field, usage, bit, max);
@@ -2566,6 +2569,10 @@ static int sony_input_configured(struct hid_device *hdev,
}
sony_init_output_report(sc, sixaxis_send_output_report);
+ } else if (sc->quirks & SINO_LITE_CONTROLLER) {
+ hdev->quirks |= HID_QUIRK_SKIP_OUTPUT_REPORT_ID;
+
+ sony_init_output_report(sc, sixaxis_send_output_report);
} else if (sc->quirks & SIXAXIS_CONTROLLER_USB) {
/*
* The Sony Sixaxis does not handle HID Output Reports on the
--
2.7.4
^ permalink raw reply related
* Re: [PATCH] HID: sony: Fix up nyko core controller
From: Roderick Colenbrander @ 2017-12-13 2:02 UTC (permalink / raw)
To: Scott Moreau; +Cc: linux-input
In-Reply-To: <1513126444-7675-1-git-send-email-oreaus@gmail.com>
Alright looks good then.
Acked-by: Roderick Colenbrander <roderick.colenbrander@sony.com>
On Tue, Dec 12, 2017 at 4:54 PM, Scott Moreau <oreaus@gmail.com> wrote:
> This fixes missing d-pad axis broken since e19a267b99. The axis mapping for
> the nyko controller has the d-pad as axis 0x39 instead of d-pad as buttons.
> This is handled by the default hid mapping so we return 0 in sony_mapping.
> This controller also has no accelerometer so avoid initializing it with
> a condition in sony_input_configured() to setup these controllers.
> ---
> drivers/hid/hid-sony.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
> index b9dc3ac..1be0a35 100644
> --- a/drivers/hid/hid-sony.c
> +++ b/drivers/hid/hid-sony.c
> @@ -1225,6 +1225,9 @@ static int sony_mapping(struct hid_device *hdev, struct hid_input *hi,
> if (sc->quirks & NAVIGATION_CONTROLLER)
> return navigation_mapping(hdev, hi, field, usage, bit, max);
>
> + if (sc->quirks & SINO_LITE_CONTROLLER)
> + return 0;
> +
> if (sc->quirks & SIXAXIS_CONTROLLER)
> return sixaxis_mapping(hdev, hi, field, usage, bit, max);
>
> @@ -2566,6 +2569,10 @@ static int sony_input_configured(struct hid_device *hdev,
> }
>
> sony_init_output_report(sc, sixaxis_send_output_report);
> + } else if (sc->quirks & SINO_LITE_CONTROLLER) {
> + hdev->quirks |= HID_QUIRK_SKIP_OUTPUT_REPORT_ID;
> +
> + sony_init_output_report(sc, sixaxis_send_output_report);
> } else if (sc->quirks & SIXAXIS_CONTROLLER_USB) {
> /*
> * The Sony Sixaxis does not handle HID Output Reports on the
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* [PATCH v2] HID: sony: Fix up nyko core controller
From: Scott Moreau @ 2017-12-13 2:21 UTC (permalink / raw)
To: linux-input; +Cc: Scott Moreau
This fixes missing d-pad axis broken since e19a267b99. The axis mapping for
the nyko controller has the d-pad as axis 0x39 instead of d-pad as buttons.
This is handled by the default hid mapping so we return 0 in sony_mapping.
This controller also has no accelerometer so avoid initializing it with
a condition in sony_input_configured() to setup these controllers.
---
drivers/hid/hid-sony.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
index b9dc3ac..1be0a35 100644
--- a/drivers/hid/hid-sony.c
+++ b/drivers/hid/hid-sony.c
@@ -1225,6 +1225,9 @@ static int sony_mapping(struct hid_device *hdev, struct hid_input *hi,
if (sc->quirks & NAVIGATION_CONTROLLER)
return navigation_mapping(hdev, hi, field, usage, bit, max);
+ if (sc->quirks & SINO_LITE_CONTROLLER)
+ return 0;
+
if (sc->quirks & SIXAXIS_CONTROLLER)
return sixaxis_mapping(hdev, hi, field, usage, bit, max);
@@ -2566,6 +2569,10 @@ static int sony_input_configured(struct hid_device *hdev,
}
sony_init_output_report(sc, sixaxis_send_output_report);
+ } else if (sc->quirks & SINO_LITE_CONTROLLER) {
+ hdev->quirks |= HID_QUIRK_SKIP_OUTPUT_REPORT_ID;
+
+ sony_init_output_report(sc, sixaxis_send_output_report);
} else if (sc->quirks & SIXAXIS_CONTROLLER_USB) {
/*
* The Sony Sixaxis does not handle HID Output Reports on the
--
2.7.4
^ permalink raw reply related
* Re: [PATCH v1] HID: sony: Print reversed MAC address via %pMR
From: Colenbrander, Roelof @ 2017-12-13 2:22 UTC (permalink / raw)
To: Andy Shevchenko, Jiri Kosina, Benjamin Tissoires,
linux-input@vger.kernel.org
In-Reply-To: <20171211130612.34715-1-andriy.shevchenko@linux.intel.com>
On 12/11/2017 05:07 AM, Andy Shevchenko wrote:
> Reversed MAC addresses can be printed directly using %pMR specifier.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/hid/hid-sony.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
> index b9dc3ac4d4aa..138fd44d3c91 100644
> --- a/drivers/hid/hid-sony.c
> +++ b/drivers/hid/hid-sony.c
> @@ -2399,10 +2399,7 @@ static int sony_check_add(struct sony_sc *sc)
> memcpy(sc->mac_address, &buf[1], sizeof(sc->mac_address));
>
> snprintf(sc->hdev->uniq, sizeof(sc->hdev->uniq),
> - "%02hhx:%02hhx:%02hhx:%02hhx:%02hhx:%02hhx",
> - sc->mac_address[5], sc->mac_address[4],
> - sc->mac_address[3], sc->mac_address[2],
> - sc->mac_address[1], sc->mac_address[0]);
> + "%pMR", sc->mac_address);
> } else if ((sc->quirks & SIXAXIS_CONTROLLER_USB) ||
> (sc->quirks & NAVIGATION_CONTROLLER_USB)) {
> buf = kmalloc(SIXAXIS_REPORT_0xF2_SIZE, GFP_KERNEL);
> @@ -2432,10 +2429,7 @@ static int sony_check_add(struct sony_sc *sc)
> sc->mac_address[5-n] = buf[4+n];
>
> snprintf(sc->hdev->uniq, sizeof(sc->hdev->uniq),
> - "%02hhx:%02hhx:%02hhx:%02hhx:%02hhx:%02hhx",
> - sc->mac_address[5], sc->mac_address[4],
> - sc->mac_address[3], sc->mac_address[2],
> - sc->mac_address[1], sc->mac_address[0]);
> + "%pMR", sc->mac_address);
> } else {
> return 0;
> }
>
Looks good and in a quick test seems to function.
Acked-by: Roderick Colenbrander <roderick.colenbranderer@sony.com>
^ permalink raw reply
* [RFC PATCH] Input: hid_cmd_state can be static
From: kbuild test robot @ 2017-12-13 11:37 UTC (permalink / raw)
Cc: kbuild-all, dmitry.torokhov, robh+dt, mark.rutland, linux-kernel,
linux-input, devicetree, mylene.josserand, thomas.petazzoni,
maxime.ripard
In-Reply-To: <20171201153957.13053-2-mylene.josserand@free-electrons.com>
Fixes: 68d0bd1e4815 ("Input: Add driver for Cypress Generation 5 touchscreen")
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
cyttsp5.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/touchscreen/cyttsp5.c b/drivers/input/touchscreen/cyttsp5.c
index a41feea..9694ae41 100644
--- a/drivers/input/touchscreen/cyttsp5.c
+++ b/drivers/input/touchscreen/cyttsp5.c
@@ -139,7 +139,7 @@ struct cyttsp5_sensing_conf_data {
u8 max_tch;
};
-enum { HID_CMD_DONE, HID_CMD_BUSY } hid_cmd_state;
+static enum { HID_CMD_DONE, HID_CMD_BUSY } hid_cmd_state;
enum cyttsp5_tch_abs { /* for ordering within the extracted touch data array */
CY_TCH_X, /* X */
^ permalink raw reply related
* Re: [PATCH v4 1/2] Input: Add driver for Cypress Generation 5 touchscreen
From: kbuild test robot @ 2017-12-13 11:37 UTC (permalink / raw)
Cc: kbuild-all, dmitry.torokhov, robh+dt, mark.rutland, linux-kernel,
linux-input, devicetree, mylene.josserand, thomas.petazzoni,
maxime.ripard
In-Reply-To: <20171201153957.13053-2-mylene.josserand@free-electrons.com>
Hi Mylène,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on input/next]
[also build test WARNING on v4.15-rc3 next-20171213]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Myl-ne-Josserand/Input-Add-driver-for-Cypress-Generation-5-touchscreen/20171203-203557
base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
reproduce:
# apt-get install sparse
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
^ permalink raw reply
* Re: [PATCH] HID: elecom: rewrite report fixup for EX-G and future mice
From: Tomasz Kramkowski @ 2017-12-13 21:47 UTC (permalink / raw)
To: Alex Manoussakis
Cc: Jiri Kosina, Benjamin Tissoires, Yuxuan Shui,
Diego Elio Pettenò, linux-input, linux-kernel
In-Reply-To: <20171211173116.GA9941@gnu.org>
On Mon, Dec 11, 2017 at 12:31:16PM -0500, Alex Manoussakis wrote:
> Tomasz please add the wireless version in your next patch, a web search
> shows it's called M-XT3DRBK and the USB ID is 0x00fc.
M-XT3DRBK is the full model number for the wireless EX-G but since the
HUGE and DEFT both use their short names in the hid-ids macros then I'll
call this one EX_G_WIRELESS so that it matches the naming style of
everything else.
However, I'm a bit apprehensive about sending in a patch for a device I
can't test. Even if it's most likely going to work. Do you know of
anyone who can test this wireless EX-G variant?
I guess Jiri can chip in if he thinks this is not necessary. Technically
this patch should sit in linux-next for a while (but reportedly few
people actually run on that iirc) and the worst that could happen is
that the checks in the report fixup function don't match the expected
report and don't apply the fix, or (unlikely) some padding bits get
exposed as buttons with no function.
Either way, I've made this change locally and will be submitting v2 when
I have a bit more time later this week.
> Thanks,
> Alex
--
Tomasz Kramkowski | GPG: 40B037BA0A5B8680 | Web: https://the-tk.com/
^ permalink raw reply
* Re: [PATCH] HID: elecom: rewrite report fixup for EX-G and future mice
From: Alex Manoussakis @ 2017-12-14 1:02 UTC (permalink / raw)
To: Tomasz Kramkowski
Cc: Jiri Kosina, Benjamin Tissoires, Yuxuan Shui,
Diego Elio Pettenò, linux-input, linux-kernel
In-Reply-To: <20171213214746.GA23615@gaia.local>
On Wed, Dec 13, 2017 at 09:47:46PM +0000, Tomasz Kramkowski wrote:
> On Mon, Dec 11, 2017 at 12:31:16PM -0500, Alex Manoussakis wrote:
> > Tomasz please add the wireless version in your next patch, a web search
> > shows it's called M-XT3DRBK and the USB ID is 0x00fc.
>
> I'll call this one EX_G_WIRELESS so that it matches the naming style
Sounds fine.
> However, I'm a bit apprehensive about sending in a patch for a device I
> can't test. Even if it's most likely going to work. Do you know of
> anyone who can test this wireless EX-G variant?
No, but I can imagine their disappointment when their device won't work
when it could have :-) Most users aren't developers and won't submit kernel
patches for their device. They'll just assume linux has subpar device support,
so it's up to us to avoid this :-P
It would be a pity to miss the opportunity to add a device variant that will
almost certainly work (and harmless in the extremely remote chance it doesn't).
Even if a Linux user with the wireless device is a developer and decides to fix
it and sends a patch to add the wireless later it's a lot more work for everyone
involved (and delay in getting it in mainline) compared to just making your work
complete now!
I didn't test the wireless HUGE either, but added it anyway. I did see reports
of people successfully using DKMS modules floating around the Internet with
their wireless HUGE/DEFT devices. I even tried one of them meant for the
*wireless* DEFT, and changed the usb ID and saw it worked for my *wired* HUGE.
This shows how Elecom tries to make their different devices work in the same
manner as much as possible (which makes sense as they won't want to complicate
their own software either) making the wireless addition a no-brainer IMO.
Also the EX_G_WIRELESS matches Elecom's convention of incrementing the wired
device ID by 1 for the wireless, so it all looks consistent and predictable.
BTW I did try your patch with my wired HUGE and it works fine, dmesg showed
your revised message after booting, and I verified all 3 Fn buttons work fine.
[ 7.444707] elecom 0003:056E:010C.0005: Fixing up ELECOM mouse button count
Thanks!
Alex
^ permalink raw reply
* Re: [PATCH v4 0/4] Make input drivers y2038 safe
From: Peter Hutterer @ 2017-12-14 5:33 UTC (permalink / raw)
To: Deepa Dinamani; +Cc: dmitry.torokhov, linux-input, linux-kernel, arnd, y2038
In-Reply-To: <20171207181306.5623-1-deepa.kernel@gmail.com>
On Thu, Dec 07, 2017 at 10:13:02AM -0800, Deepa Dinamani wrote:
> The series is aimed at making input events y2038 safe.
> It extends the lifetime of the realtime timestamps in the
> events to year 2106.
> The series is also a necessary update as glibc is set to provide
> 64 bit time_t support for 32 bit binaries. glibc plan is detailed
> at https://sourceware.org/glibc/wiki/Y2038ProofnessDesign .
>
> The series is a result of discussions with Arnd Bergmann and
> Dmitry Torokhov at last Plumbers.
>
> The plan is to deprecate realtime timestamps anyway as they
> are not appropriate for these timestamps as noted in the patch
> a80b83b7b8 by John Stultz.
>
> The design also updates the format of the input events read/ written
> to the device nodes. This breaks 32 bit interface to the input
> events at compile time as preferred by the maintainer.
>
> The userspace library changes to libevdev, libuinput and mtdev
> will be posted to the respective mailing groups for review.
Acked-by: Peter Hutterer <peter.hutterer@who-t.net>
Cheers,
Peter
> Changes from v3:
> * Updated uinput to support monotonic time only
> * Addressed review comments
> Changes from v2:
> * Updated the design to break 32 bit interfaces at compile time.
> Changes from v1:
> * Updated changes according to review comments.
> * Posted userspace library changes that go along with the series.
>
> Deepa Dinamani (4):
> uinput: Use monotonic times for uinput timestamps.
> input: evdev: Replace timeval with timespec64
> input: Deprecate real timestamps beyond year 2106
> input: serio: Replace timeval by timespec64
>
> drivers/input/evdev.c | 43 +++++++++++++++++++++++++---------------
> drivers/input/input-compat.c | 11 +++++-----
> drivers/input/input-compat.h | 3 ++-
> drivers/input/misc/uinput.c | 5 ++++-
> drivers/input/serio/hil_mlc.c | 37 +++++++++++++++++-----------------
> drivers/input/serio/hp_sdc.c | 17 ++++++++--------
> drivers/input/serio/hp_sdc_mlc.c | 10 +++++-----
> include/linux/hil_mlc.h | 6 +++---
> include/linux/hp_sdc.h | 6 +++---
> include/uapi/linux/input.h | 12 ++++++++++-
> 10 files changed, 88 insertions(+), 62 deletions(-)
>
>
> base-commit: b0a84f19a5161418d4360cd57603e94ed489915e
> --
> 2.14.1
>
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox