* Re: [Regression] Bug 216885 - HID++ Logitech G903 generates full scroll wheel events with every hi-res tick when attached via USB
From: Linux kernel regression tracking (Thorsten Leemhuis) @ 2023-01-30 9:56 UTC (permalink / raw)
To: Bastien Nocera, Benjamin Tissoires, Jiri Kosina
Cc: David Roth, open list:HID CORE LAYER, regressions@lists.linux.dev,
LKML, Tobias Klausmann, Linus
In-Reply-To: <1bb93259-1c9f-5335-a0bf-fc8641b26650@leemhuis.info>
[ccing a few people that CCed to the bug]
Hi, this is your Linux kernel regression tracker.
On 05.01.23 09:12, Thorsten Leemhuis wrote:
> [...] Quoting from https://bugzilla.kernel.org/show_bug.cgi?id=216885 :
>
>> David Roth 2023-01-04 20:37:22 UTC
>>
>> Created attachment 303526 [details]
>> Libinput record with G903 attached directly to USB
>>
>> Since
>> https://lore.kernel.org/linux-input/20220914132146.6435-1-hadess@hadess.net/T/#u
>> my Logitech G903 has gained hi res support. While normally a good
>> thing, it seems that in this case it leads to generating one normal
>> REL_WHEEL with each REL_WHEEL_HI_RES event instead of just a couple
>> of REL_WHEEL_HI_RES, followed by the standard REL_WHEEL once a
>> notch/tick is reached. This leads to overly sensitive scrolling and
>> makes the wheel basically useless.
Bastien, Benjamin, Jiri, that problem was reported 25 days ago now and
there is still no fix in sight afaics (please correct me if I'm wrong)
-- and based on the reports I've seen it seem quite a few people are
hitting it. Hence please allow me to ask:
Wouldn't it be best to revert that change for now (both in mainline and
stable of course) and then reapply it once a fix for this problem is
available? Or
Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.
>> Interestingly this only happens when the mouse is connected directly via
>> cable (PID:0xC091) and not via the Lightspeed wireless dongle
>> (PID:0x4087) where it will lead to correctly applying the times 8
>> multiplier and the relevant set of HI_RES and REL_WHEEL event once a
>> notch is reached.
>>
>> I originally thought about patching the module/adding a param to simple
>> disable high res support in general, assuming this might be something
>> people might want to configure, but seeing that this can be "fixed" that
>> way I decided to hold off on the thought.
>>
>> However it seems like we'd need to trade one set of quirks for another,
>> so not sure what the correct approach might be.
>>
>> I'll attach some libinput debug logs when the issue happens.
>
> See the ticket for more details.
>
> BTW, let me use this mail to also add the report to the list of tracked
> regressions to ensure it's doesn't fall through the cracks:
>
> #regzbot introduced: 908d325e1665
> https://bugzilla.kernel.org/show_bug.cgi?id=216885
> #regzbot title: hid: overly sensitive scrolling with Logitech G903 that
> makes the wheel basically useless
> #regzbot ignore-activity
>
> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> --
> Everything you wanna know about Linux kernel regression tracking:
> https://linux-regtracking.leemhuis.info/about/#tldr
> If I did something stupid, please tell me, as explained on that page.
^ permalink raw reply
* Re: [regression] Bug 216977 - asus t100 touchpad registered but not working
From: Hans de Goede @ 2023-01-30 10:16 UTC (permalink / raw)
To: Linux regressions mailing list, Jiri Kosina, Benjamin Tissoires
Cc: LKML, open list:HID CORE LAYER, jessegodfroy
In-Reply-To: <2f4dc626-5287-6ec7-a31d-335e5dbb9119@leemhuis.info>
Hi All,
On 1/30/23 10:22, Linux kernel regression tracking (Thorsten Leemhuis) wrote:
> Hi, this is your Linux kernel regression tracker.
>
> I noticed a regression report in bugzilla.kernel.org. As many (most?)
> kernel developer don't keep an eye on it, I decided to forward it by
> mail. Quoting from https://bugzilla.kernel.org/show_bug.cgi?id=216977 :
>
>> jessegodfroy@gmail.com 2023-01-29 15:44:34 UTC
>>
>> After upgrading the kernel from 6.0 series to the 6.1 the touchpad on my asus t100 no longer works.
>>
>> The device is registered in dmesg. I believe hid_asus is responsible for the keyboard and touchpad. The keyboard continues to function, but the touchpad does not.
>>
>> Jan 29 09:29:53 t100ta-white kernel: asus 0003:0B05:17E0.0001: input,hidraw0: USB HID v1.11 Keyboard [ASUSTek COMPUTER INC. ASUS Base Station(T100)] on usb-0000:00:14.0-3/input0
>> Jan 29 09:29:53 t100ta-white kernel: asus 0003:0B05:17E0.0002: Fixing up Asus T100 keyb report descriptor
>> Jan 29 09:29:53 t100ta-white kernel: asus 0003:0B05:17E0.0002: input,hiddev96,hidraw1: USB HID v1.11 Device [ASUSTek COMPUTER INC. ASUS Base Station(T100)] on usb-0000:00:14.0-3/input1
>> Jan 29 09:29:53 t100ta-white kernel: asus 0003:0B05:17E0.0003: input,hiddev97,hidraw2: USB HID v1.11 Mouse [ASUSTek COMPUTER INC. ASUS Base Station(T100)] on usb-0000:00:14.0-3/input2
>>
>> I do not see any changes to hid_asus that should be responsible for the change in performance.
> See the ticket for more details.
This is my bad, I accidentally broke SW_TABLET_MODE reporting on
the Asus T100* and T101* series and it is now reporting that it
is in tablet mode while it is actually docked and thus in laptop
mode.
This is causing libinput to suppress touchpad events, as
it would for a 360° hinges style 2 in 1 with the keyboard +
touchpad folded behind the display (so in tablet mode).
A fix for this has already been merged for 6.2-rc6:
"platform/x86: asus-wmi: Fix kbd_dock_devid tablet-switch reporting"
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=fdcc0602d64f22185f61c70747214b630049cc33
And the fix is also queued for the next 6.1.y stable series release:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/log/?h=queue/6.1
I'll also add this info as a comment to the bug.
Regards,
Hans
^ permalink raw reply
* Re: [regression] Bug 216977 - asus t100 touchpad registered but not working
From: Linux kernel regression tracking (Thorsten Leemhuis) @ 2023-01-30 9:25 UTC (permalink / raw)
To: Jiri Kosina, Benjamin Tissoires
Cc: Linux kernel regressions list, LKML, open list:HID CORE LAYER,
jessegodfroy
In-Reply-To: <2f4dc626-5287-6ec7-a31d-335e5dbb9119@leemhuis.info>
[resent with Benjamin's proper email address; sorry for the noise]
On 30.01.23 10:22, Linux kernel regression tracking (Thorsten Leemhuis)
wrote:
> Hi, this is your Linux kernel regression tracker.
>
> I noticed a regression report in bugzilla.kernel.org. As many (most?)
> kernel developer don't keep an eye on it, I decided to forward it by
> mail. Quoting from https://bugzilla.kernel.org/show_bug.cgi?id=216977 :
>
>> jessegodfroy@gmail.com 2023-01-29 15:44:34 UTC
>>
>> After upgrading the kernel from 6.0 series to the 6.1 the touchpad on my asus t100 no longer works.
>>
>> The device is registered in dmesg. I believe hid_asus is responsible for the keyboard and touchpad. The keyboard continues to function, but the touchpad does not.
>>
>> Jan 29 09:29:53 t100ta-white kernel: asus 0003:0B05:17E0.0001: input,hidraw0: USB HID v1.11 Keyboard [ASUSTek COMPUTER INC. ASUS Base Station(T100)] on usb-0000:00:14.0-3/input0
>> Jan 29 09:29:53 t100ta-white kernel: asus 0003:0B05:17E0.0002: Fixing up Asus T100 keyb report descriptor
>> Jan 29 09:29:53 t100ta-white kernel: asus 0003:0B05:17E0.0002: input,hiddev96,hidraw1: USB HID v1.11 Device [ASUSTek COMPUTER INC. ASUS Base Station(T100)] on usb-0000:00:14.0-3/input1
>> Jan 29 09:29:53 t100ta-white kernel: asus 0003:0B05:17E0.0003: input,hiddev97,hidraw2: USB HID v1.11 Mouse [ASUSTek COMPUTER INC. ASUS Base Station(T100)] on usb-0000:00:14.0-3/input2
>>
>> I do not see any changes to hid_asus that should be responsible for the change in performance.
> See the ticket for more details.
>
>
> [TLDR for the rest of this mail: I'm adding this report to the list of
> tracked Linux kernel regressions; the text you find below is based on a
> few templates paragraphs you might have encountered already in similar
> form.]
>
> BTW, let me use this mail to also add the report to the list of tracked
> regressions to ensure it's doesn't fall through the cracks:
>
> #regzbot introduced: v6.0..v6.1
> https://bugzilla.kernel.org/show_bug.cgi?id=216977
> #regzbot title: input: hid: asus t100 touchpad registered but not working
> #regzbot ignore-activity
>
> This isn't a regression? This issue or a fix for it are already
> discussed somewhere else? It was fixed already? You want to clarify when
> the regression started to happen? Or point out I got the title or
> something else totally wrong? Then just reply and tell me -- ideally
> while also telling regzbot about it, as explained by the page listed in
> the footer of this mail.
>
> Developers: When fixing the issue, remember to add 'Link:' tags pointing
> to the report (e.g. the buzgzilla ticket and maybe this mail as well, if
> this thread sees some discussion). See page linked in footer for details.
>
> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> --
> Everything you wanna know about Linux kernel regression tracking:
> https://linux-regtracking.leemhuis.info/about/#tldr
> If I did something stupid, please tell me, as explained on that page.
^ permalink raw reply
* [regression] Bug 216977 - asus t100 touchpad registered but not working
From: Linux kernel regression tracking (Thorsten Leemhuis) @ 2023-01-30 9:22 UTC (permalink / raw)
To: Jiri Kosina, "Benjamin Tissoires <benjamin.tissoires"
Cc: Linux kernel regressions list, LKML, open list:HID CORE LAYER,
jessegodfroy
Hi, this is your Linux kernel regression tracker.
I noticed a regression report in bugzilla.kernel.org. As many (most?)
kernel developer don't keep an eye on it, I decided to forward it by
mail. Quoting from https://bugzilla.kernel.org/show_bug.cgi?id=216977 :
> jessegodfroy@gmail.com 2023-01-29 15:44:34 UTC
>
> After upgrading the kernel from 6.0 series to the 6.1 the touchpad on my asus t100 no longer works.
>
> The device is registered in dmesg. I believe hid_asus is responsible for the keyboard and touchpad. The keyboard continues to function, but the touchpad does not.
>
> Jan 29 09:29:53 t100ta-white kernel: asus 0003:0B05:17E0.0001: input,hidraw0: USB HID v1.11 Keyboard [ASUSTek COMPUTER INC. ASUS Base Station(T100)] on usb-0000:00:14.0-3/input0
> Jan 29 09:29:53 t100ta-white kernel: asus 0003:0B05:17E0.0002: Fixing up Asus T100 keyb report descriptor
> Jan 29 09:29:53 t100ta-white kernel: asus 0003:0B05:17E0.0002: input,hiddev96,hidraw1: USB HID v1.11 Device [ASUSTek COMPUTER INC. ASUS Base Station(T100)] on usb-0000:00:14.0-3/input1
> Jan 29 09:29:53 t100ta-white kernel: asus 0003:0B05:17E0.0003: input,hiddev97,hidraw2: USB HID v1.11 Mouse [ASUSTek COMPUTER INC. ASUS Base Station(T100)] on usb-0000:00:14.0-3/input2
>
> I do not see any changes to hid_asus that should be responsible for the change in performance.
See the ticket for more details.
[TLDR for the rest of this mail: I'm adding this report to the list of
tracked Linux kernel regressions; the text you find below is based on a
few templates paragraphs you might have encountered already in similar
form.]
BTW, let me use this mail to also add the report to the list of tracked
regressions to ensure it's doesn't fall through the cracks:
#regzbot introduced: v6.0..v6.1
https://bugzilla.kernel.org/show_bug.cgi?id=216977
#regzbot title: input: hid: asus t100 touchpad registered but not working
#regzbot ignore-activity
This isn't a regression? This issue or a fix for it are already
discussed somewhere else? It was fixed already? You want to clarify when
the regression started to happen? Or point out I got the title or
something else totally wrong? Then just reply and tell me -- ideally
while also telling regzbot about it, as explained by the page listed in
the footer of this mail.
Developers: When fixing the issue, remember to add 'Link:' tags pointing
to the report (e.g. the buzgzilla ticket and maybe this mail as well, if
this thread sees some discussion). See page linked in footer for details.
Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.
^ permalink raw reply
* Re: [PATCH v8 5/5] input: pwm-beeper: handle module unloading properly
From: Frieder Schrempf @ 2023-01-30 9:07 UTC (permalink / raw)
To: Manuel Traut, linux-kernel
Cc: Dmitry Torokhov, Rob Herring, Krzysztof Kozlowski, linux-input,
devicetree
In-Reply-To: <20230126091825.220646-6-manuel.traut@mt.com>
Hi Manuel,
On 26.01.23 10:18, Manuel Traut wrote:
> 'input: pwm-beeper: add feature to set volume via sysfs' adds device
> attributes without removing them on error or if the module is unloaded.
>
> If the module will be unloaded and loaded again it fails:
> [ 1007.918180] sysfs: cannot create duplicate filename '/devices/platform/buzzer/volume'
>
> Therefore remove device attributes on module unloading and in case
> registration at the input subsystem fails.
>
> Signed-off-by: Manuel Traut <manuel.traut@mt.com>
Thanks for picking up these old patches!
I think you need to merge this fixup patch 5/5 into patch 2/5 of this
series.
Thanks
Frieder
^ permalink raw reply
* Dependency on non-existing config I2C_DMI_CORE in commit a2f416bf062a ("HID: multitouch: Add quirks for flipped axes")
From: Lukas Bulwahn @ 2023-01-30 8:43 UTC (permalink / raw)
To: Allen Ballway, linux-input
Cc: Jiri Kosina, Jiri Kosina, Benjamin Tissoires, Henrik Rydberg,
Linux Kernel Mailing List
Dear Allen,
with commit a2f416bf062a ("HID: multitouch: Add quirks for flipped
axes"), you add code that is dependent on the CONFIG_I2C_DMI_CORE.
However, this config symbol has not been defined anywhere in the
kernel repository. Is this a mistake in your code and you intended to
refer to another config symbol? Is there another patch to come that
adds this config symbol? Or is this a config symbol that only exists
in some out-of-tree repository?
Something might be odd here, because this code is effectively dead now
with being dependent on a non-existing config symbol.
Best regards,
Lukas
^ permalink raw reply
* Re: [PATCH 0/9] HID: Constify lowlevel HID drivers
From: Hans de Goede @ 2023-01-30 8:36 UTC (permalink / raw)
To: Thomas Weißschuh, Basavaraj Natikar, Jiri Kosina,
Benjamin Tissoires, K. Y. Srinivasan, Haiyang Zhang, Wei Liu,
Dexuan Cui, Filipe Laíns, Srinivas Pandruvada,
Maximilian Luz, Corentin Chary, Mark Gross, Viresh Kumar,
Johan Hovold, Alex Elder, Greg Kroah-Hartman
Cc: linux-input, linux-kernel, linux-hyperv, platform-driver-x86,
acpi4asus-user, greybus-dev, linux-staging
In-Reply-To: <20230130-hid-const-ll-driver-v1-0-3fc282b3b1d0@weissschuh.net>
Hi,
On 1/30/23 04:59, Thomas Weißschuh wrote:
> Since 52d225346904 ("HID: Make lowlevel driver structs const") the
> lowlevel HID drivers are only exposed as const.
>
> Take advantage of this to constify the underlying structures, too.
>
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Thanks, series looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
I'll also pick up / merge patches 7 + 8 into pdx86/for-next
sometime this week.
Regards,
Hans
> ---
> Thomas Weißschuh (9):
> HID: amd_sfh: Constify lowlevel HID driver
> HID: hyperv: Constify lowlevel HID driver
> HID: logitech-dj: Constify lowlevel HID driver
> HID: steam: Constify lowlevel HID driver
> HID: intel-ish-hid: Constify lowlevel HID driver
> HID: surface-hid: Constify lowlevel HID driver
> platform/x86: asus-tf103c-dock: Constify lowlevel HID driver
> platform/x86: asus-tf103c-dock: Constify toprow keymap
> staging: greybus: hid: Constify lowlevel HID driver
>
> drivers/hid/amd-sfh-hid/amd_sfh_hid.c | 2 +-
> drivers/hid/hid-hyperv.c | 2 +-
> drivers/hid/hid-logitech-dj.c | 4 ++--
> drivers/hid/hid-steam.c | 2 +-
> drivers/hid/intel-ish-hid/ishtp-hid.c | 2 +-
> drivers/hid/surface-hid/surface_hid_core.c | 2 +-
> drivers/platform/x86/asus-tf103c-dock.c | 4 ++--
> drivers/staging/greybus/hid.c | 2 +-
> 8 files changed, 10 insertions(+), 10 deletions(-)
> ---
> base-commit: e04955db6a7c3fc4a1e6978649b61a6f5f8028e3
> change-id: 20230130-hid-const-ll-driver-fcfdd3af11b8
>
> Best regards,
^ permalink raw reply
* Re: [PATCH] Input: exc3000 - properly stop timer on shutdown
From: Miko Larsson @ 2023-01-30 6:17 UTC (permalink / raw)
To: Dmitry Torokhov, Stahl, Michael, linux-input; +Cc: linux-kernel
In-Reply-To: <Y9dK57BFqtlf8NmN@google.com>
On Sun, 2023-01-29 at 20:43 -0800, Dmitry Torokhov wrote:
> We need to stop the timer on driver unbind or probe failures,
> otherwise
> we get UAF/Oops.
>
> Fixes: 7e577a17f2ee ("Input: add I2C attached EETI EXC3000 multi
> touch driver")
> Reported-by: "Stahl, Michael" <mstahl@moba.de>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
> drivers/input/touchscreen/exc3000.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/input/touchscreen/exc3000.c
> b/drivers/input/touchscreen/exc3000.c
> index 4b7eee01c6aa..69eae79e2087 100644
> --- a/drivers/input/touchscreen/exc3000.c
> +++ b/drivers/input/touchscreen/exc3000.c
> @@ -109,6 +109,11 @@ static inline void exc3000_schedule_timer(struct
> exc3000_data *data)
> mod_timer(&data->timer, jiffies +
> msecs_to_jiffies(EXC3000_TIMEOUT_MS));
> }
>
> +static void exc3000_shutdown_timer(void *timer)
> +{
> + timer_shutdown_sync(timer);
> +}
> +
> static int exc3000_read_frame(struct exc3000_data *data, u8 *buf)
> {
> struct i2c_client *client = data->client;
> @@ -386,6 +391,11 @@ static int exc3000_probe(struct i2c_client
> *client)
> if (error)
> return error;
>
> + error = devm_add_action_or_reset(&client->dev,
> exc3000_shutdown_timer,
> + &data->timer);
> + if (error)
> + return error;
> +
> error = devm_request_threaded_irq(&client->dev, client->irq,
> NULL, exc3000_interrupt,
> IRQF_ONESHOT,
> client->name, data);
> --
> 2.39.1.456.gfc5497dd1b-goog
>
>
This should probably be Cc'ed to the stable mailing list.
--
~miko
^ permalink raw reply
* Re: [PATCH] Input: edt-ft5x06 - fix typo in a comment
From: Dmitry Torokhov @ 2023-01-30 4:48 UTC (permalink / raw)
To: Dario Binacchi
Cc: linux-kernel, Michael Trimarchi, Oliver Graute,
Uwe Kleine-König, Wolfram Sang, linux-input
In-Reply-To: <20230128162325.64467-1-dario.binacchi@amarulasolutions.com>
On Sat, Jan 28, 2023 at 05:23:25PM +0100, Dario Binacchi wrote:
> Replace 'firmares' with 'firmwares'.
>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Applied, thank you.
--
Dmitry
^ permalink raw reply
* Re: [PATCH] Input: tegra-kbc - Use devm_platform_get_and_ioremap_resource()
From: Dmitry Torokhov @ 2023-01-30 4:48 UTC (permalink / raw)
To: ye.xingchen
Cc: ldewangan, thierry.reding, jonathanh, linux-input, linux-tegra,
linux-kernel
In-Reply-To: <202301281613032191431@zte.com.cn>
On Sat, Jan 28, 2023 at 04:13:03PM +0800, ye.xingchen@zte.com.cn wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
Applied, thank you.
--
Dmitry
^ permalink raw reply
* Re: [PATCH] Input: st-keyscan - Use devm_platform_get_and_ioremap_resource()
From: Dmitry Torokhov @ 2023-01-30 4:48 UTC (permalink / raw)
To: ye.xingchen
Cc: andriy.shevchenko, jonathan.cameron, linux-input, linux-kernel
In-Reply-To: <202301281611305841413@zte.com.cn>
On Sat, Jan 28, 2023 at 04:11:30PM +0800, ye.xingchen@zte.com.cn wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
Applied, thank you.
--
Dmitry
^ permalink raw reply
* Re: [PATCH] Input: spear-keyboard - Use devm_platform_get_and_ioremap_resource()
From: Dmitry Torokhov @ 2023-01-30 4:48 UTC (permalink / raw)
To: ye.xingchen; +Cc: jonathan.cameron, linux-input, linux-kernel
In-Reply-To: <202301281609576851394@zte.com.cn>
On Sat, Jan 28, 2023 at 04:09:57PM +0800, ye.xingchen@zte.com.cn wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
Applied, thank you.
--
Dmitry
^ permalink raw reply
* Re: [PATCH] Input: olpc_apsp - Use devm_platform_get_and_ioremap_resource()
From: Dmitry Torokhov @ 2023-01-30 4:48 UTC (permalink / raw)
To: ye.xingchen; +Cc: wsa+renesas, linux-input, linux-kernel
In-Reply-To: <202301281608287301370@zte.com.cn>
On Sat, Jan 28, 2023 at 04:08:28PM +0800, ye.xingchen@zte.com.cn wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
Applied, thank you.
--
Dmitry
^ permalink raw reply
* Re: [PATCH] Input: arc_ps2 - Use devm_platform_get_and_ioremap_resource()
From: Dmitry Torokhov @ 2023-01-30 4:47 UTC (permalink / raw)
To: ye.xingchen; +Cc: linux-input, linux-kernel
In-Reply-To: <202301281606309671328@zte.com.cn>
On Sat, Jan 28, 2023 at 04:06:30PM +0800, ye.xingchen@zte.com.cn wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
Applied, thank you.
--
Dmitry
^ permalink raw reply
* Re: [PATCH] Input: apbps2 - Use devm_platform_get_and_ioremap_resource()
From: Dmitry Torokhov @ 2023-01-30 4:47 UTC (permalink / raw)
To: ye.xingchen; +Cc: wsa+renesas, linux-input, linux-kernel
In-Reply-To: <202301281604596831304@zte.com.cn>
On Sat, Jan 28, 2023 at 04:04:59PM +0800, ye.xingchen@zte.com.cn wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
Applied, thank you.
--
Dmitry
^ permalink raw reply
* Re: [PATCH] Input: altera_ps2 - Use devm_platform_get_and_ioremap_resource()
From: Dmitry Torokhov @ 2023-01-30 4:47 UTC (permalink / raw)
To: ye.xingchen; +Cc: wsa+renesas, linux-input, linux-kernel
In-Reply-To: <202301281603290601283@zte.com.cn>
On Sat, Jan 28, 2023 at 04:03:29PM +0800, ye.xingchen@zte.com.cn wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
Applied, thank you.
--
Dmitry
^ permalink raw reply
* [PATCH] Input: exc3000 - properly stop timer on shutdown
From: Dmitry Torokhov @ 2023-01-30 4:43 UTC (permalink / raw)
To: Stahl, Michael, linux-input; +Cc: linux-kernel
We need to stop the timer on driver unbind or probe failures, otherwise
we get UAF/Oops.
Fixes: 7e577a17f2ee ("Input: add I2C attached EETI EXC3000 multi touch driver")
Reported-by: "Stahl, Michael" <mstahl@moba.de>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/input/touchscreen/exc3000.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/input/touchscreen/exc3000.c b/drivers/input/touchscreen/exc3000.c
index 4b7eee01c6aa..69eae79e2087 100644
--- a/drivers/input/touchscreen/exc3000.c
+++ b/drivers/input/touchscreen/exc3000.c
@@ -109,6 +109,11 @@ static inline void exc3000_schedule_timer(struct exc3000_data *data)
mod_timer(&data->timer, jiffies + msecs_to_jiffies(EXC3000_TIMEOUT_MS));
}
+static void exc3000_shutdown_timer(void *timer)
+{
+ timer_shutdown_sync(timer);
+}
+
static int exc3000_read_frame(struct exc3000_data *data, u8 *buf)
{
struct i2c_client *client = data->client;
@@ -386,6 +391,11 @@ static int exc3000_probe(struct i2c_client *client)
if (error)
return error;
+ error = devm_add_action_or_reset(&client->dev, exc3000_shutdown_timer,
+ &data->timer);
+ if (error)
+ return error;
+
error = devm_request_threaded_irq(&client->dev, client->irq,
NULL, exc3000_interrupt, IRQF_ONESHOT,
client->name, data);
--
2.39.1.456.gfc5497dd1b-goog
--
Dmitry
^ permalink raw reply related
* Re: [PATCH v5 0/3] Input: ads7846 - fix support for ADS7845
From: Dmitry Torokhov @ 2023-01-30 4:35 UTC (permalink / raw)
To: Luca Ellero
Cc: daniel, m.felsch, andriy.shevchenko, u.kleine-koenig, mkl,
miquel.raynal, imre.deak, luca.ellero, linux-input, linux-kernel
In-Reply-To: <20230126105227.47648-1-l.ellero@asem.it>
On Thu, Jan 26, 2023 at 11:52:24AM +0100, Luca Ellero wrote:
> ADS7845 support is buggy in this driver.
> These patches fix various issues to get it work properly.
Applied the lot, thank you.
--
Dmitry
^ permalink raw reply
* Re: [PATCH] input: keyboard: fix a Kconfig spelling mistake & hyphenation
From: Dmitry Torokhov @ 2023-01-30 4:34 UTC (permalink / raw)
To: Randy Dunlap; +Cc: linux-kernel, linux-input
In-Reply-To: <20230124233453.22893-1-rdunlap@infradead.org>
On Tue, Jan 24, 2023 at 03:34:53PM -0800, Randy Dunlap wrote:
> Correct a spelling mistake (reported by codespell).
> Also hyphenate "matrix-based".
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: linux-input@vger.kernel.org
Applied, thank you.
--
Dmitry
^ permalink raw reply
* [PATCH 8/9] platform/x86: asus-tf103c-dock: Constify toprow keymap
From: Thomas Weißschuh @ 2023-01-30 3:59 UTC (permalink / raw)
To: Basavaraj Natikar, Jiri Kosina, Benjamin Tissoires,
K. Y. Srinivasan, Haiyang Zhang, Wei Liu, Dexuan Cui,
Filipe Laíns, Srinivas Pandruvada, Maximilian Luz,
Corentin Chary, Hans de Goede, Mark Gross, Viresh Kumar,
Johan Hovold, Alex Elder, Greg Kroah-Hartman
Cc: linux-input, linux-kernel, linux-hyperv, platform-driver-x86,
acpi4asus-user, greybus-dev, linux-staging, Thomas Weißschuh
In-Reply-To: <20230130-hid-const-ll-driver-v1-0-3fc282b3b1d0@weissschuh.net>
This structure is never modified, make it const.
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
drivers/platform/x86/asus-tf103c-dock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/asus-tf103c-dock.c b/drivers/platform/x86/asus-tf103c-dock.c
index 84c45e8f51ad..aeb1138464df 100644
--- a/drivers/platform/x86/asus-tf103c-dock.c
+++ b/drivers/platform/x86/asus-tf103c-dock.c
@@ -259,7 +259,7 @@ static const struct hid_ll_driver tf103c_dock_hid_ll_driver = {
.raw_request = tf103c_dock_hid_raw_request,
};
-static int tf103c_dock_toprow_codes[13][2] = {
+static const int tf103c_dock_toprow_codes[13][2] = {
/* Normal, AltGr pressed */
{ KEY_POWER, KEY_F1 },
{ KEY_RFKILL, KEY_F2 },
--
2.39.1
^ permalink raw reply related
* [PATCH 7/9] platform/x86: asus-tf103c-dock: Constify lowlevel HID driver
From: Thomas Weißschuh @ 2023-01-30 3:59 UTC (permalink / raw)
To: Basavaraj Natikar, Jiri Kosina, Benjamin Tissoires,
K. Y. Srinivasan, Haiyang Zhang, Wei Liu, Dexuan Cui,
Filipe Laíns, Srinivas Pandruvada, Maximilian Luz,
Corentin Chary, Hans de Goede, Mark Gross, Viresh Kumar,
Johan Hovold, Alex Elder, Greg Kroah-Hartman
Cc: linux-input, linux-kernel, linux-hyperv, platform-driver-x86,
acpi4asus-user, greybus-dev, linux-staging, Thomas Weißschuh
In-Reply-To: <20230130-hid-const-ll-driver-v1-0-3fc282b3b1d0@weissschuh.net>
Since commit 52d225346904 ("HID: Make lowlevel driver structs const")
the lowlevel HID drivers are only exposed as const.
Take advantage of this to constify the underlying structure, too.
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
drivers/platform/x86/asus-tf103c-dock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/asus-tf103c-dock.c b/drivers/platform/x86/asus-tf103c-dock.c
index 62310e06282b..84c45e8f51ad 100644
--- a/drivers/platform/x86/asus-tf103c-dock.c
+++ b/drivers/platform/x86/asus-tf103c-dock.c
@@ -250,7 +250,7 @@ static int tf103c_dock_hid_raw_request(struct hid_device *hid, u8 reportnum,
return 0;
}
-static struct hid_ll_driver tf103c_dock_hid_ll_driver = {
+static const struct hid_ll_driver tf103c_dock_hid_ll_driver = {
.parse = tf103c_dock_hid_parse,
.start = tf103c_dock_hid_start,
.stop = tf103c_dock_hid_stop,
--
2.39.1
^ permalink raw reply related
* [PATCH 5/9] HID: intel-ish-hid: Constify lowlevel HID driver
From: Thomas Weißschuh @ 2023-01-30 3:59 UTC (permalink / raw)
To: Basavaraj Natikar, Jiri Kosina, Benjamin Tissoires,
K. Y. Srinivasan, Haiyang Zhang, Wei Liu, Dexuan Cui,
Filipe Laíns, Srinivas Pandruvada, Maximilian Luz,
Corentin Chary, Hans de Goede, Mark Gross, Viresh Kumar,
Johan Hovold, Alex Elder, Greg Kroah-Hartman
Cc: linux-input, linux-kernel, linux-hyperv, platform-driver-x86,
acpi4asus-user, greybus-dev, linux-staging, Thomas Weißschuh
In-Reply-To: <20230130-hid-const-ll-driver-v1-0-3fc282b3b1d0@weissschuh.net>
Since commit 52d225346904 ("HID: Make lowlevel driver structs const")
the lowlevel HID drivers are only exposed as const.
Take advantage of this to constify the underlying structure, too.
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
drivers/hid/intel-ish-hid/ishtp-hid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/intel-ish-hid/ishtp-hid.c b/drivers/hid/intel-ish-hid/ishtp-hid.c
index 14c271d7d8a9..00c6f0ebf356 100644
--- a/drivers/hid/intel-ish-hid/ishtp-hid.c
+++ b/drivers/hid/intel-ish-hid/ishtp-hid.c
@@ -183,7 +183,7 @@ void ishtp_hid_wakeup(struct hid_device *hid)
wake_up_interruptible(&hid_data->hid_wait);
}
-static struct hid_ll_driver ishtp_hid_ll_driver = {
+static const struct hid_ll_driver ishtp_hid_ll_driver = {
.parse = ishtp_hid_parse,
.start = ishtp_hid_start,
.stop = ishtp_hid_stop,
--
2.39.1
^ permalink raw reply related
* [PATCH 6/9] HID: surface-hid: Constify lowlevel HID driver
From: Thomas Weißschuh @ 2023-01-30 3:59 UTC (permalink / raw)
To: Basavaraj Natikar, Jiri Kosina, Benjamin Tissoires,
K. Y. Srinivasan, Haiyang Zhang, Wei Liu, Dexuan Cui,
Filipe Laíns, Srinivas Pandruvada, Maximilian Luz,
Corentin Chary, Hans de Goede, Mark Gross, Viresh Kumar,
Johan Hovold, Alex Elder, Greg Kroah-Hartman
Cc: linux-input, linux-kernel, linux-hyperv, platform-driver-x86,
acpi4asus-user, greybus-dev, linux-staging, Thomas Weißschuh
In-Reply-To: <20230130-hid-const-ll-driver-v1-0-3fc282b3b1d0@weissschuh.net>
Since commit 52d225346904 ("HID: Make lowlevel driver structs const")
the lowlevel HID drivers are only exposed as const.
Take advantage of this to constify the underlying structure, too.
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
drivers/hid/surface-hid/surface_hid_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/surface-hid/surface_hid_core.c b/drivers/hid/surface-hid/surface_hid_core.c
index 87637f813de2..a3e9cceddfac 100644
--- a/drivers/hid/surface-hid/surface_hid_core.c
+++ b/drivers/hid/surface-hid/surface_hid_core.c
@@ -174,7 +174,7 @@ static int surface_hid_raw_request(struct hid_device *hid, unsigned char reportn
return -EIO;
}
-static struct hid_ll_driver surface_hid_ll_driver = {
+static const struct hid_ll_driver surface_hid_ll_driver = {
.start = surface_hid_start,
.stop = surface_hid_stop,
.open = surface_hid_open,
--
2.39.1
^ permalink raw reply related
* [PATCH 9/9] staging: greybus: hid: Constify lowlevel HID driver
From: Thomas Weißschuh @ 2023-01-30 3:59 UTC (permalink / raw)
To: Basavaraj Natikar, Jiri Kosina, Benjamin Tissoires,
K. Y. Srinivasan, Haiyang Zhang, Wei Liu, Dexuan Cui,
Filipe Laíns, Srinivas Pandruvada, Maximilian Luz,
Corentin Chary, Hans de Goede, Mark Gross, Viresh Kumar,
Johan Hovold, Alex Elder, Greg Kroah-Hartman
Cc: linux-input, linux-kernel, linux-hyperv, platform-driver-x86,
acpi4asus-user, greybus-dev, linux-staging, Thomas Weißschuh
In-Reply-To: <20230130-hid-const-ll-driver-v1-0-3fc282b3b1d0@weissschuh.net>
Since commit 52d225346904 ("HID: Make lowlevel driver structs const")
the lowlevel HID drivers are only exposed as const.
Take advantage of this to constify the underlying structure, too.
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
drivers/staging/greybus/hid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/hid.c b/drivers/staging/greybus/hid.c
index adb91286803a..15335c38cb26 100644
--- a/drivers/staging/greybus/hid.c
+++ b/drivers/staging/greybus/hid.c
@@ -381,7 +381,7 @@ static int gb_hid_power(struct hid_device *hid, int lvl)
}
/* HID structure to pass callbacks */
-static struct hid_ll_driver gb_hid_ll_driver = {
+static const struct hid_ll_driver gb_hid_ll_driver = {
.parse = gb_hid_parse,
.start = gb_hid_start,
.stop = gb_hid_stop,
--
2.39.1
^ permalink raw reply related
* [PATCH 2/9] HID: hyperv: Constify lowlevel HID driver
From: Thomas Weißschuh @ 2023-01-30 3:59 UTC (permalink / raw)
To: Basavaraj Natikar, Jiri Kosina, Benjamin Tissoires,
K. Y. Srinivasan, Haiyang Zhang, Wei Liu, Dexuan Cui,
Filipe Laíns, Srinivas Pandruvada, Maximilian Luz,
Corentin Chary, Hans de Goede, Mark Gross, Viresh Kumar,
Johan Hovold, Alex Elder, Greg Kroah-Hartman
Cc: linux-input, linux-kernel, linux-hyperv, platform-driver-x86,
acpi4asus-user, greybus-dev, linux-staging, Thomas Weißschuh
In-Reply-To: <20230130-hid-const-ll-driver-v1-0-3fc282b3b1d0@weissschuh.net>
Since commit 52d225346904 ("HID: Make lowlevel driver structs const")
the lowlevel HID drivers are only exposed as const.
Take advantage of this to constify the underlying structure, too.
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
drivers/hid/hid-hyperv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-hyperv.c b/drivers/hid/hid-hyperv.c
index cf12f17e6533..819eb38eb5df 100644
--- a/drivers/hid/hid-hyperv.c
+++ b/drivers/hid/hid-hyperv.c
@@ -424,7 +424,7 @@ static int mousevsc_hid_raw_request(struct hid_device *hid,
return 0;
}
-static struct hid_ll_driver mousevsc_ll_driver = {
+static const struct hid_ll_driver mousevsc_ll_driver = {
.parse = mousevsc_hid_parse,
.open = mousevsc_hid_open,
.close = mousevsc_hid_close,
--
2.39.1
^ permalink raw reply related
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox