* [dtor-input:next] BUILD SUCCESS 6906f5060d39f95aa0be30e998e0cc1179ba3d04
From: kernel test robot @ 2023-03-20 16:53 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: linux-input
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
branch HEAD: 6906f5060d39f95aa0be30e998e0cc1179ba3d04 Input: iqs62x-keys - suppress duplicated error message in .remove()
elapsed time: 727m
configs tested: 303
configs skipped: 20
The following configs have been built successfully.
More configs may be tested in the coming days.
tested configs:
alpha allyesconfig gcc
alpha buildonly-randconfig-r001-20230320 gcc
alpha buildonly-randconfig-r005-20230319 gcc
alpha defconfig gcc
alpha randconfig-r005-20230319 gcc
alpha randconfig-r011-20230319 gcc
alpha randconfig-r014-20230319 gcc
alpha randconfig-r023-20230319 gcc
alpha randconfig-r033-20230319 gcc
alpha randconfig-r035-20230319 gcc
alpha randconfig-r036-20230319 gcc
arc allyesconfig gcc
arc buildonly-randconfig-r001-20230319 gcc
arc buildonly-randconfig-r003-20230319 gcc
arc buildonly-randconfig-r005-20230320 gcc
arc defconfig gcc
arc nsimosci_defconfig gcc
arc randconfig-r006-20230319 gcc
arc randconfig-r024-20230319 gcc
arc randconfig-r043-20230319 gcc
arc randconfig-r043-20230320 gcc
arm allmodconfig gcc
arm allyesconfig gcc
arm assabet_defconfig gcc
arm buildonly-randconfig-r005-20230319 gcc
arm defconfig gcc
arm nhk8815_defconfig gcc
arm randconfig-r003-20230319 clang
arm randconfig-r012-20230319 gcc
arm randconfig-r013-20230319 gcc
arm randconfig-r025-20230319 gcc
arm randconfig-r032-20230319 clang
arm randconfig-r046-20230319 gcc
arm randconfig-r046-20230320 clang
arm stm32_defconfig gcc
arm64 allyesconfig gcc
arm64 defconfig gcc
arm64 randconfig-r003-20230320 clang
csky alldefconfig gcc
csky defconfig gcc
csky randconfig-r001-20230319 gcc
csky randconfig-r003-20230319 gcc
csky randconfig-r006-20230319 gcc
csky randconfig-r014-20230319 gcc
csky randconfig-r022-20230319 gcc
csky randconfig-r031-20230319 gcc
csky randconfig-r033-20230319 gcc
csky randconfig-r035-20230320 gcc
hexagon buildonly-randconfig-r001-20230319 clang
hexagon buildonly-randconfig-r003-20230319 clang
hexagon buildonly-randconfig-r004-20230319 clang
hexagon randconfig-r001-20230319 clang
hexagon randconfig-r004-20230320 clang
hexagon randconfig-r021-20230319 clang
hexagon randconfig-r022-20230319 clang
hexagon randconfig-r032-20230319 clang
hexagon randconfig-r041-20230319 clang
hexagon randconfig-r041-20230320 clang
hexagon randconfig-r045-20230319 clang
hexagon randconfig-r045-20230320 clang
i386 allyesconfig gcc
i386 buildonly-randconfig-r006-20230320 clang
i386 debian-10.3-func gcc
i386 debian-10.3-kselftests gcc
i386 debian-10.3-kunit gcc
i386 debian-10.3-kvm gcc
i386 debian-10.3 gcc
i386 defconfig gcc
i386 randconfig-a001-20230320 clang
i386 randconfig-a001 gcc
i386 randconfig-a002-20230320 clang
i386 randconfig-a002 clang
i386 randconfig-a003-20230320 clang
i386 randconfig-a003 gcc
i386 randconfig-a004-20230320 clang
i386 randconfig-a004 clang
i386 randconfig-a005-20230320 clang
i386 randconfig-a005 gcc
i386 randconfig-a006-20230320 clang
i386 randconfig-a006 clang
i386 randconfig-a011-20230320 gcc
i386 randconfig-a011 clang
i386 randconfig-a012-20230320 gcc
i386 randconfig-a012 gcc
i386 randconfig-a013-20230320 gcc
i386 randconfig-a013 clang
i386 randconfig-a014-20230320 gcc
i386 randconfig-a014 gcc
i386 randconfig-a015-20230320 gcc
i386 randconfig-a015 clang
i386 randconfig-a016-20230320 gcc
i386 randconfig-a016 gcc
i386 randconfig-c001 gcc
ia64 allmodconfig gcc
ia64 buildonly-randconfig-r003-20230319 gcc
ia64 defconfig gcc
ia64 randconfig-r004-20230319 gcc
ia64 randconfig-r021-20230319 gcc
ia64 randconfig-r033-20230319 gcc
ia64 randconfig-r036-20230319 gcc
ia64 randconfig-r036-20230320 gcc
loongarch allmodconfig gcc
loongarch allnoconfig gcc
loongarch buildonly-randconfig-r003-20230320 gcc
loongarch buildonly-randconfig-r006-20230319 gcc
loongarch defconfig gcc
loongarch randconfig-r005-20230319 gcc
loongarch randconfig-r011-20230319 gcc
loongarch randconfig-r013-20230319 gcc
loongarch randconfig-r014-20230319 gcc
loongarch randconfig-r015-20230319 gcc
loongarch randconfig-r022-20230319 gcc
loongarch randconfig-r025-20230320 gcc
loongarch randconfig-r026-20230320 gcc
loongarch randconfig-r031-20230319 gcc
loongarch randconfig-r032-20230319 gcc
loongarch randconfig-r034-20230319 gcc
m68k allmodconfig gcc
m68k amiga_defconfig gcc
m68k defconfig gcc
m68k randconfig-r005-20230319 gcc
m68k randconfig-r014-20230319 gcc
m68k randconfig-r015-20230319 gcc
m68k randconfig-r026-20230319 gcc
m68k randconfig-r031-20230319 gcc
m68k virt_defconfig gcc
microblaze buildonly-randconfig-r001-20230319 gcc
microblaze randconfig-r005-20230319 gcc
microblaze randconfig-r014-20230319 gcc
microblaze randconfig-r026-20230319 gcc
microblaze randconfig-r034-20230319 gcc
mips allmodconfig gcc
mips allyesconfig gcc
mips gpr_defconfig gcc
mips malta_defconfig clang
mips maltasmvp_defconfig gcc
mips randconfig-r004-20230319 clang
mips randconfig-r005-20230319 clang
mips randconfig-r026-20230319 gcc
mips randconfig-r034-20230320 gcc
mips rs90_defconfig clang
nios2 3c120_defconfig gcc
nios2 buildonly-randconfig-r005-20230320 gcc
nios2 buildonly-randconfig-r006-20230319 gcc
nios2 buildonly-randconfig-r006-20230320 gcc
nios2 defconfig gcc
nios2 randconfig-r002-20230319 gcc
nios2 randconfig-r003-20230319 gcc
nios2 randconfig-r004-20230320 gcc
nios2 randconfig-r005-20230320 gcc
nios2 randconfig-r006-20230319 gcc
nios2 randconfig-r015-20230319 gcc
nios2 randconfig-r023-20230320 gcc
nios2 randconfig-r026-20230319 gcc
nios2 randconfig-r035-20230319 gcc
nios2 randconfig-r036-20230319 gcc
openrisc buildonly-randconfig-r004-20230319 gcc
openrisc randconfig-r001-20230319 gcc
openrisc randconfig-r006-20230319 gcc
openrisc randconfig-r021-20230319 gcc
openrisc randconfig-r022-20230319 gcc
openrisc randconfig-r023-20230319 gcc
openrisc randconfig-r024-20230319 gcc
openrisc randconfig-r025-20230319 gcc
openrisc randconfig-r034-20230319 gcc
openrisc randconfig-r035-20230319 gcc
parisc defconfig gcc
parisc randconfig-r002-20230320 gcc
parisc randconfig-r022-20230319 gcc
parisc randconfig-r025-20230319 gcc
parisc randconfig-r031-20230319 gcc
parisc64 defconfig gcc
powerpc allmodconfig gcc
powerpc allnoconfig gcc
powerpc buildonly-randconfig-r002-20230319 clang
powerpc buildonly-randconfig-r004-20230319 clang
powerpc canyonlands_defconfig gcc
powerpc icon_defconfig clang
powerpc klondike_defconfig gcc
powerpc ksi8560_defconfig clang
powerpc mgcoge_defconfig gcc
powerpc microwatt_defconfig clang
powerpc mpc834x_mds_defconfig gcc
powerpc mpc85xx_cds_defconfig gcc
powerpc pq2fads_defconfig gcc
powerpc randconfig-r002-20230319 gcc
powerpc randconfig-r021-20230319 clang
powerpc randconfig-r021-20230320 gcc
powerpc randconfig-r024-20230319 clang
powerpc randconfig-r025-20230319 clang
powerpc randconfig-r033-20230319 gcc
riscv allmodconfig gcc
riscv allnoconfig gcc
riscv buildonly-randconfig-r002-20230319 clang
riscv defconfig gcc
riscv nommu_k210_defconfig gcc
riscv randconfig-r001-20230320 clang
riscv randconfig-r002-20230319 gcc
riscv randconfig-r004-20230319 gcc
riscv randconfig-r005-20230319 gcc
riscv randconfig-r006-20230319 gcc
riscv randconfig-r012-20230319 clang
riscv randconfig-r016-20230319 clang
riscv randconfig-r032-20230319 gcc
riscv randconfig-r036-20230319 gcc
riscv randconfig-r042-20230319 clang
riscv randconfig-r042-20230320 gcc
riscv rv32_defconfig gcc
s390 allmodconfig gcc
s390 allyesconfig gcc
s390 buildonly-randconfig-r001-20230319 clang
s390 buildonly-randconfig-r002-20230319 clang
s390 defconfig gcc
s390 randconfig-r001-20230320 clang
s390 randconfig-r004-20230320 clang
s390 randconfig-r006-20230320 clang
s390 randconfig-r015-20230319 clang
s390 randconfig-r023-20230319 clang
s390 randconfig-r044-20230319 clang
s390 randconfig-r044-20230320 gcc
sh allmodconfig gcc
sh ap325rxa_defconfig gcc
sh apsh4ad0a_defconfig gcc
sh buildonly-randconfig-r002-20230320 gcc
sh buildonly-randconfig-r004-20230319 gcc
sh r7785rp_defconfig gcc
sh randconfig-r006-20230320 gcc
sh randconfig-r011-20230319 gcc
sh randconfig-r023-20230319 gcc
sh randconfig-r024-20230319 gcc
sh randconfig-r032-20230319 gcc
sh randconfig-r034-20230319 gcc
sh rsk7269_defconfig gcc
sh se7721_defconfig gcc
sh se7722_defconfig gcc
sh sh03_defconfig gcc
sh sh7710voipgw_defconfig gcc
sh sh7785lcr_defconfig gcc
sparc buildonly-randconfig-r004-20230320 gcc
sparc buildonly-randconfig-r006-20230319 gcc
sparc defconfig gcc
sparc randconfig-r001-20230319 gcc
sparc randconfig-r004-20230319 gcc
sparc randconfig-r012-20230319 gcc
sparc randconfig-r015-20230319 gcc
sparc randconfig-r016-20230319 gcc
sparc randconfig-r021-20230319 gcc
sparc randconfig-r022-20230319 gcc
sparc randconfig-r024-20230320 gcc
sparc randconfig-r031-20230319 gcc
sparc randconfig-r035-20230319 gcc
sparc64 defconfig gcc
sparc64 randconfig-r001-20230319 gcc
sparc64 randconfig-r011-20230319 gcc
sparc64 randconfig-r016-20230319 gcc
sparc64 randconfig-r025-20230319 gcc
sparc64 randconfig-r033-20230319 gcc
sparc64 randconfig-r035-20230319 gcc
um i386_defconfig gcc
um x86_64_defconfig gcc
x86_64 allnoconfig gcc
x86_64 allyesconfig gcc
x86_64 defconfig gcc
x86_64 kexec gcc
x86_64 randconfig-a001-20230320 clang
x86_64 randconfig-a001 clang
x86_64 randconfig-a002-20230320 clang
x86_64 randconfig-a002 gcc
x86_64 randconfig-a003-20230320 clang
x86_64 randconfig-a003 clang
x86_64 randconfig-a004-20230320 clang
x86_64 randconfig-a004 gcc
x86_64 randconfig-a005-20230320 clang
x86_64 randconfig-a005 clang
x86_64 randconfig-a006-20230320 clang
x86_64 randconfig-a006 gcc
x86_64 randconfig-a011 gcc
x86_64 randconfig-a012 clang
x86_64 randconfig-a013 gcc
x86_64 randconfig-a014 clang
x86_64 randconfig-a015 gcc
x86_64 randconfig-a016 clang
x86_64 randconfig-k001 clang
x86_64 randconfig-r006-20230320 clang
x86_64 randconfig-r022-20230320 gcc
x86_64 rhel-8.3-bpf gcc
x86_64 rhel-8.3-kunit gcc
x86_64 rhel-8.3-kvm gcc
x86_64 rhel-8.3-syz gcc
x86_64 rhel-8.3 gcc
xtensa cadence_csp_defconfig gcc
xtensa common_defconfig gcc
xtensa defconfig gcc
xtensa iss_defconfig gcc
xtensa randconfig-r002-20230319 gcc
xtensa randconfig-r003-20230319 gcc
xtensa randconfig-r003-20230320 gcc
xtensa randconfig-r004-20230319 gcc
xtensa randconfig-r013-20230319 gcc
xtensa randconfig-r031-20230319 gcc
xtensa randconfig-r033-20230320 gcc
xtensa randconfig-r034-20230319 gcc
xtensa xip_kc705_defconfig gcc
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
^ permalink raw reply
* Re: [PATCH] HID: wiimote: check completion in wiimod_battery_get_property
From: David Rheinsberg @ 2023-03-20 19:08 UTC (permalink / raw)
To: Nikita Zhandarovich
Cc: Jiri Kosina, Benjamin Tissoires, David Herrmann, linux-input,
linux-kernel, lvc-project
In-Reply-To: <20230320153419.9185-1-n.zhandarovich@fintech.ru>
Hi
On Mon, 20 Mar 2023 at 16:34, Nikita Zhandarovich
<n.zhandarovich@fintech.ru> wrote:
>
> wiimote_cmd_wait() in wiimod_battery_get_property() may signal that the
> task of getting specific battery property was interrupted or timed out.
> There is no need to do any further computation in such cases, so just
> return the error.
>
> Found by Linux Verification Center (linuxtesting.org) with static
> analysis tool SVACE.
>
> Fixes: dcf392313817 ("HID: wiimote: convert BATTERY to module")
> Signed-off-by: Nikita Zhandarovich <n.zhandarovich@fintech.ru>
> ---
> drivers/hid/hid-wiimote-modules.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-wiimote-modules.c b/drivers/hid/hid-wiimote-modules.c
> index dbccdfa63916..9755718d9856 100644
> --- a/drivers/hid/hid-wiimote-modules.c
> +++ b/drivers/hid/hid-wiimote-modules.c
> @@ -220,8 +220,10 @@ static int wiimod_battery_get_property(struct power_supply *psy,
> wiiproto_req_status(wdata);
> spin_unlock_irqrestore(&wdata->state.lock, flags);
>
> - wiimote_cmd_wait(wdata);
> + ret = wiimote_cmd_wait(wdata);
> wiimote_cmd_release(wdata);
> + if (ret)
> + return ret;
The current code returns cached battery-information in case a
synchronous update did not succeed. Battery information is likely
updated regularly, anyway, so the synchronous update is usually not
required.
I don't think bailing out and returning the error to the caller is
required or gains us anything but more complexity. Or am I missing
something here?
Thanks
David
^ permalink raw reply
* [dtor-input:for-linus] BUILD SUCCESS 754ff5060daf5a1cf4474eff9b4edeb6c17ef7ab
From: kernel test robot @ 2023-03-20 19:20 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: linux-input
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus
branch HEAD: 754ff5060daf5a1cf4474eff9b4edeb6c17ef7ab Input: alps - fix compatibility with -funsigned-char
elapsed time: 725m
configs tested: 296
configs skipped: 20
The following configs have been built successfully.
More configs may be tested in the coming days.
tested configs:
alpha allyesconfig gcc
alpha buildonly-randconfig-r001-20230320 gcc
alpha buildonly-randconfig-r004-20230320 gcc
alpha buildonly-randconfig-r005-20230319 gcc
alpha defconfig gcc
alpha randconfig-r012-20230320 gcc
alpha randconfig-r013-20230320 gcc
alpha randconfig-r023-20230319 gcc
alpha randconfig-r024-20230320 gcc
alpha randconfig-r033-20230319 gcc
alpha randconfig-r036-20230319 gcc
arc allyesconfig gcc
arc buildonly-randconfig-r002-20230313 gcc
arc buildonly-randconfig-r004-20230313 gcc
arc defconfig gcc
arc nsimosci_defconfig gcc
arc randconfig-r003-20230320 gcc
arc randconfig-r006-20230319 gcc
arc randconfig-r015-20230320 gcc
arc randconfig-r016-20230320 gcc
arc randconfig-r024-20230319 gcc
arc randconfig-r043-20230319 gcc
arc randconfig-r043-20230320 gcc
arm allmodconfig gcc
arm allyesconfig gcc
arm assabet_defconfig gcc
arm defconfig gcc
arm mvebu_v7_defconfig gcc
arm randconfig-r003-20230319 clang
arm randconfig-r012-20230319 gcc
arm randconfig-r025-20230319 gcc
arm randconfig-r046-20230319 gcc
arm randconfig-r046-20230320 clang
arm stm32_defconfig gcc
arm64 allyesconfig gcc
arm64 buildonly-randconfig-r004-20230319 gcc
arm64 defconfig gcc
arm64 randconfig-r003-20230320 clang
csky alldefconfig gcc
csky defconfig gcc
csky randconfig-r001-20230319 gcc
csky randconfig-r002-20230320 gcc
csky randconfig-r003-20230319 gcc
csky randconfig-r006-20230319 gcc
csky randconfig-r012-20230319 gcc
csky randconfig-r014-20230319 gcc
csky randconfig-r022-20230319 gcc
csky randconfig-r026-20230319 gcc
csky randconfig-r031-20230319 gcc
csky randconfig-r035-20230320 gcc
hexagon buildonly-randconfig-r001-20230319 clang
hexagon buildonly-randconfig-r003-20230319 clang
hexagon randconfig-r004-20230320 clang
hexagon randconfig-r016-20230319 clang
hexagon randconfig-r032-20230319 clang
hexagon randconfig-r041-20230319 clang
hexagon randconfig-r041-20230320 clang
hexagon randconfig-r045-20230319 clang
hexagon randconfig-r045-20230320 clang
i386 allyesconfig gcc
i386 buildonly-randconfig-r003-20230313 gcc
i386 debian-10.3-func gcc
i386 debian-10.3-kselftests gcc
i386 debian-10.3-kunit gcc
i386 debian-10.3-kvm gcc
i386 debian-10.3 gcc
i386 defconfig gcc
i386 randconfig-a001-20230320 clang
i386 randconfig-a002-20230320 clang
i386 randconfig-a002 clang
i386 randconfig-a003-20230320 clang
i386 randconfig-a004-20230320 clang
i386 randconfig-a004 clang
i386 randconfig-a005-20230320 clang
i386 randconfig-a006-20230320 clang
i386 randconfig-a006 clang
i386 randconfig-a011-20230320 gcc
i386 randconfig-a011 clang
i386 randconfig-a012-20230320 gcc
i386 randconfig-a012 gcc
i386 randconfig-a013-20230320 gcc
i386 randconfig-a013 clang
i386 randconfig-a014-20230320 gcc
i386 randconfig-a014 gcc
i386 randconfig-a015-20230320 gcc
i386 randconfig-a015 clang
i386 randconfig-a016-20230320 gcc
i386 randconfig-a016 gcc
i386 randconfig-c001 gcc
ia64 allmodconfig gcc
ia64 buildonly-randconfig-r003-20230319 gcc
ia64 buildonly-randconfig-r006-20230312 gcc
ia64 defconfig gcc
ia64 randconfig-r006-20230319 gcc
ia64 randconfig-r021-20230319 gcc
ia64 randconfig-r024-20230319 gcc
ia64 randconfig-r033-20230319 gcc
ia64 randconfig-r036-20230320 gcc
ia64 tiger_defconfig gcc
loongarch allmodconfig gcc
loongarch allnoconfig gcc
loongarch buildonly-randconfig-r006-20230320 gcc
loongarch defconfig gcc
loongarch randconfig-r002-20230319 gcc
loongarch randconfig-r005-20230319 gcc
loongarch randconfig-r006-20230319 gcc
loongarch randconfig-r013-20230319 gcc
loongarch randconfig-r015-20230319 gcc
loongarch randconfig-r015-20230320 gcc
loongarch randconfig-r021-20230320 gcc
loongarch randconfig-r022-20230319 gcc
loongarch randconfig-r025-20230320 gcc
loongarch randconfig-r026-20230320 gcc
loongarch randconfig-r032-20230319 gcc
m68k allmodconfig gcc
m68k amiga_defconfig gcc
m68k apollo_defconfig gcc
m68k defconfig gcc
m68k randconfig-r005-20230319 gcc
m68k randconfig-r012-20230320 gcc
m68k randconfig-r014-20230319 gcc
m68k randconfig-r026-20230319 gcc
m68k randconfig-r031-20230319 gcc
m68k virt_defconfig gcc
microblaze buildonly-randconfig-r006-20230319 gcc
microblaze randconfig-r003-20230319 gcc
microblaze randconfig-r014-20230319 gcc
microblaze randconfig-r026-20230319 gcc
microblaze randconfig-r032-20230319 gcc
microblaze randconfig-r034-20230319 gcc
mips allmodconfig gcc
mips allyesconfig gcc
mips buildonly-randconfig-r002-20230320 gcc
mips buildonly-randconfig-r004-20230312 gcc
mips maltasmvp_defconfig gcc
mips randconfig-r005-20230319 clang
mips randconfig-r005-20230320 gcc
mips randconfig-r011-20230320 clang
mips randconfig-r013-20230319 gcc
mips randconfig-r014-20230320 clang
mips randconfig-r026-20230319 gcc
mips randconfig-r034-20230320 gcc
mips randconfig-r036-20230319 clang
nios2 3c120_defconfig gcc
nios2 defconfig gcc
nios2 randconfig-r002-20230319 gcc
nios2 randconfig-r003-20230319 gcc
nios2 randconfig-r023-20230320 gcc
nios2 randconfig-r025-20230319 gcc
nios2 randconfig-r034-20230319 gcc
nios2 randconfig-r036-20230319 gcc
openrisc randconfig-r001-20230319 gcc
openrisc randconfig-r021-20230319 gcc
openrisc randconfig-r022-20230319 gcc
openrisc randconfig-r023-20230319 gcc
openrisc randconfig-r024-20230319 gcc
openrisc randconfig-r025-20230319 gcc
openrisc randconfig-r034-20230319 gcc
openrisc randconfig-r035-20230319 gcc
parisc buildonly-randconfig-r005-20230313 gcc
parisc defconfig gcc
parisc randconfig-r004-20230319 gcc
parisc randconfig-r011-20230319 gcc
parisc randconfig-r015-20230319 gcc
parisc randconfig-r022-20230319 gcc
parisc randconfig-r025-20230319 gcc
parisc randconfig-r025-20230320 gcc
parisc64 defconfig gcc
powerpc allmodconfig gcc
powerpc allnoconfig gcc
powerpc buildonly-randconfig-r002-20230319 clang
powerpc buildonly-randconfig-r004-20230319 clang
powerpc canyonlands_defconfig gcc
powerpc fsp2_defconfig clang
powerpc icon_defconfig clang
powerpc klondike_defconfig gcc
powerpc mgcoge_defconfig gcc
powerpc microwatt_defconfig clang
powerpc mpc834x_mds_defconfig gcc
powerpc mpc85xx_cds_defconfig gcc
powerpc randconfig-r002-20230319 gcc
powerpc randconfig-r005-20230319 gcc
powerpc randconfig-r006-20230319 gcc
powerpc randconfig-r013-20230320 gcc
powerpc randconfig-r021-20230320 gcc
powerpc randconfig-r033-20230319 gcc
riscv allmodconfig gcc
riscv allnoconfig gcc
riscv buildonly-randconfig-r001-20230312 gcc
riscv defconfig gcc
riscv nommu_k210_defconfig gcc
riscv randconfig-r001-20230320 clang
riscv randconfig-r002-20230319 gcc
riscv randconfig-r004-20230319 gcc
riscv randconfig-r005-20230319 gcc
riscv randconfig-r006-20230319 gcc
riscv randconfig-r016-20230319 clang
riscv randconfig-r016-20230320 gcc
riscv randconfig-r023-20230319 clang
riscv randconfig-r032-20230319 gcc
riscv randconfig-r036-20230319 gcc
riscv randconfig-r042-20230319 clang
riscv randconfig-r042-20230320 gcc
riscv rv32_defconfig gcc
s390 allmodconfig gcc
s390 allyesconfig gcc
s390 buildonly-randconfig-r002-20230319 clang
s390 defconfig gcc
s390 randconfig-r004-20230320 clang
s390 randconfig-r006-20230320 clang
s390 randconfig-r014-20230319 clang
s390 randconfig-r021-20230319 clang
s390 randconfig-r044-20230319 clang
s390 randconfig-r044-20230320 gcc
sh allmodconfig gcc
sh ap325rxa_defconfig gcc
sh apsh4ad0a_defconfig gcc
sh buildonly-randconfig-r004-20230319 gcc
sh buildonly-randconfig-r005-20230312 gcc
sh hp6xx_defconfig gcc
sh r7785rp_defconfig gcc
sh randconfig-r005-20230320 gcc
sh randconfig-r011-20230319 gcc
sh randconfig-r023-20230319 gcc
sh randconfig-r032-20230319 gcc
sh rsk7269_defconfig gcc
sh se7721_defconfig gcc
sh sh7710voipgw_defconfig gcc
sh sh7785lcr_defconfig gcc
sparc defconfig gcc
sparc randconfig-r001-20230319 gcc
sparc randconfig-r002-20230319 gcc
sparc randconfig-r002-20230320 gcc
sparc randconfig-r004-20230319 gcc
sparc randconfig-r012-20230319 gcc
sparc randconfig-r015-20230319 gcc
sparc randconfig-r016-20230319 gcc
sparc randconfig-r021-20230319 gcc
sparc randconfig-r024-20230320 gcc
sparc randconfig-r031-20230319 gcc
sparc randconfig-r035-20230319 gcc
sparc64 buildonly-randconfig-r005-20230319 gcc
sparc64 defconfig gcc
sparc64 randconfig-r001-20230320 gcc
sparc64 randconfig-r011-20230319 gcc
sparc64 randconfig-r026-20230320 gcc
sparc64 randconfig-r033-20230319 gcc
sparc64 randconfig-r035-20230319 gcc
um i386_defconfig gcc
um x86_64_defconfig gcc
x86_64 allnoconfig gcc
x86_64 allyesconfig gcc
x86_64 defconfig gcc
x86_64 kexec gcc
x86_64 randconfig-a001-20230320 clang
x86_64 randconfig-a001 clang
x86_64 randconfig-a002-20230320 clang
x86_64 randconfig-a002 gcc
x86_64 randconfig-a003-20230320 clang
x86_64 randconfig-a003 clang
x86_64 randconfig-a004-20230320 clang
x86_64 randconfig-a004 gcc
x86_64 randconfig-a005-20230320 clang
x86_64 randconfig-a005 clang
x86_64 randconfig-a006-20230320 clang
x86_64 randconfig-a006 gcc
x86_64 randconfig-a011-20230320 gcc
x86_64 randconfig-a011 gcc
x86_64 randconfig-a012-20230320 gcc
x86_64 randconfig-a012 clang
x86_64 randconfig-a013-20230320 gcc
x86_64 randconfig-a013 gcc
x86_64 randconfig-a014-20230320 gcc
x86_64 randconfig-a014 clang
x86_64 randconfig-a015-20230320 gcc
x86_64 randconfig-a015 gcc
x86_64 randconfig-a016-20230320 gcc
x86_64 randconfig-a016 clang
x86_64 randconfig-k001 clang
x86_64 randconfig-r006-20230320 clang
x86_64 randconfig-r022-20230320 gcc
x86_64 randconfig-r023-20230320 gcc
x86_64 rhel-8.3 gcc
xtensa cadence_csp_defconfig gcc
xtensa common_defconfig gcc
xtensa defconfig gcc
xtensa iss_defconfig gcc
xtensa randconfig-r001-20230319 gcc
xtensa randconfig-r003-20230319 gcc
xtensa randconfig-r004-20230319 gcc
xtensa randconfig-r011-20230320 gcc
xtensa randconfig-r013-20230319 gcc
xtensa randconfig-r031-20230319 gcc
xtensa randconfig-r033-20230320 gcc
xtensa randconfig-r034-20230319 gcc
xtensa xip_kc705_defconfig gcc
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
^ permalink raw reply
* Re: [PATCH 0/4] HID: explicitly include linux/leds.h
From: Thomas Weißschuh @ 2023-03-20 22:18 UTC (permalink / raw)
To: Jiri Kosina, Benjamin Tissoires, Hans de Goede; +Cc: linux-input, linux-kernel
In-Reply-To: <20230215-power_supply-leds-hid-v1-0-35b6f1dcee8a@weissschuh.net>
Friendly ping,
this seems to have fallen through the cracks.
Thanks,
Thomas
On Wed, Feb 15, 2023 at 01:03:33AM +0000, Thomas Weißschuh wrote:
> Instead of relying on an accidental, transitive inclusion of linux/leds.h
> use it directly.
>
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
> Thomas Weißschuh (4):
> HID: steelseries: explicitly include linux/leds.h
> HID: lg-g15: explicitly include linux/leds.h
> HID: asus: explicitly include linux/leds.h
> HID: apple: explicitly include linux/leds.h
>
> drivers/hid/hid-apple.c | 1 +
> drivers/hid/hid-asus.c | 1 +
> drivers/hid/hid-lg-g15.c | 1 +
> drivers/hid/hid-steelseries.c | 1 +
> 4 files changed, 4 insertions(+)
> ---
> base-commit: e1c04510f521e853019afeca2a5991a5ef8d6a5b
> change-id: 20230215-power_supply-leds-hid-f99a0a3fd2bf
>
> Best regards,
> --
> Thomas Weißschuh <linux@weissschuh.net>
>
^ permalink raw reply
* [PATCH] dt-bindings: input: Drop unneeded quotes
From: Rob Herring @ 2023-03-20 23:47 UTC (permalink / raw)
To: Dmitry Torokhov, Krzysztof Kozlowski, Benson Leung, Guenter Roeck,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Mattijs Korpershoek, Matthias Brugger,
AngeloGioacchino Del Regno
Cc: linux-input, devicetree, linux-kernel, chrome-platform,
linux-arm-kernel, linux-mediatek
Cleanup bindings dropping unneeded quotes. Once all these are fixed,
checking for this can be enabled in yamllint.
Signed-off-by: Rob Herring <robh@kernel.org>
---
Documentation/devicetree/bindings/input/adc-joystick.yaml | 4 ++--
.../devicetree/bindings/input/google,cros-ec-keyb.yaml | 2 +-
Documentation/devicetree/bindings/input/imx-keypad.yaml | 2 +-
Documentation/devicetree/bindings/input/matrix-keymap.yaml | 2 +-
.../devicetree/bindings/input/mediatek,mt6779-keypad.yaml | 2 +-
.../devicetree/bindings/input/microchip,cap11xx.yaml | 4 ++--
Documentation/devicetree/bindings/input/pwm-vibrator.yaml | 4 ++--
Documentation/devicetree/bindings/input/regulator-haptic.yaml | 4 ++--
.../bindings/input/touchscreen/elan,elants_i2c.yaml | 4 ++--
9 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/Documentation/devicetree/bindings/input/adc-joystick.yaml b/Documentation/devicetree/bindings/input/adc-joystick.yaml
index da0f8dfca8bf..6c244d66f8ce 100644
--- a/Documentation/devicetree/bindings/input/adc-joystick.yaml
+++ b/Documentation/devicetree/bindings/input/adc-joystick.yaml
@@ -2,8 +2,8 @@
# Copyright 2019-2020 Artur Rojek
%YAML 1.2
---
-$id: "http://devicetree.org/schemas/input/adc-joystick.yaml#"
-$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+$id: http://devicetree.org/schemas/input/adc-joystick.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
title: ADC attached joystick
diff --git a/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml b/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml
index e05690b3e963..3486c81699a8 100644
--- a/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml
+++ b/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml
@@ -57,7 +57,7 @@ if:
contains:
const: google,cros-ec-keyb
then:
- $ref: "/schemas/input/matrix-keymap.yaml#"
+ $ref: /schemas/input/matrix-keymap.yaml#
required:
- keypad,num-rows
- keypad,num-columns
diff --git a/Documentation/devicetree/bindings/input/imx-keypad.yaml b/Documentation/devicetree/bindings/input/imx-keypad.yaml
index 7514df62b592..b110eb1f3358 100644
--- a/Documentation/devicetree/bindings/input/imx-keypad.yaml
+++ b/Documentation/devicetree/bindings/input/imx-keypad.yaml
@@ -10,7 +10,7 @@ maintainers:
- Liu Ying <gnuiyl@gmail.com>
allOf:
- - $ref: "/schemas/input/matrix-keymap.yaml#"
+ - $ref: /schemas/input/matrix-keymap.yaml#
description: |
The KPP is designed to interface with a keypad matrix with 2-point contact
diff --git a/Documentation/devicetree/bindings/input/matrix-keymap.yaml b/Documentation/devicetree/bindings/input/matrix-keymap.yaml
index 4d6dbe91646d..a715c2a773fe 100644
--- a/Documentation/devicetree/bindings/input/matrix-keymap.yaml
+++ b/Documentation/devicetree/bindings/input/matrix-keymap.yaml
@@ -21,7 +21,7 @@ description: |
properties:
linux,keymap:
- $ref: '/schemas/types.yaml#/definitions/uint32-array'
+ $ref: /schemas/types.yaml#/definitions/uint32-array
description: |
An array of packed 1-cell entries containing the equivalent of row,
column and linux key-code. The 32-bit big endian cell is packed as:
diff --git a/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml b/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml
index d768c30f48fb..47aac8794b68 100644
--- a/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml
+++ b/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml
@@ -10,7 +10,7 @@ maintainers:
- Mattijs Korpershoek <mkorpershoek@baylibre.com>
allOf:
- - $ref: "/schemas/input/matrix-keymap.yaml#"
+ - $ref: /schemas/input/matrix-keymap.yaml#
description: |
Mediatek's Keypad controller is used to interface a SoC with a matrix-type
diff --git a/Documentation/devicetree/bindings/input/microchip,cap11xx.yaml b/Documentation/devicetree/bindings/input/microchip,cap11xx.yaml
index 5fa625b5c5fb..5b5d4f7d3482 100644
--- a/Documentation/devicetree/bindings/input/microchip,cap11xx.yaml
+++ b/Documentation/devicetree/bindings/input/microchip,cap11xx.yaml
@@ -1,8 +1,8 @@
# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
%YAML 1.2
---
-$id: "http://devicetree.org/schemas/input/microchip,cap11xx.yaml#"
-$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+$id: http://devicetree.org/schemas/input/microchip,cap11xx.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
title: Microchip CAP11xx based capacitive touch sensors
diff --git a/Documentation/devicetree/bindings/input/pwm-vibrator.yaml b/Documentation/devicetree/bindings/input/pwm-vibrator.yaml
index a70a636ee112..d32716c604fe 100644
--- a/Documentation/devicetree/bindings/input/pwm-vibrator.yaml
+++ b/Documentation/devicetree/bindings/input/pwm-vibrator.yaml
@@ -1,8 +1,8 @@
# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
%YAML 1.2
---
-$id: "http://devicetree.org/schemas/input/pwm-vibrator.yaml#"
-$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+$id: http://devicetree.org/schemas/input/pwm-vibrator.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
title: PWM vibrator
diff --git a/Documentation/devicetree/bindings/input/regulator-haptic.yaml b/Documentation/devicetree/bindings/input/regulator-haptic.yaml
index 627891e1ef55..cf63f834dd7d 100644
--- a/Documentation/devicetree/bindings/input/regulator-haptic.yaml
+++ b/Documentation/devicetree/bindings/input/regulator-haptic.yaml
@@ -1,8 +1,8 @@
# SPDX-License-Identifier: GPL-2.0
%YAML 1.2
---
-$id: "http://devicetree.org/schemas/input/regulator-haptic.yaml#"
-$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+$id: http://devicetree.org/schemas/input/regulator-haptic.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
title: Regulator Haptic
diff --git a/Documentation/devicetree/bindings/input/touchscreen/elan,elants_i2c.yaml b/Documentation/devicetree/bindings/input/touchscreen/elan,elants_i2c.yaml
index f9053e5e9b24..3255c2c8951a 100644
--- a/Documentation/devicetree/bindings/input/touchscreen/elan,elants_i2c.yaml
+++ b/Documentation/devicetree/bindings/input/touchscreen/elan,elants_i2c.yaml
@@ -1,8 +1,8 @@
# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
%YAML 1.2
---
-$id: "http://devicetree.org/schemas/input/touchscreen/elan,elants_i2c.yaml#"
-$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+$id: http://devicetree.org/schemas/input/touchscreen/elan,elants_i2c.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
title: Elantech I2C Touchscreen
--
2.39.2
^ permalink raw reply related
* Re: [PATCH] HID: wiimote: check completion in wiimod_battery_get_property
From: Nikita Zhandarovich @ 2023-03-21 6:13 UTC (permalink / raw)
To: David Rheinsberg
Cc: Jiri Kosina, Benjamin Tissoires, David Herrmann, linux-input,
linux-kernel, lvc-project
In-Reply-To: <CADyDSO6nvFaC8dZKuSYcqgdiL8oub+eKU-PqYSeH2cXnVw-=Uw@mail.gmail.com>
On 3/20/23 12:08, David Rheinsberg wrote:
> Hi
>
> On Mon, 20 Mar 2023 at 16:34, Nikita Zhandarovich
> <n.zhandarovich@fintech.ru> wrote:
>>
>> wiimote_cmd_wait() in wiimod_battery_get_property() may signal that the
>> task of getting specific battery property was interrupted or timed out.
>> There is no need to do any further computation in such cases, so just
>> return the error.
>>
>> Found by Linux Verification Center (linuxtesting.org) with static
>> analysis tool SVACE.
>>
>> Fixes: dcf392313817 ("HID: wiimote: convert BATTERY to module")
>> Signed-off-by: Nikita Zhandarovich <n.zhandarovich@fintech.ru>
>> ---
>> drivers/hid/hid-wiimote-modules.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/hid/hid-wiimote-modules.c b/drivers/hid/hid-wiimote-modules.c
>> index dbccdfa63916..9755718d9856 100644
>> --- a/drivers/hid/hid-wiimote-modules.c
>> +++ b/drivers/hid/hid-wiimote-modules.c
>> @@ -220,8 +220,10 @@ static int wiimod_battery_get_property(struct power_supply *psy,
>> wiiproto_req_status(wdata);
>> spin_unlock_irqrestore(&wdata->state.lock, flags);
>>
>> - wiimote_cmd_wait(wdata);
>> + ret = wiimote_cmd_wait(wdata);
>> wiimote_cmd_release(wdata);
>> + if (ret)
>> + return ret;
>
> The current code returns cached battery-information in case a
> synchronous update did not succeed. Battery information is likely
> updated regularly, anyway, so the synchronous update is usually not
> required.
>
> I don't think bailing out and returning the error to the caller is
> required or gains us anything but more complexity. Or am I missing
> something here?
>
> Thanks
> David
Hi. I think you are right, my change is not that essential to begin with
and there is no urgency to patch this.
Thanks for your patience,
Nikita
^ permalink raw reply
* Re: [PATCH] dt-bindings: input: Drop unneeded quotes
From: Krzysztof Kozlowski @ 2023-03-21 6:48 UTC (permalink / raw)
To: Rob Herring, Dmitry Torokhov, Krzysztof Kozlowski, Benson Leung,
Guenter Roeck, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, Mattijs Korpershoek,
Matthias Brugger, AngeloGioacchino Del Regno
Cc: linux-input, devicetree, linux-kernel, chrome-platform,
linux-arm-kernel, linux-mediatek
In-Reply-To: <20230320234718.2930154-1-robh@kernel.org>
On 21/03/2023 00:47, Rob Herring wrote:
> Cleanup bindings dropping unneeded quotes. Once all these are fixed,
> checking for this can be enabled in yamllint.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply
* Re: [PATCH] dt-bindings: input: Drop unneeded quotes
From: Mattijs Korpershoek @ 2023-03-21 15:07 UTC (permalink / raw)
To: Rob Herring, Dmitry Torokhov, Krzysztof Kozlowski, Benson Leung,
Guenter Roeck, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, Matthias Brugger,
AngeloGioacchino Del Regno
Cc: linux-input, devicetree, linux-kernel, chrome-platform,
linux-arm-kernel, linux-mediatek
In-Reply-To: <20230320234718.2930154-1-robh@kernel.org>
On lun., mars 20, 2023 at 18:47, Rob Herring <robh@kernel.org> wrote:
> Cleanup bindings dropping unneeded quotes. Once all these are fixed,
> checking for this can be enabled in yamllint.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> # for mediatek,mt6779-keypad.yaml
> ---
> Documentation/devicetree/bindings/input/adc-joystick.yaml | 4 ++--
> .../devicetree/bindings/input/google,cros-ec-keyb.yaml | 2 +-
> Documentation/devicetree/bindings/input/imx-keypad.yaml | 2 +-
> Documentation/devicetree/bindings/input/matrix-keymap.yaml | 2 +-
> .../devicetree/bindings/input/mediatek,mt6779-keypad.yaml | 2 +-
> .../devicetree/bindings/input/microchip,cap11xx.yaml | 4 ++--
> Documentation/devicetree/bindings/input/pwm-vibrator.yaml | 4 ++--
> Documentation/devicetree/bindings/input/regulator-haptic.yaml | 4 ++--
> .../bindings/input/touchscreen/elan,elants_i2c.yaml | 4 ++--
> 9 files changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/input/adc-joystick.yaml b/Documentation/devicetree/bindings/input/adc-joystick.yaml
> index da0f8dfca8bf..6c244d66f8ce 100644
> --- a/Documentation/devicetree/bindings/input/adc-joystick.yaml
> +++ b/Documentation/devicetree/bindings/input/adc-joystick.yaml
> @@ -2,8 +2,8 @@
> # Copyright 2019-2020 Artur Rojek
> %YAML 1.2
> ---
> -$id: "http://devicetree.org/schemas/input/adc-joystick.yaml#"
> -$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +$id: http://devicetree.org/schemas/input/adc-joystick.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>
> title: ADC attached joystick
>
> diff --git a/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml b/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml
> index e05690b3e963..3486c81699a8 100644
> --- a/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml
> +++ b/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml
> @@ -57,7 +57,7 @@ if:
> contains:
> const: google,cros-ec-keyb
> then:
> - $ref: "/schemas/input/matrix-keymap.yaml#"
> + $ref: /schemas/input/matrix-keymap.yaml#
> required:
> - keypad,num-rows
> - keypad,num-columns
> diff --git a/Documentation/devicetree/bindings/input/imx-keypad.yaml b/Documentation/devicetree/bindings/input/imx-keypad.yaml
> index 7514df62b592..b110eb1f3358 100644
> --- a/Documentation/devicetree/bindings/input/imx-keypad.yaml
> +++ b/Documentation/devicetree/bindings/input/imx-keypad.yaml
> @@ -10,7 +10,7 @@ maintainers:
> - Liu Ying <gnuiyl@gmail.com>
>
> allOf:
> - - $ref: "/schemas/input/matrix-keymap.yaml#"
> + - $ref: /schemas/input/matrix-keymap.yaml#
>
> description: |
> The KPP is designed to interface with a keypad matrix with 2-point contact
> diff --git a/Documentation/devicetree/bindings/input/matrix-keymap.yaml b/Documentation/devicetree/bindings/input/matrix-keymap.yaml
> index 4d6dbe91646d..a715c2a773fe 100644
> --- a/Documentation/devicetree/bindings/input/matrix-keymap.yaml
> +++ b/Documentation/devicetree/bindings/input/matrix-keymap.yaml
> @@ -21,7 +21,7 @@ description: |
>
> properties:
> linux,keymap:
> - $ref: '/schemas/types.yaml#/definitions/uint32-array'
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> description: |
> An array of packed 1-cell entries containing the equivalent of row,
> column and linux key-code. The 32-bit big endian cell is packed as:
> diff --git a/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml b/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml
> index d768c30f48fb..47aac8794b68 100644
> --- a/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml
> +++ b/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml
> @@ -10,7 +10,7 @@ maintainers:
> - Mattijs Korpershoek <mkorpershoek@baylibre.com>
>
> allOf:
> - - $ref: "/schemas/input/matrix-keymap.yaml#"
> + - $ref: /schemas/input/matrix-keymap.yaml#
>
> description: |
> Mediatek's Keypad controller is used to interface a SoC with a matrix-type
> diff --git a/Documentation/devicetree/bindings/input/microchip,cap11xx.yaml b/Documentation/devicetree/bindings/input/microchip,cap11xx.yaml
> index 5fa625b5c5fb..5b5d4f7d3482 100644
> --- a/Documentation/devicetree/bindings/input/microchip,cap11xx.yaml
> +++ b/Documentation/devicetree/bindings/input/microchip,cap11xx.yaml
> @@ -1,8 +1,8 @@
> # SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> %YAML 1.2
> ---
> -$id: "http://devicetree.org/schemas/input/microchip,cap11xx.yaml#"
> -$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +$id: http://devicetree.org/schemas/input/microchip,cap11xx.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>
> title: Microchip CAP11xx based capacitive touch sensors
>
> diff --git a/Documentation/devicetree/bindings/input/pwm-vibrator.yaml b/Documentation/devicetree/bindings/input/pwm-vibrator.yaml
> index a70a636ee112..d32716c604fe 100644
> --- a/Documentation/devicetree/bindings/input/pwm-vibrator.yaml
> +++ b/Documentation/devicetree/bindings/input/pwm-vibrator.yaml
> @@ -1,8 +1,8 @@
> # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> %YAML 1.2
> ---
> -$id: "http://devicetree.org/schemas/input/pwm-vibrator.yaml#"
> -$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +$id: http://devicetree.org/schemas/input/pwm-vibrator.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>
> title: PWM vibrator
>
> diff --git a/Documentation/devicetree/bindings/input/regulator-haptic.yaml b/Documentation/devicetree/bindings/input/regulator-haptic.yaml
> index 627891e1ef55..cf63f834dd7d 100644
> --- a/Documentation/devicetree/bindings/input/regulator-haptic.yaml
> +++ b/Documentation/devicetree/bindings/input/regulator-haptic.yaml
> @@ -1,8 +1,8 @@
> # SPDX-License-Identifier: GPL-2.0
> %YAML 1.2
> ---
> -$id: "http://devicetree.org/schemas/input/regulator-haptic.yaml#"
> -$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +$id: http://devicetree.org/schemas/input/regulator-haptic.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>
> title: Regulator Haptic
>
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/elan,elants_i2c.yaml b/Documentation/devicetree/bindings/input/touchscreen/elan,elants_i2c.yaml
> index f9053e5e9b24..3255c2c8951a 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/elan,elants_i2c.yaml
> +++ b/Documentation/devicetree/bindings/input/touchscreen/elan,elants_i2c.yaml
> @@ -1,8 +1,8 @@
> # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> %YAML 1.2
> ---
> -$id: "http://devicetree.org/schemas/input/touchscreen/elan,elants_i2c.yaml#"
> -$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +$id: http://devicetree.org/schemas/input/touchscreen/elan,elants_i2c.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>
> title: Elantech I2C Touchscreen
>
> --
> 2.39.2
^ permalink raw reply
* Re: [PATCH 2/2] Input: i8042 - add TUXEDO devices to i8042 quirk tables for partial fix
From: Werner Sembach @ 2023-03-21 16:10 UTC (permalink / raw)
To: Hans de Goede, dmitry.torokhov, tiwai, samuel, linux-input,
linux-kernel
In-Reply-To: <e84a2cb3-ea2f-6ce4-aba8-4026b3e6bedd@redhat.com>
Am 11.07.22 um 14:55 schrieb Hans de Goede:
> Hi,
>
> On 7/11/22 14:45, Werner Sembach wrote:
>> Hi,
>>
>> On 7/8/22 21:39, Hans de Goede wrote:
>>> Hi,
>>>
>>> On 7/8/22 18:10, Werner Sembach wrote:
>>>> A lot of modern Clevo barebones have touchpad and/or keyboard issues after
>>>> suspend fixable with nomux + reset + noloop + nopnp. Luckily, none of them
>>>> have an external PS/2 port so this can safely be set for all of them.
>>>>
>>>> I'm not entirely sure if every device listed really needs all four quirks,
>>>> but after testing and production use. No negative effects could be
>>>> observed when setting all four.
>>>>
>>>> Setting SERIO_QUIRK_NOMUX or SERIO_QUIRK_RESET_ALWAYS on the Clevo N150CU
>>>> and the Clevo NHxxRZQ makes the keyboard very laggy for ~5 seconds after
>>>> boot and sometimes also after resume. However both are required for the
>>>> keyboard to not fail completely sometimes after boot or resume.
>>> Hmm, the very laggy bit does not sound good. Have you looked into other
>>> solutions, e.g. what happens if you use just nomux without any of the
>>> other 3 options ?
>> I tried a lot of combinations, but it was some time ago.
>>
>> iirc: at least nomux and reset are required and both individually cause the lagging.
>>
>> So the issue is not fixed by just using a different set of quirks.
> Hmm, ok. So given that this seems to be the best we can do
> the patch looks good to me:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>
> Regards,
>
> Hans
Afaik this patch never got merged. Sadly I still have no better solution, so I
wanted to bring the patch up for discussion again as it still makes the
situation better in my opinion.
Kind Regards,
Werner Sembach
>
>
>>>> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
>>>> Cc: stable@vger.kernel.org
>>>> ---
>>>> drivers/input/serio/i8042-x86ia64io.h | 28 +++++++++++++++++++++++++++
>>>> 1 file changed, 28 insertions(+)
>>>>
>>>> diff --git a/drivers/input/serio/i8042-x86ia64io.h b/drivers/input/serio/i8042-x86ia64io.h
>>>> index 5204a7dd61d4..9dc0266e5168 100644
>>>> --- a/drivers/input/serio/i8042-x86ia64io.h
>>>> +++ b/drivers/input/serio/i8042-x86ia64io.h
>>>> @@ -1107,6 +1107,20 @@ static const struct dmi_system_id i8042_dmi_quirk_table[] __initconst = {
>>>> .driver_data = (void *)(SERIO_QUIRK_NOMUX | SERIO_QUIRK_RESET_ALWAYS |
>>>> SERIO_QUIRK_NOLOOP | SERIO_QUIRK_NOPNP)
>>>> },
>>>> + {
>>>> + /*
>>>> + * Setting SERIO_QUIRK_NOMUX or SERIO_QUIRK_RESET_ALWAYS makes
>>>> + * the keyboard very laggy for ~5 seconds after boot and
>>>> + * sometimes also after resume.
>>>> + * However both are required for the keyboard to not fail
>>>> + * completely sometimes after boot or resume.
>>>> + */
>>>> + .matches = {
>>>> + DMI_MATCH(DMI_BOARD_NAME, "N150CU"),
>>>> + },
>>>> + .driver_data = (void *)(SERIO_QUIRK_NOMUX | SERIO_QUIRK_RESET_ALWAYS |
>>>> + SERIO_QUIRK_NOLOOP | SERIO_QUIRK_NOPNP)
>>>> + },
>>>> {
>>>> .matches = {
>>>> DMI_MATCH(DMI_BOARD_NAME, "NH5xAx"),
>>>> @@ -1114,6 +1128,20 @@ static const struct dmi_system_id i8042_dmi_quirk_table[] __initconst = {
>>>> .driver_data = (void *)(SERIO_QUIRK_NOMUX | SERIO_QUIRK_RESET_ALWAYS |
>>>> SERIO_QUIRK_NOLOOP | SERIO_QUIRK_NOPNP)
>>>> },
>>>> + {
>>>> + /*
>>>> + * Setting SERIO_QUIRK_NOMUX or SERIO_QUIRK_RESET_ALWAYS makes
>>>> + * the keyboard very laggy for ~5 seconds after boot and
>>>> + * sometimes also after resume.
>>>> + * However both are required for the keyboard to not fail
>>>> + * completely sometimes after boot or resume.
>>>> + */
>>>> + .matches = {
>>>> + DMI_MATCH(DMI_BOARD_NAME, "NHxxRZQ"),
>>>> + },
>>>> + .driver_data = (void *)(SERIO_QUIRK_NOMUX | SERIO_QUIRK_RESET_ALWAYS |
>>>> + SERIO_QUIRK_NOLOOP | SERIO_QUIRK_NOPNP)
>>>> + },
>>>> {
>>>> .matches = {
>>>> DMI_MATCH(DMI_BOARD_NAME, "NL5xRU"),
>
^ permalink raw reply
* Re: [PATCH 2/2] Input: i8042 - add TUXEDO devices to i8042 quirk tables for partial fix
From: Dmitry Torokhov @ 2023-03-21 18:53 UTC (permalink / raw)
To: Werner Sembach; +Cc: Hans de Goede, tiwai, samuel, linux-input, linux-kernel
In-Reply-To: <f50b3db3-785d-3efd-b45d-13e1e93f60cc@tuxedocomputers.com>
Hi Werner,
On Tue, Mar 21, 2023 at 05:10:19PM +0100, Werner Sembach wrote:
> Am 11.07.22 um 14:55 schrieb Hans de Goede:
> > Hi,
> >
> > On 7/11/22 14:45, Werner Sembach wrote:
> > > Hi,
> > >
> > > On 7/8/22 21:39, Hans de Goede wrote:
> > > > Hi,
> > > >
> > > > On 7/8/22 18:10, Werner Sembach wrote:
> > > > > A lot of modern Clevo barebones have touchpad and/or keyboard issues after
> > > > > suspend fixable with nomux + reset + noloop + nopnp. Luckily, none of them
> > > > > have an external PS/2 port so this can safely be set for all of them.
> > > > >
> > > > > I'm not entirely sure if every device listed really needs all four quirks,
> > > > > but after testing and production use. No negative effects could be
> > > > > observed when setting all four.
> > > > >
> > > > > Setting SERIO_QUIRK_NOMUX or SERIO_QUIRK_RESET_ALWAYS on the Clevo N150CU
> > > > > and the Clevo NHxxRZQ makes the keyboard very laggy for ~5 seconds after
> > > > > boot and sometimes also after resume. However both are required for the
> > > > > keyboard to not fail completely sometimes after boot or resume.
> > > > Hmm, the very laggy bit does not sound good. Have you looked into other
> > > > solutions, e.g. what happens if you use just nomux without any of the
> > > > other 3 options ?
> > > I tried a lot of combinations, but it was some time ago.
> > >
> > > iirc: at least nomux and reset are required and both individually cause the lagging.
> > >
> > > So the issue is not fixed by just using a different set of quirks.
> > Hmm, ok. So given that this seems to be the best we can do
> > the patch looks good to me:
> >
> > Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> >
> > Regards,
> >
> > Hans
>
> Afaik this patch never got merged. Sadly I still have no better solution, so
> I wanted to bring the patch up for discussion again as it still makes the
> situation better in my opinion.
Could you rebase on top of the latest kernel?
Thanks.
--
Dmitry
^ permalink raw reply
* [PATCH v3] Input: i8042 - add TUXEDO devices to i8042 quirk tables for partial fix
From: Werner Sembach @ 2023-03-21 19:16 UTC (permalink / raw)
To: dmitry.torokhov, hdegoede, wse, mkorpershoek, chenhuacai, tiwai,
wsa+renesas, linux-input, linux-kernel
A lot of modern Clevo barebones have touchpad and/or keyboard issues after
suspend fixable with nomux + reset + noloop + nopnp. Luckily, none of them
have an external PS/2 port so this can safely be set for all of them.
I'm not entirely sure if every device listed really needs all four quirks,
but after testing and production use. No negative effects could be
observed when setting all four.
Setting SERIO_QUIRK_NOMUX or SERIO_QUIRK_RESET_ALWAYS on the Clevo N150CU
and the Clevo NHxxRZQ makes the keyboard very laggy for ~5 seconds after
boot and sometimes also after resume. However both are required for the
keyboard to not fail completely sometimes after boot or resume.
Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
Cc: stable@vger.kernel.org
---
drivers/input/serio/i8042-acpipnpio.h | 28 +++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/drivers/input/serio/i8042-acpipnpio.h b/drivers/input/serio/i8042-acpipnpio.h
index efc61736099b9..371406f85ab39 100644
--- a/drivers/input/serio/i8042-acpipnpio.h
+++ b/drivers/input/serio/i8042-acpipnpio.h
@@ -1116,6 +1116,20 @@ static const struct dmi_system_id i8042_dmi_quirk_table[] __initconst = {
.driver_data = (void *)(SERIO_QUIRK_NOMUX | SERIO_QUIRK_RESET_ALWAYS |
SERIO_QUIRK_NOLOOP | SERIO_QUIRK_NOPNP)
},
+ {
+ /*
+ * Setting SERIO_QUIRK_NOMUX or SERIO_QUIRK_RESET_ALWAYS makes
+ * the keyboard very laggy for ~5 seconds after boot and
+ * sometimes also after resume.
+ * However both are required for the keyboard to not fail
+ * completely sometimes after boot or resume.
+ */
+ .matches = {
+ DMI_MATCH(DMI_BOARD_NAME, "N150CU"),
+ },
+ .driver_data = (void *)(SERIO_QUIRK_NOMUX | SERIO_QUIRK_RESET_ALWAYS |
+ SERIO_QUIRK_NOLOOP | SERIO_QUIRK_NOPNP)
+ },
{
.matches = {
DMI_MATCH(DMI_BOARD_NAME, "NH5xAx"),
@@ -1123,6 +1137,20 @@ static const struct dmi_system_id i8042_dmi_quirk_table[] __initconst = {
.driver_data = (void *)(SERIO_QUIRK_NOMUX | SERIO_QUIRK_RESET_ALWAYS |
SERIO_QUIRK_NOLOOP | SERIO_QUIRK_NOPNP)
},
+ {
+ /*
+ * Setting SERIO_QUIRK_NOMUX or SERIO_QUIRK_RESET_ALWAYS makes
+ * the keyboard very laggy for ~5 seconds after boot and
+ * sometimes also after resume.
+ * However both are required for the keyboard to not fail
+ * completely sometimes after boot or resume.
+ */
+ .matches = {
+ DMI_MATCH(DMI_BOARD_NAME, "NHxxRZQ"),
+ },
+ .driver_data = (void *)(SERIO_QUIRK_NOMUX | SERIO_QUIRK_RESET_ALWAYS |
+ SERIO_QUIRK_NOLOOP | SERIO_QUIRK_NOPNP)
+ },
{
.matches = {
DMI_MATCH(DMI_BOARD_NAME, "NL5xRU"),
--
2.34.1
^ permalink raw reply related
* Re: [PATCH 2/2] Input: i8042 - add TUXEDO devices to i8042 quirk tables for partial fix
From: Werner Sembach @ 2023-03-21 19:18 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: Hans de Goede, tiwai, samuel, linux-input, linux-kernel
In-Reply-To: <ZBn9HYw/NOvHFkrk@google.com>
Am 21.03.23 um 19:53 schrieb Dmitry Torokhov:
> Hi Werner,
>
> On Tue, Mar 21, 2023 at 05:10:19PM +0100, Werner Sembach wrote:
>> Am 11.07.22 um 14:55 schrieb Hans de Goede:
>>> Hi,
>>>
>>> On 7/11/22 14:45, Werner Sembach wrote:
>>>> Hi,
>>>>
>>>> On 7/8/22 21:39, Hans de Goede wrote:
>>>>> Hi,
>>>>>
>>>>> On 7/8/22 18:10, Werner Sembach wrote:
>>>>>> A lot of modern Clevo barebones have touchpad and/or keyboard issues after
>>>>>> suspend fixable with nomux + reset + noloop + nopnp. Luckily, none of them
>>>>>> have an external PS/2 port so this can safely be set for all of them.
>>>>>>
>>>>>> I'm not entirely sure if every device listed really needs all four quirks,
>>>>>> but after testing and production use. No negative effects could be
>>>>>> observed when setting all four.
>>>>>>
>>>>>> Setting SERIO_QUIRK_NOMUX or SERIO_QUIRK_RESET_ALWAYS on the Clevo N150CU
>>>>>> and the Clevo NHxxRZQ makes the keyboard very laggy for ~5 seconds after
>>>>>> boot and sometimes also after resume. However both are required for the
>>>>>> keyboard to not fail completely sometimes after boot or resume.
>>>>> Hmm, the very laggy bit does not sound good. Have you looked into other
>>>>> solutions, e.g. what happens if you use just nomux without any of the
>>>>> other 3 options ?
>>>> I tried a lot of combinations, but it was some time ago.
>>>>
>>>> iirc: at least nomux and reset are required and both individually cause the lagging.
>>>>
>>>> So the issue is not fixed by just using a different set of quirks.
>>> Hmm, ok. So given that this seems to be the best we can do
>>> the patch looks good to me:
>>>
>>> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>>>
>>> Regards,
>>>
>>> Hans
>> Afaik this patch never got merged. Sadly I still have no better solution, so
>> I wanted to bring the patch up for discussion again as it still makes the
>> situation better in my opinion.
> Could you rebase on top of the latest kernel?
>
> Thanks.
>
ofc, sent as v3
^ permalink raw reply
* [PATCH] Input: cma3000_d0x - Clean up some inconsistent indenting
From: Jiapeng Chong @ 2023-03-22 6:41 UTC (permalink / raw)
To: dmitry.torokhov; +Cc: linux-input, linux-kernel, Jiapeng Chong, Abaci Robot
No functional modification involved.
drivers/input/misc/cma3000_d0x.c:328 cma3000_init() warn: inconsistent indenting.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4588
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/input/misc/cma3000_d0x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/misc/cma3000_d0x.c b/drivers/input/misc/cma3000_d0x.c
index e6feb73bb52b..c444a44e4576 100644
--- a/drivers/input/misc/cma3000_d0x.c
+++ b/drivers/input/misc/cma3000_d0x.c
@@ -325,7 +325,7 @@ struct cma3000_accl_data *cma3000_init(struct device *dev, int irq,
input_dev->open = cma3000_open;
input_dev->close = cma3000_close;
- __set_bit(EV_ABS, input_dev->evbit);
+ __set_bit(EV_ABS, input_dev->evbit);
input_set_abs_params(input_dev, ABS_X,
-data->g_range, data->g_range, pdata->fuzz_x, 0);
--
2.20.1.7.g153144c
^ permalink raw reply related
* [PATCH] Input: silead - Use dev_err_probe()
From: ye.xingchen @ 2023-03-22 8:50 UTC (permalink / raw)
To: hdegoede; +Cc: dmitry.torokhov, linux-input, platform-driver-x86, linux-kernel
From: Ye Xingchen <ye.xingchen@zte.com.cn>
Replace the open-code with dev_err_probe() to simplify the code.
Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
---
drivers/input/touchscreen/silead.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/input/touchscreen/silead.c b/drivers/input/touchscreen/silead.c
index a37fac089010..f464155aed65 100644
--- a/drivers/input/touchscreen/silead.c
+++ b/drivers/input/touchscreen/silead.c
@@ -706,11 +706,9 @@ static int silead_ts_probe(struct i2c_client *client)
/* Power GPIO pin */
data->gpio_power = devm_gpiod_get_optional(dev, "power", GPIOD_OUT_LOW);
- if (IS_ERR(data->gpio_power)) {
- if (PTR_ERR(data->gpio_power) != -EPROBE_DEFER)
- dev_err(dev, "Shutdown GPIO request failed\n");
- return PTR_ERR(data->gpio_power);
- }
+ if (IS_ERR(data->gpio_power))
+ return dev_err_probe(dev, PTR_ERR(data->gpio_power),
+ "Shutdown GPIO request failed\n");
error = silead_ts_setup(client);
if (error)
--
2.25.1
^ permalink raw reply related
* Re: [PATCH] Input: silead - Use dev_err_probe()
From: Hans de Goede @ 2023-03-22 9:41 UTC (permalink / raw)
To: ye.xingchen
Cc: dmitry.torokhov, linux-input, platform-driver-x86, linux-kernel
In-Reply-To: <202303221650190306634@zte.com.cn>
Hi,
On 3/22/23 09:50, ye.xingchen@zte.com.cn wrote:
> From: Ye Xingchen <ye.xingchen@zte.com.cn>
>
> Replace the open-code with dev_err_probe() to simplify the code.
>
> Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/input/touchscreen/silead.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/input/touchscreen/silead.c b/drivers/input/touchscreen/silead.c
> index a37fac089010..f464155aed65 100644
> --- a/drivers/input/touchscreen/silead.c
> +++ b/drivers/input/touchscreen/silead.c
> @@ -706,11 +706,9 @@ static int silead_ts_probe(struct i2c_client *client)
>
> /* Power GPIO pin */
> data->gpio_power = devm_gpiod_get_optional(dev, "power", GPIOD_OUT_LOW);
> - if (IS_ERR(data->gpio_power)) {
> - if (PTR_ERR(data->gpio_power) != -EPROBE_DEFER)
> - dev_err(dev, "Shutdown GPIO request failed\n");
> - return PTR_ERR(data->gpio_power);
> - }
> + if (IS_ERR(data->gpio_power))
> + return dev_err_probe(dev, PTR_ERR(data->gpio_power),
> + "Shutdown GPIO request failed\n");
>
> error = silead_ts_setup(client);
> if (error)
^ permalink raw reply
* [PATCH v2 0/2] platform/x86: Add driver for Yoga Tablet mode switch
From: Andrew Kallmeyer @ 2023-03-23 2:51 UTC (permalink / raw)
To: platform-driver-x86
Cc: Andrew Kallmeyer, Gergo Koteles, Ike Panhc, linux-input,
Hans de Goede, Armin Wolf, Barnabás Pőcze
This driver maps the Lenovo Yoga tablet mode switch to a SW_TABLET_MODE input
device. This will make the tablet status available to desktop environments.
This patch series is the result of the discussion at
https://lore.kernel.org/r/CAG4kvq9US=-NjyXFMzJYu2zCJryJWtOc7FGZbrewpgCDjdAkbg@mail.gmail.com/
I decided to follow-up on the patch Gergo wrote and respond to the review
comments to get it merged and available for everyone.
Gergo and I have tested this on the Yoga 7 14ARB7, and the Yoga 7 14AIL7
respectively. Additionally, according to reports at
https://github.com/lukas-w/yoga-usage-mode, which uses the same WMI devices,
this driver should work with:
Yoga C940, Ideapad flex 14API, Yoga 9 14IAP7, Yoga 7 14ARB7, etc.
The diff since v1 is as follows:
v1: https://lore.kernel.org/platform-driver-x86/20230310041726.217447-1-kallmeyeras@gmail.com/
--- a/drivers/platform/x86/lenovo-ymc.c
+++ b/drivers/platform/x86/lenovo-ymc.c
@@ -18,7 +18,7 @@
#define LENOVO_YMC_QUERY_GUID "09B0EE6E-C3FD-4243-8DA1-7911FF80BB8C"
#define LENOVO_YMC_QUERY_INSTANCE 0
-#define LENOVO_YMC_QUERY_METHOD 0xAB
+#define LENOVO_YMC_QUERY_METHOD 0x01
static bool ec_trigger __read_mostly;
module_param(ec_trigger, bool, 0644);
@@ -103,6 +103,12 @@ static void lenovo_ymc_notify(struct wmi_device *wdev, union acpi_object *data)
lenovo_ymc_trigger_ec(wdev, priv);
}
+static void lenovo_ymc_remove(struct wmi_device *wdev)
+{
+ struct lenovo_ymc_private *priv = dev_get_drvdata(&wdev->dev);
+ acpi_dev_put(priv->ec_acpi_dev);
+}
+
static int lenovo_ymc_probe(struct wmi_device *wdev, const void *ctx)
{
struct input_dev *input_dev;
@@ -117,7 +123,7 @@ static int lenovo_ymc_probe(struct wmi_device *wdev, const void *ctx)
if (ec_trigger) {
pr_debug("Lenovo YMC enable EC triggering.\n");
- priv->ec_acpi_dev = acpi_dev_get_first_match_dev("VCP2004", NULL, -1);
+ priv->ec_acpi_dev = acpi_dev_get_first_match_dev("VPC2004", NULL, -1);
if (!priv->ec_acpi_dev) {
dev_err(&wdev->dev, "Could not find EC ACPI device.\n");
return -ENODEV;
@@ -151,7 +157,10 @@ static int lenovo_ymc_probe(struct wmi_device *wdev, const void *ctx)
priv->input_dev = input_dev;
dev_set_drvdata(&wdev->dev, priv);
+
+ // Report the state for the first time on probe
lenovo_ymc_trigger_ec(wdev, priv);
+ lenovo_ymc_notify(wdev, NULL);
return 0;
}
@@ -168,6 +177,7 @@ static struct wmi_driver lenovo_ymc_driver = {
.id_table = lenovo_ymc_wmi_id_table,
.probe = lenovo_ymc_probe,
.notify = lenovo_ymc_notify,
+ .remove = lenovo_ymc_remove,
};
module_wmi_driver(lenovo_ymc_driver);
Andrew Kallmeyer (1):
platform/x86: Move ideapad ACPI helpers to a new header
Gergo Koteles (1):
platform/x86: Add driver for Yoga Tablet Mode switch
drivers/platform/x86/Kconfig | 10 ++
drivers/platform/x86/Makefile | 1 +
drivers/platform/x86/ideapad-laptop.c | 135 +------------------
drivers/platform/x86/ideapad-laptop.h | 152 +++++++++++++++++++++
drivers/platform/x86/lenovo-ymc.c | 187 ++++++++++++++++++++++++++
5 files changed, 351 insertions(+), 134 deletions(-)
create mode 100644 drivers/platform/x86/ideapad-laptop.h
create mode 100644 drivers/platform/x86/lenovo-ymc.c
--
2.40.0
^ permalink raw reply
* [PATCH v2 1/2] platform/x86: Move ideapad ACPI helpers to a new header
From: Andrew Kallmeyer @ 2023-03-23 2:51 UTC (permalink / raw)
To: platform-driver-x86
Cc: Andrew Kallmeyer, Gergo Koteles, Ike Panhc, linux-input,
Hans de Goede, Armin Wolf, Barnabás Pőcze
In-Reply-To: <20230323025200.5462-1-kallmeyeras@gmail.com>
These functions will be used by a driver written by Gergo Koteles to
detect the tablet mode switch in Lenovo Yoga laptops. These changes were
discussed in review of that patch.
This is the minimal set of functions needed in that driver, there are
several more small functions left in the ACPI Helpers section in
ideapad-laptop.c. The only change is the functions are now marked inline
as requested in the review comments.
Signed-off-by: Andrew Kallmeyer <kallmeyeras@gmail.com>
Link: https://lore.kernel.org/r/20221004214332.35934-1-soyer@irl.hu/
---
drivers/platform/x86/ideapad-laptop.c | 135 +----------------------
drivers/platform/x86/ideapad-laptop.h | 151 ++++++++++++++++++++++++++
2 files changed, 152 insertions(+), 134 deletions(-)
create mode 100644 drivers/platform/x86/ideapad-laptop.h
diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
index 0eb5bfdd8..55f56697e 100644
--- a/drivers/platform/x86/ideapad-laptop.c
+++ b/drivers/platform/x86/ideapad-laptop.c
@@ -20,7 +20,6 @@
#include <linux/init.h>
#include <linux/input.h>
#include <linux/input/sparse-keymap.h>
-#include <linux/jiffies.h>
#include <linux/kernel.h>
#include <linux/leds.h>
#include <linux/module.h>
@@ -31,6 +30,7 @@
#include <linux/sysfs.h>
#include <linux/types.h>
#include <linux/wmi.h>
+#include "ideapad-laptop.h"
#include <acpi/video.h>
@@ -85,33 +85,6 @@ enum {
SALS_FNLOCK_OFF = 0xf,
};
-enum {
- VPCCMD_R_VPC1 = 0x10,
- VPCCMD_R_BL_MAX,
- VPCCMD_R_BL,
- VPCCMD_W_BL,
- VPCCMD_R_WIFI,
- VPCCMD_W_WIFI,
- VPCCMD_R_BT,
- VPCCMD_W_BT,
- VPCCMD_R_BL_POWER,
- VPCCMD_R_NOVO,
- VPCCMD_R_VPC2,
- VPCCMD_R_TOUCHPAD,
- VPCCMD_W_TOUCHPAD,
- VPCCMD_R_CAMERA,
- VPCCMD_W_CAMERA,
- VPCCMD_R_3G,
- VPCCMD_W_3G,
- VPCCMD_R_ODD, /* 0x21 */
- VPCCMD_W_FAN,
- VPCCMD_R_RF,
- VPCCMD_W_RF,
- VPCCMD_R_FAN = 0x2B,
- VPCCMD_R_SPECIAL_BUTTONS = 0x31,
- VPCCMD_W_BL_POWER = 0x33,
-};
-
struct ideapad_dytc_priv {
enum platform_profile_option current_profile;
struct platform_profile_handler pprof;
@@ -227,7 +200,6 @@ static void ideapad_shared_exit(struct ideapad_private *priv)
/*
* ACPI Helpers
*/
-#define IDEAPAD_EC_TIMEOUT 200 /* in ms */
static int eval_int(acpi_handle handle, const char *name, unsigned long *res)
{
@@ -270,116 +242,11 @@ static int exec_sals(acpi_handle handle, unsigned long arg)
return exec_simple_method(handle, "SALS", arg);
}
-static int eval_int_with_arg(acpi_handle handle, const char *name, unsigned long arg, unsigned long *res)
-{
- struct acpi_object_list params;
- unsigned long long result;
- union acpi_object in_obj;
- acpi_status status;
-
- params.count = 1;
- params.pointer = &in_obj;
- in_obj.type = ACPI_TYPE_INTEGER;
- in_obj.integer.value = arg;
-
- status = acpi_evaluate_integer(handle, (char *)name, ¶ms, &result);
- if (ACPI_FAILURE(status))
- return -EIO;
-
- if (res)
- *res = result;
-
- return 0;
-}
-
static int eval_dytc(acpi_handle handle, unsigned long cmd, unsigned long *res)
{
return eval_int_with_arg(handle, "DYTC", cmd, res);
}
-static int eval_vpcr(acpi_handle handle, unsigned long cmd, unsigned long *res)
-{
- return eval_int_with_arg(handle, "VPCR", cmd, res);
-}
-
-static int eval_vpcw(acpi_handle handle, unsigned long cmd, unsigned long data)
-{
- struct acpi_object_list params;
- union acpi_object in_obj[2];
- acpi_status status;
-
- params.count = 2;
- params.pointer = in_obj;
- in_obj[0].type = ACPI_TYPE_INTEGER;
- in_obj[0].integer.value = cmd;
- in_obj[1].type = ACPI_TYPE_INTEGER;
- in_obj[1].integer.value = data;
-
- status = acpi_evaluate_object(handle, "VPCW", ¶ms, NULL);
- if (ACPI_FAILURE(status))
- return -EIO;
-
- return 0;
-}
-
-static int read_ec_data(acpi_handle handle, unsigned long cmd, unsigned long *data)
-{
- unsigned long end_jiffies, val;
- int err;
-
- err = eval_vpcw(handle, 1, cmd);
- if (err)
- return err;
-
- end_jiffies = jiffies + msecs_to_jiffies(IDEAPAD_EC_TIMEOUT) + 1;
-
- while (time_before(jiffies, end_jiffies)) {
- schedule();
-
- err = eval_vpcr(handle, 1, &val);
- if (err)
- return err;
-
- if (val == 0)
- return eval_vpcr(handle, 0, data);
- }
-
- acpi_handle_err(handle, "timeout in %s\n", __func__);
-
- return -ETIMEDOUT;
-}
-
-static int write_ec_cmd(acpi_handle handle, unsigned long cmd, unsigned long data)
-{
- unsigned long end_jiffies, val;
- int err;
-
- err = eval_vpcw(handle, 0, data);
- if (err)
- return err;
-
- err = eval_vpcw(handle, 1, cmd);
- if (err)
- return err;
-
- end_jiffies = jiffies + msecs_to_jiffies(IDEAPAD_EC_TIMEOUT) + 1;
-
- while (time_before(jiffies, end_jiffies)) {
- schedule();
-
- err = eval_vpcr(handle, 1, &val);
- if (err)
- return err;
-
- if (val == 0)
- return 0;
- }
-
- acpi_handle_err(handle, "timeout in %s\n", __func__);
-
- return -ETIMEDOUT;
-}
-
/*
* debugfs
*/
diff --git a/drivers/platform/x86/ideapad-laptop.h b/drivers/platform/x86/ideapad-laptop.h
new file mode 100644
index 000000000..7dd8ce027
--- /dev/null
+++ b/drivers/platform/x86/ideapad-laptop.h
@@ -0,0 +1,151 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * ideapad-laptop.h - Lenovo IdeaPad ACPI Extras
+ *
+ * Copyright © 2010 Intel Corporation
+ * Copyright © 2010 David Woodhouse <dwmw2@infradead.org>
+ */
+
+#ifndef _IDEAPAD_LAPTOP_H_
+#define _IDEAPAD_LAPTOP_H_
+
+#include <linux/acpi.h>
+#include <linux/jiffies.h>
+#include <linux/errno.h>
+
+enum {
+ VPCCMD_R_VPC1 = 0x10,
+ VPCCMD_R_BL_MAX,
+ VPCCMD_R_BL,
+ VPCCMD_W_BL,
+ VPCCMD_R_WIFI,
+ VPCCMD_W_WIFI,
+ VPCCMD_R_BT,
+ VPCCMD_W_BT,
+ VPCCMD_R_BL_POWER,
+ VPCCMD_R_NOVO,
+ VPCCMD_R_VPC2,
+ VPCCMD_R_TOUCHPAD,
+ VPCCMD_W_TOUCHPAD,
+ VPCCMD_R_CAMERA,
+ VPCCMD_W_CAMERA,
+ VPCCMD_R_3G,
+ VPCCMD_W_3G,
+ VPCCMD_R_ODD, /* 0x21 */
+ VPCCMD_W_FAN,
+ VPCCMD_R_RF,
+ VPCCMD_W_RF,
+ VPCCMD_R_FAN = 0x2B,
+ VPCCMD_R_SPECIAL_BUTTONS = 0x31,
+ VPCCMD_W_BL_POWER = 0x33,
+};
+
+static inline int eval_int_with_arg(acpi_handle handle, const char *name, unsigned long arg, unsigned long *res)
+{
+ struct acpi_object_list params;
+ unsigned long long result;
+ union acpi_object in_obj;
+ acpi_status status;
+
+ params.count = 1;
+ params.pointer = &in_obj;
+ in_obj.type = ACPI_TYPE_INTEGER;
+ in_obj.integer.value = arg;
+
+ status = acpi_evaluate_integer(handle, (char *)name, ¶ms, &result);
+ if (ACPI_FAILURE(status))
+ return -EIO;
+
+ if (res)
+ *res = result;
+
+ return 0;
+}
+
+static inline int eval_vpcr(acpi_handle handle, unsigned long cmd, unsigned long *res)
+{
+ return eval_int_with_arg(handle, "VPCR", cmd, res);
+}
+
+static inline int eval_vpcw(acpi_handle handle, unsigned long cmd, unsigned long data)
+{
+ struct acpi_object_list params;
+ union acpi_object in_obj[2];
+ acpi_status status;
+
+ params.count = 2;
+ params.pointer = in_obj;
+ in_obj[0].type = ACPI_TYPE_INTEGER;
+ in_obj[0].integer.value = cmd;
+ in_obj[1].type = ACPI_TYPE_INTEGER;
+ in_obj[1].integer.value = data;
+
+ status = acpi_evaluate_object(handle, "VPCW", ¶ms, NULL);
+ if (ACPI_FAILURE(status))
+ return -EIO;
+
+ return 0;
+}
+
+#define IDEAPAD_EC_TIMEOUT 200 /* in ms */
+
+static inline int read_ec_data(acpi_handle handle, unsigned long cmd, unsigned long *data)
+{
+ unsigned long end_jiffies, val;
+ int err;
+
+ err = eval_vpcw(handle, 1, cmd);
+ if (err)
+ return err;
+
+ end_jiffies = jiffies + msecs_to_jiffies(IDEAPAD_EC_TIMEOUT) + 1;
+
+ while (time_before(jiffies, end_jiffies)) {
+ schedule();
+
+ err = eval_vpcr(handle, 1, &val);
+ if (err)
+ return err;
+
+ if (val == 0)
+ return eval_vpcr(handle, 0, data);
+ }
+
+ acpi_handle_err(handle, "timeout in %s\n", __func__);
+
+ return -ETIMEDOUT;
+}
+
+static inline int write_ec_cmd(acpi_handle handle, unsigned long cmd, unsigned long data)
+{
+ unsigned long end_jiffies, val;
+ int err;
+
+ err = eval_vpcw(handle, 0, data);
+ if (err)
+ return err;
+
+ err = eval_vpcw(handle, 1, cmd);
+ if (err)
+ return err;
+
+ end_jiffies = jiffies + msecs_to_jiffies(IDEAPAD_EC_TIMEOUT) + 1;
+
+ while (time_before(jiffies, end_jiffies)) {
+ schedule();
+
+ err = eval_vpcr(handle, 1, &val);
+ if (err)
+ return err;
+
+ if (val == 0)
+ return 0;
+ }
+
+ acpi_handle_err(handle, "timeout in %s\n", __func__);
+
+ return -ETIMEDOUT;
+}
+
+#undef IDEAPAD_EC_TIMEOUT
+#endif /* !_IDEAPAD_LAPTOP_H_ */
--
2.40.0
^ permalink raw reply related
* [PATCH v2 2/2] platform/x86: Add driver for Yoga Tablet Mode switch
From: Andrew Kallmeyer @ 2023-03-23 2:52 UTC (permalink / raw)
To: platform-driver-x86
Cc: Andrew Kallmeyer, Gergo Koteles, Ike Panhc, linux-input,
Hans de Goede, Armin Wolf, Barnabás Pőcze
In-Reply-To: <20230323025200.5462-1-kallmeyeras@gmail.com>
From: Gergo Koteles <soyer@irl.hu>
This WMI driver for the tablet mode control switch for Lenovo Yoga
notebooks was originally written by Gergo Koteles. The mode is mapped to
a SW_TABLET_MODE switch capable input device.
Andrew followed the suggestions that were posted in reply to Gergo's RFC
patch, and on the v1 version of this patch to follow-up and get it
merged.
Changes from Gergo's RFC:
- Refactored obtaining a reference to the EC ACPI device needed for the
quirk implementation as suggested by Hans de Goede
- Applied small fixes and switched to devm_input_allocate_device() and
removing input_unregister_device() as suggested by Barnabás Pőcze.
- Merged the lenovo_ymc_trigger_ec function with the
ideapad_trigger_ymc_next_read function since it was no longer
external.
- Added the word "Tablet" to the driver description to hopefully make
it more clear.
- Fixed the LENOVO_YMC_QUERY_METHOD ID and the name string for the EC
APCI device trigged for the quirk
- Triggered the input event on probe so that the initial tablet mode
state when the driver is loaded is reported to userspace as suggested
by Armin Wolf.
We have tested this on the Yoga 7 14AIL7 for the non-quirk path and on
the Yoga 7 14ARB7 which has the firmware bug that requires triggering
the embedded controller to send the mode change events. This workaround
is also used by the Windows drivers.
According to reports at https://github.com/lukas-w/yoga-usage-mode,
which uses the same WMI devices, the following models should also work:
Yoga C940, Ideapad flex 14API, Yoga 9 14IAP7, Yoga 7 14ARB7, etc.
Signed-off-by: Gergo Koteles <soyer@irl.hu>
Co-developed-by: Andrew Kallmeyer <kallmeyeras@gmail.com>
Signed-off-by: Andrew Kallmeyer <kallmeyeras@gmail.com>
Link: https://lore.kernel.org/r/20221004214332.35934-1-soyer@irl.hu/
Link: https://lore.kernel.org/platform-driver-x86/20230310041726.217447-1-kallmeyeras@gmail.com/
---
drivers/platform/x86/Kconfig | 10 ++
drivers/platform/x86/Makefile | 1 +
drivers/platform/x86/ideapad-laptop.h | 1 +
drivers/platform/x86/lenovo-ymc.c | 187 ++++++++++++++++++++++++++
4 files changed, 199 insertions(+)
create mode 100644 drivers/platform/x86/lenovo-ymc.c
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 5692385e2..858be0c65 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -470,6 +470,16 @@ config IDEAPAD_LAPTOP
This is a driver for Lenovo IdeaPad netbooks contains drivers for
rfkill switch, hotkey, fan control and backlight control.
+config LENOVO_YMC
+ tristate "Lenovo Yoga Tablet Mode Control"
+ depends on ACPI_WMI
+ depends on INPUT
+ depends on IDEAPAD_LAPTOP
+ select INPUT_SPARSEKMAP
+ help
+ This driver maps the Tablet Mode Control switch to SW_TABLET_MODE input
+ events for Lenovo Yoga notebooks.
+
config SENSORS_HDAPS
tristate "Thinkpad Hard Drive Active Protection System (hdaps)"
depends on INPUT
diff --git a/drivers/platform/x86/Makefile b/drivers/platform/x86/Makefile
index 1d3d1b025..10054cdea 100644
--- a/drivers/platform/x86/Makefile
+++ b/drivers/platform/x86/Makefile
@@ -63,6 +63,7 @@ obj-$(CONFIG_UV_SYSFS) += uv_sysfs.o
# IBM Thinkpad and Lenovo
obj-$(CONFIG_IBM_RTL) += ibm_rtl.o
obj-$(CONFIG_IDEAPAD_LAPTOP) += ideapad-laptop.o
+obj-$(CONFIG_LENOVO_YMC) += lenovo-ymc.o
obj-$(CONFIG_SENSORS_HDAPS) += hdaps.o
obj-$(CONFIG_THINKPAD_ACPI) += thinkpad_acpi.o
obj-$(CONFIG_THINKPAD_LMI) += think-lmi.o
diff --git a/drivers/platform/x86/ideapad-laptop.h b/drivers/platform/x86/ideapad-laptop.h
index 7dd8ce027..2564cb1cd 100644
--- a/drivers/platform/x86/ideapad-laptop.h
+++ b/drivers/platform/x86/ideapad-laptop.h
@@ -35,6 +35,7 @@ enum {
VPCCMD_W_FAN,
VPCCMD_R_RF,
VPCCMD_W_RF,
+ VPCCMD_W_YMC = 0x2A,
VPCCMD_R_FAN = 0x2B,
VPCCMD_R_SPECIAL_BUTTONS = 0x31,
VPCCMD_W_BL_POWER = 0x33,
diff --git a/drivers/platform/x86/lenovo-ymc.c b/drivers/platform/x86/lenovo-ymc.c
new file mode 100644
index 000000000..c64f7ec85
--- /dev/null
+++ b/drivers/platform/x86/lenovo-ymc.c
@@ -0,0 +1,187 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * lenovo-ymc.c - Lenovo Yoga Mode Control driver
+ *
+ * Copyright © 2022 Gergo Koteles <soyer@irl.hu>
+ */
+
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
+#include <linux/acpi.h>
+#include <linux/dmi.h>
+#include <linux/input.h>
+#include <linux/input/sparse-keymap.h>
+#include <linux/wmi.h>
+#include "ideapad-laptop.h"
+
+#define LENOVO_YMC_EVENT_GUID "06129D99-6083-4164-81AD-F092F9D773A6"
+#define LENOVO_YMC_QUERY_GUID "09B0EE6E-C3FD-4243-8DA1-7911FF80BB8C"
+
+#define LENOVO_YMC_QUERY_INSTANCE 0
+#define LENOVO_YMC_QUERY_METHOD 0x01
+
+static bool ec_trigger __read_mostly;
+module_param(ec_trigger, bool, 0644);
+MODULE_PARM_DESC(ec_trigger, "Enable EC triggering to emit YMC events");
+
+static const struct dmi_system_id ec_trigger_quirk_dmi_table[] = {
+ {
+ // Lenovo Yoga 7 14ARB7
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "82QF"),
+ },
+ },
+ { },
+};
+
+struct lenovo_ymc_private {
+ struct input_dev *input_dev;
+ struct acpi_device *ec_acpi_dev;
+};
+
+static void lenovo_ymc_trigger_ec(struct wmi_device *wdev, struct lenovo_ymc_private *priv)
+{
+ int err;
+
+ if (!ec_trigger || !priv || !priv->ec_acpi_dev)
+ return;
+ err = write_ec_cmd(priv->ec_acpi_dev->handle, VPCCMD_W_YMC, 1);
+ if (err)
+ dev_warn(&wdev->dev, "Could not write YMC: %d\n", err);
+}
+
+static const struct key_entry lenovo_ymc_keymap[] = {
+ // Laptop
+ { KE_SW, 0x01, { .sw = { SW_TABLET_MODE, 0 } } },
+ // Tablet
+ { KE_SW, 0x02, { .sw = { SW_TABLET_MODE, 1 } } },
+ // Drawing Board
+ { KE_SW, 0x03, { .sw = { SW_TABLET_MODE, 1 } } },
+ // Tent
+ { KE_SW, 0x04, { .sw = { SW_TABLET_MODE, 1 } } },
+ { KE_END },
+};
+
+static void lenovo_ymc_notify(struct wmi_device *wdev, union acpi_object *data)
+{
+ struct lenovo_ymc_private *priv = dev_get_drvdata(&wdev->dev);
+
+ u32 input_val = 0;
+ struct acpi_buffer input = {sizeof(input_val), &input_val};
+ struct acpi_buffer output = {ACPI_ALLOCATE_BUFFER, NULL};
+ acpi_status status;
+ union acpi_object *obj;
+ int code;
+
+ status = wmi_evaluate_method(LENOVO_YMC_QUERY_GUID,
+ LENOVO_YMC_QUERY_INSTANCE,
+ LENOVO_YMC_QUERY_METHOD,
+ &input, &output);
+
+ if (ACPI_FAILURE(status)) {
+ dev_warn(&wdev->dev,
+ "Failed to evaluate query method: %s\n",
+ acpi_format_exception(status));
+ return;
+ }
+
+ obj = output.pointer;
+
+ if (obj->type != ACPI_TYPE_INTEGER) {
+ dev_warn(&wdev->dev,
+ "WMI event data is not an integer\n");
+ goto free_obj;
+ }
+ code = obj->integer.value;
+
+ if (!sparse_keymap_report_event(priv->input_dev, code, 1, true))
+ dev_warn(&wdev->dev, "Unknown key %d pressed\n", code);
+
+free_obj:
+ kfree(obj);
+ lenovo_ymc_trigger_ec(wdev, priv);
+}
+
+static void lenovo_ymc_remove(struct wmi_device *wdev)
+{
+ struct lenovo_ymc_private *priv = dev_get_drvdata(&wdev->dev);
+ acpi_dev_put(priv->ec_acpi_dev);
+}
+
+static int lenovo_ymc_probe(struct wmi_device *wdev, const void *ctx)
+{
+ struct input_dev *input_dev;
+ struct lenovo_ymc_private *priv;
+ int err;
+
+ ec_trigger |= dmi_check_system(ec_trigger_quirk_dmi_table);
+
+ priv = devm_kzalloc(&wdev->dev, sizeof(*priv), GFP_KERNEL);
+ if (!priv)
+ return -ENOMEM;
+
+ if (ec_trigger) {
+ pr_debug("Lenovo YMC enable EC triggering.\n");
+ priv->ec_acpi_dev = acpi_dev_get_first_match_dev("VPC2004", NULL, -1);
+ if (!priv->ec_acpi_dev) {
+ dev_err(&wdev->dev, "Could not find EC ACPI device.\n");
+ return -ENODEV;
+ }
+ }
+
+ input_dev = devm_input_allocate_device(&wdev->dev);
+ if (!input_dev)
+ return -ENOMEM;
+
+ input_dev->name = "Lenovo Yoga Tablet Mode Control switch";
+ input_dev->phys = LENOVO_YMC_EVENT_GUID "/input0";
+ input_dev->id.bustype = BUS_HOST;
+ input_dev->dev.parent = &wdev->dev;
+
+ input_set_capability(input_dev, EV_SW, SW_TABLET_MODE);
+
+ err = sparse_keymap_setup(input_dev, lenovo_ymc_keymap, NULL);
+ if (err) {
+ dev_err(&wdev->dev,
+ "Could not set up input device keymap: %d\n", err);
+ return err;
+ }
+
+ err = input_register_device(input_dev);
+ if (err) {
+ dev_err(&wdev->dev,
+ "Could not register input device: %d\n", err);
+ return err;
+ }
+
+ priv->input_dev = input_dev;
+ dev_set_drvdata(&wdev->dev, priv);
+
+ // Report the state for the first time on probe
+ lenovo_ymc_trigger_ec(wdev, priv);
+ lenovo_ymc_notify(wdev, NULL);
+ return 0;
+}
+
+static const struct wmi_device_id lenovo_ymc_wmi_id_table[] = {
+ { .guid_string = LENOVO_YMC_EVENT_GUID },
+ { }
+};
+MODULE_DEVICE_TABLE(wmi, lenovo_ymc_wmi_id_table);
+
+static struct wmi_driver lenovo_ymc_driver = {
+ .driver = {
+ .name = "lenovo-ymc",
+ },
+ .id_table = lenovo_ymc_wmi_id_table,
+ .probe = lenovo_ymc_probe,
+ .notify = lenovo_ymc_notify,
+ .remove = lenovo_ymc_remove,
+};
+
+module_wmi_driver(lenovo_ymc_driver);
+
+MODULE_AUTHOR("Gergo Koteles <soyer@irl.hu>");
+MODULE_DESCRIPTION("Lenovo Yoga Mode Control driver");
+MODULE_LICENSE("GPL");
--
2.40.0
^ permalink raw reply related
* [PATCH 1/2] dt-bindings: input: fsl,scu-key: add wakeup-source property
From: Peng Fan (OSS) @ 2023-03-23 9:31 UTC (permalink / raw)
To: dmitry.torokhov, robh+dt, krzysztof.kozlowski+dt
Cc: shawnguo, aisheng.dong, linux-input, devicetree, linux-kernel,
linux-arm-kernel, s.hauer, kernel, festevam, linux-imx, Peng Fan
From: Peng Fan <peng.fan@nxp.com>
Add wakeup-source to indicate whether it could work to wakeup the system
from suspend mode.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
Documentation/devicetree/bindings/input/fsl,scu-key.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/input/fsl,scu-key.yaml b/Documentation/devicetree/bindings/input/fsl,scu-key.yaml
index e5a3c355ee1f..037d4aa7364f 100644
--- a/Documentation/devicetree/bindings/input/fsl,scu-key.yaml
+++ b/Documentation/devicetree/bindings/input/fsl,scu-key.yaml
@@ -24,6 +24,10 @@ properties:
linux,keycodes:
maxItems: 1
+ wakeup-source:
+ description: pwr key can be used as a wakeup source
+ type: boolean
+
required:
- compatible
- linux,keycodes
--
2.37.1
^ permalink raw reply related
* [PATCH 2/2] input: imx_sc_key: add wakeup support
From: Peng Fan (OSS) @ 2023-03-23 9:31 UTC (permalink / raw)
To: dmitry.torokhov, robh+dt, krzysztof.kozlowski+dt
Cc: shawnguo, aisheng.dong, linux-input, devicetree, linux-kernel,
linux-arm-kernel, s.hauer, kernel, festevam, linux-imx, Peng Fan
In-Reply-To: <20230323093141.4070840-1-peng.fan@oss.nxp.com>
From: Peng Fan <peng.fan@nxp.com>
Add support for waking up from system wide suspend.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
drivers/input/keyboard/imx_sc_key.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/input/keyboard/imx_sc_key.c b/drivers/input/keyboard/imx_sc_key.c
index d18839f1f4f6..234f23cf9990 100644
--- a/drivers/input/keyboard/imx_sc_key.c
+++ b/drivers/input/keyboard/imx_sc_key.c
@@ -151,6 +151,8 @@ static int imx_sc_key_probe(struct platform_device *pdev)
priv->input = input;
platform_set_drvdata(pdev, priv);
+ device_init_wakeup(&pdev->dev, device_property_read_bool(&pdev->dev, "wakeup-source"));
+
error = imx_scu_irq_group_enable(SC_IRQ_GROUP_WAKE, SC_IRQ_BUTTON,
true);
if (error) {
--
2.37.1
^ permalink raw reply related
* Re: [PATCH v2 2/2] platform/x86: Add driver for Yoga Tablet Mode switch
From: Barnabás Pőcze @ 2023-03-23 12:05 UTC (permalink / raw)
To: Andrew Kallmeyer
Cc: platform-driver-x86, Gergo Koteles, Ike Panhc, linux-input,
Hans de Goede, Armin Wolf
In-Reply-To: <20230323025200.5462-3-kallmeyeras@gmail.com>
Hi
2023. március 23., csütörtök 3:52 keltezéssel, Andrew Kallmeyer <kallmeyeras@gmail.com> írta:
> From: Gergo Koteles <soyer@irl.hu>
>
> This WMI driver for the tablet mode control switch for Lenovo Yoga
> notebooks was originally written by Gergo Koteles. The mode is mapped to
> a SW_TABLET_MODE switch capable input device.
>
> Andrew followed the suggestions that were posted in reply to Gergo's RFC
> patch, and on the v1 version of this patch to follow-up and get it
> merged.
>
> Changes from Gergo's RFC:
>
> - Refactored obtaining a reference to the EC ACPI device needed for the
> quirk implementation as suggested by Hans de Goede
> - Applied small fixes and switched to devm_input_allocate_device() and
> removing input_unregister_device() as suggested by Barnabás Pőcze.
> - Merged the lenovo_ymc_trigger_ec function with the
> ideapad_trigger_ymc_next_read function since it was no longer
> external.
> - Added the word "Tablet" to the driver description to hopefully make
> it more clear.
> - Fixed the LENOVO_YMC_QUERY_METHOD ID and the name string for the EC
> APCI device trigged for the quirk
> - Triggered the input event on probe so that the initial tablet mode
> state when the driver is loaded is reported to userspace as suggested
> by Armin Wolf.
>
> We have tested this on the Yoga 7 14AIL7 for the non-quirk path and on
> the Yoga 7 14ARB7 which has the firmware bug that requires triggering
> the embedded controller to send the mode change events. This workaround
> is also used by the Windows drivers.
>
> According to reports at https://github.com/lukas-w/yoga-usage-mode,
> which uses the same WMI devices, the following models should also work:
> Yoga C940, Ideapad flex 14API, Yoga 9 14IAP7, Yoga 7 14ARB7, etc.
>
> Signed-off-by: Gergo Koteles <soyer@irl.hu>
> Co-developed-by: Andrew Kallmeyer <kallmeyeras@gmail.com>
> Signed-off-by: Andrew Kallmeyer <kallmeyeras@gmail.com>
> Link: https://lore.kernel.org/r/20221004214332.35934-1-soyer@irl.hu/
> Link: https://lore.kernel.org/platform-driver-x86/20230310041726.217447-1-kallmeyeras@gmail.com/
> ---
> [...]
> +struct lenovo_ymc_private {
> + struct input_dev *input_dev;
> + struct acpi_device *ec_acpi_dev;
> +};
> +
> +static void lenovo_ymc_trigger_ec(struct wmi_device *wdev, struct lenovo_ymc_private *priv)
> +{
> + int err;
> +
> + if (!ec_trigger || !priv || !priv->ec_acpi_dev)
I think just the `!priv->ec_acpi_dev` check is sufficient.
> + return;
> + err = write_ec_cmd(priv->ec_acpi_dev->handle, VPCCMD_W_YMC, 1);
> + if (err)
> + dev_warn(&wdev->dev, "Could not write YMC: %d\n", err);
> +}
> [...]
> +static int lenovo_ymc_probe(struct wmi_device *wdev, const void *ctx)
> +{
> + struct input_dev *input_dev;
> + struct lenovo_ymc_private *priv;
> + int err;
> +
> + ec_trigger |= dmi_check_system(ec_trigger_quirk_dmi_table);
> +
> + priv = devm_kzalloc(&wdev->dev, sizeof(*priv), GFP_KERNEL);
> + if (!priv)
> + return -ENOMEM;
> +
> + if (ec_trigger) {
> + pr_debug("Lenovo YMC enable EC triggering.\n");
> + priv->ec_acpi_dev = acpi_dev_get_first_match_dev("VPC2004", NULL, -1);
The reference is leaked in case of an error. Use `devm_add_action_or_reset()`:
static void acpi_dev_put_helper(void *p) { acpi_dev_put(p); }
[...]
priv->ec_acpi_dev = acpi_dev_get_first_match_dev("VPC2004", NULL, -1);
if (!priv->ec_acpi_dev)
...
err = devm_add_action_or_reset(&wdev->dev, acpi_dev_put_helper, priv->ec_acpi_dev)
if (err)
...
And then you can remove `lenovo_ymc_remove()` altogether.
> + if (!priv->ec_acpi_dev) {
> + dev_err(&wdev->dev, "Could not find EC ACPI device.\n");
> + return -ENODEV;
> + }
> + }
> +
> + input_dev = devm_input_allocate_device(&wdev->dev);
> + if (!input_dev)
> + return -ENOMEM;
> +
> + input_dev->name = "Lenovo Yoga Tablet Mode Control switch";
> + input_dev->phys = LENOVO_YMC_EVENT_GUID "/input0";
> + input_dev->id.bustype = BUS_HOST;
> + input_dev->dev.parent = &wdev->dev;
> +
> + input_set_capability(input_dev, EV_SW, SW_TABLET_MODE);
As far as I can tell `sparse_keymap_setup()` already sets the above.
> +
> + err = sparse_keymap_setup(input_dev, lenovo_ymc_keymap, NULL);
> + if (err) {
> + dev_err(&wdev->dev,
> + "Could not set up input device keymap: %d\n", err);
> + return err;
> + }
> +
> + err = input_register_device(input_dev);
> + if (err) {
> + dev_err(&wdev->dev,
> + "Could not register input device: %d\n", err);
> + return err;
> + }
> +
> + priv->input_dev = input_dev;
> + dev_set_drvdata(&wdev->dev, priv);
> +
> + // Report the state for the first time on probe
> + lenovo_ymc_trigger_ec(wdev, priv);
> + lenovo_ymc_notify(wdev, NULL);
> + return 0;
> +}
> [...]
Regards,
Barnabás Pőcze
^ permalink raw reply
* [PATCH 2/6] Input: cyttsp5: remove unused code
From: Maximilian Weigand @ 2023-03-23 13:52 UTC (permalink / raw)
To: Linus Walleij, Dmitry Torokhov, linux-input, linux-kernel,
devicetree
Cc: Maximilian Weigand, Alistair Francis
In-Reply-To: <20230323135205.1160879-1-mweigand@mweigand.net>
The removed lines were remnants of the android driver of the touch
screen and are not used in the current driver.
Signed-off-by: Maximilian Weigand <mweigand@mweigand.net>
Reviewed-by: Alistair Francis <alistair@alistair23.me>
---
drivers/input/touchscreen/cyttsp5.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/input/touchscreen/cyttsp5.c b/drivers/input/touchscreen/cyttsp5.c
index 42c7b44e37f8..8b0c6975c6ec 100644
--- a/drivers/input/touchscreen/cyttsp5.c
+++ b/drivers/input/touchscreen/cyttsp5.c
@@ -600,13 +600,9 @@ static int cyttsp5_get_hid_descriptor(struct cyttsp5 *ts,
struct cyttsp5_hid_desc *desc)
{
struct device *dev = ts->dev;
- __le16 hid_desc_register = cpu_to_le16(HID_DESC_REG);
int rc;
u8 cmd[2];
- /* Set HID descriptor register */
- memcpy(cmd, &hid_desc_register, sizeof(hid_desc_register));
-
rc = cyttsp5_write(ts, HID_DESC_REG, NULL, 0);
if (rc) {
dev_err(dev, "Failed to get HID descriptor, rc=%d\n", rc);
--
2.39.2
^ permalink raw reply related
* [PATCH 3/6] devicetree: input: cypress,tt21000: fix interrupt type in dts example
From: Maximilian Weigand @ 2023-03-23 13:52 UTC (permalink / raw)
To: Linus Walleij, Dmitry Torokhov, linux-input, linux-kernel,
devicetree
Cc: Maximilian Weigand, Alistair Francis
In-Reply-To: <20230323135205.1160879-1-mweigand@mweigand.net>
Triggering the interrupt of the IRQ_TYPE_LEVEL_LOW type can lead to
probing issues with the device for the current driver (encountered on
the Pine64 PineNote). Basically the interrupt would be triggered before
certain commands were sent to the device, leading to a race between the
device responding fast enough and the irq handler fetching a data frame
from it. Actually all devices currently using the driver already use a
falling edge trigger.
Signed-off-by: Maximilian Weigand <mweigand@mweigand.net>
Reviewed-by: Alistair Francis <alistair@alistair23.me>
---
.../devicetree/bindings/input/touchscreen/cypress,tt21000.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml b/Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml
index 1959ec394768..a77203c78d6e 100644
--- a/Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml
+++ b/Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml
@@ -83,7 +83,7 @@ examples:
pinctrl-names = "default";
pinctrl-0 = <&tp_reset_ds203>;
interrupt-parent = <&pio>;
- interrupts = <1 5 IRQ_TYPE_LEVEL_LOW>;
+ interrupts = <1 5 IRQ_TYPE_EDGE_FALLING>;
reset-gpios = <&pio 7 1 GPIO_ACTIVE_LOW>;
vdd-supply = <®_touch>;
--
2.39.2
^ permalink raw reply related
* [PATCH 6/6] Input: cyttsp5: implement proper sleep and wakeup procedures
From: Maximilian Weigand @ 2023-03-23 13:52 UTC (permalink / raw)
To: Linus Walleij, Dmitry Torokhov, linux-input, linux-kernel,
devicetree
Cc: Maximilian Weigand, Alistair Francis
In-Reply-To: <20230323135205.1160879-1-mweigand@mweigand.net>
The touchscreen can be put into a deep sleep state that prevents it from
emitting touch irqs. Put the touchscreen into deep sleep during suspend
if it is not marked as a wakeup source.
This also fixes a problem with the touchscreen getting unresponsive after
system resume because it pulled the interrupt line low during sleep in
response to a touch event, thereby effectively disabling the interrupt
handling (which triggers on the falling edge).
Signed-off-by: Maximilian Weigand <mweigand@mweigand.net>
Reviewed-by: Alistair Francis <alistair@alistair23.me>
---
drivers/input/touchscreen/cyttsp5.c | 129 +++++++++++++++++++++++++++-
1 file changed, 128 insertions(+), 1 deletion(-)
diff --git a/drivers/input/touchscreen/cyttsp5.c b/drivers/input/touchscreen/cyttsp5.c
index 01dd10a596ab..3e8387f6347c 100644
--- a/drivers/input/touchscreen/cyttsp5.c
+++ b/drivers/input/touchscreen/cyttsp5.c
@@ -43,6 +43,7 @@
#define HID_DESC_REG 0x1
#define HID_INPUT_REG 0x3
#define HID_OUTPUT_REG 0x4
+#define HID_COMMAND_REG 0x5
#define REPORT_ID_TOUCH 0x1
#define REPORT_ID_BTN 0x3
@@ -68,6 +69,7 @@
#define HID_APP_OUTPUT_REPORT_ID 0x2F
#define HID_BL_RESPONSE_REPORT_ID 0x30
#define HID_BL_OUTPUT_REPORT_ID 0x40
+#define HID_RESPONSE_REPORT_ID 0xF0
#define HID_OUTPUT_RESPONSE_REPORT_OFFSET 2
#define HID_OUTPUT_RESPONSE_CMD_OFFSET 4
@@ -78,9 +80,15 @@
#define HID_SYSINFO_BTN_MASK GENMASK(7, 0)
#define HID_SYSINFO_MAX_BTN 8
+#define HID_CMD_SET_POWER 0x8
+
+#define HID_POWER_ON 0x0
+#define HID_POWER_SLEEP 0x1
+
#define CY_HID_OUTPUT_TIMEOUT_MS 200
#define CY_HID_OUTPUT_GET_SYSINFO_TIMEOUT_MS 3000
#define CY_HID_GET_HID_DESCRIPTOR_TIMEOUT_MS 4000
+#define CY_HID_SET_POWER_TIMEOUT 500
/* maximum number of concurrent tracks */
#define TOUCH_REPORT_SIZE 10
@@ -100,6 +108,14 @@
#define TOUCH_REPORT_USAGE_PG_MIN 0xFF010063
#define TOUCH_COL_USAGE_PG 0x000D0022
+#define SET_CMD_LOW(byte, bits) \
+ ((byte) = (((byte) & 0xF0) | ((bits) & 0x0F)))
+#define SET_CMD_HIGH(byte, bits)\
+ ((byte) = (((byte) & 0x0F) | ((bits) & 0xF0)))
+#define SET_CMD_OPCODE(byte, opcode) SET_CMD_LOW(byte, opcode)
+#define SET_CMD_REPORT_TYPE(byte, type) SET_CMD_HIGH(byte, ((type) << 4))
+#define SET_CMD_REPORT_ID(byte, id) SET_CMD_LOW(byte, id)
+
/* System Information interface definitions */
struct cyttsp5_sensing_conf_data_dev {
u8 electrodes_x;
@@ -179,6 +195,7 @@ struct cyttsp5_hid_desc {
struct cyttsp5 {
struct device *dev;
struct completion cmd_done;
+ struct completion cmd_command_done;
struct cyttsp5_sysinfo sysinfo;
struct cyttsp5_hid_desc hid_desc;
u8 cmd_buf[CYTTSP5_PREALLOCATED_CMD_BUFFER];
@@ -191,6 +208,7 @@ struct cyttsp5 {
struct regmap *regmap;
struct touchscreen_properties prop;
struct regulator *vdd;
+ bool is_wakeup_source;
};
/*
@@ -556,6 +574,84 @@ static int cyttsp5_hid_output_get_sysinfo(struct cyttsp5 *ts)
return cyttsp5_get_sysinfo_regs(ts);
}
+static int cyttsp5_enter_sleep(struct cyttsp5 *ts)
+{
+ int rc;
+ u8 cmd[2];
+ u16 crc;
+
+ memset(cmd, 0, sizeof(cmd));
+
+ SET_CMD_REPORT_TYPE(cmd[0], 0);
+ SET_CMD_REPORT_ID(cmd[0], HID_POWER_SLEEP);
+ SET_CMD_OPCODE(cmd[1], HID_CMD_SET_POWER);
+
+ rc = cyttsp5_write(ts, HID_COMMAND_REG, cmd, 2);
+ if (rc) {
+ dev_err(ts->dev, "Failed to write command %d", rc);
+ return rc;
+ }
+
+ rc = wait_for_completion_interruptible_timeout(&ts->cmd_command_done,
+ msecs_to_jiffies(CY_HID_SET_POWER_TIMEOUT));
+ if (rc <= 0) {
+ dev_err(ts->dev, "HID output cmd execution timed out\n");
+ rc = -ETIMEDOUT;
+ return rc;
+ }
+
+ /* validate */
+ if ((ts->response_buf[2] != HID_RESPONSE_REPORT_ID)
+ || ((ts->response_buf[3] & 0x3) != HID_POWER_SLEEP)
+ || ((ts->response_buf[4] & 0xF) != HID_CMD_SET_POWER)) {
+ rc = -EINVAL;
+ dev_err(ts->dev, "Validation of the sleep response failed\n");
+ return rc;
+ }
+
+ return 0;
+
+}
+
+static int cyttsp5_wakeup(struct cyttsp5 *ts)
+{
+ int rc;
+ u8 cmd[2];
+ u16 crc;
+
+ memset(cmd, 0, sizeof(cmd));
+
+ SET_CMD_REPORT_TYPE(cmd[0], 0);
+ SET_CMD_REPORT_ID(cmd[0], HID_POWER_ON);
+ SET_CMD_OPCODE(cmd[1], HID_CMD_SET_POWER);
+
+ rc = cyttsp5_write(ts, HID_COMMAND_REG, cmd, 2);
+ if (rc) {
+ dev_err(ts->dev, "Failed to write command %d", rc);
+ return rc;
+ }
+
+ rc = wait_for_completion_interruptible_timeout(&ts->cmd_command_done,
+ msecs_to_jiffies(CY_HID_SET_POWER_TIMEOUT));
+ if (rc <= 0) {
+ dev_err(ts->dev, "HID output cmd execution timed out\n");
+ rc = -ETIMEDOUT;
+ return rc;
+ }
+
+ /* validate */
+ if ((ts->response_buf[2] != HID_RESPONSE_REPORT_ID)
+ || ((ts->response_buf[3] & 0x3) != HID_POWER_ON)
+ || ((ts->response_buf[4] & 0xF) != HID_CMD_SET_POWER)) {
+ rc = -EINVAL;
+ dev_err(ts->dev, "Validation of the sleep response failed\n");
+ return rc;
+ }
+
+ return 0;
+
+}
+
static int cyttsp5_hid_output_bl_launch_app(struct cyttsp5 *ts)
{
int rc;
@@ -670,6 +766,10 @@ static irqreturn_t cyttsp5_handle_irq(int irq, void *handle)
case HID_BTN_REPORT_ID:
cyttsp5_btn_attention(ts->dev);
break;
+ case HID_RESPONSE_REPORT_ID:
+ memcpy(ts->response_buf, ts->input_buf, size);
+ complete(&ts->cmd_command_done);
+ break;
default:
/* It is not an input but a command response */
memcpy(ts->response_buf, ts->input_buf, size);
@@ -784,6 +884,7 @@ static int cyttsp5_probe(struct device *dev, struct regmap *regmap, int irq,
dev_set_drvdata(dev, ts);
init_completion(&ts->cmd_done);
+ init_completion(&ts->cmd_command_done);
/* Power up the device */
ts->vdd = devm_regulator_get(dev, "vdd");
@@ -830,8 +931,11 @@ static int cyttsp5_probe(struct device *dev, struct regmap *regmap, int irq,
return error;
}
- if (device_property_read_bool(dev, "wakeup-source"))
+ if (device_property_read_bool(dev, "wakeup-source")) {
device_init_wakeup(dev, true);
+ ts->is_wakeup_source = true;
+ } else
+ ts->is_wakeup_source = false;
error = cyttsp5_startup(ts);
if (error) {
@@ -884,6 +988,29 @@ static const struct i2c_device_id cyttsp5_i2c_id[] = {
};
MODULE_DEVICE_TABLE(i2c, cyttsp5_i2c_id);
+static int __maybe_unused cyttsp5_suspend(struct device *dev)
+{
+ struct cyttsp5 *ts = dev_get_drvdata(dev);
+
+ if (!ts->is_wakeup_source)
+ cyttsp5_enter_sleep(ts);
+ return 0;
+}
+
+static int __maybe_unused cyttsp5_resume(struct device *dev)
+{
+ struct cyttsp5 *ts = dev_get_drvdata(dev);
+ struct i2c_client *client = to_i2c_client(dev);
+ int error;
+
+ if (!ts->is_wakeup_source)
+ cyttsp5_wakeup(ts);
+
+ return 0;
+}
+
+static SIMPLE_DEV_PM_OPS(cyttsp5_pm, cyttsp5_suspend, cyttsp5_resume);
+
static struct i2c_driver cyttsp5_i2c_driver = {
.driver = {
.name = CYTTSP5_NAME,
--
2.39.2
^ permalink raw reply related
* [PATCH 5/6] devicetree: input: cypress,tt21000: add wakeup-source entry to documentation
From: Maximilian Weigand @ 2023-03-23 13:52 UTC (permalink / raw)
To: Linus Walleij, Dmitry Torokhov, linux-input, linux-kernel,
devicetree
Cc: Maximilian Weigand, Alistair Francis
In-Reply-To: <20230323135205.1160879-1-mweigand@mweigand.net>
The touchscreen can be used to wake up systems from sleep and therefore
the wakeup-source entry should be included in the documentation.
Signed-off-by: Maximilian Weigand <mweigand@mweigand.net>
Reviewed-by: Alistair Francis <alistair@alistair23.me>
---
.../devicetree/bindings/input/touchscreen/cypress,tt21000.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml b/Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml
index a77203c78d6e..e2da13b7991d 100644
--- a/Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml
+++ b/Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml
@@ -40,6 +40,8 @@ properties:
linux,keycodes:
description: EV_ABS specific event code generated by the axis.
+ wakeup-source: true
+
patternProperties:
"^button@[0-9]+$":
type: object
--
2.39.2
^ permalink raw reply related
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox