* Re: [PATCH] input/touchscreen: synaptics_tcm_oncell: add driver
From: Dmitry Torokhov @ 2024-03-28 17:53 UTC (permalink / raw)
To: Frieder Hannenheim, Marge Yang; +Cc: linux-input, linux-kernel
In-Reply-To: <20240327214643.7055-1-friederhannenheim@riseup.net>
[ now CCing for real ]
Hi Frieder,
On Wed, Mar 27, 2024 at 10:39:12PM +0100, Frieder Hannenheim wrote:
> This is a bit of a stripped down and partially reworked driver for the
> synaptics_tcm_oncell touchscreen. I based my work off the driver in the
> LineageOS kernel found at
> https://github.com/LineageOS/android_kernel_oneplus_sm8250 branch
> lineage-20. The code was originally written by OnePlus developers but
> I'm not sure how to credit them correctly.
So the first question is: does this device not use Synaptics RMI4
protocol?
I am CCing Marge Yang of Synaptics who may shed some light on the kind
of touch controller this is.
Thanks.
--
Dmitry
^ permalink raw reply
* Re: [PATCH] Input: stmpe - drop driver owner assignment
From: Dmitry Torokhov @ 2024-03-28 17:54 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Maxime Coquelin, Alexandre Torgue, linux-input, linux-stm32,
linux-arm-kernel, linux-kernel
In-Reply-To: <20240327174655.519503-1-krzysztof.kozlowski@linaro.org>
On Wed, Mar 27, 2024 at 06:46:55PM +0100, Krzysztof Kozlowski wrote:
> Core in platform_driver_register() already sets the .owner, so driver
> does not need to.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Applied, thank you.
--
Dmitry
^ permalink raw reply
* Re: [PATCH 02/19] Input: atlas: - drop owner assignment
From: Dmitry Torokhov @ 2024-03-28 17:55 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rafael J. Wysocki, Len Brown, Robert Moore, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Benson Leung,
Tzung-Bi Shih, Corentin Chary, Luke D. Jones, Hans de Goede,
Ilpo Järvinen, Thadeu Lima de Souza Cascardo,
Daniel Oliveira Nascimento, Pali Rohár, Matan Ziv-Av,
Mattia Dongili, Azael Avalos, Richard Cochran, Jeff Sipek,
Ajay Kaher, Alexey Makhalov, VMware PV-Drivers Reviewers,
Theodore Ts'o, Jason A. Donenfeld, Rafael J. Wysocki,
linux-acpi, linux-kernel, acpica-devel, linux-input, netdev,
chrome-platform, platform-driver-x86
In-Reply-To: <20240327-b4-module-owner-acpi-v1-2-725241a2d224@linaro.org>
On Wed, Mar 27, 2024 at 08:43:49AM +0100, Krzysztof Kozlowski wrote:
> ACPI bus core already sets the .owner, so driver does not need to.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
But please fix the stray colon in the subject.
>
> ---
>
> Depends on the first patch.
> ---
> drivers/input/misc/atlas_btns.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/input/misc/atlas_btns.c b/drivers/input/misc/atlas_btns.c
> index 3c9bbd04e143..5b9be2957746 100644
> --- a/drivers/input/misc/atlas_btns.c
> +++ b/drivers/input/misc/atlas_btns.c
> @@ -127,7 +127,6 @@ MODULE_DEVICE_TABLE(acpi, atlas_device_ids);
> static struct acpi_driver atlas_acpi_driver = {
> .name = ACPI_ATLAS_NAME,
> .class = ACPI_ATLAS_CLASS,
> - .owner = THIS_MODULE,
> .ids = atlas_device_ids,
> .ops = {
> .add = atlas_acpi_button_add,
>
> --
> 2.34.1
>
--
Dmitry
^ permalink raw reply
* Re: [PATCH RFC 1/7] regulator: devres: add APIs for reference supplies
From: Dmitry Torokhov @ 2024-03-28 18:03 UTC (permalink / raw)
To: David Lechner
Cc: Jonathan Corbet, Liam Girdwood, Mark Brown, Jean Delvare,
Guenter Roeck, Support Opensource, Cosmin Tanislav,
Lars-Peter Clausen, Michael Hennerich, Jonathan Cameron,
Antoniu Miclaus, Greg Kroah-Hartman, linux-doc, linux-kernel,
linux-hwmon, linux-iio, linux-staging, linux-input
In-Reply-To: <20240327-regulator-get-enable-get-votlage-v1-1-5f4517faa059@baylibre.com>
On Wed, Mar 27, 2024 at 06:18:50PM -0500, David Lechner wrote:
> A common use case for regulators is to supply a reference voltage to an
> analog input or output device. This adds two new devres APIs to get,
> enable, and get the voltage in a single call. This allows eliminating
> boilerplate code in drivers that use reference supplies in this way.
>
> devm_regulator_get_enable_get_voltage() is intended for cases where the
> supply is required to provide an external reference voltage.
>
> devm_regulator_get_optional_enable_get_voltage() is intended for cases
> where the supply is optional and device typically uses an internal
> reference voltage if the supply is not available.
So because we decided that we could not have devm_regulator_enable()
because of (IMO) contrived example of someone totally mixing up the devm
and non-devm APIs we now have to make more and more devm- variants
simply because we do not have access to the regulator structure with
devm_regulator_get_enable() and so all normal APIs are not available.
This is quite bad honestly. Mark, could we please reverse this
shortsighted decision and have normal devm_regulator_enable() operating
on a regulator?
Thanks.
--
Dmitry
^ permalink raw reply
* Re: [PATCH v3] Input: xen-kbdfront - drop keys to shrink modalias
From: Dmitry Torokhov @ 2024-03-28 18:05 UTC (permalink / raw)
To: Jason Andryuk
Cc: linux-kernel, Phillip Susi, stable, Mattijs Korpershoek,
linux-input, xen-devel, Juergen Gross
In-Reply-To: <CAKf6xpv2oDpPB3wWh=Fz_ahDVgmvw2MSj_q3RYqQ8NG6km5Tuw@mail.gmail.com>
Hi Jason,
On Wed, Mar 20, 2024 at 01:42:27PM -0400, Jason Andryuk wrote:
> Hi Dmitry,
>
> Do you have any feedback, or can you pick up this patch? It solves a
> real issue affecting udev, which crashes the Debian installer and
> breaks the mouse for Gnome.
>
> Or would you be okay if this patch went in via the Xen tree?
I'd rather not. Could you please ping me in 2 weeks on this. I promise
we find a solution before the next release.
Thanks.
--
Dmitry
^ permalink raw reply
* Re: [PATCH v1 1/4] dt-bindings: input: Add Himax HX83102J touchscreen
From: Conor Dooley @ 2024-03-28 18:05 UTC (permalink / raw)
To: Allen Lin
Cc: Conor Dooley, Rob Herring, dmitry.torokhov,
krzysztof.kozlowski+dt, conor+dt, jikos, benjamin.tissoires,
linux-input, devicetree, linux-kernel
In-Reply-To: <TY0PR06MB5611F7123B22C4FDEE319C049E3B2@TY0PR06MB5611.apcprd06.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 1145 bytes --]
On Thu, Mar 28, 2024 at 02:05:17PM +0800, Allen Lin wrote:
> OK, I will list all supplies required by the driver in the Yaml
> document as shown below,
>
> properties:
> compatible:
> const: himax,hx83102j
>
> reg:
> maxItems: 1
>
> interrupts:
> maxItems: 1
>
> reset-gpios:
> maxItems: 1
>
> vccd-supply:
> description: A phandle for the regualtor supplying IO power.
>
> vsn-supply:
> description: Negative supply regulator.
>
> vsp-supply:
> description: Positive supply regulator.
>
> ddreset-gpios:
I think this should be s/dd// with the description explaining how this
display reset is related to this device.
Otherwise, this looks okay to me.
On another note - every time you reply to me I get it 3 times. Can you
fix that please?
Thanks,
Conor.
> description: A phandle of gpio for display reset controlled by the
> LCD driver.
>
> required:
> - compatible
> - reg
> - interrupts
> - reset-gpios
> - panel
> - vccd-supply
> - vsn-supply
> - vsp-supply
> - ddreset-gpios
>
>
> Thanks,
> Allen
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply
* Re: [PATCH 02/19] Input: atlas: - drop owner assignment
From: Krzysztof Kozlowski @ 2024-03-28 18:18 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Rafael J. Wysocki, Len Brown, Robert Moore, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Benson Leung,
Tzung-Bi Shih, Corentin Chary, Luke D. Jones, Hans de Goede,
Ilpo Järvinen, Thadeu Lima de Souza Cascardo,
Daniel Oliveira Nascimento, Pali Rohár, Matan Ziv-Av,
Mattia Dongili, Azael Avalos, Richard Cochran, Jeff Sipek,
Ajay Kaher, Alexey Makhalov, VMware PV-Drivers Reviewers,
Theodore Ts'o, Jason A. Donenfeld, Rafael J. Wysocki,
linux-acpi, linux-kernel, acpica-devel, linux-input, netdev,
chrome-platform, platform-driver-x86
In-Reply-To: <ZgWu-33aKyCOjRBX@google.com>
On 28/03/2024 18:55, Dmitry Torokhov wrote:
> On Wed, Mar 27, 2024 at 08:43:49AM +0100, Krzysztof Kozlowski wrote:
>> ACPI bus core already sets the .owner, so driver does not need to.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>
> But please fix the stray colon in the subject.
Ykes, sure. I will send a v2 today or tomorrow with collected tags, so
this could go via Rafael.
Best regards,
Krzysztof
^ permalink raw reply
* Re: [PATCH RFC 1/7] regulator: devres: add APIs for reference supplies
From: Mark Brown @ 2024-03-28 18:18 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: David Lechner, Jonathan Corbet, Liam Girdwood, Jean Delvare,
Guenter Roeck, Support Opensource, Cosmin Tanislav,
Lars-Peter Clausen, Michael Hennerich, Jonathan Cameron,
Antoniu Miclaus, Greg Kroah-Hartman, linux-doc, linux-kernel,
linux-hwmon, linux-iio, linux-staging, linux-input
In-Reply-To: <ZgWw66OpLnLPdCn-@google.com>
[-- Attachment #1: Type: text/plain, Size: 892 bytes --]
On Thu, Mar 28, 2024 at 11:03:23AM -0700, Dmitry Torokhov wrote:
> So because we decided that we could not have devm_regulator_enable()
> because of (IMO) contrived example of someone totally mixing up the devm
> and non-devm APIs we now have to make more and more devm- variants
> simply because we do not have access to the regulator structure with
> devm_regulator_get_enable() and so all normal APIs are not available.
I don't follow what you're saying here? What normal APIs are not
available? AFAICT this has nothing to do with a devm enable, it's a
combined operation which reports the voltage for the regulator if one is
available which would still be being added even if it used a devm
enable.
> This is quite bad honestly. Mark, could we please reverse this
> shortsighted decision and have normal devm_regulator_enable() operating
> on a regulator?
Nothing has changed here.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply
* [PATCH v2 00/19] ACPI: store owner from modules with acpi_bus_register_driver()
From: Krzysztof Kozlowski @ 2024-03-28 19:49 UTC (permalink / raw)
To: Rafael J. Wysocki, Len Brown, Robert Moore, Dmitry Torokhov,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Benson Leung, Tzung-Bi Shih, Corentin Chary, Luke D. Jones,
Hans de Goede, Ilpo Järvinen, Thadeu Lima de Souza Cascardo,
Pali Rohár, Matan Ziv-Av, Mattia Dongili, Azael Avalos,
Ajay Kaher, Alexey Makhalov, VMware PV-Drivers Reviewers,
Richard Cochran, Theodore Ts'o, Jason A. Donenfeld
Cc: linux-acpi, linux-kernel, acpica-devel, linux-input, netdev,
chrome-platform, platform-driver-x86, Rafael J. Wysocki,
Krzysztof Kozlowski
Changes in v2:
- Correct input and platform/chrome subjects.
- Add acks.
- Link to v1: https://lore.kernel.org/r/20240327-b4-module-owner-acpi-v1-0-725241a2d224@linaro.org
Merging
=======
All further patches depend on the first amba patch, therefore one way is
to ack and take it via one tree, e.g. ACPI.
Description
===========
Modules registering driver with acpi_bus_register_driver() often forget to
set .owner field.
Solve the problem by moving this task away from the drivers to the core
amba bus code, just like we did for platform_driver in commit
9447057eaff8 ("platform_device: use a macro instead of
platform_driver_register").
Best regards,
Krzysztof
---
Krzysztof Kozlowski (19):
ACPI: store owner from modules with acpi_bus_register_driver()
Input: atlas - drop owner assignment
net: fjes: drop owner assignment
platform/chrome: wilco_ec: drop owner assignment
platform: asus-laptop: drop owner assignment
platform: classmate-laptop: drop owner assignment
platform/x86/dell: drop owner assignment
platform/x86/eeepc: drop owner assignment
platform/x86/intel/rst: drop owner assignment
platform/x86/intel/smartconnect: drop owner assignment
platform/x86/lg-laptop: drop owner assignment
platform/x86/sony-laptop: drop owner assignment
platform/x86/toshiba_acpi: drop owner assignment
platform/x86/toshiba_bluetooth: drop owner assignment
platform/x86/toshiba_haps: drop owner assignment
platform/x86/wireless-hotkey: drop owner assignment
ptp: vmw: drop owner assignment
virt: vmgenid: drop owner assignment
ACPI: drop redundant owner from acpi_driver
drivers/acpi/bus.c | 9 +++++----
drivers/input/misc/atlas_btns.c | 1 -
drivers/net/fjes/fjes_main.c | 1 -
drivers/platform/chrome/wilco_ec/event.c | 1 -
drivers/platform/x86/asus-laptop.c | 1 -
drivers/platform/x86/classmate-laptop.c | 5 -----
drivers/platform/x86/dell/dell-rbtn.c | 1 -
drivers/platform/x86/eeepc-laptop.c | 1 -
drivers/platform/x86/intel/rst.c | 1 -
drivers/platform/x86/intel/smartconnect.c | 1 -
drivers/platform/x86/lg-laptop.c | 1 -
drivers/platform/x86/sony-laptop.c | 2 --
drivers/platform/x86/toshiba_acpi.c | 1 -
drivers/platform/x86/toshiba_bluetooth.c | 1 -
drivers/platform/x86/toshiba_haps.c | 1 -
drivers/platform/x86/wireless-hotkey.c | 1 -
drivers/ptp/ptp_vmw.c | 1 -
drivers/virt/vmgenid.c | 1 -
include/acpi/acpi_bus.h | 8 ++++++--
19 files changed, 11 insertions(+), 28 deletions(-)
---
base-commit: 02e345c7445b96358707ee2e5ca1dfc9b3458d39
change-id: 20240327-b4-module-owner-acpi-d4948a922351
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
^ permalink raw reply
* [PATCH v2 01/19] ACPI: store owner from modules with acpi_bus_register_driver()
From: Krzysztof Kozlowski @ 2024-03-28 19:49 UTC (permalink / raw)
To: Rafael J. Wysocki, Len Brown, Robert Moore, Dmitry Torokhov,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Benson Leung, Tzung-Bi Shih, Corentin Chary, Luke D. Jones,
Hans de Goede, Ilpo Järvinen, Thadeu Lima de Souza Cascardo,
Pali Rohár, Matan Ziv-Av, Mattia Dongili, Azael Avalos,
Ajay Kaher, Alexey Makhalov, VMware PV-Drivers Reviewers,
Richard Cochran, Theodore Ts'o, Jason A. Donenfeld
Cc: linux-acpi, linux-kernel, acpica-devel, linux-input, netdev,
chrome-platform, platform-driver-x86, Rafael J. Wysocki,
Krzysztof Kozlowski
In-Reply-To: <20240328-b4-module-owner-acpi-v2-0-1e5552c2c69f@linaro.org>
Modules registering driver with acpi_bus_register_driver() often forget to
set .owner field. The field is used by some of other kernel parts for
reference counting (try_module_get()), so it is expected that drivers
will set it.
Solve the problem by moving this task away from the drivers to the core
ACPI bus code, just like we did for platform_driver in
commit 9447057eaff8 ("platform_device: use a macro instead of
platform_driver_register").
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/acpi/bus.c | 9 +++++----
include/acpi/acpi_bus.h | 7 ++++++-
2 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
index d9fa730416f1..eda951032f3c 100644
--- a/drivers/acpi/bus.c
+++ b/drivers/acpi/bus.c
@@ -990,25 +990,26 @@ EXPORT_SYMBOL_GPL(acpi_driver_match_device);
-------------------------------------------------------------------------- */
/**
- * acpi_bus_register_driver - register a driver with the ACPI bus
+ * __acpi_bus_register_driver - register a driver with the ACPI bus
* @driver: driver being registered
+ * @owner: owning module/driver
*
* Registers a driver with the ACPI bus. Searches the namespace for all
* devices that match the driver's criteria and binds. Returns zero for
* success or a negative error status for failure.
*/
-int acpi_bus_register_driver(struct acpi_driver *driver)
+int __acpi_bus_register_driver(struct acpi_driver *driver, struct module *owner)
{
if (acpi_disabled)
return -ENODEV;
driver->drv.name = driver->name;
driver->drv.bus = &acpi_bus_type;
- driver->drv.owner = driver->owner;
+ driver->drv.owner = owner;
return driver_register(&driver->drv);
}
-EXPORT_SYMBOL(acpi_bus_register_driver);
+EXPORT_SYMBOL(__acpi_bus_register_driver);
/**
* acpi_bus_unregister_driver - unregisters a driver with the ACPI bus
diff --git a/include/acpi/acpi_bus.h b/include/acpi/acpi_bus.h
index 5de954e2b18a..7453be56f855 100644
--- a/include/acpi/acpi_bus.h
+++ b/include/acpi/acpi_bus.h
@@ -656,7 +656,12 @@ void acpi_scan_lock_release(void);
void acpi_lock_hp_context(void);
void acpi_unlock_hp_context(void);
int acpi_scan_add_handler(struct acpi_scan_handler *handler);
-int acpi_bus_register_driver(struct acpi_driver *driver);
+/*
+ * use a macro to avoid include chaining to get THIS_MODULE
+ */
+#define acpi_bus_register_driver(drv) \
+ __acpi_bus_register_driver(drv, THIS_MODULE)
+int __acpi_bus_register_driver(struct acpi_driver *driver, struct module *owner);
void acpi_bus_unregister_driver(struct acpi_driver *driver);
int acpi_bus_scan(acpi_handle handle);
void acpi_bus_trim(struct acpi_device *start);
--
2.34.1
^ permalink raw reply related
* [PATCH v2 02/19] Input: atlas - drop owner assignment
From: Krzysztof Kozlowski @ 2024-03-28 19:49 UTC (permalink / raw)
To: Rafael J. Wysocki, Len Brown, Robert Moore, Dmitry Torokhov,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Benson Leung, Tzung-Bi Shih, Corentin Chary, Luke D. Jones,
Hans de Goede, Ilpo Järvinen, Thadeu Lima de Souza Cascardo,
Pali Rohár, Matan Ziv-Av, Mattia Dongili, Azael Avalos,
Ajay Kaher, Alexey Makhalov, VMware PV-Drivers Reviewers,
Richard Cochran, Theodore Ts'o, Jason A. Donenfeld
Cc: linux-acpi, linux-kernel, acpica-devel, linux-input, netdev,
chrome-platform, platform-driver-x86, Rafael J. Wysocki,
Krzysztof Kozlowski
In-Reply-To: <20240328-b4-module-owner-acpi-v2-0-1e5552c2c69f@linaro.org>
ACPI bus core already sets the .owner, so driver does not need to.
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Depends on the first patch.
---
drivers/input/misc/atlas_btns.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/input/misc/atlas_btns.c b/drivers/input/misc/atlas_btns.c
index 3c9bbd04e143..5b9be2957746 100644
--- a/drivers/input/misc/atlas_btns.c
+++ b/drivers/input/misc/atlas_btns.c
@@ -127,7 +127,6 @@ MODULE_DEVICE_TABLE(acpi, atlas_device_ids);
static struct acpi_driver atlas_acpi_driver = {
.name = ACPI_ATLAS_NAME,
.class = ACPI_ATLAS_CLASS,
- .owner = THIS_MODULE,
.ids = atlas_device_ids,
.ops = {
.add = atlas_acpi_button_add,
--
2.34.1
^ permalink raw reply related
* [PATCH v2 03/19] net: fjes: drop owner assignment
From: Krzysztof Kozlowski @ 2024-03-28 19:49 UTC (permalink / raw)
To: Rafael J. Wysocki, Len Brown, Robert Moore, Dmitry Torokhov,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Benson Leung, Tzung-Bi Shih, Corentin Chary, Luke D. Jones,
Hans de Goede, Ilpo Järvinen, Thadeu Lima de Souza Cascardo,
Pali Rohár, Matan Ziv-Av, Mattia Dongili, Azael Avalos,
Ajay Kaher, Alexey Makhalov, VMware PV-Drivers Reviewers,
Richard Cochran, Theodore Ts'o, Jason A. Donenfeld
Cc: linux-acpi, linux-kernel, acpica-devel, linux-input, netdev,
chrome-platform, platform-driver-x86, Rafael J. Wysocki,
Krzysztof Kozlowski
In-Reply-To: <20240328-b4-module-owner-acpi-v2-0-1e5552c2c69f@linaro.org>
ACPI bus core already sets the .owner, so driver does not need to.
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Depends on the first patch.
---
drivers/net/fjes/fjes_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/fjes/fjes_main.c b/drivers/net/fjes/fjes_main.c
index 5fbe33a09bb0..324b34f3ac93 100644
--- a/drivers/net/fjes/fjes_main.c
+++ b/drivers/net/fjes/fjes_main.c
@@ -156,7 +156,6 @@ static void fjes_acpi_remove(struct acpi_device *device)
static struct acpi_driver fjes_acpi_driver = {
.name = DRV_NAME,
.class = DRV_NAME,
- .owner = THIS_MODULE,
.ids = fjes_acpi_ids,
.ops = {
.add = fjes_acpi_add,
--
2.34.1
^ permalink raw reply related
* [PATCH v2 04/19] platform/chrome: wilco_ec: drop owner assignment
From: Krzysztof Kozlowski @ 2024-03-28 19:49 UTC (permalink / raw)
To: Rafael J. Wysocki, Len Brown, Robert Moore, Dmitry Torokhov,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Benson Leung, Tzung-Bi Shih, Corentin Chary, Luke D. Jones,
Hans de Goede, Ilpo Järvinen, Thadeu Lima de Souza Cascardo,
Pali Rohár, Matan Ziv-Av, Mattia Dongili, Azael Avalos,
Ajay Kaher, Alexey Makhalov, VMware PV-Drivers Reviewers,
Richard Cochran, Theodore Ts'o, Jason A. Donenfeld
Cc: linux-acpi, linux-kernel, acpica-devel, linux-input, netdev,
chrome-platform, platform-driver-x86, Rafael J. Wysocki,
Krzysztof Kozlowski
In-Reply-To: <20240328-b4-module-owner-acpi-v2-0-1e5552c2c69f@linaro.org>
ACPI bus core already sets the .owner, so driver does not need to.
Acked-by: Tzung-Bi Shih <tzungbi@kernel.org>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Depends on the first patch.
---
drivers/platform/chrome/wilco_ec/event.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/platform/chrome/wilco_ec/event.c b/drivers/platform/chrome/wilco_ec/event.c
index 13291fb4214e..ae34e81c5d18 100644
--- a/drivers/platform/chrome/wilco_ec/event.c
+++ b/drivers/platform/chrome/wilco_ec/event.c
@@ -523,7 +523,6 @@ static struct acpi_driver event_driver = {
.notify = event_device_notify,
.remove = event_device_remove,
},
- .owner = THIS_MODULE,
};
static int __init event_module_init(void)
--
2.34.1
^ permalink raw reply related
* [PATCH v2 05/19] platform: asus-laptop: drop owner assignment
From: Krzysztof Kozlowski @ 2024-03-28 19:49 UTC (permalink / raw)
To: Rafael J. Wysocki, Len Brown, Robert Moore, Dmitry Torokhov,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Benson Leung, Tzung-Bi Shih, Corentin Chary, Luke D. Jones,
Hans de Goede, Ilpo Järvinen, Thadeu Lima de Souza Cascardo,
Pali Rohár, Matan Ziv-Av, Mattia Dongili, Azael Avalos,
Ajay Kaher, Alexey Makhalov, VMware PV-Drivers Reviewers,
Richard Cochran, Theodore Ts'o, Jason A. Donenfeld
Cc: linux-acpi, linux-kernel, acpica-devel, linux-input, netdev,
chrome-platform, platform-driver-x86, Rafael J. Wysocki,
Krzysztof Kozlowski
In-Reply-To: <20240328-b4-module-owner-acpi-v2-0-1e5552c2c69f@linaro.org>
ACPI bus core already sets the .owner, so driver does not need to.
Acked-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Depends on the first patch.
---
drivers/platform/x86/asus-laptop.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c
index bf03ea1b1274..78c42767295a 100644
--- a/drivers/platform/x86/asus-laptop.c
+++ b/drivers/platform/x86/asus-laptop.c
@@ -1925,7 +1925,6 @@ MODULE_DEVICE_TABLE(acpi, asus_device_ids);
static struct acpi_driver asus_acpi_driver = {
.name = ASUS_LAPTOP_NAME,
.class = ASUS_LAPTOP_CLASS,
- .owner = THIS_MODULE,
.ids = asus_device_ids,
.flags = ACPI_DRIVER_ALL_NOTIFY_EVENTS,
.ops = {
--
2.34.1
^ permalink raw reply related
* [PATCH v2 06/19] platform: classmate-laptop: drop owner assignment
From: Krzysztof Kozlowski @ 2024-03-28 19:49 UTC (permalink / raw)
To: Rafael J. Wysocki, Len Brown, Robert Moore, Dmitry Torokhov,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Benson Leung, Tzung-Bi Shih, Corentin Chary, Luke D. Jones,
Hans de Goede, Ilpo Järvinen, Thadeu Lima de Souza Cascardo,
Pali Rohár, Matan Ziv-Av, Mattia Dongili, Azael Avalos,
Ajay Kaher, Alexey Makhalov, VMware PV-Drivers Reviewers,
Richard Cochran, Theodore Ts'o, Jason A. Donenfeld
Cc: linux-acpi, linux-kernel, acpica-devel, linux-input, netdev,
chrome-platform, platform-driver-x86, Rafael J. Wysocki,
Krzysztof Kozlowski
In-Reply-To: <20240328-b4-module-owner-acpi-v2-0-1e5552c2c69f@linaro.org>
ACPI bus core already sets the .owner, so driver does not need to.
Acked-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Acked-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/platform/x86/classmate-laptop.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/platform/x86/classmate-laptop.c b/drivers/platform/x86/classmate-laptop.c
index 2edaea2492df..87462e7c6219 100644
--- a/drivers/platform/x86/classmate-laptop.c
+++ b/drivers/platform/x86/classmate-laptop.c
@@ -434,7 +434,6 @@ static const struct acpi_device_id cmpc_accel_device_ids_v4[] = {
};
static struct acpi_driver cmpc_accel_acpi_driver_v4 = {
- .owner = THIS_MODULE,
.name = "cmpc_accel_v4",
.class = "cmpc_accel_v4",
.ids = cmpc_accel_device_ids_v4,
@@ -660,7 +659,6 @@ static const struct acpi_device_id cmpc_accel_device_ids[] = {
};
static struct acpi_driver cmpc_accel_acpi_driver = {
- .owner = THIS_MODULE,
.name = "cmpc_accel",
.class = "cmpc_accel",
.ids = cmpc_accel_device_ids,
@@ -754,7 +752,6 @@ static const struct acpi_device_id cmpc_tablet_device_ids[] = {
};
static struct acpi_driver cmpc_tablet_acpi_driver = {
- .owner = THIS_MODULE,
.name = "cmpc_tablet",
.class = "cmpc_tablet",
.ids = cmpc_tablet_device_ids,
@@ -996,7 +993,6 @@ static const struct acpi_device_id cmpc_ipml_device_ids[] = {
};
static struct acpi_driver cmpc_ipml_acpi_driver = {
- .owner = THIS_MODULE,
.name = "cmpc",
.class = "cmpc",
.ids = cmpc_ipml_device_ids,
@@ -1064,7 +1060,6 @@ static const struct acpi_device_id cmpc_keys_device_ids[] = {
};
static struct acpi_driver cmpc_keys_acpi_driver = {
- .owner = THIS_MODULE,
.name = "cmpc_keys",
.class = "cmpc_keys",
.ids = cmpc_keys_device_ids,
--
2.34.1
^ permalink raw reply related
* [PATCH v2 07/19] platform/x86/dell: drop owner assignment
From: Krzysztof Kozlowski @ 2024-03-28 19:49 UTC (permalink / raw)
To: Rafael J. Wysocki, Len Brown, Robert Moore, Dmitry Torokhov,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Benson Leung, Tzung-Bi Shih, Corentin Chary, Luke D. Jones,
Hans de Goede, Ilpo Järvinen, Thadeu Lima de Souza Cascardo,
Pali Rohár, Matan Ziv-Av, Mattia Dongili, Azael Avalos,
Ajay Kaher, Alexey Makhalov, VMware PV-Drivers Reviewers,
Richard Cochran, Theodore Ts'o, Jason A. Donenfeld
Cc: linux-acpi, linux-kernel, acpica-devel, linux-input, netdev,
chrome-platform, platform-driver-x86, Rafael J. Wysocki,
Krzysztof Kozlowski
In-Reply-To: <20240328-b4-module-owner-acpi-v2-0-1e5552c2c69f@linaro.org>
ACPI bus core already sets the .owner, so driver does not need to.
Acked-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/platform/x86/dell/dell-rbtn.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/platform/x86/dell/dell-rbtn.c b/drivers/platform/x86/dell/dell-rbtn.c
index c8fcb537fd65..a415c432d4c3 100644
--- a/drivers/platform/x86/dell/dell-rbtn.c
+++ b/drivers/platform/x86/dell/dell-rbtn.c
@@ -295,7 +295,6 @@ static struct acpi_driver rbtn_driver = {
.remove = rbtn_remove,
.notify = rbtn_notify,
},
- .owner = THIS_MODULE,
};
--
2.34.1
^ permalink raw reply related
* [PATCH v2 08/19] platform/x86/eeepc: drop owner assignment
From: Krzysztof Kozlowski @ 2024-03-28 19:49 UTC (permalink / raw)
To: Rafael J. Wysocki, Len Brown, Robert Moore, Dmitry Torokhov,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Benson Leung, Tzung-Bi Shih, Corentin Chary, Luke D. Jones,
Hans de Goede, Ilpo Järvinen, Thadeu Lima de Souza Cascardo,
Pali Rohár, Matan Ziv-Av, Mattia Dongili, Azael Avalos,
Ajay Kaher, Alexey Makhalov, VMware PV-Drivers Reviewers,
Richard Cochran, Theodore Ts'o, Jason A. Donenfeld
Cc: linux-acpi, linux-kernel, acpica-devel, linux-input, netdev,
chrome-platform, platform-driver-x86, Rafael J. Wysocki,
Krzysztof Kozlowski
In-Reply-To: <20240328-b4-module-owner-acpi-v2-0-1e5552c2c69f@linaro.org>
ACPI bus core already sets the .owner, so driver does not need to.
Acked-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/platform/x86/eeepc-laptop.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/platform/x86/eeepc-laptop.c b/drivers/platform/x86/eeepc-laptop.c
index ff1b70269ccb..447364bed249 100644
--- a/drivers/platform/x86/eeepc-laptop.c
+++ b/drivers/platform/x86/eeepc-laptop.c
@@ -1463,7 +1463,6 @@ MODULE_DEVICE_TABLE(acpi, eeepc_device_ids);
static struct acpi_driver eeepc_acpi_driver = {
.name = EEEPC_LAPTOP_NAME,
.class = EEEPC_ACPI_CLASS,
- .owner = THIS_MODULE,
.ids = eeepc_device_ids,
.flags = ACPI_DRIVER_ALL_NOTIFY_EVENTS,
.ops = {
--
2.34.1
^ permalink raw reply related
* [PATCH v2 09/19] platform/x86/intel/rst: drop owner assignment
From: Krzysztof Kozlowski @ 2024-03-28 19:49 UTC (permalink / raw)
To: Rafael J. Wysocki, Len Brown, Robert Moore, Dmitry Torokhov,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Benson Leung, Tzung-Bi Shih, Corentin Chary, Luke D. Jones,
Hans de Goede, Ilpo Järvinen, Thadeu Lima de Souza Cascardo,
Pali Rohár, Matan Ziv-Av, Mattia Dongili, Azael Avalos,
Ajay Kaher, Alexey Makhalov, VMware PV-Drivers Reviewers,
Richard Cochran, Theodore Ts'o, Jason A. Donenfeld
Cc: linux-acpi, linux-kernel, acpica-devel, linux-input, netdev,
chrome-platform, platform-driver-x86, Rafael J. Wysocki,
Krzysztof Kozlowski
In-Reply-To: <20240328-b4-module-owner-acpi-v2-0-1e5552c2c69f@linaro.org>
ACPI bus core already sets the .owner, so driver does not need to.
Acked-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/platform/x86/intel/rst.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/platform/x86/intel/rst.c b/drivers/platform/x86/intel/rst.c
index 35814a7707af..6bc9c4a603e0 100644
--- a/drivers/platform/x86/intel/rst.c
+++ b/drivers/platform/x86/intel/rst.c
@@ -125,7 +125,6 @@ static const struct acpi_device_id irst_ids[] = {
};
static struct acpi_driver irst_driver = {
- .owner = THIS_MODULE,
.name = "intel_rapid_start",
.class = "intel_rapid_start",
.ids = irst_ids,
--
2.34.1
^ permalink raw reply related
* [PATCH v2 10/19] platform/x86/intel/smartconnect: drop owner assignment
From: Krzysztof Kozlowski @ 2024-03-28 19:49 UTC (permalink / raw)
To: Rafael J. Wysocki, Len Brown, Robert Moore, Dmitry Torokhov,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Benson Leung, Tzung-Bi Shih, Corentin Chary, Luke D. Jones,
Hans de Goede, Ilpo Järvinen, Thadeu Lima de Souza Cascardo,
Pali Rohár, Matan Ziv-Av, Mattia Dongili, Azael Avalos,
Ajay Kaher, Alexey Makhalov, VMware PV-Drivers Reviewers,
Richard Cochran, Theodore Ts'o, Jason A. Donenfeld
Cc: linux-acpi, linux-kernel, acpica-devel, linux-input, netdev,
chrome-platform, platform-driver-x86, Rafael J. Wysocki,
Krzysztof Kozlowski
In-Reply-To: <20240328-b4-module-owner-acpi-v2-0-1e5552c2c69f@linaro.org>
ACPI bus core already sets the .owner, so driver does not need to.
Acked-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/platform/x86/intel/smartconnect.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/platform/x86/intel/smartconnect.c b/drivers/platform/x86/intel/smartconnect.c
index 64c2dc93472f..cd25d0585324 100644
--- a/drivers/platform/x86/intel/smartconnect.c
+++ b/drivers/platform/x86/intel/smartconnect.c
@@ -32,7 +32,6 @@ static const struct acpi_device_id smartconnect_ids[] = {
MODULE_DEVICE_TABLE(acpi, smartconnect_ids);
static struct acpi_driver smartconnect_driver = {
- .owner = THIS_MODULE,
.name = "intel_smart_connect",
.class = "intel_smart_connect",
.ids = smartconnect_ids,
--
2.34.1
^ permalink raw reply related
* [PATCH v2 11/19] platform/x86/lg-laptop: drop owner assignment
From: Krzysztof Kozlowski @ 2024-03-28 19:49 UTC (permalink / raw)
To: Rafael J. Wysocki, Len Brown, Robert Moore, Dmitry Torokhov,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Benson Leung, Tzung-Bi Shih, Corentin Chary, Luke D. Jones,
Hans de Goede, Ilpo Järvinen, Thadeu Lima de Souza Cascardo,
Pali Rohár, Matan Ziv-Av, Mattia Dongili, Azael Avalos,
Ajay Kaher, Alexey Makhalov, VMware PV-Drivers Reviewers,
Richard Cochran, Theodore Ts'o, Jason A. Donenfeld
Cc: linux-acpi, linux-kernel, acpica-devel, linux-input, netdev,
chrome-platform, platform-driver-x86, Rafael J. Wysocki,
Krzysztof Kozlowski
In-Reply-To: <20240328-b4-module-owner-acpi-v2-0-1e5552c2c69f@linaro.org>
ACPI bus core already sets the .owner, so driver does not need to.
Acked-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/platform/x86/lg-laptop.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/platform/x86/lg-laptop.c b/drivers/platform/x86/lg-laptop.c
index ad3c39e9e9f5..36e88b9d59ea 100644
--- a/drivers/platform/x86/lg-laptop.c
+++ b/drivers/platform/x86/lg-laptop.c
@@ -790,7 +790,6 @@ static struct acpi_driver acpi_driver = {
.remove = acpi_remove,
.notify = acpi_notify,
},
- .owner = THIS_MODULE,
};
static int __init acpi_init(void)
--
2.34.1
^ permalink raw reply related
* [PATCH v2 12/19] platform/x86/sony-laptop: drop owner assignment
From: Krzysztof Kozlowski @ 2024-03-28 19:49 UTC (permalink / raw)
To: Rafael J. Wysocki, Len Brown, Robert Moore, Dmitry Torokhov,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Benson Leung, Tzung-Bi Shih, Corentin Chary, Luke D. Jones,
Hans de Goede, Ilpo Järvinen, Thadeu Lima de Souza Cascardo,
Pali Rohár, Matan Ziv-Av, Mattia Dongili, Azael Avalos,
Ajay Kaher, Alexey Makhalov, VMware PV-Drivers Reviewers,
Richard Cochran, Theodore Ts'o, Jason A. Donenfeld
Cc: linux-acpi, linux-kernel, acpica-devel, linux-input, netdev,
chrome-platform, platform-driver-x86, Rafael J. Wysocki,
Krzysztof Kozlowski
In-Reply-To: <20240328-b4-module-owner-acpi-v2-0-1e5552c2c69f@linaro.org>
ACPI bus core already sets the .owner, so driver does not need to.
Acked-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/platform/x86/sony-laptop.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c
index 40878e327afd..3e94fdd1ea52 100644
--- a/drivers/platform/x86/sony-laptop.c
+++ b/drivers/platform/x86/sony-laptop.c
@@ -3303,7 +3303,6 @@ static struct acpi_driver sony_nc_driver = {
.name = SONY_NC_DRIVER_NAME,
.class = SONY_NC_CLASS,
.ids = sony_nc_device_ids,
- .owner = THIS_MODULE,
.ops = {
.add = sony_nc_add,
.remove = sony_nc_remove,
@@ -4844,7 +4843,6 @@ static struct acpi_driver sony_pic_driver = {
.name = SONY_PIC_DRIVER_NAME,
.class = SONY_PIC_CLASS,
.ids = sony_pic_device_ids,
- .owner = THIS_MODULE,
.ops = {
.add = sony_pic_add,
.remove = sony_pic_remove,
--
2.34.1
^ permalink raw reply related
* [PATCH v2 13/19] platform/x86/toshiba_acpi: drop owner assignment
From: Krzysztof Kozlowski @ 2024-03-28 19:49 UTC (permalink / raw)
To: Rafael J. Wysocki, Len Brown, Robert Moore, Dmitry Torokhov,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Benson Leung, Tzung-Bi Shih, Corentin Chary, Luke D. Jones,
Hans de Goede, Ilpo Järvinen, Thadeu Lima de Souza Cascardo,
Pali Rohár, Matan Ziv-Av, Mattia Dongili, Azael Avalos,
Ajay Kaher, Alexey Makhalov, VMware PV-Drivers Reviewers,
Richard Cochran, Theodore Ts'o, Jason A. Donenfeld
Cc: linux-acpi, linux-kernel, acpica-devel, linux-input, netdev,
chrome-platform, platform-driver-x86, Rafael J. Wysocki,
Krzysztof Kozlowski
In-Reply-To: <20240328-b4-module-owner-acpi-v2-0-1e5552c2c69f@linaro.org>
ACPI bus core already sets the .owner, so driver does not need to.
Acked-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/platform/x86/toshiba_acpi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c
index 291f14ef6702..6f9bd675f044 100644
--- a/drivers/platform/x86/toshiba_acpi.c
+++ b/drivers/platform/x86/toshiba_acpi.c
@@ -3581,7 +3581,6 @@ static SIMPLE_DEV_PM_OPS(toshiba_acpi_pm,
static struct acpi_driver toshiba_acpi_driver = {
.name = "Toshiba ACPI driver",
- .owner = THIS_MODULE,
.ids = toshiba_device_ids,
.flags = ACPI_DRIVER_ALL_NOTIFY_EVENTS,
.ops = {
--
2.34.1
^ permalink raw reply related
* [PATCH v2 14/19] platform/x86/toshiba_bluetooth: drop owner assignment
From: Krzysztof Kozlowski @ 2024-03-28 19:49 UTC (permalink / raw)
To: Rafael J. Wysocki, Len Brown, Robert Moore, Dmitry Torokhov,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Benson Leung, Tzung-Bi Shih, Corentin Chary, Luke D. Jones,
Hans de Goede, Ilpo Järvinen, Thadeu Lima de Souza Cascardo,
Pali Rohár, Matan Ziv-Av, Mattia Dongili, Azael Avalos,
Ajay Kaher, Alexey Makhalov, VMware PV-Drivers Reviewers,
Richard Cochran, Theodore Ts'o, Jason A. Donenfeld
Cc: linux-acpi, linux-kernel, acpica-devel, linux-input, netdev,
chrome-platform, platform-driver-x86, Rafael J. Wysocki,
Krzysztof Kozlowski
In-Reply-To: <20240328-b4-module-owner-acpi-v2-0-1e5552c2c69f@linaro.org>
ACPI bus core already sets the .owner, so driver does not need to.
Acked-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/platform/x86/toshiba_bluetooth.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/platform/x86/toshiba_bluetooth.c b/drivers/platform/x86/toshiba_bluetooth.c
index d8f81962a240..dad2c3e55904 100644
--- a/drivers/platform/x86/toshiba_bluetooth.c
+++ b/drivers/platform/x86/toshiba_bluetooth.c
@@ -59,7 +59,6 @@ static struct acpi_driver toshiba_bt_rfkill_driver = {
.remove = toshiba_bt_rfkill_remove,
.notify = toshiba_bt_rfkill_notify,
},
- .owner = THIS_MODULE,
.drv.pm = &toshiba_bt_pm,
};
--
2.34.1
^ permalink raw reply related
* [PATCH v2 15/19] platform/x86/toshiba_haps: drop owner assignment
From: Krzysztof Kozlowski @ 2024-03-28 19:49 UTC (permalink / raw)
To: Rafael J. Wysocki, Len Brown, Robert Moore, Dmitry Torokhov,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Benson Leung, Tzung-Bi Shih, Corentin Chary, Luke D. Jones,
Hans de Goede, Ilpo Järvinen, Thadeu Lima de Souza Cascardo,
Pali Rohár, Matan Ziv-Av, Mattia Dongili, Azael Avalos,
Ajay Kaher, Alexey Makhalov, VMware PV-Drivers Reviewers,
Richard Cochran, Theodore Ts'o, Jason A. Donenfeld
Cc: linux-acpi, linux-kernel, acpica-devel, linux-input, netdev,
chrome-platform, platform-driver-x86, Rafael J. Wysocki,
Krzysztof Kozlowski
In-Reply-To: <20240328-b4-module-owner-acpi-v2-0-1e5552c2c69f@linaro.org>
ACPI bus core already sets the .owner, so driver does not need to.
Acked-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/platform/x86/toshiba_haps.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/platform/x86/toshiba_haps.c b/drivers/platform/x86/toshiba_haps.c
index 8c9f76286b08..03dfddeee0c0 100644
--- a/drivers/platform/x86/toshiba_haps.c
+++ b/drivers/platform/x86/toshiba_haps.c
@@ -251,7 +251,6 @@ MODULE_DEVICE_TABLE(acpi, haps_device_ids);
static struct acpi_driver toshiba_haps_driver = {
.name = "Toshiba HAPS",
- .owner = THIS_MODULE,
.ids = haps_device_ids,
.flags = ACPI_DRIVER_ALL_NOTIFY_EVENTS,
.ops = {
--
2.34.1
^ permalink raw reply related
* [PATCH v2 16/19] platform/x86/wireless-hotkey: drop owner assignment
From: Krzysztof Kozlowski @ 2024-03-28 19:49 UTC (permalink / raw)
To: Rafael J. Wysocki, Len Brown, Robert Moore, Dmitry Torokhov,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Benson Leung, Tzung-Bi Shih, Corentin Chary, Luke D. Jones,
Hans de Goede, Ilpo Järvinen, Thadeu Lima de Souza Cascardo,
Pali Rohár, Matan Ziv-Av, Mattia Dongili, Azael Avalos,
Ajay Kaher, Alexey Makhalov, VMware PV-Drivers Reviewers,
Richard Cochran, Theodore Ts'o, Jason A. Donenfeld
Cc: linux-acpi, linux-kernel, acpica-devel, linux-input, netdev,
chrome-platform, platform-driver-x86, Rafael J. Wysocki,
Krzysztof Kozlowski
In-Reply-To: <20240328-b4-module-owner-acpi-v2-0-1e5552c2c69f@linaro.org>
ACPI bus core already sets the .owner, so driver does not need to.
Acked-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/platform/x86/wireless-hotkey.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/platform/x86/wireless-hotkey.c b/drivers/platform/x86/wireless-hotkey.c
index 4422863f47bb..e95cdbbfb708 100644
--- a/drivers/platform/x86/wireless-hotkey.c
+++ b/drivers/platform/x86/wireless-hotkey.c
@@ -110,7 +110,6 @@ static void wl_remove(struct acpi_device *device)
static struct acpi_driver wl_driver = {
.name = "wireless-hotkey",
- .owner = THIS_MODULE,
.ids = wl_ids,
.ops = {
.add = wl_add,
--
2.34.1
^ permalink raw reply related
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox