* Lenovo Ideapad and hid-multitouch
From: Luigi Baldoni @ 2024-08-30 13:23 UTC (permalink / raw)
To: linux-input; +Cc: Benjamin Tissoires, Stephane Chatty
Hello everyone,
I've had a problem with the touchpad on my Lenovo Ideapad laptop since buying it, namely
it's way too sensitive and this results in fake clicks and jumpy behaviour overall.
Libinput people told me there's nothing they can do (https://gitlab.freedesktop.org/libinput/libinput/-/issues/946)
and referred me to this mailing list.
Do you see a potential margin of improvement here?
If there's any further test I could run or experimental drivers to try, please tell me.
Thanks
^ permalink raw reply
* RE: [PATCH RESEND v11 0/3] adp5588-keys: Support for dedicated gpio operation
From: Agarwal, Utsav @ 2024-08-30 11:50 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Hennerich, Michael, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Sa, Nuno, linux-input@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Artamonovs, Arturs, Bimpikas, Vasileios, Gaskell, Oliver,
Conor Dooley
In-Reply-To: <ZtC_kx1lty1jeKH8@google.com>
> -----Original Message-----
> From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Sent: Thursday, August 29, 2024 7:36 PM
> To: Agarwal, Utsav <Utsav.Agarwal@analog.com>
> Cc: Hennerich, Michael <Michael.Hennerich@analog.com>; Rob Herring
> <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley
> <conor+dt@kernel.org>; Sa, Nuno <Nuno.Sa@analog.com>; linux-
> input@vger.kernel.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org; Artamonovs, Arturs
> <Arturs.Artamonovs@analog.com>; Bimpikas, Vasileios
> <Vasileios.Bimpikas@analog.com>; Gaskell, Oliver
> <Oliver.Gaskell@analog.com>; Conor Dooley <conor.dooley@microchip.com>
> Subject: Re: [PATCH RESEND v11 0/3] adp5588-keys: Support for dedicated gpio
> operation
>
> [External]
>
> On Mon, Aug 26, 2024 at 06:22:00PM +0100, Utsav Agarwal via B4 Relay wrote:
> > Current state of the driver for the ADP5588/87 only allows partial
> > I/O to be used as GPIO. This support was previously present as a
> > separate gpio driver, which was dropped with the commit
> > 5ddc896088b0 ("gpio: gpio-adp5588: drop the driver") since the
> > functionality was deemed to have been merged with adp5588-keys.
> >
> > This series of patches re-enables this support by allowing the driver to
> > relax the requirement for registering a keymap and enable pure GPIO
> > operation.
> >
> > Signed-off-by: Utsav Agarwal <utsav.agarwal@analog.com>
>
> Applied the series after squashing in additional changes discussed in
> patch #2, thank you.
>
> --
> Dmitry
Thank you!
- Utsav
^ permalink raw reply
* Re: [PATCH v8 0/7] firmware: support i.MX95 SCMI BBM/MISC Extenstion
From: Sudeep Holla @ 2024-08-30 11:12 UTC (permalink / raw)
To: Cristian Marussi, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Peng Fan, Alexandre Belloni, Dmitry Torokhov, Peng Fan (OSS)
Cc: Sudeep Holla, arm-scmi, linux-arm-kernel, devicetree,
linux-kernel, imx, linux-rtc, linux-input
In-Reply-To: <20240823-imx95-bbm-misc-v2-v8-0-e600ed9e9271@nxp.com>
On Fri, 23 Aug 2024 17:05:16 +0800, Peng Fan (OSS) wrote:
> i.MX95 System Manager Firmware source: https://github.com/nxp-imx/imx-sm
> To generate html from the repo: make html
>
> i.MX95 System Manager Firmware support vendor extension protocol:
> - Battery Backed Module(BBM) Protocol
> This protocol is intended provide access to the battery-backed module.
> This contains persistent storage (GPR), an RTC, and the ON/OFF button.
> The protocol can also provide access to similar functions implemented via
> external board components. The BBM protocol provides functions to:
>
> [...]
Applied to sudeep.holla/linux (for-next/scmi/updates), thanks!
(with various minor changes to fix the build and sparse errors reported)
[1/7] dt-bindings: firmware: add i.MX95 SCMI Extension protocol
https://git.kernel.org/sudeep.holla/c/7d2b23fda996
[2/7] firmware: arm_scmi: add initial support for i.MX BBM protocol
https://git.kernel.org/sudeep.holla/c/41845541adeb
[3/7] firmware: arm_scmi: add initial support for i.MX MISC protocol
https://git.kernel.org/sudeep.holla/c/61c9f03e22fc
[4/7] firmware: arm_scmi: add NXP i.MX95 SCMI documentation
https://git.kernel.org/sudeep.holla/c/c66beeab7436
[5/7] firmware: imx: add i.MX95 MISC driver
https://git.kernel.org/sudeep.holla/c/0b4f8a68b292
[6/7] rtc: support i.MX95 BBM RTC
https://git.kernel.org/sudeep.holla/c/3008598ef3b0
[7/7] input: keyboard: support i.MX95 BBM module
https://git.kernel.org/sudeep.holla/c/d17baf052cbb
--
Regards,
Sudeep
^ permalink raw reply
* Re: [PATCH v8 6/7] rtc: support i.MX95 BBM RTC
From: Sudeep Holla @ 2024-08-30 10:19 UTC (permalink / raw)
To: Alexandre Belloni
Cc: Peng Fan (OSS), Cristian Marussi, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Peng Fan, Dmitry Torokhov,
arm-scmi, linux-arm-kernel, devicetree, linux-kernel, imx,
linux-rtc, linux-input
In-Reply-To: <20240830091246fce62c34@mail.local>
On Fri, Aug 30, 2024 at 11:12:46AM +0200, Alexandre Belloni wrote:
> On 27/08/2024 11:34:55+0100, Sudeep Holla wrote:
> > Hi Alexandre,
> >
> > On Fri, Aug 23, 2024 at 05:05:22PM +0800, Peng Fan (OSS) wrote:
> > > From: Peng Fan <peng.fan@nxp.com>
> > >
> > > The BBM module provides RTC feature. To i.MX95, this module is managed by
> > > System Manager and exported System Control Management Interface(SCMI).
> > > Linux could use i.MX SCMI BBM Extension protocol to use RTC feature.
> > >
> > > This driver is to use SCMI interface to get/set RTC.
> > >
> >
> > Are you fine if I take this along with dependent SCMI changes via SoC tree ?
>
> Sure, please do.
>
Thanks!
--
Regards,
Sudeep
^ permalink raw reply
* Re: [PATCH v26 31/33] ALSA: usb-audio: Add USB offload route kcontrol
From: Pierre-Louis Bossart @ 2024-08-30 10:05 UTC (permalink / raw)
To: Wesley Cheng, srinivas.kandagatla, mathias.nyman, perex, conor+dt,
dmitry.torokhov, corbet, broonie, lgirdwood, tiwai, krzk+dt,
Thinh.Nguyen, bgoswami, robh, gregkh
Cc: linux-kernel, devicetree, linux-sound, linux-input, linux-usb,
linux-arm-msm, linux-doc, alsa-devel
In-Reply-To: <20240829194105.1504814-32-quic_wcheng@quicinc.com>
On 8/29/24 21:41, Wesley Cheng wrote:
> In order to allow userspace/applications know about USB offloading status,
> expose a sound kcontrol that fetches information about which sound card
> and PCM index the USB device is mapped to for supporting offloading. In
> the USB audio offloading framework, the ASoC BE DAI link is the entity
> responsible for registering to the SOC USB layer.
>
> It is expected for the USB SND offloading driver to add the kcontrol to the
> sound card associated with the USB audio device. An example output would
> look like:
this is very odd, the offloading driver adds a control to another card?
That seems like a rather important layering violation.
I thought it was done the other way, the USB audio card created a
control that would point to the other card/device.
>
> tinymix -D 1 get 'USB Offload Playback Route PCM#0'
> -1, -1 (range -1->255)
>
> This example signifies that there is no mapped ASoC path available for the
> USB SND device.
but that control would not even exist if the ASoC-based driver isn't probed.
It's become really hard to follow, I've been on all this for 1.5hrs and
losing track of the design.
> tinymix -D 1 get 'USB Offload Playback Route PCM#0'
> 0, 0 (range -1->255)
>
> This example signifies that the offload path is available over ASoC sound
> card index#0 and PCM device#0.
>
> Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com>
> ---
> sound/usb/Kconfig | 10 +++
> sound/usb/Makefile | 2 +
> sound/usb/mixer_usb_offload.c | 102 ++++++++++++++++++++++++++++++
> sound/usb/mixer_usb_offload.h | 17 +++++
> sound/usb/qcom/Makefile | 2 +-
> sound/usb/qcom/qc_audio_offload.c | 2 +
> 6 files changed, 134 insertions(+), 1 deletion(-)
> create mode 100644 sound/usb/mixer_usb_offload.c
> create mode 100644 sound/usb/mixer_usb_offload.h
>
> diff --git a/sound/usb/Kconfig b/sound/usb/Kconfig
> index 5cc3eaf53e6b..e3fbf9541d0b 100644
> --- a/sound/usb/Kconfig
> +++ b/sound/usb/Kconfig
> @@ -176,10 +176,20 @@ config SND_BCD2000
> To compile this driver as a module, choose M here: the module
> will be called snd-bcd2000.
>
> +config SND_USB_OFFLOAD_MIXER
> + tristate "USB Audio Offload mixer control"
> + help
> + Say Y to enable the USB audio offloading mixer controls. This
> + exposes an USB offload capable kcontrol to signal to applications
> + about which platform sound card can support USB audio offload.
> + The returning values specify the mapped ASoC card and PCM device
> + the USB audio device is associated to.
> +
> config SND_USB_AUDIO_QMI
> tristate "Qualcomm Audio Offload driver"
> depends on QCOM_QMI_HELPERS && SND_USB_AUDIO && USB_XHCI_SIDEBAND && SND_SOC_USB
> select SND_PCM
> + select SND_USB_OFFLOAD_MIXER
> help
> Say Y here to enable the Qualcomm USB audio offloading feature.
>
> diff --git a/sound/usb/Makefile b/sound/usb/Makefile
> index 54a06a2f73ca..2f19f854944c 100644
> --- a/sound/usb/Makefile
> +++ b/sound/usb/Makefile
> @@ -36,3 +36,5 @@ obj-$(CONFIG_SND_USB_US122L) += snd-usbmidi-lib.o
>
> obj-$(CONFIG_SND) += misc/ usx2y/ caiaq/ 6fire/ hiface/ bcd2000/ qcom/
> obj-$(CONFIG_SND_USB_LINE6) += line6/
> +
> +obj-$(CONFIG_SND_USB_OFFLOAD_MIXER) += mixer_usb_offload.o
> diff --git a/sound/usb/mixer_usb_offload.c b/sound/usb/mixer_usb_offload.c
> new file mode 100644
> index 000000000000..16e2fd634684
> --- /dev/null
> +++ b/sound/usb/mixer_usb_offload.c
> @@ -0,0 +1,102 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2022-2024 Qualcomm Innovation Center, Inc. All rights reserved.
> + */
> +
> +#include <linux/usb.h>
> +
> +#include <sound/core.h>
> +#include <sound/control.h>
> +#include <sound/soc-usb.h>
> +
> +#include "usbaudio.h"
> +#include "card.h"
> +#include "helper.h"
> +#include "mixer.h"
> +
> +#include "mixer_usb_offload.h"
> +
> +#define PCM_IDX(n) ((n) & 0xffff)
> +#define CARD_IDX(n) ((n) >> 16)
> +
> +static int
> +snd_usb_offload_route_get(struct snd_kcontrol *kcontrol,
> + struct snd_ctl_elem_value *ucontrol)
> +{
> + struct device *sysdev = snd_kcontrol_chip(kcontrol);
> + int ret;
> +
> + ret = snd_soc_usb_update_offload_route(sysdev,
> + CARD_IDX(kcontrol->private_value),
> + PCM_IDX(kcontrol->private_value),
> + SNDRV_PCM_STREAM_PLAYBACK,
> + ucontrol->value.integer.value);
> + if (ret < 0) {
> + ucontrol->value.integer.value[0] = -1;
> + ucontrol->value.integer.value[1] = -1;
> + }
> +
> + return 0;
> +}
> +
> +static int snd_usb_offload_route_info(struct snd_kcontrol *kcontrol,
> + struct snd_ctl_elem_info *uinfo)
> +{
> + uinfo->type = SNDRV_CTL_ELEM_TYPE_INTEGER;
> + uinfo->count = 2;
> + uinfo->value.integer.min = -1;
> + /* Arbitrary max value, as there is no 'limit' on number of PCM devices */
> + uinfo->value.integer.max = 0xff;
> +
> + return 0;
> +}
> +
> +static struct snd_kcontrol_new snd_usb_offload_mapped_ctl = {
> + .iface = SNDRV_CTL_ELEM_IFACE_CARD,
> + .access = SNDRV_CTL_ELEM_ACCESS_READ,
> + .info = snd_usb_offload_route_info,
> + .get = snd_usb_offload_route_get,
> +};
> +
> +/**
> + * snd_usb_offload_create_ctl() - Add USB offload bounded mixer
> + * @chip - USB SND chip device
> + *
> + * Creates a sound control for a USB audio device, so that applications can
> + * query for if there is an available USB audio offload path, and which
> + * card is managing it.
> + */
> +int snd_usb_offload_create_ctl(struct snd_usb_audio *chip)
> +{
> + struct usb_device *udev = chip->dev;
> + struct snd_kcontrol_new *chip_kctl;
> + struct snd_usb_substream *subs;
> + struct snd_usb_stream *as;
> + char ctl_name[37];
> + int ret;
> +
> + list_for_each_entry(as, &chip->pcm_list, list) {
> + subs = &as->substream[SNDRV_PCM_STREAM_PLAYBACK];
> + if (!subs->ep_num)
> + continue;
> +
> + chip_kctl = &snd_usb_offload_mapped_ctl;
> + chip_kctl->count = 1;
> + /*
> + * Store the associated USB SND card number and PCM index for
> + * the kctl.
> + */
> + chip_kctl->private_value = as->pcm_index |
> + chip->card->number << 16;
> + sprintf(ctl_name, "USB Offload Playback Route PCM#%d",
> + as->pcm_index);
> + chip_kctl->name = ctl_name;
> + ret = snd_ctl_add(chip->card, snd_ctl_new1(chip_kctl,
> + udev->bus->sysdev));
> + if (ret < 0)
> + break;
> + }
> +
> + return ret;
> +}
> +EXPORT_SYMBOL_GPL(snd_usb_offload_create_ctl);
> diff --git a/sound/usb/mixer_usb_offload.h b/sound/usb/mixer_usb_offload.h
> new file mode 100644
> index 000000000000..3f6e2a8b19c8
> --- /dev/null
> +++ b/sound/usb/mixer_usb_offload.h
> @@ -0,0 +1,17 @@
> +/* SPDX-License-Identifier: GPL-2.0
> + *
> + * Copyright (c) 2022-2024 Qualcomm Innovation Center, Inc. All rights reserved.
> + */
> +
> +#ifndef __USB_OFFLOAD_MIXER_H
> +#define __USB_OFFLOAD_MIXER_H
> +
> +#if IS_ENABLED(CONFIG_SND_USB_OFFLOAD_MIXER)
> +int snd_usb_offload_create_ctl(struct snd_usb_audio *chip);
> +#else
> +static inline int snd_usb_offload_create_ctl(struct snd_usb_audio *chip)
> +{
> + return 0;
> +}
> +#endif
> +#endif /* __USB_OFFLOAD_MIXER_H */
> diff --git a/sound/usb/qcom/Makefile b/sound/usb/qcom/Makefile
> index a81c9b28d484..4005e8391ab9 100644
> --- a/sound/usb/qcom/Makefile
> +++ b/sound/usb/qcom/Makefile
> @@ -1,2 +1,2 @@
> snd-usb-audio-qmi-objs := usb_audio_qmi_v01.o qc_audio_offload.o
> -obj-$(CONFIG_SND_USB_AUDIO_QMI) += snd-usb-audio-qmi.o
> \ No newline at end of file
> +obj-$(CONFIG_SND_USB_AUDIO_QMI) += snd-usb-audio-qmi.o
> diff --git a/sound/usb/qcom/qc_audio_offload.c b/sound/usb/qcom/qc_audio_offload.c
> index a7ad15404fd1..5b9262a116be 100644
> --- a/sound/usb/qcom/qc_audio_offload.c
> +++ b/sound/usb/qcom/qc_audio_offload.c
> @@ -36,6 +36,7 @@
> #include "../helper.h"
> #include "../pcm.h"
> #include "../power.h"
> +#include "../mixer_usb_offload.h"
>
> #include "usb_audio_qmi_v01.h"
>
> @@ -1703,6 +1704,7 @@ static void qc_usb_audio_offload_probe(struct snd_usb_audio *chip)
> sdev->card_idx = chip->card->number;
> sdev->chip_idx = chip->index;
>
> + snd_usb_offload_create_ctl(chip);
> snd_soc_usb_connect(usb_get_usb_backend(udev), sdev);
> }
>
^ permalink raw reply
* Re: [PATCH v26 30/33] ALSA: usb-audio: qcom: Use card and PCM index from QMI request
From: Pierre-Louis Bossart @ 2024-08-30 9:58 UTC (permalink / raw)
To: Wesley Cheng, srinivas.kandagatla, mathias.nyman, perex, conor+dt,
dmitry.torokhov, corbet, broonie, lgirdwood, tiwai, krzk+dt,
Thinh.Nguyen, bgoswami, robh, gregkh
Cc: linux-kernel, devicetree, linux-sound, linux-input, linux-usb,
linux-arm-msm, linux-doc, alsa-devel
In-Reply-To: <20240829194105.1504814-31-quic_wcheng@quicinc.com>
On 8/29/24 21:41, Wesley Cheng wrote:
> Utilize the card and PCM index coming from the USB QMI stream request.
> This field follows what is set by the ASoC USB backend, and could
> potentially carry information about a specific device selected through the
> ASoC USB backend. The backend also has information about the last USB
> sound device plugged in, so it can choose to select the last device plugged
> in, accordingly.
>
> Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com>
> ---
> sound/usb/qcom/qc_audio_offload.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/sound/usb/qcom/qc_audio_offload.c b/sound/usb/qcom/qc_audio_offload.c
> index 0bd533f539e4..a7ad15404fd1 100644
> --- a/sound/usb/qcom/qc_audio_offload.c
> +++ b/sound/usb/qcom/qc_audio_offload.c
> @@ -106,8 +106,6 @@ struct uaudio_qmi_dev {
> bool er_mapped;
> /* reference count to number of possible consumers */
> atomic_t qdev_in_use;
> - /* idx to last udev card number plugged in */
> - unsigned int last_card_num;
> };
>
> struct uaudio_dev {
> @@ -1261,7 +1259,7 @@ static int prepare_qmi_response(struct snd_usb_substream *subs,
>
> pcm_dev_num = (req_msg->usb_token & QMI_STREAM_REQ_DEV_NUM_MASK) >> 8;
> xfer_buf_len = req_msg->xfer_buff_size;
> - card_num = uaudio_qdev->last_card_num;
> + card_num = (req_msg->usb_token & QMI_STREAM_REQ_CARD_NUM_MASK) >> 16;
>
> if (!uadev[card_num].ctrl_intf) {
> dev_err(&subs->dev->dev, "audio ctrl intf info not cached\n");
> @@ -1455,8 +1453,7 @@ static void handle_uaudio_stream_req(struct qmi_handle *handle,
>
> direction = (req_msg->usb_token & QMI_STREAM_REQ_DIRECTION);
> pcm_dev_num = (req_msg->usb_token & QMI_STREAM_REQ_DEV_NUM_MASK) >> 8;
> - pcm_card_num = req_msg->enable ? uaudio_qdev->last_card_num :
> - ffs(uaudio_qdev->card_slot) - 1;
> + pcm_card_num = (req_msg->usb_token & QMI_STREAM_REQ_CARD_NUM_MASK) >> 16;
> if (pcm_card_num >= SNDRV_CARDS) {
> ret = -EINVAL;
> goto response;
> @@ -1706,7 +1703,6 @@ static void qc_usb_audio_offload_probe(struct snd_usb_audio *chip)
> sdev->card_idx = chip->card->number;
> sdev->chip_idx = chip->index;
>
> - uaudio_qdev->last_card_num = chip->card->number;
> snd_soc_usb_connect(usb_get_usb_backend(udev), sdev);
> }
This entire path seems like a bad split/merge, it removes stuff that was
done earlier. Also it's not clear what this has to do with 'QMI', card
and PCM device management is usually done at a higher level.
not following, please be mindful of reviewer fatigue when adding such
changes in patch 30/33....
^ permalink raw reply
* Re: [PATCH v26 29/33] ALSA: usb-audio: qcom: Don't allow USB offload path if PCM device is in use
From: Pierre-Louis Bossart @ 2024-08-30 9:55 UTC (permalink / raw)
To: Wesley Cheng, srinivas.kandagatla, mathias.nyman, perex, conor+dt,
dmitry.torokhov, corbet, broonie, lgirdwood, tiwai, krzk+dt,
Thinh.Nguyen, bgoswami, robh, gregkh
Cc: linux-kernel, devicetree, linux-sound, linux-input, linux-usb,
linux-arm-msm, linux-doc, alsa-devel
In-Reply-To: <20240829194105.1504814-30-quic_wcheng@quicinc.com>
On 8/29/24 21:41, Wesley Cheng wrote:
> Add proper checks and updates to the USB substream once receiving a USB QMI
> stream enable request. If the substream is already in use from the non
> offload path, reject the stream enable request. In addition, update the
> USB substream opened parameter when enabling the offload path, so the
> non offload path can be blocked.
>
> Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com>
> ---
> sound/usb/qcom/qc_audio_offload.c | 15 ++++++++++++++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/sound/usb/qcom/qc_audio_offload.c b/sound/usb/qcom/qc_audio_offload.c
> index e9f2fd6bbb41..0bd533f539e4 100644
> --- a/sound/usb/qcom/qc_audio_offload.c
> +++ b/sound/usb/qcom/qc_audio_offload.c
> @@ -1482,12 +1482,17 @@ static void handle_uaudio_stream_req(struct qmi_handle *handle,
> goto response;
> }
>
> + mutex_lock(&chip->mutex);
> if (req_msg->enable) {
> - if (info_idx < 0 || chip->system_suspend) {
> + if (info_idx < 0 || chip->system_suspend || subs->opened) {
> ret = -EBUSY;
> + mutex_unlock(&chip->mutex);
> +
> goto response;
> }
> + subs->opened = 1;
> }
> + mutex_unlock(&chip->mutex);
>
> if (req_msg->service_interval_valid) {
> ret = get_data_interval_from_si(subs,
> @@ -1509,6 +1514,11 @@ static void handle_uaudio_stream_req(struct qmi_handle *handle,
> if (!ret)
> ret = prepare_qmi_response(subs, req_msg, &resp,
> info_idx);
> + if (ret < 0) {
> + mutex_lock(&chip->mutex);
> + subs->opened = 0;
> + mutex_unlock(&chip->mutex);
> + }
> } else {
> info = &uadev[pcm_card_num].info[info_idx];
> if (info->data_ep_pipe) {
> @@ -1532,6 +1542,9 @@ static void handle_uaudio_stream_req(struct qmi_handle *handle,
> }
>
> disable_audio_stream(subs);
> + mutex_lock(&chip->mutex);
> + subs->opened = 0;
> + mutex_unlock(&chip->mutex);
> }
>
This sounds ok but I wonder why all this needs to be done in
Qualcomm-specific layers instead of soc-usb?
^ permalink raw reply
* Re: [PATCH v26 28/33] ALSA: usb-audio: qcom: Introduce QC USB SND offloading support
From: Pierre-Louis Bossart @ 2024-08-30 9:52 UTC (permalink / raw)
To: Wesley Cheng, srinivas.kandagatla, mathias.nyman, perex, conor+dt,
dmitry.torokhov, corbet, broonie, lgirdwood, tiwai, krzk+dt,
Thinh.Nguyen, bgoswami, robh, gregkh
Cc: linux-kernel, devicetree, linux-sound, linux-input, linux-usb,
linux-arm-msm, linux-doc, alsa-devel
In-Reply-To: <20240829194105.1504814-29-quic_wcheng@quicinc.com>
> +/* Stream disable request timeout during USB device disconnect */
> +#define DEV_RELEASE_WAIT_TIMEOUT 10000 /* in ms */
10s really? That seems rather large for a stream disable timeout...
> +static struct snd_usb_platform_ops offload_ops = {
> + .connect_cb = qc_usb_audio_offload_probe,
> + .disconnect_cb = qc_usb_audio_offload_disconnect,
> + .suspend_cb = qc_usb_audio_offload_suspend,
> +};
You probably want to explain why there's no .resume_cb?
The comments mention also that the suspend_cb has to stop playback, but
then who resumes playback :-)
^ permalink raw reply
* Re: [PATCH v26 26/33] ALSA: usb-audio: Prevent starting of audio stream if in use
From: Pierre-Louis Bossart @ 2024-08-30 9:45 UTC (permalink / raw)
To: Wesley Cheng, srinivas.kandagatla, mathias.nyman, perex, conor+dt,
dmitry.torokhov, corbet, broonie, lgirdwood, tiwai, krzk+dt,
Thinh.Nguyen, bgoswami, robh, gregkh
Cc: linux-kernel, devicetree, linux-sound, linux-input, linux-usb,
linux-arm-msm, linux-doc, alsa-devel
In-Reply-To: <20240829194105.1504814-27-quic_wcheng@quicinc.com>
On 8/29/24 21:40, Wesley Cheng wrote:
> With USB audio offloading, an audio session is started from the ASoC
> platform sound card and PCM devices. Likewise, the USB SND path is still
> readily available for use, in case the non-offload path is desired. In
> order to prevent the two entities from attempting to use the USB bus,
> introduce a flag that determines when either paths are in use.
>
> If a PCM device is already in use, the check will return an error to
> userspace notifying that the stream is currently busy. This ensures that
> only one path is using the USB substream.
>
> Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
I would also move this patch earlier in the series since it has no
dependency on USB offload really, and if somehow it breaks USB audio
regular paths we'd want to know early for bisection.
> ---
> sound/usb/card.h | 1 +
> sound/usb/pcm.c | 29 ++++++++++++++++++++++++++---
> 2 files changed, 27 insertions(+), 3 deletions(-)
>
> diff --git a/sound/usb/card.h b/sound/usb/card.h
> index 15cda1730076..d8b8522e1613 100644
> --- a/sound/usb/card.h
> +++ b/sound/usb/card.h
> @@ -165,6 +165,7 @@ struct snd_usb_substream {
> unsigned int pkt_offset_adj; /* Bytes to drop from beginning of packets (for non-compliant devices) */
> unsigned int stream_offset_adj; /* Bytes to drop from beginning of stream (for non-compliant devices) */
>
> + unsigned int opened:1; /* pcm device opened */
> unsigned int running: 1; /* running status */
> unsigned int period_elapsed_pending; /* delay period handling */
>
> diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c
> index 18467da6fd9e..b24ee38fad72 100644
> --- a/sound/usb/pcm.c
> +++ b/sound/usb/pcm.c
> @@ -1241,8 +1241,17 @@ static int snd_usb_pcm_open(struct snd_pcm_substream *substream)
> struct snd_usb_stream *as = snd_pcm_substream_chip(substream);
> struct snd_pcm_runtime *runtime = substream->runtime;
> struct snd_usb_substream *subs = &as->substream[direction];
> + struct snd_usb_audio *chip = subs->stream->chip;
> int ret;
>
> + mutex_lock(&chip->mutex);
> + if (subs->opened) {
> + mutex_unlock(&chip->mutex);
> + return -EBUSY;
> + }
> + subs->opened = 1;
> + mutex_unlock(&chip->mutex);
> +
> runtime->hw = snd_usb_hardware;
> /* need an explicit sync to catch applptr update in low-latency mode */
> if (direction == SNDRV_PCM_STREAM_PLAYBACK &&
> @@ -1259,13 +1268,23 @@ static int snd_usb_pcm_open(struct snd_pcm_substream *substream)
>
> ret = setup_hw_info(runtime, subs);
> if (ret < 0)
> - return ret;
> + goto err_open;
> ret = snd_usb_autoresume(subs->stream->chip);
> if (ret < 0)
> - return ret;
> + goto err_open;
> ret = snd_media_stream_init(subs, as->pcm, direction);
> if (ret < 0)
> - snd_usb_autosuspend(subs->stream->chip);
> + goto err_resume;
> +
> + return 0;
> +
> +err_resume:
> + snd_usb_autosuspend(subs->stream->chip);
> +err_open:
> + mutex_lock(&chip->mutex);
> + subs->opened = 0;
> + mutex_unlock(&chip->mutex);
> +
> return ret;
> }
>
> @@ -1274,6 +1293,7 @@ static int snd_usb_pcm_close(struct snd_pcm_substream *substream)
> int direction = substream->stream;
> struct snd_usb_stream *as = snd_pcm_substream_chip(substream);
> struct snd_usb_substream *subs = &as->substream[direction];
> + struct snd_usb_audio *chip = subs->stream->chip;
> int ret;
>
> snd_media_stop_pipeline(subs);
> @@ -1287,6 +1307,9 @@ static int snd_usb_pcm_close(struct snd_pcm_substream *substream)
>
> subs->pcm_substream = NULL;
> snd_usb_autosuspend(subs->stream->chip);
> + mutex_lock(&chip->mutex);
> + subs->opened = 0;
> + mutex_unlock(&chip->mutex);
>
> return 0;
> }
^ permalink raw reply
* Re: [PATCH v26 25/33] ALSA: usb-audio: Save UAC sample size information
From: Pierre-Louis Bossart @ 2024-08-30 9:42 UTC (permalink / raw)
To: Wesley Cheng, srinivas.kandagatla, mathias.nyman, perex, conor+dt,
dmitry.torokhov, corbet, broonie, lgirdwood, tiwai, krzk+dt,
Thinh.Nguyen, bgoswami, robh, gregkh
Cc: linux-kernel, devicetree, linux-sound, linux-input, linux-usb,
linux-arm-msm, linux-doc, alsa-devel
In-Reply-To: <20240829194105.1504814-26-quic_wcheng@quicinc.com>
On 8/29/24 21:40, Wesley Cheng wrote:
> Within the UAC descriptor, there is information describing the size of a
> sample (bSubframeSize/bSubslotSize) and the number of relevant bits
> (bBitResolution). Currently, fmt_bits carries only the bit resolution,
> however, some offloading entities may also require the overall size of the
> sample. Save this information in a separate parameter, as depending on the
> UAC format type, the sample size can not easily be decoded from other
> existing parameters.
>
> Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com>
> ---
> sound/usb/card.h | 1 +
> sound/usb/format.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/sound/usb/card.h b/sound/usb/card.h
> index 23d9e6fc69e7..15cda1730076 100644
> --- a/sound/usb/card.h
> +++ b/sound/usb/card.h
> @@ -15,6 +15,7 @@ struct audioformat {
> unsigned int channels; /* # channels */
> unsigned int fmt_type; /* USB audio format type (1-3) */
> unsigned int fmt_bits; /* number of significant bits */
> + unsigned int fmt_sz; /* overall audio sub frame/slot size */
> unsigned int frame_size; /* samples per frame for non-audio */
> unsigned char iface; /* interface number */
> unsigned char altsetting; /* corresponding alternate setting */
> diff --git a/sound/usb/format.c b/sound/usb/format.c
> index 3b45d0ee7693..5fde543536a8 100644
> --- a/sound/usb/format.c
> +++ b/sound/usb/format.c
> @@ -80,6 +80,7 @@ static u64 parse_audio_format_i_type(struct snd_usb_audio *chip,
> }
>
> fp->fmt_bits = sample_width;
> + fp->fmt_sz = sample_bytes;
>
> if ((pcm_formats == 0) &&
> (format == 0 || format == (1 << UAC_FORMAT_TYPE_I_UNDEFINED))) {
Should this patch be added first? I mean, I don't see any dependency on
USB offload
I am actually confused as to how the regular USB audio path deals with
format, this must be inferred somewhere from the fmt_bits. Probably a
question for Takashi :-)
^ permalink raw reply
* Re: [PATCH v26 24/33] ALSA: usb-audio: Introduce USB SND platform op callbacks
From: Pierre-Louis Bossart @ 2024-08-30 9:38 UTC (permalink / raw)
To: Wesley Cheng, srinivas.kandagatla, mathias.nyman, perex, conor+dt,
dmitry.torokhov, corbet, broonie, lgirdwood, tiwai, krzk+dt,
Thinh.Nguyen, bgoswami, robh, gregkh
Cc: linux-kernel, devicetree, linux-sound, linux-input, linux-usb,
linux-arm-msm, linux-doc, alsa-devel
In-Reply-To: <20240829194105.1504814-25-quic_wcheng@quicinc.com>
On 8/29/24 21:40, Wesley Cheng wrote:
> Allow for different platforms to be notified on USB SND connect/disconnect
> sequences. This allows for platform USB SND modules to properly initialize
> and populate internal structures with references to the USB SND chip
> device.
>
> Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com>
> ---
> sound/usb/card.c | 53 ++++++++++++++++++++++++++++++++++++++++++++++++
> sound/usb/card.h | 10 +++++++++
> 2 files changed, 63 insertions(+)
>
> diff --git a/sound/usb/card.c b/sound/usb/card.c
> index 1f9dfcd8f336..7f120aa006c0 100644
> --- a/sound/usb/card.c
> +++ b/sound/usb/card.c
> @@ -118,6 +118,42 @@ MODULE_PARM_DESC(skip_validation, "Skip unit descriptor validation (default: no)
> static DEFINE_MUTEX(register_mutex);
> static struct snd_usb_audio *usb_chip[SNDRV_CARDS];
> static struct usb_driver usb_audio_driver;
> +static struct snd_usb_platform_ops *platform_ops;
> +
> +/*
> + * Register platform specific operations that will be notified on events
> + * which occur in USB SND. The platform driver can utilize this path to
> + * enable features, such as USB audio offloading, which allows for audio data
> + * to be queued by an audio DSP.
> + *
> + * Only one set of platform operations can be registered to USB SND. The
> + * platform register operation is protected by the register_mutex.
> + */
> +int snd_usb_register_platform_ops(struct snd_usb_platform_ops *ops)
> +{
> + guard(mutex)(®ister_mutex);
> + if (platform_ops)
> + return -EEXIST;
> +
> + platform_ops = ops;
> + return 0;
> +}
> +EXPORT_SYMBOL_GPL(snd_usb_register_platform_ops);
> +
> +/*
> + * Unregisters the current set of platform operations. This allows for
Unregister?
> + * a new set to be registered if required.
> + *
> + * The platform unregister operation is protected by the register_mutex.
> + */
> +int snd_usb_unregister_platform_ops(void)
> +{
> + guard(mutex)(®ister_mutex);
> + platform_ops = NULL;
> +
> + return 0;
> +}
> +EXPORT_SYMBOL_GPL(snd_usb_unregister_platform_ops);
>
> /*
> * Checks to see if requested audio profile, i.e sample rate, # of
> @@ -946,7 +982,11 @@ static int usb_audio_probe(struct usb_interface *intf,
> chip->num_interfaces++;
> usb_set_intfdata(intf, chip);
> atomic_dec(&chip->active);
> +
> + if (platform_ops && platform_ops->connect_cb)
> + platform_ops->connect_cb(chip);
> mutex_unlock(®ister_mutex);
> +
> return 0;
>
> __error:
> @@ -983,6 +1023,9 @@ static void usb_audio_disconnect(struct usb_interface *intf)
> card = chip->card;
>
> mutex_lock(®ister_mutex);
> + if (platform_ops && platform_ops->disconnect_cb)
> + platform_ops->disconnect_cb(chip);
> +
> if (atomic_inc_return(&chip->shutdown) == 1) {
> struct snd_usb_stream *as;
> struct snd_usb_endpoint *ep;
> @@ -1130,6 +1173,11 @@ static int usb_audio_suspend(struct usb_interface *intf, pm_message_t message)
> chip->system_suspend = chip->num_suspended_intf;
> }
>
> + mutex_lock(®ister_mutex);
> + if (platform_ops && platform_ops->suspend_cb)
> + platform_ops->suspend_cb(intf, message);
> + mutex_unlock(®ister_mutex);
> +
> return 0;
> }
>
> @@ -1170,6 +1218,11 @@ static int usb_audio_resume(struct usb_interface *intf)
>
> snd_usb_midi_v2_resume_all(chip);
>
> + mutex_lock(®ister_mutex);
> + if (platform_ops && platform_ops->resume_cb)
> + platform_ops->resume_cb(intf);
> + mutex_unlock(®ister_mutex);
> +
> out:
> if (chip->num_suspended_intf == chip->system_suspend) {
> snd_power_change_state(chip->card, SNDRV_CTL_POWER_D0);
> diff --git a/sound/usb/card.h b/sound/usb/card.h
> index 4f4f3f39b7fa..23d9e6fc69e7 100644
> --- a/sound/usb/card.h
> +++ b/sound/usb/card.h
> @@ -207,7 +207,17 @@ struct snd_usb_stream {
> struct list_head list;
> };
>
> +struct snd_usb_platform_ops {
> + void (*connect_cb)(struct snd_usb_audio *chip);
> + void (*disconnect_cb)(struct snd_usb_audio *chip);
> + void (*suspend_cb)(struct usb_interface *intf, pm_message_t message);
> + void (*resume_cb)(struct usb_interface *intf);
> +};
You're using the same mutex to protect all four callbacks, so how would
things work if e.g. you disconnected a device during the resume operation?
^ permalink raw reply
* Re: [PATCH v26 23/33] ASoC: qcom: qdsp6: Fetch USB offload mapped card and PCM device
From: Pierre-Louis Bossart @ 2024-08-30 9:34 UTC (permalink / raw)
To: Wesley Cheng, srinivas.kandagatla, mathias.nyman, perex, conor+dt,
dmitry.torokhov, corbet, broonie, lgirdwood, tiwai, krzk+dt,
Thinh.Nguyen, bgoswami, robh, gregkh
Cc: linux-kernel, devicetree, linux-sound, linux-input, linux-usb,
linux-arm-msm, linux-doc, alsa-devel
In-Reply-To: <20240829194105.1504814-24-quic_wcheng@quicinc.com>
On 8/29/24 21:40, Wesley Cheng wrote:
> The USB SND path may need to know how the USB offload path is routed, so
> that applications can open the proper sound card and PCM device. The
> implementation for the QC ASoC design has a "USB Mixer" kcontrol for each
> possible FE (Q6ASM) DAI, which can be utilized to know which front end link
> is enabled.
>
> When an application/userspace queries for the mapped offload devices, the
> logic will lookup the USB mixer status though the following path:
>
> MultiMedia* <-> MM_DL* <-> USB Mixer*
>
> The "USB Mixer" is a DAPM widget, and the q6routing entity will set the
> DAPM connect status accordingly if the USB mixer is enabled. If enabled,
> the Q6USB backend link can fetch the PCM device number from the FE DAI
> link (Multimedia*). With respects to the card number, that is
> straightforward, as the ASoC components have direct references to the ASoC
> platform sound card.
>
> An example output can be shown below:
>
> Number of controls: 9
> name value
> Capture Channel Map 0, 0 (range 0->36)
> Playback Channel Map 0, 0 (range 0->36)
> Headset Capture Switch On
> Headset Capture Volume 1 (range 0->4)
> Sidetone Playback Switch On
> Sidetone Playback Volume 4096 (range 0->8192)
> Headset Playback Switch On
> Headset Playback Volume 20, 20 (range 0->24)
> USB Offload Playback Route PCM#0 0, 1 (range -1->255)
>
> The "USB Offload Playback Route PCM#*" kcontrol will signify the
> corresponding card and pcm device it is offload to. (card#0 pcm - device#1)
> If the USB SND device supports multiple audio interfaces, then it will
> contain several PCM streams, hence in those situations, it is expected
> that there will be multiple playback route kcontrols created.
>
> Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com>
> ---
> sound/soc/qcom/qdsp6/q6usb.c | 104 +++++++++++++++++++++++++++++++++++
> 1 file changed, 104 insertions(+)
>
> diff --git a/sound/soc/qcom/qdsp6/q6usb.c b/sound/soc/qcom/qdsp6/q6usb.c
> index 10337d70eb27..c2fc0dedf430 100644
> --- a/sound/soc/qcom/qdsp6/q6usb.c
> +++ b/sound/soc/qcom/qdsp6/q6usb.c
> @@ -132,6 +132,109 @@ static int q6usb_audio_ports_of_xlate_dai_name(struct snd_soc_component *compone
> return ret;
> }
>
> +static int q6usb_get_pcm_id_from_widget(struct snd_soc_dapm_widget *w)
> +{
> + struct snd_soc_pcm_runtime *rtd;
> + struct snd_soc_dai *dai;
> +
> + for_each_card_rtds(w->dapm->card, rtd) {
> + dai = snd_soc_rtd_to_cpu(rtd, 0);
> + /*
> + * Only look for playback widget. RTD number carries the assigned
> + * PCM index.
> + */
> + if (dai->stream[0].widget == w)
> + return rtd->num;
> + }
> +
> + return -1;
> +}
> +
> +static int q6usb_usb_mixer_enabled(struct snd_soc_dapm_widget *w)
> +{
> + struct snd_soc_dapm_path *p;
> +
> + /* Checks to ensure USB path is enabled/connected */
> + snd_soc_dapm_widget_for_each_sink_path(w, p)
> + if (!strcmp(p->sink->name, "USB Mixer") && p->connect)
> + return 1;
> +
> + return 0;
> +}
> +
> +static int q6usb_get_pcm_id(struct snd_soc_component *component)
> +{
> + struct snd_soc_dapm_widget *w;
> + struct snd_soc_dapm_path *p;
> + int pidx;
> +
> + /*
> + * Traverse widgets to find corresponding FE widget. The DAI links are
> + * built like the following:
> + * MultiMedia* <-> MM_DL* <-> USB Mixer*
> + */
> + for_each_card_widgets(component->card, w) {
> + if (!strncmp(w->name, "MultiMedia", 10)) {
> + /*
> + * Look up all paths associated with the FE widget to see if
> + * the USB BE is enabled. The sink widget is responsible to
> + * link with the USB mixers.
> + */
> + snd_soc_dapm_widget_for_each_sink_path(w, p) {
> + if (q6usb_usb_mixer_enabled(p->sink)) {
> + pidx = q6usb_get_pcm_id_from_widget(w);
> + return pidx;
> + }
> + }
Humm, there should be a note that the design assumes that the USB
offload path exposes a single PCM per endpoints - same as the
non-offloaded path. If the ASoC card has multiple PCMs for each
endpoint, possibly with different processing on each PCM, then the
mapping would fail.
The other question is whether you need to walk in the DAPM graph, in
theory DPCM has helpers to find which FEs are connected to which BE.
^ permalink raw reply
* Re: [PATCH v26 22/33] ASoC: qcom: qdsp6: Add headphone jack for offload connection status
From: Pierre-Louis Bossart @ 2024-08-30 9:27 UTC (permalink / raw)
To: Wesley Cheng, srinivas.kandagatla, mathias.nyman, perex, conor+dt,
dmitry.torokhov, corbet, broonie, lgirdwood, tiwai, krzk+dt,
Thinh.Nguyen, bgoswami, robh, gregkh
Cc: linux-kernel, devicetree, linux-sound, linux-input, linux-usb,
linux-arm-msm, linux-doc, alsa-devel
In-Reply-To: <20240829194105.1504814-23-quic_wcheng@quicinc.com>
> /* Selects the latest USB headset plugged in for offloading */
> + if (data->hs_jack && list_empty(&data->devices))
> + snd_jack_report(data->hs_jack->jack, SND_JACK_USB);
> +
with the list_empty check, this looks like only the first connected
headset will be handled, not the last?
> list_add_tail(&sdev->list, &data->devices);
> } else {
> list_del(&sdev->list);
> +
> + if (data->hs_jack && list_empty(&data->devices))
> + snd_jack_report(data->hs_jack->jack, 0);
> }
> mutex_unlock(&data->mutex);
>
> return 0;
> }
^ permalink raw reply
* Re: [PATCH v26 21/33] ASoC: qcom: qdsp6: Add USB backend ASoC driver for Q6
From: Pierre-Louis Bossart @ 2024-08-30 9:21 UTC (permalink / raw)
To: Wesley Cheng, srinivas.kandagatla, mathias.nyman, perex, conor+dt,
dmitry.torokhov, corbet, broonie, lgirdwood, tiwai, krzk+dt,
Thinh.Nguyen, bgoswami, robh, gregkh
Cc: linux-kernel, devicetree, linux-sound, linux-input, linux-usb,
linux-arm-msm, linux-doc, alsa-devel
In-Reply-To: <20240829194105.1504814-22-quic_wcheng@quicinc.com>
On 8/29/24 21:40, Wesley Cheng wrote:
> Create a USB BE component that will register a new USB port to the ASoC USB
> framework. This will handle determination on if the requested audio
> profile is supported by the USB device currently selected.
>
> Check for if the PCM format is supported during the hw_params callback. If
> the profile is not supported then the userspace ALSA entity will receive an
> error, and can take further action.
>
> Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com>
> ---
> include/sound/q6usboffload.h | 20 +++
> sound/soc/qcom/Kconfig | 10 ++
> sound/soc/qcom/qdsp6/Makefile | 1 +
> sound/soc/qcom/qdsp6/q6usb.c | 246 ++++++++++++++++++++++++++++++++++
> 4 files changed, 277 insertions(+)
> create mode 100644 include/sound/q6usboffload.h
> create mode 100644 sound/soc/qcom/qdsp6/q6usb.c
>
> diff --git a/include/sound/q6usboffload.h b/include/sound/q6usboffload.h
> new file mode 100644
> index 000000000000..49ab2c34b84c
> --- /dev/null
> +++ b/include/sound/q6usboffload.h
> @@ -0,0 +1,20 @@
> +/* SPDX-License-Identifier: GPL-2.0
> + *
> + * linux/sound/q6usboffload.h -- QDSP6 USB offload
not sure about the linux/ prefix?
> + *
> + * Copyright (c) 2022-2024 Qualcomm Innovation Center, Inc. All rights reserved.
> + */
> +
> +/**
> + * struct q6usb_offload
> + * @dev - dev handle to usb be
> + * @sid - streamID for iommu
> + * @intr_num - usb interrupter number
> + * @domain - allocated iommu domain
> + **/
> +struct q6usb_offload {
> + struct device *dev;
> + long long sid;
> + u16 intr_num;
> + struct iommu_domain *domain;
> +};
consider reordering to avoid holes/alignment issues, e.g. all pointers
first, then long long then u16
> +static int q6usb_hw_params(struct snd_pcm_substream *substream,
> + struct snd_pcm_hw_params *params,
> + struct snd_soc_dai *dai)
> +{
> + struct q6usb_port_data *data = dev_get_drvdata(dai->dev);
> + struct snd_soc_pcm_runtime *rtd = substream->private_data;
> + struct snd_soc_dai *cpu_dai = snd_soc_rtd_to_cpu(rtd, 0);
> + int direction = substream->stream;
> + struct q6afe_port *q6usb_afe;
> + struct snd_soc_usb_device *sdev;
> + int ret = -EINVAL;
> +
> + mutex_lock(&data->mutex);
> +
> + /* No active chip index */
> + if (list_empty(&data->devices))
> + goto out;
-ENODEV for the default return value>?
> +
> + sdev = list_last_entry(&data->devices, struct snd_soc_usb_device, list);
> +
> + ret = snd_soc_usb_find_supported_format(sdev->chip_idx, params, direction);
> + if (ret < 0)
> + goto out;
> +
> + q6usb_afe = q6afe_port_get_from_id(cpu_dai->dev, USB_RX);
> + if (IS_ERR(q6usb_afe))
> + goto out;
> +
> + /* Notify audio DSP about the devices being offloaded */
> + ret = afe_port_send_usb_dev_param(q6usb_afe, sdev->card_idx,
> + sdev->ppcm_idx[sdev->num_playback - 1]);
don't you need a symmetrical notification upon hw_free()?
Also what happens if there are multiple calls to hw_params, which is
quite legit in ALSA/ASoC?
^ permalink raw reply
* Re: [PATCH v26 20/33] ASoC: qcom: qdsp6: q6afe: Increase APR timeout
From: Pierre-Louis Bossart @ 2024-08-30 9:13 UTC (permalink / raw)
To: Wesley Cheng, srinivas.kandagatla, mathias.nyman, perex, conor+dt,
dmitry.torokhov, corbet, broonie, lgirdwood, tiwai, krzk+dt,
Thinh.Nguyen, bgoswami, robh, gregkh
Cc: linux-kernel, devicetree, linux-sound, linux-input, linux-usb,
linux-arm-msm, linux-doc, alsa-devel
In-Reply-To: <20240829194105.1504814-21-quic_wcheng@quicinc.com>
On 8/29/24 21:40, Wesley Cheng wrote:
> For USB offloading situations, the AFE port start command will result in a
> QMI handshake between the Q6DSP and the main processor. Depending on if
> the USB bus is suspended, this routine would require more time to complete,
> as resuming the USB bus has some overhead associated with it. Increase the
> timeout to 3s to allow for sufficient time for the USB QMI stream enable
> handshake to complete.
>
> Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> ---
> sound/soc/qcom/qdsp6/q6afe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/qcom/qdsp6/q6afe.c b/sound/soc/qcom/qdsp6/q6afe.c
> index 3ee6ff8a6bc3..b5b2af2ce50c 100644
> --- a/sound/soc/qcom/qdsp6/q6afe.c
> +++ b/sound/soc/qcom/qdsp6/q6afe.c
> @@ -366,7 +366,7 @@
> #define AFE_API_VERSION_SLOT_MAPPING_CONFIG 1
> #define AFE_API_VERSION_CODEC_DMA_CONFIG 1
>
> -#define TIMEOUT_MS 1000
> +#define TIMEOUT_MS 3000
> #define AFE_CMD_RESP_AVAIL 0
> #define AFE_CMD_RESP_NONE 1
> #define AFE_CLK_TOKEN 1024
^ permalink raw reply
* Re: [PATCH v26 19/33] ASoC: qcom: qdsp6: Introduce USB AFE port to q6dsp
From: Pierre-Louis Bossart @ 2024-08-30 9:12 UTC (permalink / raw)
To: Wesley Cheng, srinivas.kandagatla, mathias.nyman, perex, conor+dt,
dmitry.torokhov, corbet, broonie, lgirdwood, tiwai, krzk+dt,
Thinh.Nguyen, bgoswami, robh, gregkh
Cc: linux-kernel, devicetree, linux-sound, linux-input, linux-usb,
linux-arm-msm, linux-doc, alsa-devel
In-Reply-To: <20240829194105.1504814-20-quic_wcheng@quicinc.com>
On 8/29/24 21:40, Wesley Cheng wrote:
> The QC ADSP is able to support USB playback endpoints, so that the main
> application processor can be placed into lower CPU power modes. This adds
> the required AFE port configurations and port start command to start an
> audio session.
>
> Specifically, the QC ADSP can support all potential endpoints that are
> exposed by the audio data interface. This includes, feedback endpoints
> (both implicit and explicit) as well as the isochronous (data) endpoints.
I think you meant
"
this includes isochronous data endpoints, in either synchronous mode or
asynchronous mode. In the latter case both implicit or explicit feedback
endpoints are supported.
"
And now I don't remember how *controls* are handled.
Is this the case that all controls exposed by endpoint zero are visible
in both the regular USB-audio card AND the offloaded card, with changes
mirrored?
It's important to explain so that the volumes are consistent no matter
which path is used. This should be added to the documentation.
> +static const struct snd_soc_dai_ops q6afe_usb_ops = {
> + .probe = msm_dai_q6_dai_probe,
> + .prepare = q6afe_dai_prepare,
> + .hw_params = q6afe_usb_hw_params,
> + /*
> + * Shutdown callback required to stop the USB AFE port, which is enabled
> + * by the prepare() stage. This stops the audio traffic on the USB AFE
> + * port on the Q6DSP.
> + */
> + .shutdown = q6afe_dai_shutdown,
> + /*
> + * Startup callback not needed, as AFE port start command passes the PCM
> + * parameters within the AFE command, which is provided by the PCM core
> + * during the prepare() stage.
> + */
Humm, now this is a bit confusing. Why would you need a shutdown, can't
you use the hw_free() callback for symmetry with prepare()?
^ permalink raw reply
* Re: [PATCH v26 16/33] ASoC: doc: Add documentation for SOC USB
From: Pierre-Louis Bossart @ 2024-08-30 9:03 UTC (permalink / raw)
To: Wesley Cheng, srinivas.kandagatla, mathias.nyman, perex, conor+dt,
dmitry.torokhov, corbet, broonie, lgirdwood, tiwai, krzk+dt,
Thinh.Nguyen, bgoswami, robh, gregkh
Cc: linux-kernel, devicetree, linux-sound, linux-input, linux-usb,
linux-arm-msm, linux-doc, alsa-devel
In-Reply-To: <20240829194105.1504814-17-quic_wcheng@quicinc.com>
> diff --git a/Documentation/sound/soc/index.rst b/Documentation/sound/soc/index.rst
> index e57df2dab2fd..8bed8f8f48da 100644
> --- a/Documentation/sound/soc/index.rst
> +++ b/Documentation/sound/soc/index.rst
> @@ -18,3 +18,4 @@ The documentation is spilt into the following sections:-
> jack
> dpcm
> codec-to-codec
> + usb
> diff --git a/Documentation/sound/soc/usb.rst b/Documentation/sound/soc/usb.rst
> new file mode 100644
> index 000000000000..bd3d9eb86b07
> --- /dev/null
> +++ b/Documentation/sound/soc/usb.rst
> @@ -0,0 +1,429 @@
> +================
> +ASoC USB support
> +================
> +
> +Overview
> +========
> +In order to leverage the existing USB sound device support in ALSA, the
> +ASoC USB APIs are introduced to allow for the entities to communicate
> +with one another.
nit-pick: entities is rather vague and an overloaded term in USB audio.
Maybe "allow the subsystems to exchange configuration information"
> +One potential use case would be to support USB audio offloading, which is
> +an implementation that allows for an external DSP on the SoC to handle the
nit-pick: not sure about the reference to an 'external DSP'. "external"
would usually to a stand-alone device and there's no real need for DSP
capabilities for USB offload, e.g. a regular embedded core would do just
fine.
maybe "allows for an alternate power-optimized path in the audio
subsystem to handle the transfer of audio data over the USB bus"
> +transfer of audio data over the USB bus. This would let the main
> +processor to stay in lower power modes for longer duration. The following
> +is an example design of how the ASoC and ALSA pieces can be connected
> +together to achieve this:
> + int snd_soc_usb_update_offload_route(struct device *dev, int card, int pcm,
> + int direction, long *route)
> +..
> +
> + - ``dev``: USB device to look up offload path mapping
> + - ``card``: USB sound card index
> + - ``pcm``: USB sound PCM device index
> + - ``direction``: direction to fetch offload routing information
> + - ``route``: mapping of sound card and pcm indexes for the offload path
nit-pick: again explain how the card and pcm indices are handled.
> +--------------------------------
> +USB devices can be hotplugged into the USB root hub at any point in time.
"root hub" really?
Is this really required? I would think the entire framework would work
just fine if the device is connected to any hub at any level, not just
"the" root hub.
^ permalink raw reply
* Re: [PATCH v26 15/33] ASoC: usb: Fetch ASoC card and pcm device information
From: Pierre-Louis Bossart @ 2024-08-30 8:50 UTC (permalink / raw)
To: Wesley Cheng, srinivas.kandagatla, mathias.nyman, perex, conor+dt,
dmitry.torokhov, corbet, broonie, lgirdwood, tiwai, krzk+dt,
Thinh.Nguyen, bgoswami, robh, gregkh
Cc: linux-kernel, devicetree, linux-sound, linux-input, linux-usb,
linux-arm-msm, linux-doc, alsa-devel
In-Reply-To: <20240829194105.1504814-16-quic_wcheng@quicinc.com>
On 8/29/24 21:40, Wesley Cheng wrote:
> USB SND needs to know how the USB offload path is being routed. This would
> allow for applications to open the corresponding sound card and pcm device
> when it wants to take the audio offload path. This callback should return
> the mapped indexes based on the USB SND device information.
>
> Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> diff --git a/include/sound/soc-usb.h b/include/sound/soc-usb.h
> index 5c788cbfa82e..86876098a2b7 100644
> --- a/include/sound/soc-usb.h
> +++ b/include/sound/soc-usb.h
> @@ -36,6 +36,7 @@ struct snd_soc_usb_device {
> * @list - list head for SND SOC struct list
> * @component - reference to ASoC component
> * @connection_status_cb - callback to notify connection events
> + * @update_offload_route_info - callback to fetch mapped ASoC device
nit-pick: explain that 'route' refers to the (card, device) pair and
isn't related to the concept of DAPM route.
> * @priv_data - driver data
> **/
> struct snd_soc_usb {
> @@ -44,6 +45,9 @@ struct snd_soc_usb {
> int (*connection_status_cb)(struct snd_soc_usb *usb,
> struct snd_soc_usb_device *sdev,
> bool connected);
> + int (*update_offload_route_info)(struct snd_soc_component *component,
> + int card, int pcm, int direction,
> + long *route);
nit-pick: also explain the format used for the (card, device) pair
stored in the long
> void *priv_data;
> };
>
> @@ -59,6 +63,8 @@ void *snd_soc_usb_find_priv_data(struct device *dev);
> int snd_soc_usb_setup_offload_jack(struct snd_soc_component *component,
> struct snd_soc_jack *jack);
> int snd_soc_usb_disable_offload_jack(struct snd_soc_component *component);
> +int snd_soc_usb_update_offload_route(struct device *dev, int card, int pcm,
> + int direction, long *route);
>
> struct snd_soc_usb *snd_soc_usb_allocate_port(struct snd_soc_component *component,
> void *data);
> @@ -101,6 +107,12 @@ static inline int snd_soc_usb_disable_offload_jack(struct snd_soc_component *com
> return 0;
> }
>
> +static int snd_soc_usb_update_offload_route(struct device *dev, int card, int pcm,
> + int direction, long *route)
> +{
> + return -ENODEV;
> +}
> +
> static inline struct snd_soc_usb *
> snd_soc_usb_allocate_port(struct snd_soc_component *component, void *data)
> {
> diff --git a/sound/soc/soc-usb.c b/sound/soc/soc-usb.c
> index 3d5354298206..de249e8a28cb 100644
> --- a/sound/soc/soc-usb.c
> +++ b/sound/soc/soc-usb.c
> @@ -117,6 +117,37 @@ int snd_soc_usb_disable_offload_jack(struct snd_soc_component *component)
> }
> EXPORT_SYMBOL_GPL(snd_soc_usb_disable_offload_jack);
>
> +/**
> + * snd_soc_usb_update_offload_route - Find active USB offload path
> + * @dev - USB device to get offload status
> + * @card - USB card index
> + * @pcm - USB PCM device index
> + * @direction - playback or capture direction
> + * @route - pointer to route output array
> + *
> + * Fetch the current status for the USB SND card and PCM device indexes
> + * specified.
> + */
> +int snd_soc_usb_update_offload_route(struct device *dev, int card, int pcm,
> + int direction, long *route)
> +{
> + struct snd_soc_usb *ctx;
> + int ret;
> +
> + ctx = snd_soc_find_usb_ctx(dev);
> + if (!ctx)
> + return -ENODEV;
> +
> + mutex_lock(&ctx_mutex);
> + if (ctx && ctx->update_offload_route_info)
> + ret = ctx->update_offload_route_info(ctx->component, card, pcm,
> + direction, route);
> + mutex_unlock(&ctx_mutex);
> +
> + return ret;
> +}
> +EXPORT_SYMBOL_GPL(snd_soc_usb_update_offload_route);
> +
> /**
> * snd_soc_usb_find_priv_data() - Retrieve private data stored
> * @dev: device reference
^ permalink raw reply
* Re: [PATCH v26 14/33] ASoC: usb: Create SOC USB SND jack kcontrol
From: Pierre-Louis Bossart @ 2024-08-30 8:46 UTC (permalink / raw)
To: Wesley Cheng, srinivas.kandagatla, mathias.nyman, perex, conor+dt,
dmitry.torokhov, corbet, broonie, lgirdwood, tiwai, krzk+dt,
Thinh.Nguyen, bgoswami, robh, gregkh
Cc: linux-kernel, devicetree, linux-sound, linux-input, linux-usb,
linux-arm-msm, linux-doc, alsa-devel
In-Reply-To: <20240829194105.1504814-15-quic_wcheng@quicinc.com>
On 8/29/24 21:40, Wesley Cheng wrote:
> Expose API for creation of a jack control for notifying of available
> devices that are plugged in/discovered, and that support offloading. This
> allows for control names to be standardized across implementations of USB
> audio offloading.
>
> Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Some nit-picks below.
> diff --git a/include/sound/soc-usb.h b/include/sound/soc-usb.h
> index b550ee87b748..5c788cbfa82e 100644
> --- a/include/sound/soc-usb.h
> +++ b/include/sound/soc-usb.h
> @@ -6,6 +6,8 @@
> #ifndef __LINUX_SND_SOC_USB_H
> #define __LINUX_SND_SOC_USB_H
>
> +#include <sound/soc.h>
> +
nit-pick: move this to patch 12/33
> diff --git a/sound/soc/soc-usb.c b/sound/soc/soc-usb.c
> index 8ade2060d8fe..3d5354298206 100644
> --- a/sound/soc/soc-usb.c
> +++ b/sound/soc/soc-usb.c
> @@ -4,8 +4,10 @@
> */
> #include <linux/of.h>
> #include <linux/usb.h>
> -#include <sound/soc.h>
> +
nit-pick: move this to patch 12/33
> +#include <sound/jack.h>
> #include <sound/soc-usb.h>
> +
> #include "../usb/card.h"
>
> static DEFINE_MUTEX(ctx_mutex);
> @@ -57,6 +59,64 @@ static struct snd_soc_usb *snd_soc_find_usb_ctx(struct device *dev)
> return ctx ? ctx : NULL;
> }
>
> +/* SOC USB sound kcontrols */
> +/**
> + * snd_soc_usb_setup_offload_jack() - Create USB offloading jack
> + * @component: USB DPCM backend DAI component
> + * @jack: jack structure to create
> + *
> + * Creates a jack device for notifying userspace of the availability
> + * of an offload capable device.
> + *
> + * Returns 0 on success, negative on error.
> + *
> + */
> +int snd_soc_usb_setup_offload_jack(struct snd_soc_component *component,
> + struct snd_soc_jack *jack)
> +{
> + int ret;
> +
> + ret = snd_soc_card_jack_new(component->card, "USB Offload Jack",
> + SND_JACK_USB, jack);
> + if (ret < 0) {
> + dev_err(component->card->dev, "Unable to add USB offload jack\n");
nit-pick: be consistent and return the code in the error log as done below.
> + return ret;
> + }
> +
> + ret = snd_soc_component_set_jack(component, jack, NULL);
> + if (ret) {
> + dev_err(component->card->dev, "Failed to set jack: %d\n", ret);
> + return ret;
> + }
> +
> + return 0;
> +}
^ permalink raw reply
* Re: [PATCH v26 13/33] ASoC: usb: Add PCM format check API for USB backend
From: Pierre-Louis Bossart @ 2024-08-30 8:41 UTC (permalink / raw)
To: Wesley Cheng, srinivas.kandagatla, mathias.nyman, perex, conor+dt,
dmitry.torokhov, corbet, broonie, lgirdwood, tiwai, krzk+dt,
Thinh.Nguyen, bgoswami, robh, gregkh
Cc: linux-kernel, devicetree, linux-sound, linux-input, linux-usb,
linux-arm-msm, linux-doc, alsa-devel
In-Reply-To: <20240829194105.1504814-14-quic_wcheng@quicinc.com>
On 8/29/24 21:40, Wesley Cheng wrote:
> Introduce a helper to check if a particular PCM format is supported by the
> USB audio device connected. If the USB audio device does not have an
> audio profile which can support the requested format, then notify the USB
> backend.
>
> Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
^ permalink raw reply
* Re: [PATCH v26 12/33] ASoC: Add SOC USB APIs for adding an USB backend
From: Pierre-Louis Bossart @ 2024-08-30 8:40 UTC (permalink / raw)
To: Wesley Cheng, srinivas.kandagatla, mathias.nyman, perex, conor+dt,
dmitry.torokhov, corbet, broonie, lgirdwood, tiwai, krzk+dt,
Thinh.Nguyen, bgoswami, robh, gregkh
Cc: linux-kernel, devicetree, linux-sound, linux-input, linux-usb,
linux-arm-msm, linux-doc, alsa-devel
In-Reply-To: <20240829194105.1504814-13-quic_wcheng@quicinc.com>
On 8/29/24 21:40, Wesley Cheng wrote:
> Some platforms may have support for offloading USB audio devices to a
> dedicated audio DSP. Introduce a set of APIs that allow for management of
> USB sound card and PCM devices enumerated by the USB SND class driver.
> This allows for the ASoC components to be aware of what USB devices are
> available for offloading.
>
> Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
minor nit-picks below if you respin the series.
> +
> +/**
> + * struct snd_soc_usb_device
> + * @card_idx - sound card index associated with USB device
> + * @chip_idx - USB sound chip array index
> + * @cpcm_idx - capture PCM index array associated with USB device
> + * @ppcm_idx - playback PCM index array associated with USB device
> + * @num_playback - number of playback streams
> + * @num_capture - number of capture streams
> + * @list - list head for SoC USB devices
> + **/
> +struct snd_soc_usb_device {
> + int card_idx;
> + int chip_idx;
> +
> + /* PCM index arrays */
> + unsigned int *cpcm_idx; /* TODO: capture path is not tested yet */
> + unsigned int *ppcm_idx;
> + int num_playback;
> + int num_capture; /* TODO: capture path is not tested yet */
nit-pick: I would keep the order between capture and playback consistent.
> +int snd_soc_usb_connect(struct device *usbdev, struct snd_soc_usb_device *sdev);
> +int snd_soc_usb_disconnect(struct device *usbdev, struct snd_soc_usb_device *sdev);
> +void *snd_soc_usb_find_priv_data(struct device *dev);
nit-pick: I would keep the parameter naming consistent with
struct device *usbdev
> +static inline void *snd_soc_usb_find_priv_data(struct device *dev)
same here.
> +/**
> + * snd_soc_usb_allocate_port() - allocate a SOC USB port for offloading support
> + * @component: USB DPCM backend DAI component
> + * @num_streams: number of offloading sessions supported
> + * @data: private data
> + *
> + * Allocate and initialize a SOC USB port. The SOC USB port is used to communicate
> + * different USB audio devices attached, in order to start audio offloading handled
> + * by an ASoC entity. USB device plug in/out events are signalled with a
typo: signaled
^ permalink raw reply
* Re: [PATCH v26 11/33] ALSA: usb-audio: Check for support for requested audio format
From: Pierre-Louis Bossart @ 2024-08-30 8:34 UTC (permalink / raw)
To: Wesley Cheng, srinivas.kandagatla, mathias.nyman, perex, conor+dt,
dmitry.torokhov, corbet, broonie, lgirdwood, tiwai, krzk+dt,
Thinh.Nguyen, bgoswami, robh, gregkh
Cc: linux-kernel, devicetree, linux-sound, linux-input, linux-usb,
linux-arm-msm, linux-doc, alsa-devel
In-Reply-To: <20240829194105.1504814-12-quic_wcheng@quicinc.com>
On 8/29/24 21:40, Wesley Cheng wrote:
> Allow for checks on a specific USB audio device to see if a requested PCM
> format is supported. This is needed for support when playback is
> initiated by the ASoC USB backend path.
>
> Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
^ permalink raw reply
* Re: [PATCH v26 10/33] ALSA: usb-audio: Export USB SND APIs for modules
From: Pierre-Louis Bossart @ 2024-08-30 8:33 UTC (permalink / raw)
To: Wesley Cheng, srinivas.kandagatla, mathias.nyman, perex, conor+dt,
dmitry.torokhov, corbet, broonie, lgirdwood, tiwai, krzk+dt,
Thinh.Nguyen, bgoswami, robh, gregkh
Cc: linux-kernel, devicetree, linux-sound, linux-input, linux-usb,
linux-arm-msm, linux-doc, alsa-devel
In-Reply-To: <20240829194105.1504814-11-quic_wcheng@quicinc.com>
On 8/29/24 21:40, Wesley Cheng wrote:
> Some vendor modules will utilize useful parsing and endpoint management
> APIs to start audio playback/capture.
>
> Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
^ permalink raw reply
* Re: [PATCH v26 09/33] ALSA: Add USB audio device jack type
From: Pierre-Louis Bossart @ 2024-08-30 8:28 UTC (permalink / raw)
To: Wesley Cheng, srinivas.kandagatla, mathias.nyman, perex, conor+dt,
dmitry.torokhov, corbet, broonie, lgirdwood, tiwai, krzk+dt,
Thinh.Nguyen, bgoswami, robh, gregkh
Cc: linux-kernel, devicetree, linux-sound, linux-input, linux-usb,
linux-arm-msm, linux-doc, alsa-devel
In-Reply-To: <20240829194105.1504814-10-quic_wcheng@quicinc.com>
On 8/29/24 21:40, Wesley Cheng wrote:
> Add an USB jack type, in order to support notifying of a valid USB audio
> device. Since USB audio devices can have a slew of different
> configurations that reach beyond the basic headset and headphone use cases,
> classify these devices differently.
>
> Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
^ permalink raw reply
* Re: [PATCH v8 6/7] rtc: support i.MX95 BBM RTC
From: Alexandre Belloni @ 2024-08-30 9:12 UTC (permalink / raw)
To: Sudeep Holla
Cc: Peng Fan (OSS), Cristian Marussi, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Peng Fan, Dmitry Torokhov,
arm-scmi, linux-arm-kernel, devicetree, linux-kernel, imx,
linux-rtc, linux-input
In-Reply-To: <Zs2rz1FT1UsKQBj6@bogus>
On 27/08/2024 11:34:55+0100, Sudeep Holla wrote:
> Hi Alexandre,
>
> On Fri, Aug 23, 2024 at 05:05:22PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > The BBM module provides RTC feature. To i.MX95, this module is managed by
> > System Manager and exported System Control Management Interface(SCMI).
> > Linux could use i.MX SCMI BBM Extension protocol to use RTC feature.
> >
> > This driver is to use SCMI interface to get/set RTC.
> >
>
> Are you fine if I take this along with dependent SCMI changes via SoC tree ?
Sure, please do.
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox