* Re: [PATCH v2 00/27 5.10.y] Backport minmax.h updates from v6.17-rc7
From: Greg KH @ 2025-10-19 12:38 UTC (permalink / raw)
To: Nathan Chancellor
Cc: Eliav Farber, stable, linux, jdike, richard, anton.ivanov,
dave.hansen, luto, peterz, tglx, mingo, bp, x86, hpa, tony.luck,
qiuxu.zhuo, mchehab, james.morse, rric, harry.wentland,
sunpeng.li, alexander.deucher, christian.koenig, airlied, daniel,
evan.quan, james.qian.wang, liviu.dudau, mihail.atanassov,
brian.starkey, maarten.lankhorst, mripard, tzimmermann, robdclark,
sean, jdelvare, linux, fery, dmitry.torokhov, agk, snitzer,
dm-devel, rajur, davem, kuba, peppe.cavallaro, alexandre.torgue,
joabreu, mcoquelin.stm32, malattia, hdegoede, mgross,
intel-linux-scu, artur.paszkiewicz, jejb, martin.petersen,
sakari.ailus, clm, josef, dsterba, xiang, chao, jack, tytso,
adilger.kernel, dushistov, luc.vanoostenryck, rostedt, pmladek,
sergey.senozhatsky, andriy.shevchenko, linux, minchan, ngupta,
akpm, kuznet, yoshfuji, pablo, kadlec, fw, jmaloy, ying.xue,
willy, sashal, ruanjinjie, David.Laight, herve.codina, Jason,
keescook, kbusch, bvanassche, ndesaulniers, linux-arm-kernel,
linux-kernel, linux-um, linux-edac, amd-gfx, dri-devel,
linux-arm-msm, freedreno, linux-hwmon, linux-input, linux-media,
netdev, linux-stm32, platform-driver-x86, linux-scsi,
linux-staging, linux-btrfs, linux-erofs, linux-ext4, linux-sparse,
linux-mm, netfilter-devel, coreteam, tipc-discussion
In-Reply-To: <20251017160924.GA2728735@ax162>
On Fri, Oct 17, 2025 at 05:09:24PM +0100, Nathan Chancellor wrote:
> On Fri, Oct 17, 2025 at 05:03:02PM +0200, Greg KH wrote:
> > On Fri, Oct 17, 2025 at 09:04:52AM +0000, Eliav Farber wrote:
> > > This series backports 27 patches to update minmax.h in the 5.10.y
> > > branch, aligning it with v6.17-rc7.
> > >
> > > The ultimate goal is to synchronize all long-term branches so that they
> > > include the full set of minmax.h changes.
> > >
> > > - 6.12.y has already been backported; the changes are included in
> > > v6.12.49.
> > > - 6.6.y has already been backported; the changes are included in
> > > v6.6.109.
> > > - 6.1.y has already been backported; the changes are currently in the
> > > 6.1-stable tree.
> > > - 5.15.y has already been backported; the changes are currently in the
> > > 5.15-stable tree.
> >
> > With this series applied, on an arm64 server, building 'allmodconfig', I
> > get the following build error.
> >
> > Oddly I don't see it on my x86 server, perhaps due to different compiler
> > versions?
> >
> > Any ideas?
> >
> > thanks,
> >
> > greg k-h
> >
> > ------------------------
> >
> > In function ‘rt2800_txpower_to_dev’,
> > inlined from ‘rt2800_config_channel’ at ../drivers/net/wireless/ralink/rt2x00/rt2800lib.c:4022:25:
> > ./../include/linux/compiler_types.h:309:45: error: call to ‘__compiletime_assert_1168’ declared with attribute error: clamp() low limit -7 greater than high limit 15
> > 309 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
> > | ^
> > ./../include/linux/compiler_types.h:290:25: note: in definition of macro ‘__compiletime_assert’
> > 290 | prefix ## suffix(); \
> > | ^~~~~~
> > ./../include/linux/compiler_types.h:309:9: note: in expansion of macro ‘_compiletime_assert’
> > 309 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
> > | ^~~~~~~~~~~~~~~~~~~
> > ../include/linux/build_bug.h:39:37: note: in expansion of macro ‘compiletime_assert’
> > 39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
> > | ^~~~~~~~~~~~~~~~~~
> > ../include/linux/minmax.h:188:9: note: in expansion of macro ‘BUILD_BUG_ON_MSG’
> > 188 | BUILD_BUG_ON_MSG(statically_true(ulo > uhi), \
> > | ^~~~~~~~~~~~~~~~
> > ../include/linux/minmax.h:195:9: note: in expansion of macro ‘__clamp_once’
> > 195 | __clamp_once(type, val, lo, hi, __UNIQUE_ID(v_), __UNIQUE_ID(l_), __UNIQUE_ID(h_))
> > | ^~~~~~~~~~~~
> > ../include/linux/minmax.h:218:36: note: in expansion of macro ‘__careful_clamp’
> > 218 | #define clamp_t(type, val, lo, hi) __careful_clamp(type, val, lo, hi)
> > | ^~~~~~~~~~~~~~~
> > ../drivers/net/wireless/ralink/rt2x00/rt2800lib.c:3980:24: note: in expansion of macro ‘clamp_t’
> > 3980 | return clamp_t(char, txpower, MIN_A_TXPOWER, MAX_A_TXPOWER);
> > | ^~~~~~~
>
> Missing commit 3bc753c06dd0 ("kbuild: treat char as always unsigned")?
That's going to be messy to backport, it's not even in 6.1.y, so let's
leave that alone if at all possible.
thanks,
greg k-h
^ permalink raw reply
* Re: [PATCH v2 00/27 5.10.y] Backport minmax.h updates from v6.17-rc7
From: Greg KH @ 2025-10-19 12:37 UTC (permalink / raw)
To: Farber, Eliav
Cc: stable@vger.kernel.org, linux@armlinux.org.uk, jdike@addtoit.com,
richard@nod.at, anton.ivanov@cambridgegreys.com,
dave.hansen@linux.intel.com, luto@kernel.org,
peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, x86@kernel.org, hpa@zytor.com, tony.luck@intel.com,
qiuxu.zhuo@intel.com, mchehab@kernel.org, james.morse@arm.com,
rric@kernel.org, harry.wentland@amd.com, sunpeng.li@amd.com,
alexander.deucher@amd.com, christian.koenig@amd.com,
airlied@linux.ie, daniel@ffwll.ch, evan.quan@amd.com,
james.qian.wang@arm.com, liviu.dudau@arm.com,
mihail.atanassov@arm.com, brian.starkey@arm.com,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, robdclark@gmail.com, sean@poorly.run,
jdelvare@suse.com, linux@roeck-us.net, fery@cypress.com,
dmitry.torokhov@gmail.com, agk@redhat.com, snitzer@redhat.com,
dm-devel@redhat.com, rajur@chelsio.com, davem@davemloft.net,
kuba@kernel.org, peppe.cavallaro@st.com, alexandre.torgue@st.com,
joabreu@synopsys.com, mcoquelin.stm32@gmail.com,
malattia@linux.it, hdegoede@redhat.com, mgross@linux.intel.com,
intel-linux-scu@intel.com, artur.paszkiewicz@intel.com,
jejb@linux.ibm.com, martin.petersen@oracle.com,
sakari.ailus@linux.intel.com, clm@fb.com, josef@toxicpanda.com,
dsterba@suse.com, xiang@kernel.org, chao@kernel.org,
jack@suse.com, tytso@mit.edu, adilger.kernel@dilger.ca,
dushistov@mail.ru, luc.vanoostenryck@gmail.com,
rostedt@goodmis.org, pmladek@suse.com,
sergey.senozhatsky@gmail.com, andriy.shevchenko@linux.intel.com,
linux@rasmusvillemoes.dk, minchan@kernel.org, ngupta@vflare.org,
akpm@linux-foundation.org, kuznet@ms2.inr.ac.ru,
yoshfuji@linux-ipv6.org, pablo@netfilter.org,
kadlec@netfilter.org, fw@strlen.de, jmaloy@redhat.com,
ying.xue@windriver.com, willy@infradead.org, sashal@kernel.org,
ruanjinjie@huawei.com, David.Laight@aculab.com,
herve.codina@bootlin.com, Jason@zx2c4.com, keescook@chromium.org,
kbusch@kernel.org, nathan@kernel.org, bvanassche@acm.org,
ndesaulniers@google.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-um@lists.infradead.org,
linux-edac@vger.kernel.org, amd-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
freedreno@lists.freedesktop.org, linux-hwmon@vger.kernel.org,
linux-input@vger.kernel.org, linux-media@vger.kernel.org,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
platform-driver-x86@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-staging@lists.linux.dev, linux-btrfs@vger.kernel.org,
linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org,
linux-sparse@vger.kernel.org, linux-mm@kvack.org,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
tipc-discussion@lists.sourceforge.net
In-Reply-To: <CH0PR18MB5433BB2E99395D2AC8B0E0FBC6F7A@CH0PR18MB5433.namprd18.prod.outlook.com>
On Sat, Oct 18, 2025 at 08:07:32PM +0000, Farber, Eliav wrote:
> > On Fri, Oct 17, 2025 at 09:04:52AM +0000, Eliav Farber wrote:
> > > This series backports 27 patches to update minmax.h in the 5.10.y
> > > branch, aligning it with v6.17-rc7.
> > >
> > > The ultimate goal is to synchronize all long-term branches so that they
> > > include the full set of minmax.h changes.
> > >
> > > - 6.12.y has already been backported; the changes are included in
> > > v6.12.49.
> > > - 6.6.y has already been backported; the changes are included in
> > > v6.6.109.
> > > - 6.1.y has already been backported; the changes are currently in the
> > > 6.1-stable tree.
> > > - 5.15.y has already been backported; the changes are currently in the
> > > 5.15-stable tree.
> >
> > With this series applied, on an arm64 server, building 'allmodconfig', I
> > get the following build error.
> >
> > Oddly I don't see it on my x86 server, perhaps due to different compiler
> > versions?
> >
> > Any ideas?
>
> This mainline commit is missing:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/net/wireless/ralink/rt2x00/rt2800lib.c?h=v6.18-rc1&id=66063033f77e10b985258126a97573f84bb8d3b4
>
> This fix already exists in 5.15.y:
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/drivers/net/wireless/ralink/rt2x00/rt2800lib.c?h=v5.15.194&id=2d3cef3d7a5df260a14a6679c4aca0c97e570ee5
> …but is missing in 5.10.y.
>
> I now backported it to 5.10.y here:
> https://lore.kernel.org/stable/20251018195945.18825-1-farbere@amazon.com/T/#u
Thanks,I've queued that up now.
greg k-h
^ permalink raw reply
* [dtor-input:next] BUILD SUCCESS e8ec34ed4616043026aa11caa2daf9cecb4b93a7
From: kernel test robot @ 2025-10-19 6:03 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: linux-input
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
branch HEAD: e8ec34ed4616043026aa11caa2daf9cecb4b93a7 dt-bindings: input: ti,twl4030-keypad: convert to DT schema
elapsed time: 1449m
configs tested: 249
configs skipped: 8
The following configs have been built successfully.
More configs may be tested in the coming days.
tested configs:
alpha allnoconfig clang-22
alpha allnoconfig gcc-15.1.0
alpha allyesconfig clang-19
alpha allyesconfig gcc-15.1.0
alpha defconfig clang-19
alpha defconfig gcc-15.1.0
arc allmodconfig gcc-15.1.0
arc allnoconfig clang-22
arc allnoconfig gcc-15.1.0
arc allyesconfig gcc-15.1.0
arc axs101_defconfig gcc-15.1.0
arc defconfig clang-19
arc defconfig gcc-15.1.0
arc randconfig-001-20251018 gcc-12.5.0
arc randconfig-001-20251019 clang-22
arc randconfig-002-20251018 gcc-8.5.0
arc randconfig-002-20251019 clang-22
arm allmodconfig gcc-15.1.0
arm allnoconfig clang-22
arm allyesconfig gcc-15.1.0
arm am200epdkit_defconfig gcc-15.1.0
arm defconfig clang-19
arm defconfig clang-22
arm milbeaut_m10v_defconfig clang-19
arm randconfig-001-20251018 clang-19
arm randconfig-001-20251019 clang-22
arm randconfig-002-20251018 clang-20
arm randconfig-002-20251019 clang-22
arm randconfig-003-20251018 clang-22
arm randconfig-003-20251019 clang-22
arm randconfig-004-20251018 gcc-15.1.0
arm randconfig-004-20251019 clang-22
arm64 allmodconfig clang-19
arm64 allnoconfig clang-22
arm64 allnoconfig gcc-15.1.0
arm64 defconfig clang-19
arm64 defconfig gcc-15.1.0
arm64 randconfig-001-20251018 gcc-8.5.0
arm64 randconfig-001-20251019 clang-22
arm64 randconfig-002-20251018 clang-22
arm64 randconfig-002-20251019 clang-22
arm64 randconfig-003-20251018 gcc-13.4.0
arm64 randconfig-003-20251019 clang-22
arm64 randconfig-004-20251018 gcc-11.5.0
arm64 randconfig-004-20251019 clang-22
csky allnoconfig clang-22
csky allnoconfig gcc-15.1.0
csky defconfig clang-19
csky defconfig gcc-15.1.0
csky randconfig-001-20251018 gcc-9.5.0
csky randconfig-001-20251019 clang-16
csky randconfig-002-20251018 gcc-9.5.0
csky randconfig-002-20251019 clang-16
hexagon allmodconfig clang-17
hexagon allmodconfig clang-19
hexagon allnoconfig clang-22
hexagon allyesconfig clang-19
hexagon allyesconfig clang-22
hexagon defconfig clang-19
hexagon defconfig clang-22
hexagon randconfig-001-20251018 clang-22
hexagon randconfig-001-20251019 clang-16
hexagon randconfig-002-20251018 clang-22
hexagon randconfig-002-20251019 clang-16
i386 allmodconfig clang-20
i386 allmodconfig gcc-14
i386 allnoconfig clang-20
i386 allnoconfig gcc-14
i386 allyesconfig clang-20
i386 allyesconfig gcc-14
i386 buildonly-randconfig-001-20251018 gcc-14
i386 buildonly-randconfig-001-20251019 gcc-13
i386 buildonly-randconfig-002-20251018 gcc-14
i386 buildonly-randconfig-002-20251019 gcc-13
i386 buildonly-randconfig-003-20251018 clang-20
i386 buildonly-randconfig-003-20251019 gcc-13
i386 buildonly-randconfig-004-20251018 gcc-14
i386 buildonly-randconfig-004-20251019 gcc-13
i386 buildonly-randconfig-005-20251018 clang-20
i386 buildonly-randconfig-005-20251019 gcc-13
i386 buildonly-randconfig-006-20251018 clang-20
i386 buildonly-randconfig-006-20251019 gcc-13
i386 defconfig clang-20
i386 randconfig-001-20251019 clang-20
i386 randconfig-002-20251019 clang-20
i386 randconfig-003-20251019 clang-20
i386 randconfig-004-20251019 clang-20
i386 randconfig-005-20251019 clang-20
i386 randconfig-006-20251019 clang-20
i386 randconfig-007-20251019 clang-20
i386 randconfig-011-20251019 gcc-14
i386 randconfig-012-20251019 gcc-14
i386 randconfig-013-20251019 gcc-14
i386 randconfig-014-20251019 gcc-14
i386 randconfig-015-20251019 gcc-14
i386 randconfig-016-20251019 gcc-14
i386 randconfig-017-20251019 gcc-14
loongarch allmodconfig clang-19
loongarch allnoconfig clang-22
loongarch defconfig clang-19
loongarch randconfig-001-20251018 clang-22
loongarch randconfig-001-20251019 clang-16
loongarch randconfig-002-20251018 gcc-13.4.0
loongarch randconfig-002-20251019 clang-16
m68k allmodconfig clang-19
m68k allmodconfig gcc-15.1.0
m68k allnoconfig gcc-15.1.0
m68k allyesconfig clang-19
m68k allyesconfig gcc-15.1.0
m68k atari_defconfig gcc-15.1.0
m68k defconfig clang-19
m68k defconfig gcc-15.1.0
microblaze allmodconfig clang-19
microblaze allmodconfig gcc-15.1.0
microblaze allnoconfig gcc-15.1.0
microblaze allyesconfig clang-19
microblaze allyesconfig gcc-15.1.0
microblaze defconfig gcc-15.1.0
mips allnoconfig gcc-15.1.0
mips bcm63xx_defconfig clang-22
nios2 allnoconfig gcc-11.5.0
nios2 defconfig gcc-11.5.0
nios2 defconfig gcc-15.1.0
nios2 randconfig-001-20251018 gcc-11.5.0
nios2 randconfig-001-20251019 clang-16
nios2 randconfig-002-20251018 gcc-8.5.0
nios2 randconfig-002-20251019 clang-16
openrisc allnoconfig gcc-15.1.0
openrisc allyesconfig gcc-15.1.0
openrisc defconfig gcc-14
parisc allmodconfig gcc-15.1.0
parisc allnoconfig gcc-15.1.0
parisc allyesconfig gcc-15.1.0
parisc defconfig gcc-15.1.0
parisc randconfig-001-20251018 gcc-10.5.0
parisc randconfig-001-20251019 clang-16
parisc randconfig-002-20251018 gcc-14.3.0
parisc randconfig-002-20251019 clang-16
parisc64 defconfig gcc-15.1.0
powerpc allmodconfig gcc-15.1.0
powerpc allnoconfig gcc-15.1.0
powerpc allyesconfig clang-22
powerpc holly_defconfig clang-22
powerpc mpc834x_itx_defconfig clang-16
powerpc mpc866_ads_defconfig clang-22
powerpc rainier_defconfig gcc-15.1.0
powerpc randconfig-001-20251018 clang-22
powerpc randconfig-001-20251019 clang-16
powerpc randconfig-002-20251018 clang-22
powerpc randconfig-002-20251019 clang-16
powerpc randconfig-003-20251018 gcc-14.3.0
powerpc randconfig-003-20251019 clang-16
powerpc warp_defconfig gcc-15.1.0
powerpc64 randconfig-001-20251018 gcc-10.5.0
powerpc64 randconfig-002-20251018 gcc-12.5.0
powerpc64 randconfig-002-20251019 clang-16
powerpc64 randconfig-003-20251018 clang-22
riscv allmodconfig clang-22
riscv allnoconfig gcc-15.1.0
riscv allyesconfig clang-16
riscv defconfig gcc-14
riscv randconfig-001-20251019 clang-19
riscv randconfig-001-20251019 gcc-11.5.0
riscv randconfig-002-20251019 gcc-11.5.0
s390 allmodconfig clang-18
s390 allmodconfig gcc-15.1.0
s390 allnoconfig clang-22
s390 allyesconfig gcc-15.1.0
s390 defconfig gcc-14
s390 randconfig-001-20251019 gcc-11.5.0
s390 randconfig-001-20251019 gcc-8.5.0
s390 randconfig-002-20251019 clang-22
s390 randconfig-002-20251019 gcc-11.5.0
sh allmodconfig gcc-15.1.0
sh allnoconfig gcc-15.1.0
sh allyesconfig gcc-15.1.0
sh defconfig gcc-14
sh edosk7705_defconfig gcc-15.1.0
sh kfr2r09-romimage_defconfig gcc-15.1.0
sh randconfig-001-20251019 gcc-11.5.0
sh randconfig-001-20251019 gcc-15.1.0
sh randconfig-002-20251019 gcc-11.5.0
sh randconfig-002-20251019 gcc-15.1.0
sh sdk7786_defconfig gcc-15.1.0
sparc alldefconfig gcc-15.1.0
sparc allmodconfig gcc-15.1.0
sparc allnoconfig gcc-15.1.0
sparc defconfig gcc-15.1.0
sparc randconfig-001-20251019 gcc-11.5.0
sparc randconfig-002-20251019 gcc-11.5.0
sparc randconfig-002-20251019 gcc-13.4.0
sparc64 defconfig gcc-14
sparc64 randconfig-001-20251019 gcc-11.5.0
sparc64 randconfig-001-20251019 gcc-8.5.0
sparc64 randconfig-002-20251019 gcc-11.5.0
sparc64 randconfig-002-20251019 gcc-14.3.0
um allmodconfig clang-19
um allnoconfig clang-22
um allyesconfig clang-19
um allyesconfig gcc-14
um defconfig gcc-14
um i386_defconfig gcc-14
um randconfig-001-20251019 gcc-11.5.0
um randconfig-001-20251019 gcc-13
um randconfig-002-20251019 clang-22
um randconfig-002-20251019 gcc-11.5.0
um x86_64_defconfig gcc-14
x86_64 allnoconfig clang-20
x86_64 allyesconfig clang-20
x86_64 buildonly-randconfig-001-20251018 gcc-14
x86_64 buildonly-randconfig-001-20251019 clang-20
x86_64 buildonly-randconfig-002-20251018 gcc-14
x86_64 buildonly-randconfig-002-20251019 clang-20
x86_64 buildonly-randconfig-003-20251018 gcc-14
x86_64 buildonly-randconfig-003-20251019 clang-20
x86_64 buildonly-randconfig-004-20251018 gcc-14
x86_64 buildonly-randconfig-004-20251019 clang-20
x86_64 buildonly-randconfig-005-20251018 gcc-14
x86_64 buildonly-randconfig-005-20251019 clang-20
x86_64 buildonly-randconfig-006-20251018 clang-20
x86_64 buildonly-randconfig-006-20251019 clang-20
x86_64 defconfig clang-20
x86_64 defconfig gcc-14
x86_64 kexec clang-20
x86_64 randconfig-001-20251019 clang-20
x86_64 randconfig-002-20251019 clang-20
x86_64 randconfig-003-20251019 clang-20
x86_64 randconfig-004-20251019 clang-20
x86_64 randconfig-005-20251019 clang-20
x86_64 randconfig-006-20251019 clang-20
x86_64 randconfig-007-20251019 clang-20
x86_64 randconfig-008-20251019 clang-20
x86_64 randconfig-071-20251019 clang-20
x86_64 randconfig-072-20251019 clang-20
x86_64 randconfig-073-20251019 clang-20
x86_64 randconfig-074-20251019 clang-20
x86_64 randconfig-075-20251019 clang-20
x86_64 randconfig-076-20251019 clang-20
x86_64 randconfig-077-20251019 clang-20
x86_64 randconfig-078-20251019 clang-20
x86_64 rhel-9.4 clang-20
x86_64 rhel-9.4-func clang-20
x86_64 rhel-9.4-kselftests clang-20
x86_64 rhel-9.4-rust clang-20
xtensa allnoconfig gcc-15.1.0
xtensa randconfig-001-20251019 gcc-11.5.0
xtensa randconfig-001-20251019 gcc-14.3.0
xtensa randconfig-002-20251019 gcc-11.5.0
xtensa randconfig-002-20251019 gcc-8.5.0
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply
* [dtor-input:for-linus] BUILD SUCCESS 69aeb507312306f73495598a055293fa749d454e
From: kernel test robot @ 2025-10-19 6:02 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: linux-input
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus
branch HEAD: 69aeb507312306f73495598a055293fa749d454e Input: pegasus-notetaker - fix potential out-of-bounds access
elapsed time: 1449m
configs tested: 243
configs skipped: 7
The following configs have been built successfully.
More configs may be tested in the coming days.
tested configs:
alpha allnoconfig clang-22
alpha allnoconfig gcc-15.1.0
alpha allyesconfig clang-19
alpha allyesconfig gcc-15.1.0
alpha defconfig clang-19
arc allmodconfig gcc-15.1.0
arc allnoconfig clang-22
arc allnoconfig gcc-15.1.0
arc allyesconfig gcc-15.1.0
arc axs101_defconfig clang-22
arc defconfig clang-19
arc nsim_700_defconfig gcc-15.1.0
arc randconfig-001-20251018 gcc-12.5.0
arc randconfig-001-20251019 clang-22
arc randconfig-002-20251018 gcc-8.5.0
arc randconfig-002-20251019 clang-22
arm allmodconfig gcc-15.1.0
arm allnoconfig clang-22
arm allyesconfig gcc-15.1.0
arm defconfig clang-19
arm randconfig-001-20251018 clang-19
arm randconfig-001-20251019 clang-22
arm randconfig-002-20251018 clang-20
arm randconfig-002-20251019 clang-22
arm randconfig-003-20251018 clang-22
arm randconfig-003-20251019 clang-22
arm randconfig-004-20251018 gcc-15.1.0
arm randconfig-004-20251019 clang-22
arm64 allmodconfig clang-19
arm64 allnoconfig clang-22
arm64 allnoconfig gcc-15.1.0
arm64 defconfig clang-19
arm64 randconfig-001-20251018 gcc-8.5.0
arm64 randconfig-001-20251019 clang-22
arm64 randconfig-002-20251018 clang-22
arm64 randconfig-002-20251019 clang-22
arm64 randconfig-003-20251018 gcc-13.4.0
arm64 randconfig-003-20251019 clang-22
arm64 randconfig-004-20251018 gcc-11.5.0
arm64 randconfig-004-20251019 clang-22
csky allnoconfig clang-22
csky allnoconfig gcc-15.1.0
csky defconfig clang-19
csky randconfig-001-20251018 gcc-9.5.0
csky randconfig-001-20251019 clang-16
csky randconfig-002-20251018 gcc-9.5.0
csky randconfig-002-20251019 clang-16
hexagon allmodconfig clang-17
hexagon allmodconfig clang-19
hexagon allnoconfig clang-22
hexagon allyesconfig clang-19
hexagon allyesconfig clang-22
hexagon defconfig clang-19
hexagon randconfig-001-20251018 clang-22
hexagon randconfig-001-20251019 clang-16
hexagon randconfig-002-20251018 clang-22
hexagon randconfig-002-20251019 clang-16
i386 allmodconfig clang-20
i386 allmodconfig gcc-14
i386 allnoconfig clang-20
i386 allnoconfig gcc-14
i386 allyesconfig clang-20
i386 allyesconfig gcc-14
i386 buildonly-randconfig-001-20251018 gcc-14
i386 buildonly-randconfig-001-20251019 gcc-13
i386 buildonly-randconfig-002-20251018 gcc-14
i386 buildonly-randconfig-002-20251019 gcc-13
i386 buildonly-randconfig-003-20251018 clang-20
i386 buildonly-randconfig-003-20251019 gcc-13
i386 buildonly-randconfig-004-20251018 gcc-14
i386 buildonly-randconfig-004-20251019 gcc-13
i386 buildonly-randconfig-005-20251018 clang-20
i386 buildonly-randconfig-005-20251019 gcc-13
i386 buildonly-randconfig-006-20251018 clang-20
i386 buildonly-randconfig-006-20251019 gcc-13
i386 defconfig clang-20
i386 randconfig-001-20251019 clang-20
i386 randconfig-002-20251019 clang-20
i386 randconfig-003-20251019 clang-20
i386 randconfig-004-20251019 clang-20
i386 randconfig-005-20251019 clang-20
i386 randconfig-006-20251019 clang-20
i386 randconfig-007-20251019 clang-20
i386 randconfig-011-20251019 gcc-14
i386 randconfig-012-20251019 gcc-14
i386 randconfig-013-20251019 gcc-14
i386 randconfig-014-20251019 gcc-14
i386 randconfig-015-20251019 gcc-14
i386 randconfig-016-20251019 gcc-14
i386 randconfig-017-20251019 gcc-14
loongarch allmodconfig clang-19
loongarch allnoconfig clang-22
loongarch defconfig clang-19
loongarch randconfig-001-20251018 clang-22
loongarch randconfig-001-20251019 clang-16
loongarch randconfig-002-20251018 gcc-13.4.0
loongarch randconfig-002-20251019 clang-16
m68k allmodconfig clang-19
m68k allmodconfig gcc-15.1.0
m68k allnoconfig gcc-15.1.0
m68k allyesconfig clang-19
m68k allyesconfig gcc-15.1.0
m68k amcore_defconfig gcc-15.1.0
m68k apollo_defconfig gcc-15.1.0
m68k atari_defconfig clang-22
m68k defconfig clang-19
microblaze allmodconfig clang-19
microblaze allmodconfig gcc-15.1.0
microblaze allnoconfig gcc-15.1.0
microblaze allyesconfig clang-19
microblaze allyesconfig gcc-15.1.0
microblaze defconfig gcc-15.1.0
mips allnoconfig gcc-15.1.0
mips bcm63xx_defconfig clang-22
mips ip30_defconfig gcc-15.1.0
nios2 allnoconfig gcc-11.5.0
nios2 defconfig gcc-11.5.0
nios2 defconfig gcc-15.1.0
nios2 randconfig-001-20251018 gcc-11.5.0
nios2 randconfig-001-20251019 clang-16
nios2 randconfig-002-20251018 gcc-8.5.0
nios2 randconfig-002-20251019 clang-16
openrisc allnoconfig clang-22
openrisc allnoconfig gcc-15.1.0
openrisc allyesconfig gcc-15.1.0
openrisc defconfig gcc-14
parisc allmodconfig gcc-15.1.0
parisc allnoconfig clang-22
parisc allnoconfig gcc-15.1.0
parisc allyesconfig gcc-15.1.0
parisc defconfig gcc-15.1.0
parisc randconfig-001-20251018 gcc-10.5.0
parisc randconfig-001-20251019 clang-16
parisc randconfig-002-20251018 gcc-14.3.0
parisc randconfig-002-20251019 clang-16
parisc64 defconfig gcc-15.1.0
powerpc allnoconfig clang-22
powerpc allnoconfig gcc-15.1.0
powerpc amigaone_defconfig gcc-15.1.0
powerpc fsp2_defconfig gcc-15.1.0
powerpc mpc834x_itx_defconfig clang-22
powerpc mpc866_ads_defconfig clang-22
powerpc randconfig-001-20251018 clang-22
powerpc randconfig-001-20251019 clang-16
powerpc randconfig-002-20251018 clang-22
powerpc randconfig-002-20251019 clang-16
powerpc randconfig-003-20251018 gcc-14.3.0
powerpc randconfig-003-20251019 clang-16
powerpc warp_defconfig gcc-15.1.0
powerpc64 randconfig-001-20251018 gcc-10.5.0
powerpc64 randconfig-002-20251018 gcc-12.5.0
powerpc64 randconfig-002-20251019 clang-16
powerpc64 randconfig-003-20251018 clang-22
riscv allnoconfig clang-22
riscv allnoconfig gcc-15.1.0
riscv defconfig gcc-14
riscv randconfig-001-20251019 clang-19
riscv randconfig-001-20251019 gcc-11.5.0
riscv randconfig-002-20251019 gcc-11.5.0
s390 allmodconfig clang-18
s390 allmodconfig gcc-15.1.0
s390 allnoconfig clang-22
s390 allyesconfig gcc-15.1.0
s390 defconfig gcc-14
s390 randconfig-001-20251019 gcc-11.5.0
s390 randconfig-001-20251019 gcc-8.5.0
s390 randconfig-002-20251019 clang-22
s390 randconfig-002-20251019 gcc-11.5.0
sh allmodconfig gcc-15.1.0
sh allnoconfig gcc-15.1.0
sh allyesconfig gcc-15.1.0
sh defconfig gcc-14
sh espt_defconfig gcc-15.1.0
sh randconfig-001-20251019 gcc-11.5.0
sh randconfig-001-20251019 gcc-15.1.0
sh randconfig-002-20251019 gcc-11.5.0
sh randconfig-002-20251019 gcc-15.1.0
sh sdk7786_defconfig clang-22
sparc alldefconfig clang-22
sparc allmodconfig gcc-15.1.0
sparc allnoconfig gcc-15.1.0
sparc defconfig gcc-15.1.0
sparc randconfig-001-20251019 gcc-11.5.0
sparc randconfig-002-20251019 gcc-11.5.0
sparc randconfig-002-20251019 gcc-13.4.0
sparc64 defconfig gcc-14
sparc64 randconfig-001-20251019 gcc-11.5.0
sparc64 randconfig-001-20251019 gcc-8.5.0
sparc64 randconfig-002-20251019 gcc-11.5.0
sparc64 randconfig-002-20251019 gcc-14.3.0
um allmodconfig clang-19
um allnoconfig clang-22
um allyesconfig clang-19
um allyesconfig gcc-14
um defconfig gcc-14
um i386_defconfig gcc-14
um randconfig-001-20251019 gcc-11.5.0
um randconfig-001-20251019 gcc-13
um randconfig-002-20251019 clang-22
um randconfig-002-20251019 gcc-11.5.0
um x86_64_defconfig gcc-14
x86_64 allnoconfig clang-20
x86_64 allyesconfig clang-20
x86_64 buildonly-randconfig-001-20251018 gcc-14
x86_64 buildonly-randconfig-001-20251019 clang-20
x86_64 buildonly-randconfig-002-20251018 gcc-14
x86_64 buildonly-randconfig-002-20251019 clang-20
x86_64 buildonly-randconfig-003-20251018 gcc-14
x86_64 buildonly-randconfig-003-20251019 clang-20
x86_64 buildonly-randconfig-004-20251018 gcc-14
x86_64 buildonly-randconfig-004-20251019 clang-20
x86_64 buildonly-randconfig-005-20251018 gcc-14
x86_64 buildonly-randconfig-005-20251019 clang-20
x86_64 buildonly-randconfig-006-20251018 clang-20
x86_64 buildonly-randconfig-006-20251019 clang-20
x86_64 defconfig clang-20
x86_64 defconfig gcc-14
x86_64 kexec clang-20
x86_64 randconfig-001-20251019 clang-20
x86_64 randconfig-002-20251019 clang-20
x86_64 randconfig-003-20251019 clang-20
x86_64 randconfig-004-20251019 clang-20
x86_64 randconfig-005-20251019 clang-20
x86_64 randconfig-006-20251019 clang-20
x86_64 randconfig-007-20251019 clang-20
x86_64 randconfig-008-20251019 clang-20
x86_64 randconfig-071-20251019 clang-20
x86_64 randconfig-072-20251019 clang-20
x86_64 randconfig-073-20251019 clang-20
x86_64 randconfig-074-20251019 clang-20
x86_64 randconfig-075-20251019 clang-20
x86_64 randconfig-076-20251019 clang-20
x86_64 randconfig-077-20251019 clang-20
x86_64 randconfig-078-20251019 clang-20
x86_64 rhel-9.4 clang-20
x86_64 rhel-9.4-func clang-20
x86_64 rhel-9.4-kselftests clang-20
x86_64 rhel-9.4-rust clang-20
xtensa allnoconfig gcc-15.1.0
xtensa randconfig-001-20251019 gcc-11.5.0
xtensa randconfig-001-20251019 gcc-14.3.0
xtensa randconfig-002-20251019 gcc-11.5.0
xtensa randconfig-002-20251019 gcc-8.5.0
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply
* RE: [PATCH v2 00/27 5.10.y] Backport minmax.h updates from v6.17-rc7
From: Farber, Eliav @ 2025-10-18 20:07 UTC (permalink / raw)
To: Greg KH
Cc: stable@vger.kernel.org, linux@armlinux.org.uk, jdike@addtoit.com,
richard@nod.at, anton.ivanov@cambridgegreys.com,
dave.hansen@linux.intel.com, luto@kernel.org,
peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, x86@kernel.org, hpa@zytor.com, tony.luck@intel.com,
qiuxu.zhuo@intel.com, mchehab@kernel.org, james.morse@arm.com,
rric@kernel.org, harry.wentland@amd.com, sunpeng.li@amd.com,
alexander.deucher@amd.com, christian.koenig@amd.com,
airlied@linux.ie, daniel@ffwll.ch, evan.quan@amd.com,
james.qian.wang@arm.com, liviu.dudau@arm.com,
mihail.atanassov@arm.com, brian.starkey@arm.com,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, robdclark@gmail.com, sean@poorly.run,
jdelvare@suse.com, linux@roeck-us.net, fery@cypress.com,
dmitry.torokhov@gmail.com, agk@redhat.com, snitzer@redhat.com,
dm-devel@redhat.com, rajur@chelsio.com, davem@davemloft.net,
kuba@kernel.org, peppe.cavallaro@st.com, alexandre.torgue@st.com,
joabreu@synopsys.com, mcoquelin.stm32@gmail.com,
malattia@linux.it, hdegoede@redhat.com, mgross@linux.intel.com,
intel-linux-scu@intel.com, artur.paszkiewicz@intel.com,
jejb@linux.ibm.com, martin.petersen@oracle.com,
sakari.ailus@linux.intel.com, clm@fb.com, josef@toxicpanda.com,
dsterba@suse.com, xiang@kernel.org, chao@kernel.org,
jack@suse.com, tytso@mit.edu, adilger.kernel@dilger.ca,
dushistov@mail.ru, luc.vanoostenryck@gmail.com,
rostedt@goodmis.org, pmladek@suse.com,
sergey.senozhatsky@gmail.com, andriy.shevchenko@linux.intel.com,
linux@rasmusvillemoes.dk, minchan@kernel.org, ngupta@vflare.org,
akpm@linux-foundation.org, kuznet@ms2.inr.ac.ru,
yoshfuji@linux-ipv6.org, pablo@netfilter.org,
kadlec@netfilter.org, fw@strlen.de, jmaloy@redhat.com,
ying.xue@windriver.com, willy@infradead.org, sashal@kernel.org,
ruanjinjie@huawei.com, David.Laight@aculab.com,
herve.codina@bootlin.com, Jason@zx2c4.com, keescook@chromium.org,
kbusch@kernel.org, nathan@kernel.org, bvanassche@acm.org,
ndesaulniers@google.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-um@lists.infradead.org,
linux-edac@vger.kernel.org, amd-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
freedreno@lists.freedesktop.org, linux-hwmon@vger.kernel.org,
linux-input@vger.kernel.org, linux-media@vger.kernel.org,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
platform-driver-x86@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-staging@lists.linux.dev, linux-btrfs@vger.kernel.org,
linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org,
linux-sparse@vger.kernel.org, linux-mm@kvack.org,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
tipc-discussion@lists.sourceforge.net, Farber, Eliav
In-Reply-To: <2025101704-rumble-chatroom-60b5@gregkh>
> On Fri, Oct 17, 2025 at 09:04:52AM +0000, Eliav Farber wrote:
> > This series backports 27 patches to update minmax.h in the 5.10.y
> > branch, aligning it with v6.17-rc7.
> >
> > The ultimate goal is to synchronize all long-term branches so that they
> > include the full set of minmax.h changes.
> >
> > - 6.12.y has already been backported; the changes are included in
> > v6.12.49.
> > - 6.6.y has already been backported; the changes are included in
> > v6.6.109.
> > - 6.1.y has already been backported; the changes are currently in the
> > 6.1-stable tree.
> > - 5.15.y has already been backported; the changes are currently in the
> > 5.15-stable tree.
>
> With this series applied, on an arm64 server, building 'allmodconfig', I
> get the following build error.
>
> Oddly I don't see it on my x86 server, perhaps due to different compiler
> versions?
>
> Any ideas?
This mainline commit is missing:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/net/wireless/ralink/rt2x00/rt2800lib.c?h=v6.18-rc1&id=66063033f77e10b985258126a97573f84bb8d3b4
This fix already exists in 5.15.y:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/drivers/net/wireless/ralink/rt2x00/rt2800lib.c?h=v5.15.194&id=2d3cef3d7a5df260a14a6679c4aca0c97e570ee5
…but is missing in 5.10.y.
I now backported it to 5.10.y here:
https://lore.kernel.org/stable/20251018195945.18825-1-farbere@amazon.com/T/#u
Regards, Eliav
> In function ‘rt2800_txpower_to_dev’,
> inlined from ‘rt2800_config_channel’ at ../drivers/net/wireless/ralink/rt2x00/rt2800lib.c:4022:25:
>./../include/linux/compiler_types.h:309:45: error: call to ‘__compiletime_assert_1168’ declared with attribute error: clamp() low limit -7 greater than high limit 15
> 309 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
> | ^
>./../include/linux/compiler_types.h:290:25: note: in definition of macro ‘__compiletime_assert’
> 290 | prefix ## suffix(); \
> | ^~~~~~
>./../include/linux/compiler_types.h:309:9: note: in expansion of macro ‘_compiletime_assert’
> 309 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
> | ^~~~~~~~~~~~~~~~~~~
>../include/linux/build_bug.h:39:37: note: in expansion of macro ‘compiletime_assert’
> 39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
> | ^~~~~~~~~~~~~~~~~~
>../include/linux/minmax.h:188:9: note: in expansion of macro ‘BUILD_BUG_ON_MSG’
> 188 | BUILD_BUG_ON_MSG(statically_true(ulo > uhi), \
> | ^~~~~~~~~~~~~~~~
>../include/linux/minmax.h:195:9: note: in expansion of macro ‘__clamp_once’
> 195 | __clamp_once(type, val, lo, hi, __UNIQUE_ID(v_), __UNIQUE_ID(l_), __UNIQUE_ID(h_))
> | ^~~~~~~~~~~~
>../include/linux/minmax.h:218:36: note: in expansion of macro ‘__careful_clamp’
> 218 | #define clamp_t(type, val, lo, hi) __careful_clamp(type, val, lo, hi)
> | ^~~~~~~~~~~~~~~
>../drivers/net/wireless/ralink/rt2x00/rt2800lib.c:3980:24: note: in expansion of macro ‘clamp_t’
> 3980 | return clamp_t(char, txpower, MIN_A_TXPOWER, MAX_A_TXPOWER);
> | ^~~~~~~
> In function ‘rt2800_txpower_to_dev’,
> inlined from ‘rt2800_config_channel’ at ../drivers/net/wireless/ralink/rt2x00/rt2800lib.c:4024:25:
>./../include/linux/compiler_types.h:309:45: error: call to ‘__compiletime_assert_1168’ declared with attribute error: clamp() low limit -7 greater than high limit 15
> 309 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
> | ^
>./../include/linux/compiler_types.h:290:25: note: in definition of macro ‘__compiletime_assert’
> 290 | prefix ## suffix(); \
> | ^~~~~~
>./../include/linux/compiler_types.h:309:9: note: in expansion of macro ‘_compiletime_assert’
> 309 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
> | ^~~~~~~~~~~~~~~~~~~
>../include/linux/build_bug.h:39:37: note: in expansion of macro ‘compiletime_assert’
> 39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
> | ^~~~~~~~~~~~~~~~~~
>../include/linux/minmax.h:188:9: note: in expansion of macro ‘BUILD_BUG_ON_MSG’
> 188 | BUILD_BUG_ON_MSG(statically_true(ulo > uhi), \
> | ^~~~~~~~~~~~~~~~
>../include/linux/minmax.h:195:9: note: in expansion of macro ‘__clamp_once’
> 195 | __clamp_once(type, val, lo, hi, __UNIQUE_ID(v_), __UNIQUE_ID(l_), __UNIQUE_ID(h_))
> | ^~~~~~~~~~~~
>../include/linux/minmax.h:218:36: note: in expansion of macro ‘__careful_clamp’
> 218 | #define clamp_t(type, val, lo, hi) __careful_clamp(type, val, lo, hi)
> | ^~~~~~~~~~~~~~~
>../drivers/net/wireless/ralink/rt2x00/rt2800lib.c:3980:24: note: in expansion of macro ‘clamp_t’
> 3980 | return clamp_t(char, txpower, MIN_A_TXPOWER, MAX_A_TXPOWER);
> | ^~~~~~~
> In function ‘rt2800_txpower_to_dev’,
> inlined from ‘rt2800_config_channel’ at ../drivers/net/wireless/ralink/rt2x00/rt2800lib.c:4028:4:
>./../include/linux/compiler_types.h:309:45: error: call to ‘__compiletime_assert_1168’ declared with attribute error: clamp() low limit -7 greater than high limit 15
> 309 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
> | ^
>./../include/linux/compiler_types.h:290:25: note: in definition of macro ‘__compiletime_assert’
> 290 | prefix ## suffix(); \
> | ^~~~~~
>./../include/linux/compiler_types.h:309:9: note: in expansion of macro ‘_compiletime_assert’
> 309 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
> | ^~~~~~~~~~~~~~~~~~~
>../include/linux/build_bug.h:39:37: note: in expansion of macro ‘compiletime_assert’
> 39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
> | ^~~~~~~~~~~~~~~~~~
>../include/linux/minmax.h:188:9: note: in expansion of macro ‘BUILD_BUG_ON_MSG’
> 188 | BUILD_BUG_ON_MSG(statically_true(ulo > uhi), \
> | ^~~~~~~~~~~~~~~~
>../include/linux/minmax.h:195:9: note: in expansion of macro ‘__clamp_once’
> 195 | __clamp_once(type, val, lo, hi, __UNIQUE_ID(v_), __UNIQUE_ID(l_), __UNIQUE_ID(h_))
> | ^~~~~~~~~~~~
>../include/linux/minmax.h:218:36: note: in expansion of macro ‘__careful_clamp’
> 218 | #define clamp_t(type, val, lo, hi) __careful_clamp(type, val, lo, hi)
> | ^~~~~~~~~~~~~~~
>../drivers/net/wireless/ralink/rt2x00/rt2800lib.c:3980:24: note: in expansion of macro ‘clamp_t’
> 3980 | return clamp_t(char, txpower, MIN_A_TXPOWER, MAX_A_TXPOWER);
> | ^~~~~~~
> make[6]: *** [../scripts/Makefile.build:286: drivers/net/wireless/ralink/rt2x00/rt2800lib.o] Error 1
> make[5]: *** [../scripts/Makefile.build:503: drivers/net/wireless/ralink/rt2x00] Error 2
> make[4]: *** [../scripts/Makefile.build:503: drivers/net/wireless/ralink] Error 2
> make[4]: *** Waiting for unfinished jobs....
^ permalink raw reply
* [hid:for-6.19/intel-ish-v2 1/7] drivers/hid/intel-ish-hid/ipc/ipc.c:944:36: warning: cast from 'void (*)(struct workqueue_struct *)' to 'void (*)(void *)' converts to incompatible function type
From: kernel test robot @ 2025-10-18 17:50 UTC (permalink / raw)
To: Zhang Lixu; +Cc: llvm, oe-kbuild-all, linux-input, Jiri Kosina
tree: https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-6.19/intel-ish-v2
head: 5677aa6a08c1df8bc1ec71516fe1ced9b7cb545f
commit: 0d30dae38fe01cd1de358c6039a0b1184689fe51 [1/7] HID: intel-ish-hid: Use dedicated unbound workqueues to prevent resume blocking
config: x86_64-randconfig-002-20251018 (https://download.01.org/0day-ci/archive/20251019/202510190103.qTZvfdjj-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251019/202510190103.qTZvfdjj-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202510190103.qTZvfdjj-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/hid/intel-ish-hid/ipc/ipc.c:944:36: warning: cast from 'void (*)(struct workqueue_struct *)' to 'void (*)(void *)' converts to incompatible function type [-Wcast-function-type-strict]
944 | if (devm_add_action_or_reset(dev, (void (*)(void *))destroy_workqueue,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/device/devres.h:168:34: note: expanded from macro 'devm_add_action_or_reset'
168 | __devm_add_action_or_reset(dev, action, data, #action)
| ^~~~~~
1 warning generated.
vim +944 drivers/hid/intel-ish-hid/ipc/ipc.c
935
936 static struct workqueue_struct *devm_ishtp_alloc_workqueue(struct device *dev)
937 {
938 struct workqueue_struct *wq;
939
940 wq = alloc_workqueue("ishtp_unbound_%d", WQ_UNBOUND, 0, dev->id);
941 if (!wq)
942 return NULL;
943
> 944 if (devm_add_action_or_reset(dev, (void (*)(void *))destroy_workqueue,
945 wq))
946 return NULL;
947
948 return wq;
949 }
950
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply
* [RFC 4/4] PM: sleep: clear pm_abort_suspend at suspend
From: Muhammad Usama Anjum @ 2025-10-18 14:21 UTC (permalink / raw)
To: Rafael J. Wysocki, Len Brown, Pavel Machek, Greg Kroah-Hartman,
Danilo Krummrich, Dmitry Torokhov, Thomas Gleixner,
Peter Zijlstra, linux-acpi, linux-kernel, linux-pm, linux-input
Cc: Muhammad Usama Anjum, kernel, superm1
In-Reply-To: <20251018142114.897445-1-usama.anjum@collabora.com>
Clear pm_abort_suspend counter in case a wakeup is detected during
hibernation process. If this counter isn't reset, it'll affect the
next hibernation cycle and next time hibernation will not happen as
pm_abort_suspend is still positive.
Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
---
drivers/base/power/main.c | 2 ++
kernel/cpu.c | 1 +
kernel/power/hibernate.c | 5 ++++-
kernel/power/process.c | 1 +
4 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c
index bcfb170baca63..481744e7d9688 100644
--- a/drivers/base/power/main.c
+++ b/drivers/base/power/main.c
@@ -1627,6 +1627,7 @@ static void device_suspend_late(struct device *dev, pm_message_t state, bool asy
goto Complete;
if (pm_wakeup_pending()) {
+ pm_wakeup_clear(0);
WRITE_ONCE(async_error, -EBUSY);
goto Complete;
}
@@ -1872,6 +1873,7 @@ static void device_suspend(struct device *dev, pm_message_t state, bool async)
if (pm_wakeup_pending()) {
dev->power.direct_complete = false;
+ pm_wakeup_clear(0);
WRITE_ONCE(async_error, -EBUSY);
goto Complete;
}
diff --git a/kernel/cpu.c b/kernel/cpu.c
index db9f6c539b28c..74c9f6b4947dd 100644
--- a/kernel/cpu.c
+++ b/kernel/cpu.c
@@ -1921,6 +1921,7 @@ int freeze_secondary_cpus(int primary)
if (pm_wakeup_pending()) {
pr_info("Wakeup pending. Abort CPU freeze\n");
+ pm_wakeup_clear(0);
error = -EBUSY;
break;
}
diff --git a/kernel/power/hibernate.c b/kernel/power/hibernate.c
index aadf82f57e868..1a4a5c3c64970 100644
--- a/kernel/power/hibernate.c
+++ b/kernel/power/hibernate.c
@@ -350,8 +350,10 @@ static int create_image(int platform_mode)
goto Enable_irqs;
}
- if (hibernation_test(TEST_CORE) || pm_wakeup_pending())
+ if (hibernation_test(TEST_CORE) || pm_wakeup_pending()) {
+ pm_wakeup_clear(0);
goto Power_up;
+ }
in_suspend = 1;
save_processor_state();
@@ -661,6 +663,7 @@ int hibernation_platform_enter(void)
goto Enable_irqs;
if (pm_wakeup_pending()) {
+ pm_wakeup_clear(0);
error = -EAGAIN;
goto Power_up;
}
diff --git a/kernel/power/process.c b/kernel/power/process.c
index 8ff68ebaa1e08..7a278e049940c 100644
--- a/kernel/power/process.c
+++ b/kernel/power/process.c
@@ -67,6 +67,7 @@ static int try_to_freeze_tasks(bool user_only)
break;
if (pm_wakeup_pending()) {
+ pm_wakeup_clear(0);
wakeup = true;
break;
}
--
2.47.3
^ permalink raw reply related
* [RFC 1/4] PM: hibernate: export hibernation_in_progress()
From: Muhammad Usama Anjum @ 2025-10-18 14:21 UTC (permalink / raw)
To: Rafael J. Wysocki, Len Brown, Pavel Machek, Greg Kroah-Hartman,
Danilo Krummrich, Dmitry Torokhov, Thomas Gleixner,
Peter Zijlstra, linux-acpi, linux-kernel, linux-pm, linux-input
Cc: Muhammad Usama Anjum, kernel, superm1
In-Reply-To: <20251018142114.897445-1-usama.anjum@collabora.com>
Export hibernation_in_progress() to be used by other modules. Add its
signature when hibernation config isn't enabled as well.
Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
---
include/linux/suspend.h | 2 ++
kernel/power/hibernate.c | 1 +
2 files changed, 3 insertions(+)
diff --git a/include/linux/suspend.h b/include/linux/suspend.h
index b02876f1ae38a..348831cdb60e4 100644
--- a/include/linux/suspend.h
+++ b/include/linux/suspend.h
@@ -393,6 +393,7 @@ extern void hibernation_set_ops(const struct platform_hibernation_ops *ops);
extern int hibernate(void);
extern bool system_entering_hibernation(void);
extern bool hibernation_available(void);
+extern bool hibernation_in_progress(void);
asmlinkage int swsusp_save(void);
extern struct pbe *restore_pblist;
int pfn_is_nosave(unsigned long pfn);
@@ -412,6 +413,7 @@ static inline void hibernation_set_ops(const struct platform_hibernation_ops *op
static inline int hibernate(void) { return -ENOSYS; }
static inline bool system_entering_hibernation(void) { return false; }
static inline bool hibernation_available(void) { return false; }
+static inline bool hibernation_in_progress(void) { return false; }
static inline int hibernate_quiet_exec(int (*func)(void *data), void *data) {
return -ENOTSUPP;
diff --git a/kernel/power/hibernate.c b/kernel/power/hibernate.c
index 14e85ff235512..aadf82f57e868 100644
--- a/kernel/power/hibernate.c
+++ b/kernel/power/hibernate.c
@@ -105,6 +105,7 @@ bool hibernation_in_progress(void)
{
return !atomic_read(&hibernate_atomic);
}
+EXPORT_SYMBOL_GPL(hibernation_in_progress);
bool hibernation_available(void)
{
--
2.47.3
^ permalink raw reply related
* [RFC 3/4] Input: Ignore the KEY_POWER events if hibernation is in progress
From: Muhammad Usama Anjum @ 2025-10-18 14:21 UTC (permalink / raw)
To: Rafael J. Wysocki, Len Brown, Pavel Machek, Greg Kroah-Hartman,
Danilo Krummrich, Dmitry Torokhov, Thomas Gleixner,
Peter Zijlstra, linux-acpi, linux-kernel, linux-pm, linux-input
Cc: Muhammad Usama Anjum, kernel, superm1
In-Reply-To: <20251018142114.897445-1-usama.anjum@collabora.com>
Serio drivers call input_handle_event(). Although the serio drivers have
duplicate events, they have separate code path and call
input_handle_event(). Ignore the KEY_POWER such that this event isn't
sent to the userspace if hibernation is in progress.
Abort the hibernation by calling pm awake API as well.
Without this, the event is sent to the userspace and it suspends the
device after hibernation cancellation.
Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
---
drivers/input/input.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/input/input.c b/drivers/input/input.c
index a500e1e276c21..0979f18aae6a2 100644
--- a/drivers/input/input.c
+++ b/drivers/input/input.c
@@ -26,6 +26,7 @@
#include <linux/kstrtox.h>
#include <linux/mutex.h>
#include <linux/rcupdate.h>
+#include <linux/suspend.h>
#include "input-compat.h"
#include "input-core-private.h"
#include "input-poller.h"
@@ -362,6 +363,11 @@ void input_handle_event(struct input_dev *dev,
lockdep_assert_held(&dev->event_lock);
+ if (code == KEY_POWER && hibernation_in_progress()) {
+ pm_wakeup_dev_event(&dev->dev, 0, true);
+ return;
+ }
+
disposition = input_get_disposition(dev, type, code, &value);
if (disposition != INPUT_IGNORE_EVENT) {
if (type != EV_SYN)
--
2.47.3
^ permalink raw reply related
* [RFC 2/4] ACPI: button: Cancel hibernation if button is pressed during hibernation
From: Muhammad Usama Anjum @ 2025-10-18 14:21 UTC (permalink / raw)
To: Rafael J. Wysocki, Len Brown, Pavel Machek, Greg Kroah-Hartman,
Danilo Krummrich, Dmitry Torokhov, Thomas Gleixner,
Peter Zijlstra, linux-acpi, linux-kernel, linux-pm, linux-input
Cc: Muhammad Usama Anjum, kernel, superm1
In-Reply-To: <20251018142114.897445-1-usama.anjum@collabora.com>
acpi_pm_wakeup_event() is called from acpi_button_notify() which is
called when power button is pressed. But system doesn't wake up as
pm_wakeup_dev_event() isn't called with hard parameter set in case of
hibernation. It gets set only for s2idle cases.
Call acpi_pm_wakeup_event() if power button is pressed and hibernation
is in progress. Set the hard parameter such that pm_system_wakeup()
gets called which increments pm_abort_suspend counter. Hence hibernation
would be cancelled as in hibernation path, this counter is checked if it
should be aborted.
Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
---
drivers/acpi/button.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/acpi/button.c b/drivers/acpi/button.c
index 0a70260401882..4a2575c0c44e3 100644
--- a/drivers/acpi/button.c
+++ b/drivers/acpi/button.c
@@ -20,6 +20,7 @@
#include <linux/acpi.h>
#include <linux/dmi.h>
#include <acpi/button.h>
+#include <linux/suspend.h>
#define ACPI_BUTTON_CLASS "button"
#define ACPI_BUTTON_FILE_STATE "state"
@@ -458,11 +459,16 @@ static void acpi_button_notify(acpi_handle handle, u32 event, void *data)
acpi_pm_wakeup_event(&device->dev);
button = acpi_driver_data(device);
- if (button->suspended || event == ACPI_BUTTON_NOTIFY_WAKE)
- return;
-
input = button->input;
keycode = test_bit(KEY_SLEEP, input->keybit) ? KEY_SLEEP : KEY_POWER;
+ if (event == ACPI_BUTTON_NOTIFY_STATUS && keycode == KEY_POWER &&
+ hibernation_in_progress()) {
+ pm_wakeup_dev_event(&device->dev, 0, true);
+ return;
+ }
+
+ if (button->suspended || event == ACPI_BUTTON_NOTIFY_WAKE)
+ return;
input_report_key(input, keycode, 1);
input_sync(input);
--
2.47.3
^ permalink raw reply related
* [RFC 0/4] PM: Hibernate: Add hibernation cancellation support
From: Muhammad Usama Anjum @ 2025-10-18 14:21 UTC (permalink / raw)
To: Rafael J. Wysocki, Len Brown, Pavel Machek, Greg Kroah-Hartman,
Danilo Krummrich, Dmitry Torokhov, Thomas Gleixner,
Peter Zijlstra, linux-acpi, linux-kernel, linux-pm, linux-input
Cc: Muhammad Usama Anjum, kernel, superm1
On a normal laptop/PC, the hibernation takes 15-20 seconds which is
considerable time. Once hibernation is triggered from command line or by
some GUI option, the hibernation cannot be cancelled until completed.
Its not a blocker, but poor user experience.
When power button is pressed during hibernation, it generates interrupt
and then the event is routed to userspace. If systemd is being used, the
logind handles these events and performs the specific action.
During hibernation, the first stage is to freeze the userspace. Hence
even if the power button is pressed, it doesn't aborts the hibernation
as user space daemon is frozen.
My device takes ~19 seconds to hibernate. When I was testing hibernation
using rtcwake with timeout of 10 seconds, I found out that hibernation
gets canceled around 10 seconds mark when the interrupt fires.
In this series, the idea is to find a way to cancel the hibernation.
With this series applied, the hibernation gets cancelled gracefully.
Muhammad Usama Anjum (4):
PM: hibernate: export hibernation_in_progress()
ACPI: button: Cancel hibernation if button is pressed during
hibernation
Input: Ignore the KEY_POWER events if hibernation is in progress
PM: sleep: clear pm_abort_suspend at suspend
drivers/acpi/button.c | 12 +++++++++---
drivers/base/power/main.c | 2 ++
drivers/input/input.c | 6 ++++++
include/linux/suspend.h | 2 ++
kernel/cpu.c | 1 +
kernel/power/hibernate.c | 6 +++++-
kernel/power/process.c | 1 +
7 files changed, 26 insertions(+), 4 deletions(-)
--
2.47.3
^ permalink raw reply
* [PATCH v7 9/9] HID: asus: add support for the asus-wmi brightness handler
From: Antheas Kapenekakis @ 2025-10-18 10:17 UTC (permalink / raw)
To: platform-driver-x86, linux-input
Cc: linux-kernel, Jiri Kosina, Benjamin Tissoires, Corentin Chary,
Luke D . Jones, Hans de Goede, Ilpo Järvinen, Denis Benato,
Antheas Kapenekakis
In-Reply-To: <20251018101759.4089-1-lkml@antheas.dev>
If the asus-wmi brightness handler is available, send the
keyboard brightness events to it instead of passing them
to userspace. If it is not, fall back to sending them to it.
Reviewed-by: Luke D. Jones <luke@ljones.dev>
Tested-by: Luke D. Jones <luke@ljones.dev>
Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
---
drivers/hid/hid-asus.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
index 96cff7690987..c2c25825cb42 100644
--- a/drivers/hid/hid-asus.c
+++ b/drivers/hid/hid-asus.c
@@ -324,6 +324,17 @@ static int asus_event(struct hid_device *hdev, struct hid_field *field,
usage->hid & HID_USAGE);
}
+ if (usage->type == EV_KEY && value) {
+ switch (usage->code) {
+ case KEY_KBDILLUMUP:
+ return !asus_hid_event(ASUS_EV_BRTUP);
+ case KEY_KBDILLUMDOWN:
+ return !asus_hid_event(ASUS_EV_BRTDOWN);
+ case KEY_KBDILLUMTOGGLE:
+ return !asus_hid_event(ASUS_EV_BRTTOGGLE);
+ }
+ }
+
return 0;
}
--
2.51.0
^ permalink raw reply related
* [PATCH v7 7/9] platform/x86: asus-wmi: remove unused keyboard backlight quirk
From: Antheas Kapenekakis @ 2025-10-18 10:17 UTC (permalink / raw)
To: platform-driver-x86, linux-input
Cc: linux-kernel, Jiri Kosina, Benjamin Tissoires, Corentin Chary,
Luke D . Jones, Hans de Goede, Ilpo Järvinen, Denis Benato,
Antheas Kapenekakis
In-Reply-To: <20251018101759.4089-1-lkml@antheas.dev>
The quirk for selecting whether keyboard backlight should be controlled
by HID or WMI is not needed anymore, so remove it.
Reviewed-by: Luke D. Jones <luke@ljones.dev>
Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
---
include/linux/platform_data/x86/asus-wmi.h | 40 ----------------------
1 file changed, 40 deletions(-)
diff --git a/include/linux/platform_data/x86/asus-wmi.h b/include/linux/platform_data/x86/asus-wmi.h
index 1165039013b1..d8c5269854b0 100644
--- a/include/linux/platform_data/x86/asus-wmi.h
+++ b/include/linux/platform_data/x86/asus-wmi.h
@@ -203,44 +203,4 @@ static inline void asus_hid_unregister_listener(struct asus_hid_listener *bdev)
}
#endif
-/* To be used by both hid-asus and asus-wmi to determine which controls kbd_brightness */
-static const struct dmi_system_id asus_use_hid_led_dmi_ids[] = {
- {
- .matches = {
- DMI_MATCH(DMI_PRODUCT_FAMILY, "ROG Zephyrus"),
- },
- },
- {
- .matches = {
- DMI_MATCH(DMI_PRODUCT_FAMILY, "ROG Strix"),
- },
- },
- {
- .matches = {
- DMI_MATCH(DMI_PRODUCT_FAMILY, "ROG Flow"),
- },
- },
- {
- .matches = {
- DMI_MATCH(DMI_PRODUCT_FAMILY, "ProArt P16"),
- },
- },
- {
- .matches = {
- DMI_MATCH(DMI_BOARD_NAME, "GA403U"),
- },
- },
- {
- .matches = {
- DMI_MATCH(DMI_BOARD_NAME, "GU605M"),
- },
- },
- {
- .matches = {
- DMI_MATCH(DMI_BOARD_NAME, "RC71L"),
- },
- },
- { },
-};
-
#endif /* __PLATFORM_DATA_X86_ASUS_WMI_H */
--
2.51.0
^ permalink raw reply related
* [PATCH v7 8/9] platform/x86: asus-wmi: add keyboard brightness event handler
From: Antheas Kapenekakis @ 2025-10-18 10:17 UTC (permalink / raw)
To: platform-driver-x86, linux-input
Cc: linux-kernel, Jiri Kosina, Benjamin Tissoires, Corentin Chary,
Luke D . Jones, Hans de Goede, Ilpo Järvinen, Denis Benato,
Antheas Kapenekakis
In-Reply-To: <20251018101759.4089-1-lkml@antheas.dev>
The keyboard brightness control of Asus WMI keyboards is handled in
kernel, which leads to the shortcut going from brightness 0, to 1,
to 2, and 3.
However, for HID keyboards it is exposed as a key and handled by the
user's desktop environment. For the toggle button, this means that
brightness control becomes on/off. In addition, in the absence of a
DE, the keyboard brightness does not work.
Therefore, expose an event handler for the keyboard brightness control
which can then be used by hid-asus. Since this handler is called from
an interrupt context, defer the actual work to a workqueue.
In the process, introduce ASUS_EV_MAX_BRIGHTNESS to hold the constant
for maximum brightness since it is shared between hid-asus/asus-wmi.
Reviewed-by: Luke D. Jones <luke@ljones.dev>
Tested-by: Luke D. Jones <luke@ljones.dev>
Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
---
drivers/platform/x86/asus-wmi.c | 46 +++++++++++++++++++---
include/linux/platform_data/x86/asus-wmi.h | 13 ++++++
2 files changed, 54 insertions(+), 5 deletions(-)
diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
index aab779142323..f229a50bd69e 100644
--- a/drivers/platform/x86/asus-wmi.c
+++ b/drivers/platform/x86/asus-wmi.c
@@ -1629,6 +1629,44 @@ static void kbd_led_update_all(struct work_struct *work)
}
}
+/*
+ * This function is called from hid-asus to inform asus-wmi of brightness
+ * changes initiated by the keyboard backlight keys.
+ */
+int asus_hid_event(enum asus_hid_event event)
+{
+ struct asus_wmi *asus;
+ int brightness;
+
+ guard(spinlock_irqsave)(&asus_ref.lock);
+ asus = asus_ref.asus;
+ if (!asus || !asus->kbd_led_registered)
+ return -EBUSY;
+
+ brightness = asus->kbd_led_wk;
+
+ switch (event) {
+ case ASUS_EV_BRTUP:
+ brightness += 1;
+ break;
+ case ASUS_EV_BRTDOWN:
+ brightness -= 1;
+ break;
+ case ASUS_EV_BRTTOGGLE:
+ if (brightness >= ASUS_EV_MAX_BRIGHTNESS)
+ brightness = 0;
+ else
+ brightness += 1;
+ break;
+ }
+
+ asus->kbd_led_wk = clamp_val(brightness, 0, ASUS_EV_MAX_BRIGHTNESS);
+ asus->kbd_led_notify = true;
+ queue_work(asus->led_workqueue, &asus->kbd_led_work);
+ return 0;
+}
+EXPORT_SYMBOL_GPL(asus_hid_event);
+
/*
* These functions actually update the LED's, and are called from a
* workqueue. By doing this as separate work rather than when the LED
@@ -1711,13 +1749,11 @@ static void do_kbd_led_set(struct led_classdev *led_cdev, int value)
{
struct asus_hid_listener *listener;
struct asus_wmi *asus;
- int max_level;
asus = container_of(led_cdev, struct asus_wmi, kbd_led);
- max_level = asus->kbd_led.max_brightness;
scoped_guard(spinlock_irqsave, &asus_ref.lock)
- asus->kbd_led_wk = clamp_val(value, 0, max_level);
+ asus->kbd_led_wk = clamp_val(value, 0, ASUS_EV_MAX_BRIGHTNESS);
if (asus->kbd_led_avail)
kbd_led_update(asus);
@@ -1921,7 +1957,7 @@ static int asus_wmi_led_init(struct asus_wmi *asus)
asus->kbd_led.flags = LED_BRIGHT_HW_CHANGED;
asus->kbd_led.brightness_set = kbd_led_set;
asus->kbd_led.brightness_get = kbd_led_get;
- asus->kbd_led.max_brightness = 3;
+ asus->kbd_led.max_brightness = ASUS_EV_MAX_BRIGHTNESS;
asus->kbd_led_avail = !kbd_led_read(asus, &led_val, NULL);
INIT_WORK(&asus->kbd_led_work, kbd_led_update_all);
@@ -4424,7 +4460,7 @@ static void asus_wmi_handle_event_code(int code, struct asus_wmi *asus)
return;
}
if (code == NOTIFY_KBD_BRTTOGGLE) {
- if (led_value == asus->kbd_led.max_brightness)
+ if (led_value == ASUS_EV_MAX_BRIGHTNESS)
kbd_led_set_by_kbd(asus, 0);
else
kbd_led_set_by_kbd(asus, led_value + 1);
diff --git a/include/linux/platform_data/x86/asus-wmi.h b/include/linux/platform_data/x86/asus-wmi.h
index d8c5269854b0..3f679598b629 100644
--- a/include/linux/platform_data/x86/asus-wmi.h
+++ b/include/linux/platform_data/x86/asus-wmi.h
@@ -169,6 +169,14 @@ struct asus_hid_listener {
void (*brightness_set)(struct asus_hid_listener *listener, int brightness);
};
+enum asus_hid_event {
+ ASUS_EV_BRTUP,
+ ASUS_EV_BRTDOWN,
+ ASUS_EV_BRTTOGGLE,
+};
+
+#define ASUS_EV_MAX_BRIGHTNESS 3
+
#if IS_REACHABLE(CONFIG_ASUS_WMI)
void set_ally_mcu_hack(enum asus_ally_mcu_hack status);
void set_ally_mcu_powersave(bool enabled);
@@ -177,6 +185,7 @@ int asus_wmi_evaluate_method(u32 method_id, u32 arg0, u32 arg1, u32 *retval);
int asus_hid_register_listener(struct asus_hid_listener *cdev);
void asus_hid_unregister_listener(struct asus_hid_listener *cdev);
+int asus_hid_event(enum asus_hid_event event);
#else
static inline void set_ally_mcu_hack(enum asus_ally_mcu_hack status)
{
@@ -201,6 +210,10 @@ static inline int asus_hid_register_listener(struct asus_hid_listener *bdev)
static inline void asus_hid_unregister_listener(struct asus_hid_listener *bdev)
{
}
+static inline int asus_hid_event(enum asus_hid_event event)
+{
+ return -ENODEV;
+}
#endif
#endif /* __PLATFORM_DATA_X86_ASUS_WMI_H */
--
2.51.0
^ permalink raw reply related
* [PATCH v7 6/9] HID: asus: listen to the asus-wmi brightness device instead of creating one
From: Antheas Kapenekakis @ 2025-10-18 10:17 UTC (permalink / raw)
To: platform-driver-x86, linux-input
Cc: linux-kernel, Jiri Kosina, Benjamin Tissoires, Corentin Chary,
Luke D . Jones, Hans de Goede, Ilpo Järvinen, Denis Benato,
Antheas Kapenekakis
In-Reply-To: <20251018101759.4089-1-lkml@antheas.dev>
Some ROG laptops expose multiple interfaces for controlling the
keyboard/RGB brightness. This creates a name conflict under
asus::kbd_brightness, where the second device ends up being
named asus::kbd_brightness_1 and they are both broken.
Therefore, register a listener to the asus-wmi brightness device
instead of creating a new one.
Reviewed-by: Luke D. Jones <luke@ljones.dev>
Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
---
drivers/hid/hid-asus.c | 64 +++++++-----------------------------------
1 file changed, 10 insertions(+), 54 deletions(-)
diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
index bbbac98f76c6..96cff7690987 100644
--- a/drivers/hid/hid-asus.c
+++ b/drivers/hid/hid-asus.c
@@ -102,7 +102,7 @@ MODULE_DESCRIPTION("Asus HID Keyboard and TouchPad");
#define TRKID_SGN ((TRKID_MAX + 1) >> 1)
struct asus_kbd_leds {
- struct led_classdev cdev;
+ struct asus_hid_listener listener;
struct hid_device *hdev;
struct work_struct work;
unsigned int brightness;
@@ -494,11 +494,11 @@ static void asus_schedule_work(struct asus_kbd_leds *led)
spin_unlock_irqrestore(&led->lock, flags);
}
-static void asus_kbd_backlight_set(struct led_classdev *led_cdev,
- enum led_brightness brightness)
+static void asus_kbd_backlight_set(struct asus_hid_listener *listener,
+ int brightness)
{
- struct asus_kbd_leds *led = container_of(led_cdev, struct asus_kbd_leds,
- cdev);
+ struct asus_kbd_leds *led = container_of(listener, struct asus_kbd_leds,
+ listener);
unsigned long flags;
spin_lock_irqsave(&led->lock, flags);
@@ -508,20 +508,6 @@ static void asus_kbd_backlight_set(struct led_classdev *led_cdev,
asus_schedule_work(led);
}
-static enum led_brightness asus_kbd_backlight_get(struct led_classdev *led_cdev)
-{
- struct asus_kbd_leds *led = container_of(led_cdev, struct asus_kbd_leds,
- cdev);
- enum led_brightness brightness;
- unsigned long flags;
-
- spin_lock_irqsave(&led->lock, flags);
- brightness = led->brightness;
- spin_unlock_irqrestore(&led->lock, flags);
-
- return brightness;
-}
-
static void asus_kbd_backlight_work(struct work_struct *work)
{
struct asus_kbd_leds *led = container_of(work, struct asus_kbd_leds, work);
@@ -538,34 +524,6 @@ static void asus_kbd_backlight_work(struct work_struct *work)
hid_err(led->hdev, "Asus failed to set keyboard backlight: %d\n", ret);
}
-/* WMI-based keyboard backlight LED control (via asus-wmi driver) takes
- * precedence. We only activate HID-based backlight control when the
- * WMI control is not available.
- */
-static bool asus_kbd_wmi_led_control_present(struct hid_device *hdev)
-{
- struct asus_drvdata *drvdata = hid_get_drvdata(hdev);
- u32 value;
- int ret;
-
- if (!IS_ENABLED(CONFIG_ASUS_WMI))
- return false;
-
- if (drvdata->quirks & QUIRK_ROG_NKEY_KEYBOARD &&
- dmi_check_system(asus_use_hid_led_dmi_ids)) {
- hid_info(hdev, "using HID for asus::kbd_backlight\n");
- return false;
- }
-
- ret = asus_wmi_evaluate_method(ASUS_WMI_METHODID_DSTS,
- ASUS_WMI_DEVID_KBD_BACKLIGHT, 0, &value);
- hid_dbg(hdev, "WMI backlight check: rc %d value %x", ret, value);
- if (ret)
- return false;
-
- return !!(value & ASUS_WMI_DSTS_PRESENCE_BIT);
-}
-
/*
* We don't care about any other part of the string except the version section.
* Example strings: FGA80100.RC72LA.312_T01, FGA80100.RC71LS.318_T01
@@ -700,14 +658,11 @@ static int asus_kbd_register_leds(struct hid_device *hdev)
drvdata->kbd_backlight->removed = false;
drvdata->kbd_backlight->brightness = 0;
drvdata->kbd_backlight->hdev = hdev;
- drvdata->kbd_backlight->cdev.name = "asus::kbd_backlight";
- drvdata->kbd_backlight->cdev.max_brightness = 3;
- drvdata->kbd_backlight->cdev.brightness_set = asus_kbd_backlight_set;
- drvdata->kbd_backlight->cdev.brightness_get = asus_kbd_backlight_get;
+ drvdata->kbd_backlight->listener.brightness_set = asus_kbd_backlight_set;
INIT_WORK(&drvdata->kbd_backlight->work, asus_kbd_backlight_work);
spin_lock_init(&drvdata->kbd_backlight->lock);
- ret = devm_led_classdev_register(&hdev->dev, &drvdata->kbd_backlight->cdev);
+ ret = asus_hid_register_listener(&drvdata->kbd_backlight->listener);
if (ret < 0) {
/* No need to have this still around */
devm_kfree(&hdev->dev, drvdata->kbd_backlight);
@@ -1096,7 +1051,7 @@ static int __maybe_unused asus_resume(struct hid_device *hdev) {
if (drvdata->kbd_backlight) {
const u8 buf[] = { FEATURE_KBD_REPORT_ID, 0xba, 0xc5, 0xc4,
- drvdata->kbd_backlight->cdev.brightness };
+ drvdata->kbd_backlight->brightness };
ret = asus_kbd_set_report(hdev, buf, sizeof(buf));
if (ret < 0) {
hid_err(hdev, "Asus failed to set keyboard backlight: %d\n", ret);
@@ -1232,7 +1187,6 @@ static int asus_probe(struct hid_device *hdev, const struct hid_device_id *id)
}
if (is_vendor && (drvdata->quirks & QUIRK_USE_KBD_BACKLIGHT) &&
- !asus_kbd_wmi_led_control_present(hdev) &&
asus_kbd_register_leds(hdev))
hid_warn(hdev, "Failed to initialize backlight.\n");
@@ -1273,6 +1227,8 @@ static void asus_remove(struct hid_device *hdev)
unsigned long flags;
if (drvdata->kbd_backlight) {
+ asus_hid_unregister_listener(&drvdata->kbd_backlight->listener);
+
spin_lock_irqsave(&drvdata->kbd_backlight->lock, flags);
drvdata->kbd_backlight->removed = true;
spin_unlock_irqrestore(&drvdata->kbd_backlight->lock, flags);
--
2.51.0
^ permalink raw reply related
* [PATCH v7 3/9] HID: asus: fortify keyboard handshake
From: Antheas Kapenekakis @ 2025-10-18 10:17 UTC (permalink / raw)
To: platform-driver-x86, linux-input
Cc: linux-kernel, Jiri Kosina, Benjamin Tissoires, Corentin Chary,
Luke D . Jones, Hans de Goede, Ilpo Järvinen, Denis Benato,
Antheas Kapenekakis
In-Reply-To: <20251018101759.4089-1-lkml@antheas.dev>
Handshaking with an Asus device involves sending it a feature report
with the string "ASUS Tech.Inc." and then reading it back to verify the
handshake was successful, under the feature ID the interaction will
take place.
Currently, the driver only does the first part. Add the readback to
verify the handshake was successful. As this could cause breakages,
allow the verification to fail with a dmesg error until we verify
all devices work with it (they seem to).
Since the response is more than 16 bytes, increase the buffer size
to 64 as well to avoid overflow errors.
Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
---
drivers/hid/hid-asus.c | 32 +++++++++++++++++++++++++++++---
1 file changed, 29 insertions(+), 3 deletions(-)
diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
index 4676b7f20caf..03f0d86936fc 100644
--- a/drivers/hid/hid-asus.c
+++ b/drivers/hid/hid-asus.c
@@ -48,7 +48,7 @@ MODULE_DESCRIPTION("Asus HID Keyboard and TouchPad");
#define FEATURE_REPORT_ID 0x0d
#define INPUT_REPORT_ID 0x5d
#define FEATURE_KBD_REPORT_ID 0x5a
-#define FEATURE_KBD_REPORT_SIZE 16
+#define FEATURE_KBD_REPORT_SIZE 64
#define FEATURE_KBD_LED_REPORT_ID1 0x5d
#define FEATURE_KBD_LED_REPORT_ID2 0x5e
@@ -393,14 +393,40 @@ static int asus_kbd_set_report(struct hid_device *hdev, const u8 *buf, size_t bu
static int asus_kbd_init(struct hid_device *hdev, u8 report_id)
{
+ /*
+ * The handshake is first sent as a set_report, then retrieved
+ * from a get_report. They should be equal.
+ */
const u8 buf[] = { report_id, 0x41, 0x53, 0x55, 0x53, 0x20, 0x54,
0x65, 0x63, 0x68, 0x2e, 0x49, 0x6e, 0x63, 0x2e, 0x00 };
+ u8 *readbuf;
int ret;
ret = asus_kbd_set_report(hdev, buf, sizeof(buf));
- if (ret < 0)
- hid_err(hdev, "Asus failed to send init command: %d\n", ret);
+ if (ret < 0) {
+ hid_err(hdev, "Asus failed to send handshake: %d\n", ret);
+ return ret;
+ }
+
+ readbuf = kzalloc(FEATURE_KBD_REPORT_SIZE, GFP_KERNEL);
+ if (!readbuf)
+ return -ENOMEM;
+
+ ret = hid_hw_raw_request(hdev, report_id, readbuf,
+ FEATURE_KBD_REPORT_SIZE, HID_FEATURE_REPORT,
+ HID_REQ_GET_REPORT);
+ if (ret < 0) {
+ hid_err(hdev, "Asus failed to receive handshake ack: %d\n", ret);
+ } else if (memcmp(readbuf, buf, sizeof(buf)) != 0) {
+ hid_warn(hdev, "Asus handshake returned invalid response: %*ph\n",
+ FEATURE_KBD_REPORT_SIZE, readbuf);
+ /*
+ * Do not return error if handshake is wrong until this is
+ * verified to work for all devices.
+ */
+ }
+ kfree(readbuf);
return ret;
}
--
2.51.0
^ permalink raw reply related
* [PATCH v7 5/9] platform/x86: asus-wmi: Add support for multiple kbd led handlers
From: Antheas Kapenekakis @ 2025-10-18 10:17 UTC (permalink / raw)
To: platform-driver-x86, linux-input
Cc: linux-kernel, Jiri Kosina, Benjamin Tissoires, Corentin Chary,
Luke D . Jones, Hans de Goede, Ilpo Järvinen, Denis Benato,
Antheas Kapenekakis
In-Reply-To: <20251018101759.4089-1-lkml@antheas.dev>
Some devices, such as the Z13 have multiple Aura devices connected
to them by USB. In addition, they might have a WMI interface for
RGB. In Windows, Armoury Crate exposes a unified brightness slider
for all of them, with 3 brightness levels.
Therefore, to be synergistic in Linux, and support existing tooling
such as UPower, allow adding listeners to the RGB device of the WMI
interface. If WMI does not exist, lazy initialize the interface.
Since both hid-asus and asus-wmi can both interact with the led
objects including from an atomic context, protect the brightness
access with a spinlock and update the values from a workqueue.
Use this workqueue to process WMI keyboard events as well, so they
are processed asynchronously.
Reviewed-by: Luke D. Jones <luke@ljones.dev>
Tested-by: Luke D. Jones <luke@ljones.dev>
Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
---
drivers/platform/x86/asus-wmi.c | 175 ++++++++++++++++++---
include/linux/platform_data/x86/asus-wmi.h | 17 ++
2 files changed, 168 insertions(+), 24 deletions(-)
diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
index e72a2b5d158e..aab779142323 100644
--- a/drivers/platform/x86/asus-wmi.c
+++ b/drivers/platform/x86/asus-wmi.c
@@ -36,6 +36,7 @@
#include <linux/rfkill.h>
#include <linux/seq_file.h>
#include <linux/slab.h>
+#include <linux/spinlock.h>
#include <linux/types.h>
#include <linux/units.h>
@@ -258,6 +259,9 @@ struct asus_wmi {
int tpd_led_wk;
struct led_classdev kbd_led;
int kbd_led_wk;
+ bool kbd_led_notify;
+ bool kbd_led_avail;
+ bool kbd_led_registered;
struct led_classdev lightbar_led;
int lightbar_led_wk;
struct led_classdev micmute_led;
@@ -266,6 +270,7 @@ struct asus_wmi {
struct work_struct tpd_led_work;
struct work_struct wlan_led_work;
struct work_struct lightbar_led_work;
+ struct work_struct kbd_led_work;
struct asus_rfkill wlan;
struct asus_rfkill bluetooth;
@@ -1530,6 +1535,100 @@ static void asus_wmi_battery_exit(struct asus_wmi *asus)
/* LEDs ***********************************************************************/
+struct asus_hid_ref {
+ struct list_head listeners;
+ struct asus_wmi *asus;
+ /* Protects concurrent access from hid-asus and asus-wmi to leds */
+ spinlock_t lock;
+};
+
+static struct asus_hid_ref asus_ref = {
+ .listeners = LIST_HEAD_INIT(asus_ref.listeners),
+ .asus = NULL,
+ /*
+ * Protects .asus, .asus.kbd_led_{wk,notify}, and .listener refs. Other
+ * asus variables are read-only after .asus is set. Except the led cdev
+ * device if not kbd_led_avail. That becomes read-only after the
+ * first hid-asus listener registers and triggers the work queue. It is
+ * then not referenced again until unregistering, which happens after
+ * .asus ref is dropped. Since .asus needs to be accessed by hid-asus
+ * IRQs to check if forwarding events is possible, a spinlock is used.
+ */
+ .lock = __SPIN_LOCK_UNLOCKED(asus_ref.lock),
+};
+
+/*
+ * Allows registering hid-asus listeners that want to be notified of
+ * keyboard backlight changes.
+ */
+int asus_hid_register_listener(struct asus_hid_listener *bdev)
+{
+ struct asus_wmi *asus;
+
+ guard(spinlock_irqsave)(&asus_ref.lock);
+ list_add_tail(&bdev->list, &asus_ref.listeners);
+ asus = asus_ref.asus;
+ if (asus)
+ queue_work(asus->led_workqueue, &asus->kbd_led_work);
+ return 0;
+}
+EXPORT_SYMBOL_GPL(asus_hid_register_listener);
+
+/*
+ * Allows unregistering hid-asus listeners that were added with
+ * asus_hid_register_listener().
+ */
+void asus_hid_unregister_listener(struct asus_hid_listener *bdev)
+{
+ guard(spinlock_irqsave)(&asus_ref.lock);
+ list_del(&bdev->list);
+}
+EXPORT_SYMBOL_GPL(asus_hid_unregister_listener);
+
+static void do_kbd_led_set(struct led_classdev *led_cdev, int value);
+
+static void kbd_led_update_all(struct work_struct *work)
+{
+ enum led_brightness value;
+ struct asus_wmi *asus;
+ bool registered, notify;
+ int ret;
+
+ asus = container_of(work, struct asus_wmi, kbd_led_work);
+
+ scoped_guard(spinlock_irqsave, &asus_ref.lock) {
+ registered = asus->kbd_led_registered;
+ value = asus->kbd_led_wk;
+ notify = asus->kbd_led_notify;
+ }
+
+ if (!registered) {
+ /*
+ * This workqueue runs under asus-wmi, which means probe has
+ * completed and asus-wmi will keep running until it finishes.
+ * Therefore, we can safely register the LED without holding
+ * a spinlock.
+ */
+ ret = devm_led_classdev_register(&asus->platform_device->dev,
+ &asus->kbd_led);
+ if (!ret) {
+ scoped_guard(spinlock_irqsave, &asus_ref.lock)
+ asus->kbd_led_registered = true;
+ } else {
+ pr_warn("Failed to register keyboard backlight LED: %d\n", ret);
+ return;
+ }
+ }
+
+ if (value >= 0)
+ do_kbd_led_set(&asus->kbd_led, value);
+ if (notify) {
+ scoped_guard(spinlock_irqsave, &asus_ref.lock)
+ asus->kbd_led_notify = false;
+ led_classdev_notify_brightness_hw_changed(&asus->kbd_led, value);
+ }
+}
+
/*
* These functions actually update the LED's, and are called from a
* workqueue. By doing this as separate work rather than when the LED
@@ -1576,7 +1675,8 @@ static void kbd_led_update(struct asus_wmi *asus)
{
int ctrl_param = 0;
- ctrl_param = 0x80 | (asus->kbd_led_wk & 0x7F);
+ scoped_guard(spinlock_irqsave, &asus_ref.lock)
+ ctrl_param = 0x80 | (asus->kbd_led_wk & 0x7F);
asus_wmi_set_devstate(ASUS_WMI_DEVID_KBD_BACKLIGHT, ctrl_param, NULL);
}
@@ -1609,14 +1709,23 @@ static int kbd_led_read(struct asus_wmi *asus, int *level, int *env)
static void do_kbd_led_set(struct led_classdev *led_cdev, int value)
{
+ struct asus_hid_listener *listener;
struct asus_wmi *asus;
int max_level;
asus = container_of(led_cdev, struct asus_wmi, kbd_led);
max_level = asus->kbd_led.max_brightness;
- asus->kbd_led_wk = clamp_val(value, 0, max_level);
- kbd_led_update(asus);
+ scoped_guard(spinlock_irqsave, &asus_ref.lock)
+ asus->kbd_led_wk = clamp_val(value, 0, max_level);
+
+ if (asus->kbd_led_avail)
+ kbd_led_update(asus);
+
+ scoped_guard(spinlock_irqsave, &asus_ref.lock) {
+ list_for_each_entry(listener, &asus_ref.listeners, list)
+ listener->brightness_set(listener, asus->kbd_led_wk);
+ }
}
static void kbd_led_set(struct led_classdev *led_cdev,
@@ -1631,10 +1740,11 @@ static void kbd_led_set(struct led_classdev *led_cdev,
static void kbd_led_set_by_kbd(struct asus_wmi *asus, enum led_brightness value)
{
- struct led_classdev *led_cdev = &asus->kbd_led;
-
- do_kbd_led_set(led_cdev, value);
- led_classdev_notify_brightness_hw_changed(led_cdev, asus->kbd_led_wk);
+ scoped_guard(spinlock_irqsave, &asus_ref.lock) {
+ asus->kbd_led_wk = value;
+ asus->kbd_led_notify = true;
+ }
+ queue_work(asus->led_workqueue, &asus->kbd_led_work);
}
static enum led_brightness kbd_led_get(struct led_classdev *led_cdev)
@@ -1644,10 +1754,18 @@ static enum led_brightness kbd_led_get(struct led_classdev *led_cdev)
asus = container_of(led_cdev, struct asus_wmi, kbd_led);
+ scoped_guard(spinlock_irqsave, &asus_ref.lock) {
+ if (!asus->kbd_led_avail)
+ return asus->kbd_led_wk;
+ }
+
retval = kbd_led_read(asus, &value, NULL);
if (retval < 0)
return retval;
+ scoped_guard(spinlock_irqsave, &asus_ref.lock)
+ asus->kbd_led_wk = value;
+
return value;
}
@@ -1759,7 +1877,9 @@ static int camera_led_set(struct led_classdev *led_cdev,
static void asus_wmi_led_exit(struct asus_wmi *asus)
{
- led_classdev_unregister(&asus->kbd_led);
+ scoped_guard(spinlock_irqsave, &asus_ref.lock)
+ asus_ref.asus = NULL;
+
led_classdev_unregister(&asus->tpd_led);
led_classdev_unregister(&asus->wlan_led);
led_classdev_unregister(&asus->lightbar_led);
@@ -1797,22 +1917,25 @@ static int asus_wmi_led_init(struct asus_wmi *asus)
goto error;
}
- if (!kbd_led_read(asus, &led_val, NULL) && !dmi_check_system(asus_use_hid_led_dmi_ids)) {
- pr_info("using asus-wmi for asus::kbd_backlight\n");
- asus->kbd_led_wk = led_val;
- asus->kbd_led.name = "asus::kbd_backlight";
- asus->kbd_led.flags = LED_BRIGHT_HW_CHANGED;
- asus->kbd_led.brightness_set = kbd_led_set;
- asus->kbd_led.brightness_get = kbd_led_get;
- asus->kbd_led.max_brightness = 3;
+ asus->kbd_led.name = "asus::kbd_backlight";
+ asus->kbd_led.flags = LED_BRIGHT_HW_CHANGED;
+ asus->kbd_led.brightness_set = kbd_led_set;
+ asus->kbd_led.brightness_get = kbd_led_get;
+ asus->kbd_led.max_brightness = 3;
+ asus->kbd_led_avail = !kbd_led_read(asus, &led_val, NULL);
+ INIT_WORK(&asus->kbd_led_work, kbd_led_update_all);
+ if (asus->kbd_led_avail) {
+ asus->kbd_led_wk = led_val;
if (num_rgb_groups != 0)
asus->kbd_led.groups = kbd_rgb_mode_groups;
+ } else
+ asus->kbd_led_wk = -1;
- rv = led_classdev_register(&asus->platform_device->dev,
- &asus->kbd_led);
- if (rv)
- goto error;
+ scoped_guard(spinlock_irqsave, &asus_ref.lock) {
+ asus_ref.asus = asus;
+ if (asus->kbd_led_avail || !list_empty(&asus_ref.listeners))
+ queue_work(asus->led_workqueue, &asus->kbd_led_work);
}
if (asus_wmi_dev_is_present(asus, ASUS_WMI_DEVID_WIRELESS_LED)
@@ -4272,6 +4395,7 @@ static int asus_wmi_get_event_code(union acpi_object *obj)
static void asus_wmi_handle_event_code(int code, struct asus_wmi *asus)
{
+ enum led_brightness led_value;
unsigned int key_value = 1;
bool autorelease = 1;
@@ -4288,19 +4412,22 @@ static void asus_wmi_handle_event_code(int code, struct asus_wmi *asus)
return;
}
+ scoped_guard(spinlock_irqsave, &asus_ref.lock)
+ led_value = asus->kbd_led_wk;
+
if (code == NOTIFY_KBD_BRTUP) {
- kbd_led_set_by_kbd(asus, asus->kbd_led_wk + 1);
+ kbd_led_set_by_kbd(asus, led_value + 1);
return;
}
if (code == NOTIFY_KBD_BRTDWN) {
- kbd_led_set_by_kbd(asus, asus->kbd_led_wk - 1);
+ kbd_led_set_by_kbd(asus, led_value - 1);
return;
}
if (code == NOTIFY_KBD_BRTTOGGLE) {
- if (asus->kbd_led_wk == asus->kbd_led.max_brightness)
+ if (led_value == asus->kbd_led.max_brightness)
kbd_led_set_by_kbd(asus, 0);
else
- kbd_led_set_by_kbd(asus, asus->kbd_led_wk + 1);
+ kbd_led_set_by_kbd(asus, led_value + 1);
return;
}
diff --git a/include/linux/platform_data/x86/asus-wmi.h b/include/linux/platform_data/x86/asus-wmi.h
index 8a515179113d..1165039013b1 100644
--- a/include/linux/platform_data/x86/asus-wmi.h
+++ b/include/linux/platform_data/x86/asus-wmi.h
@@ -163,11 +163,20 @@ enum asus_ally_mcu_hack {
ASUS_WMI_ALLY_MCU_HACK_DISABLED,
};
+/* Used to notify hid-asus when asus-wmi changes keyboard backlight */
+struct asus_hid_listener {
+ struct list_head list;
+ void (*brightness_set)(struct asus_hid_listener *listener, int brightness);
+};
+
#if IS_REACHABLE(CONFIG_ASUS_WMI)
void set_ally_mcu_hack(enum asus_ally_mcu_hack status);
void set_ally_mcu_powersave(bool enabled);
int asus_wmi_set_devstate(u32 dev_id, u32 ctrl_param, u32 *retval);
int asus_wmi_evaluate_method(u32 method_id, u32 arg0, u32 arg1, u32 *retval);
+
+int asus_hid_register_listener(struct asus_hid_listener *cdev);
+void asus_hid_unregister_listener(struct asus_hid_listener *cdev);
#else
static inline void set_ally_mcu_hack(enum asus_ally_mcu_hack status)
{
@@ -184,6 +193,14 @@ static inline int asus_wmi_evaluate_method(u32 method_id, u32 arg0, u32 arg1,
{
return -ENODEV;
}
+
+static inline int asus_hid_register_listener(struct asus_hid_listener *bdev)
+{
+ return -ENODEV;
+}
+static inline void asus_hid_unregister_listener(struct asus_hid_listener *bdev)
+{
+}
#endif
/* To be used by both hid-asus and asus-wmi to determine which controls kbd_brightness */
--
2.51.0
^ permalink raw reply related
* [PATCH v7 2/9] HID: asus: use same report_id in response
From: Antheas Kapenekakis @ 2025-10-18 10:17 UTC (permalink / raw)
To: platform-driver-x86, linux-input
Cc: linux-kernel, Jiri Kosina, Benjamin Tissoires, Corentin Chary,
Luke D . Jones, Hans de Goede, Ilpo Järvinen, Denis Benato,
Antheas Kapenekakis
In-Reply-To: <20251018101759.4089-1-lkml@antheas.dev>
Currently, asus_kbd_get_functions prods the device using feature
report report_id, but then is hardcoded to check the response through
FEATURE_KBD_REPORT_ID. This only works if report_id is that value
(currently true). So, use report_id in the response as well to
maintain functionality if that value changes in the future.
Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
---
drivers/hid/hid-asus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
index 7ea1037c3979..4676b7f20caf 100644
--- a/drivers/hid/hid-asus.c
+++ b/drivers/hid/hid-asus.c
@@ -422,7 +422,7 @@ static int asus_kbd_get_functions(struct hid_device *hdev,
if (!readbuf)
return -ENOMEM;
- ret = hid_hw_raw_request(hdev, FEATURE_KBD_REPORT_ID, readbuf,
+ ret = hid_hw_raw_request(hdev, report_id, readbuf,
FEATURE_KBD_REPORT_SIZE, HID_FEATURE_REPORT,
HID_REQ_GET_REPORT);
if (ret < 0) {
--
2.51.0
^ permalink raw reply related
* [PATCH v7 4/9] HID: asus: prevent binding to all HID devices on ROG
From: Antheas Kapenekakis @ 2025-10-18 10:17 UTC (permalink / raw)
To: platform-driver-x86, linux-input
Cc: linux-kernel, Jiri Kosina, Benjamin Tissoires, Corentin Chary,
Luke D . Jones, Hans de Goede, Ilpo Järvinen, Denis Benato,
Antheas Kapenekakis
In-Reply-To: <20251018101759.4089-1-lkml@antheas.dev>
Currently, when hid-asus is not loaded, NKEY keyboards load as ~6
event devices with a pretty ASUSTEK name. When it loads, it concatenates
all applications per HID endpoint, renames them, and prints errors
when some of them do not have an input device.
Therefore, change probe so that this is no longer the case. Stop
renaming the devices, omit the check for .input which causes errors on
e.g., the Z13 for some hiddev only devices, and add
HID_QUIRK_INPUT_PER_APP so that each application gets its own event.
When this is done, the probes are called multiple times. Due to this,
the rgb check needs to be moved into probe, and the report fixup should
be skipped for non-vendor endpoints (prevents multiple prints).
Reviewed-by: Luke D. Jones <luke@ljones.dev>
Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
---
drivers/hid/hid-asus.c | 59 +++++++++++++++++++++++++++---------------
1 file changed, 38 insertions(+), 21 deletions(-)
diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
index 03f0d86936fc..bbbac98f76c6 100644
--- a/drivers/hid/hid-asus.c
+++ b/drivers/hid/hid-asus.c
@@ -47,6 +47,7 @@ MODULE_DESCRIPTION("Asus HID Keyboard and TouchPad");
#define T100CHI_MOUSE_REPORT_ID 0x06
#define FEATURE_REPORT_ID 0x0d
#define INPUT_REPORT_ID 0x5d
+#define HID_USAGE_PAGE_VENDOR 0xff310000
#define FEATURE_KBD_REPORT_ID 0x5a
#define FEATURE_KBD_REPORT_SIZE 64
#define FEATURE_KBD_LED_REPORT_ID1 0x5d
@@ -89,6 +90,7 @@ MODULE_DESCRIPTION("Asus HID Keyboard and TouchPad");
#define QUIRK_ROG_NKEY_KEYBOARD BIT(11)
#define QUIRK_ROG_CLAYMORE_II_KEYBOARD BIT(12)
#define QUIRK_ROG_ALLY_XPAD BIT(13)
+#define QUIRK_SKIP_REPORT_FIXUP BIT(14)
#define I2C_KEYBOARD_QUIRKS (QUIRK_FIX_NOTEBOOK_REPORT | \
QUIRK_NO_INIT_REPORTS | \
@@ -125,7 +127,6 @@ struct asus_drvdata {
struct input_dev *tp_kbd_input;
struct asus_kbd_leds *kbd_backlight;
const struct asus_touchpad_info *tp;
- bool enable_backlight;
struct power_supply *battery;
struct power_supply_desc battery_desc;
int battery_capacity;
@@ -316,7 +317,7 @@ static int asus_e1239t_event(struct asus_drvdata *drvdat, u8 *data, int size)
static int asus_event(struct hid_device *hdev, struct hid_field *field,
struct hid_usage *usage, __s32 value)
{
- if ((usage->hid & HID_USAGE_PAGE) == 0xff310000 &&
+ if ((usage->hid & HID_USAGE_PAGE) == HID_USAGE_PAGE_VENDOR &&
(usage->hid & HID_USAGE) != 0x00 &&
(usage->hid & HID_USAGE) != 0xff && !usage->type) {
hid_warn(hdev, "Unmapped Asus vendor usagepage code 0x%02x\n",
@@ -931,11 +932,6 @@ static int asus_input_configured(struct hid_device *hdev, struct hid_input *hi)
drvdata->input = input;
- if (drvdata->enable_backlight &&
- !asus_kbd_wmi_led_control_present(hdev) &&
- asus_kbd_register_leds(hdev))
- hid_warn(hdev, "Failed to initialize backlight.\n");
-
return 0;
}
@@ -1008,15 +1004,6 @@ static int asus_input_mapping(struct hid_device *hdev,
return -1;
}
- /*
- * Check and enable backlight only on devices with UsagePage ==
- * 0xff31 to avoid initializing the keyboard firmware multiple
- * times on devices with multiple HID descriptors but same
- * PID/VID.
- */
- if (drvdata->quirks & QUIRK_USE_KBD_BACKLIGHT)
- drvdata->enable_backlight = true;
-
set_bit(EV_REP, hi->input->evbit);
return 1;
}
@@ -1133,8 +1120,10 @@ static int __maybe_unused asus_reset_resume(struct hid_device *hdev)
static int asus_probe(struct hid_device *hdev, const struct hid_device_id *id)
{
- int ret;
+ struct hid_report_enum *rep_enum;
struct asus_drvdata *drvdata;
+ struct hid_report *rep;
+ int ret, is_vendor = 0;
drvdata = devm_kzalloc(&hdev->dev, sizeof(*drvdata), GFP_KERNEL);
if (drvdata == NULL) {
@@ -1218,18 +1207,42 @@ static int asus_probe(struct hid_device *hdev, const struct hid_device_id *id)
return ret;
}
+ /* Check for vendor for RGB init and handle generic devices properly. */
+ rep_enum = &hdev->report_enum[HID_INPUT_REPORT];
+ list_for_each_entry(rep, &rep_enum->report_list, list) {
+ if ((rep->application & HID_USAGE_PAGE) == HID_USAGE_PAGE_VENDOR)
+ is_vendor = true;
+ }
+
+ /*
+ * For ROG keyboards, make them HID/hiddev compliant by creating one
+ * input per application. For interfaces other than the vendor one,
+ * disable report fixups.
+ */
+ if (drvdata->quirks & QUIRK_ROG_NKEY_KEYBOARD) {
+ if (!is_vendor)
+ drvdata->quirks |= QUIRK_SKIP_REPORT_FIXUP;
+ hdev->quirks |= HID_QUIRK_INPUT_PER_APP;
+ }
+
ret = hid_hw_start(hdev, HID_CONNECT_DEFAULT);
if (ret) {
hid_err(hdev, "Asus hw start failed: %d\n", ret);
return ret;
}
+ if (is_vendor && (drvdata->quirks & QUIRK_USE_KBD_BACKLIGHT) &&
+ !asus_kbd_wmi_led_control_present(hdev) &&
+ asus_kbd_register_leds(hdev))
+ hid_warn(hdev, "Failed to initialize backlight.\n");
+
/*
- * Check that input registration succeeded. Checking that
- * HID_CLAIMED_INPUT is set prevents a UAF when all input devices
- * were freed during registration due to no usages being mapped,
- * leaving drvdata->input pointing to freed memory.
+ * For ROG keyboards, skip rename for consistency and ->input check as
+ * some devices do not have inputs.
*/
+ if (drvdata->quirks & QUIRK_ROG_NKEY_KEYBOARD)
+ return 0;
+
if (!drvdata->input || !(hdev->claimed & HID_CLAIMED_INPUT)) {
hid_err(hdev, "Asus input not registered\n");
ret = -ENOMEM;
@@ -1352,6 +1365,10 @@ static const __u8 *asus_report_fixup(struct hid_device *hdev, __u8 *rdesc,
rdesc = new_rdesc;
}
+ /* Vendor fixups should only apply to NKEY vendor devices. */
+ if (drvdata->quirks & QUIRK_SKIP_REPORT_FIXUP)
+ return rdesc;
+
if (drvdata->quirks & QUIRK_ROG_NKEY_KEYBOARD &&
*rsize == 331 && rdesc[190] == 0x85 && rdesc[191] == 0x5a &&
rdesc[204] == 0x95 && rdesc[205] == 0x05) {
--
2.51.0
^ permalink raw reply related
* [PATCH v7 1/9] HID: asus: simplify RGB init sequence
From: Antheas Kapenekakis @ 2025-10-18 10:17 UTC (permalink / raw)
To: platform-driver-x86, linux-input
Cc: linux-kernel, Jiri Kosina, Benjamin Tissoires, Corentin Chary,
Luke D . Jones, Hans de Goede, Ilpo Järvinen, Denis Benato,
Antheas Kapenekakis
In-Reply-To: <20251018101759.4089-1-lkml@antheas.dev>
Currently, RGB initialization forks depending on whether a device is
NKEY. Then, NKEY devices are initialized using 0x5a, 0x5d, 0x5e
endpoints, and non-NKEY devices with 0x5a and then a
backlight check, which is omitted for NKEY devices.
Remove the fork, using a common initialization sequence for both,
where they are both only initialized with 0x5a, then checked for
backlight support. This patch should not affect existing functionality.
0x5d and 0x5e endpoint initializations are performed by Windows
userspace programs associated with different usages that reside under
the vendor HID. Specifically, 0x5d is used by Armoury Crate, which
controls RGB and 0x5e by an animation program for certain Asus laptops.
Neither is used currently in the driver.
Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
---
drivers/hid/hid-asus.c | 56 ++++++++++++++----------------------------
1 file changed, 19 insertions(+), 37 deletions(-)
diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
index a444d41e53b6..7ea1037c3979 100644
--- a/drivers/hid/hid-asus.c
+++ b/drivers/hid/hid-asus.c
@@ -638,50 +638,32 @@ static int asus_kbd_register_leds(struct hid_device *hdev)
unsigned char kbd_func;
int ret;
- if (drvdata->quirks & QUIRK_ROG_NKEY_KEYBOARD) {
- /* Initialize keyboard */
- ret = asus_kbd_init(hdev, FEATURE_KBD_REPORT_ID);
- if (ret < 0)
- return ret;
-
- /* The LED endpoint is initialised in two HID */
- ret = asus_kbd_init(hdev, FEATURE_KBD_LED_REPORT_ID1);
- if (ret < 0)
- return ret;
-
- ret = asus_kbd_init(hdev, FEATURE_KBD_LED_REPORT_ID2);
- if (ret < 0)
- return ret;
-
- if (dmi_match(DMI_PRODUCT_FAMILY, "ProArt P16")) {
- ret = asus_kbd_disable_oobe(hdev);
- if (ret < 0)
- return ret;
- }
-
- if (drvdata->quirks & QUIRK_ROG_ALLY_XPAD) {
- intf = to_usb_interface(hdev->dev.parent);
- udev = interface_to_usbdev(intf);
- validate_mcu_fw_version(hdev,
- le16_to_cpu(udev->descriptor.idProduct));
- }
+ ret = asus_kbd_init(hdev, FEATURE_KBD_REPORT_ID);
+ if (ret < 0)
+ return ret;
- } else {
- /* Initialize keyboard */
- ret = asus_kbd_init(hdev, FEATURE_KBD_REPORT_ID);
- if (ret < 0)
- return ret;
+ /* Get keyboard functions */
+ ret = asus_kbd_get_functions(hdev, &kbd_func, FEATURE_KBD_REPORT_ID);
+ if (ret < 0)
+ return ret;
- /* Get keyboard functions */
- ret = asus_kbd_get_functions(hdev, &kbd_func, FEATURE_KBD_REPORT_ID);
+ if (dmi_match(DMI_PRODUCT_FAMILY, "ProArt P16")) {
+ ret = asus_kbd_disable_oobe(hdev);
if (ret < 0)
return ret;
+ }
- /* Check for backlight support */
- if (!(kbd_func & SUPPORT_KBD_BACKLIGHT))
- return -ENODEV;
+ if (drvdata->quirks & QUIRK_ROG_ALLY_XPAD) {
+ intf = to_usb_interface(hdev->dev.parent);
+ udev = interface_to_usbdev(intf);
+ validate_mcu_fw_version(
+ hdev, le16_to_cpu(udev->descriptor.idProduct));
}
+ /* Check for backlight support */
+ if (!(kbd_func & SUPPORT_KBD_BACKLIGHT))
+ return -ENODEV;
+
drvdata->kbd_backlight = devm_kzalloc(&hdev->dev,
sizeof(struct asus_kbd_leds),
GFP_KERNEL);
--
2.51.0
^ permalink raw reply related
* [PATCH v7 0/9] HID: asus: Fix ASUS ROG Laptop's Keyboard backlight handling
From: Antheas Kapenekakis @ 2025-10-18 10:17 UTC (permalink / raw)
To: platform-driver-x86, linux-input
Cc: linux-kernel, Jiri Kosina, Benjamin Tissoires, Corentin Chary,
Luke D . Jones, Hans de Goede, Ilpo Järvinen, Denis Benato,
Antheas Kapenekakis
This is a two part series which does the following:
- Clean-up init sequence
- Unify backlight handling to happen under asus-wmi so that all Aura
devices have synced brightness controls and the backlight button works
properly when it is on a USB laptop keyboard instead of one w/ WMI.
For more context, see cover letter of V1. Since V5, I removed some patches
to make this easier to merge.
---
V6: https://lore.kernel.org/all/20251013201535.6737-1-lkml@antheas.dev/
V5: https://lore.kernel.org/all/20250325184601.10990-1-lkml@antheas.dev/
V4: https://lore.kernel.org/lkml/20250324210151.6042-1-lkml@antheas.dev/
V3: https://lore.kernel.org/lkml/20250322102804.418000-1-lkml@antheas.dev/
V2: https://lore.kernel.org/all/20250320220924.5023-1-lkml@antheas.dev/
V1: https://lore.kernel.org/all/20250319191320.10092-1-lkml@antheas.dev/
Changes since V6:
- Split initialization refactor into three patches, update commit text
to be clearer in what it does
- Replace spinlock accesses with guard and scoped guard in all patches
- Add missing includes mentioned by Ilpo
- Reflow, tweak comment in prevent binding to all HID devices on ROG
- Replace asus_ref.asus with local reference in all patches
- Add missing kernel doc comments
- Other minor nits from Ilpo
- User reported warning due to scheduling work while holding a spinlock.
Restructure patch for multiple handlers to limit when spinlock is held to
variable access only. In parallel, setup a workqueue to handle registration
of led device and setting brightness. This is required as registering the
led device triggers kbd_led_get which needs to hold the spinlock to
protect the led_wk value. The workqueue is also required for the hid
event passthrough to avoid scheduling work while holding the spinlock.
Apply the workqueue to wmi brightness buttons as well, as that was
omitted before this series and WMI access was performed.
- On "HID: asus: prevent binding to all HID devices on ROG", rename
quirk HANDLE_GENERIC to SKIP_REPORT_FIXUP and only skip report fixup.
This allows other quirks to apply (applies quirk that fixes keyboard
being named as a pointer device).
Changes since V5:
- It's been a long time
- Remove addition of RGB as that had some comments I need to work on
- Remove folio patch (already merged)
- Remove legacy fix patch 11 from V4. There is a small chance that
without this patch, some old NKEY keyboards might not respond to
RGB commands according to Luke, but the kernel driver does not do
RGB currently. The 0x5d init is done by Armoury crate software in
Windows. If an issue is found, we can re-add it or just remove patches
1/2 before merging. However, init could use the cleanup.
Changes since V4:
- Fix KConfig (reported by kernel robot)
- Fix Ilpo's nits, if I missed anything lmk
Changes since V3:
- Add initializer for 0x5d for old NKEY keyboards until it is verified
that it is not needed for their media keys to function.
- Cover init in asus-wmi with spinlock as per Hans
- If asus-wmi registers WMI handler with brightness, init the brightness
in USB Asus keyboards, per Hans.
- Change hid handler name to asus-UNIQ:rgb:peripheral to match led class
- Fix oops when unregistering asus-wmi by moving unregister outside of
the spin lock (but after the asus reference is set to null)
Changes since V2:
- Check lazy init succeds in asus-wmi before setting register variable
- make explicit check in asus_hid_register_listener for listener existing
to avoid re-init
- rename asus_brt to asus_hid in most places and harmonize everything
- switch to a spinlock instead of a mutex to avoid kernel ooops
- fixup hid device quirks to avoid multiple RGB devices while still exposing
all input vendor devices. This includes moving rgb init to probe
instead of the input_configured callbacks.
- Remove fan key (during retest it appears to be 0xae that is already
supported by hid-asus)
- Never unregister asus::kbd_backlight while asus-wmi is active, as that
- removes fds from userspace and breaks backlight functionality. All
- current mainline drivers do not support backlight hotplugging, so most
userspace software (e.g., KDE, UPower) is built with that assumption.
For the Ally, since it disconnects its controller during sleep, this
caused the backlight slider to not work in KDE.
Changes since V1:
- Add basic RGB support on hid-asus, (Z13/Ally) tested in KDE/Z13
- Fix ifdef else having an invalid signature (reported by kernel robot)
- Restore input arguments to init and keyboard function so they can
be re-used for RGB controls.
- Remove Z13 delay (it did not work to fix the touchpad) and replace it
with a HID_GROUP_GENERIC quirk to allow hid-multitouch to load. Squash
keyboard rename into it.
- Unregister brightness listener before removing work queue to avoid
a race condition causing corruption
- Remove spurious mutex unlock in asus_brt_event
- Place mutex lock in kbd_led_set after LED_UNREGISTERING check to avoid
relocking the mutex and causing a deadlock when unregistering leds
- Add extra check during unregistering to avoid calling unregister when
no led device is registered.
- Temporarily HID_QUIRK_INPUT_PER_APP from the ROG endpoint as it causes
the driver to create 4 RGB handlers per device. I also suspect some
extra events sneak through (KDE had the @@@@@@).
Antheas Kapenekakis (9):
HID: asus: simplify RGB init sequence
HID: asus: use same report_id in response
HID: asus: fortify keyboard handshake
HID: asus: prevent binding to all HID devices on ROG
platform/x86: asus-wmi: Add support for multiple kbd led handlers
HID: asus: listen to the asus-wmi brightness device instead of
creating one
platform/x86: asus-wmi: remove unused keyboard backlight quirk
platform/x86: asus-wmi: add keyboard brightness event handler
HID: asus: add support for the asus-wmi brightness handler
drivers/hid/hid-asus.c | 222 ++++++++++-----------
drivers/platform/x86/asus-wmi.c | 215 +++++++++++++++++---
include/linux/platform_data/x86/asus-wmi.h | 70 +++----
3 files changed, 326 insertions(+), 181 deletions(-)
base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787
--
2.51.0
^ permalink raw reply
* [PATCH v2] HID: lenovo: fixup Lenovo Yoga Slim 7x Keyboard rdesc
From: Lauri Tirkkonen @ 2025-10-18 6:35 UTC (permalink / raw)
To: Jiri Kosina, Benjamin Tissoires, linux-input, linux-kernel
The keyboard of this device has the following in its report description
for Usage (Keyboard) in Collection (Application):
# 0x15, 0x00, // Logical Minimum (0) 52
# 0x25, 0x65, // Logical Maximum (101) 54
# 0x05, 0x07, // Usage Page (Keyboard) 56
# 0x19, 0x00, // Usage Minimum (0) 58
# 0x29, 0xdd, // Usage Maximum (221) 60
# 0x81, 0x00, // Input (Data,Arr,Abs) 62
Since the Usage Min/Max range exceeds the Logical Min/Max range,
keypresses outside the Logical range are not recognized. This includes,
for example, the Japanese language keyboard variant's keys for |, _ and
\.
Fixup the report description to make the Logical range match the Usage
range, fixing the interpretation of keypresses above 101 on this device.
Signed-off-by: Lauri Tirkkonen <lauri@hacktheplanet.fi>
---
v1 -> v2: moved to hid-lenovo from hid-i2c, renamed hid-ids macro to
clarify the device only refers to the keyboard
v1: https://lore.kernel.org/all/aOdLxAEYQpV2zp77@mail.hacktheplanet.fi/
drivers/hid/hid-ids.h | 1 +
drivers/hid/hid-lenovo.c | 17 +++++++++++++++++
2 files changed, 18 insertions(+)
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index 5721b8414bbd..4b1946eb4e7f 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -715,6 +715,7 @@
#define USB_DEVICE_ID_ITE_LENOVO_YOGA2 0x8350
#define I2C_DEVICE_ID_ITE_LENOVO_LEGION_Y720 0x837a
#define USB_DEVICE_ID_ITE_LENOVO_YOGA900 0x8396
+#define I2C_DEVICE_ID_ITE_LENOVO_YOGA_SLIM_7X_KEYBOARD 0x8987
#define USB_DEVICE_ID_ITE8595 0x8595
#define USB_DEVICE_ID_ITE_MEDION_E1239T 0xce50
diff --git a/drivers/hid/hid-lenovo.c b/drivers/hid/hid-lenovo.c
index 654879814f97..9cc3e029e9f6 100644
--- a/drivers/hid/hid-lenovo.c
+++ b/drivers/hid/hid-lenovo.c
@@ -148,6 +148,14 @@ static const __u8 lenovo_tpIIbtkbd_need_fixup_collection[] = {
0x81, 0x01, /* Input (Const,Array,Abs,No Wrap,Linear,Preferred State,No Null Position) */
};
+static const __u8 lenovo_yoga7x_kbd_need_fixup_collection[] = {
+ 0x15, 0x00, // Logical Minimum (0)
+ 0x25, 0x65, // Logical Maximum (101)
+ 0x05, 0x07, // Usage Page (Keyboard)
+ 0x19, 0x00, // Usage Minimum (0)
+ 0x29, 0xDD, // Usage Maximum (221)
+};
+
static const __u8 *lenovo_report_fixup(struct hid_device *hdev, __u8 *rdesc,
unsigned int *rsize)
{
@@ -177,6 +185,13 @@ static const __u8 *lenovo_report_fixup(struct hid_device *hdev, __u8 *rdesc,
rdesc[260] = 0x01; /* report count (2) = 0x01 */
}
break;
+ case I2C_DEVICE_ID_ITE_LENOVO_YOGA_SLIM_7X_KEYBOARD:
+ if (*rsize == 176 &&
+ memcmp(&rdesc[52], lenovo_yoga7x_kbd_need_fixup_collection,
+ sizeof(lenovo_yoga7x_kbd_need_fixup_collection)) == 0) {
+ rdesc[55] = rdesc[61]; // logical maximum = usage maximum
+ }
+ break;
}
return rdesc;
}
@@ -1538,6 +1553,8 @@ static const struct hid_device_id lenovo_devices[] = {
USB_VENDOR_ID_LENOVO, USB_DEVICE_ID_LENOVO_X12_TAB) },
{ HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
USB_VENDOR_ID_LENOVO, USB_DEVICE_ID_LENOVO_X12_TAB2) },
+ { HID_DEVICE(BUS_I2C, HID_GROUP_GENERIC,
+ USB_VENDOR_ID_ITE, I2C_DEVICE_ID_ITE_LENOVO_YOGA_SLIM_7X_KEYBOARD) },
{ }
};
--
2.51.1
--
Lauri Tirkkonen | lotheac @ IRCnet
^ permalink raw reply related
* Re: [PATCH v4] input: dt-bindings: ti,twl4030-keypad: convert to DT schema
From: Dmitry Torokhov @ 2025-10-18 4:50 UTC (permalink / raw)
To: Jihed Chaibi
Cc: krzk+dt, robh, conor+dt, peter.ujfalusi, devicetree, linux-input,
linux-kernel, shuah
In-Reply-To: <20250819222823.157943-1-jihed.chaibi.dev@gmail.com>
On Wed, Aug 20, 2025 at 12:28:23AM +0200, Jihed Chaibi wrote:
> Convert the legacy TXT binding for the TWL4030 keypad module
> to the modern YAML DT schema format. This adds formal validation
> and improves documentation by inheriting from the matrix-keymap schema.
>
> Signed-off-by: Jihed Chaibi <jihed.chaibi.dev@gmail.com>
>
Applied, thank you.
--
Dmitry
^ permalink raw reply
* [dtor-input:for-linus] BUILD SUCCESS 7363096a5a08f8740c9075ecfc51945375c304bc
From: kernel test robot @ 2025-10-18 4:49 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: linux-input
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus
branch HEAD: 7363096a5a08f8740c9075ecfc51945375c304bc Input: goodix - remove setting of RST pin to input
elapsed time: 1357m
configs tested: 166
configs skipped: 3
The following configs have been built successfully.
More configs may be tested in the coming days.
tested configs:
alpha allnoconfig clang-22
alpha allnoconfig gcc-15.1.0
alpha allyesconfig gcc-15.1.0
arc allmodconfig gcc-15.1.0
arc allnoconfig clang-22
arc allnoconfig gcc-15.1.0
arc allyesconfig gcc-15.1.0
arc randconfig-001-20251017 gcc-8.5.0
arc randconfig-002-20251017 gcc-11.5.0
arm allmodconfig gcc-15.1.0
arm allnoconfig clang-22
arm allyesconfig gcc-15.1.0
arm randconfig-001-20251017 gcc-15.1.0
arm randconfig-002-20251017 clang-22
arm randconfig-003-20251017 clang-22
arm randconfig-004-20251017 clang-22
arm64 allmodconfig clang-19
arm64 allnoconfig clang-22
arm64 allnoconfig gcc-15.1.0
arm64 randconfig-001-20251017 clang-20
arm64 randconfig-002-20251017 clang-22
arm64 randconfig-003-20251017 gcc-15.1.0
arm64 randconfig-004-20251017 clang-22
csky allnoconfig clang-22
csky allnoconfig gcc-15.1.0
csky randconfig-001-20251017 gcc-15.1.0
csky randconfig-002-20251017 gcc-10.5.0
hexagon allmodconfig clang-17
hexagon allnoconfig clang-22
hexagon allyesconfig clang-22
hexagon randconfig-001-20251017 clang-22
hexagon randconfig-002-20251017 clang-22
i386 allmodconfig gcc-14
i386 allnoconfig gcc-14
i386 allyesconfig gcc-14
i386 buildonly-randconfig-001-20251017 clang-20
i386 buildonly-randconfig-001-20251018 clang-20
i386 buildonly-randconfig-002-20251017 clang-20
i386 buildonly-randconfig-002-20251018 clang-20
i386 buildonly-randconfig-003-20251017 clang-20
i386 buildonly-randconfig-003-20251018 clang-20
i386 buildonly-randconfig-004-20251017 clang-20
i386 buildonly-randconfig-004-20251018 clang-20
i386 buildonly-randconfig-005-20251017 clang-20
i386 buildonly-randconfig-005-20251018 clang-20
i386 buildonly-randconfig-006-20251017 clang-20
i386 buildonly-randconfig-006-20251018 clang-20
i386 defconfig clang-20
i386 randconfig-001-20251018 gcc-14
i386 randconfig-002-20251018 gcc-14
i386 randconfig-003-20251018 gcc-14
i386 randconfig-004-20251018 gcc-14
i386 randconfig-005-20251018 gcc-14
i386 randconfig-006-20251018 gcc-14
i386 randconfig-007-20251018 gcc-14
i386 randconfig-011-20251018 clang-20
i386 randconfig-012-20251018 clang-20
i386 randconfig-013-20251018 clang-20
i386 randconfig-014-20251018 clang-20
i386 randconfig-015-20251018 clang-20
i386 randconfig-016-20251018 clang-20
i386 randconfig-017-20251018 clang-20
loongarch allmodconfig clang-19
loongarch allnoconfig clang-22
loongarch randconfig-001-20251017 gcc-13.4.0
loongarch randconfig-002-20251017 clang-18
m68k allmodconfig gcc-15.1.0
m68k allnoconfig gcc-15.1.0
m68k allyesconfig gcc-15.1.0
microblaze allmodconfig gcc-15.1.0
microblaze allnoconfig gcc-15.1.0
microblaze allyesconfig gcc-15.1.0
microblaze defconfig gcc-15.1.0
mips allnoconfig gcc-15.1.0
nios2 allnoconfig gcc-11.5.0
nios2 defconfig gcc-11.5.0
nios2 defconfig gcc-15.1.0
nios2 randconfig-001-20251017 gcc-8.5.0
nios2 randconfig-002-20251017 gcc-8.5.0
openrisc allnoconfig clang-22
openrisc allnoconfig gcc-15.1.0
openrisc allyesconfig gcc-15.1.0
parisc allmodconfig gcc-15.1.0
parisc allnoconfig clang-22
parisc allnoconfig gcc-15.1.0
parisc allyesconfig gcc-15.1.0
parisc defconfig gcc-15.1.0
parisc randconfig-001-20251017 gcc-12.5.0
parisc randconfig-002-20251017 gcc-8.5.0
parisc64 defconfig gcc-15.1.0
powerpc allmodconfig gcc-15.1.0
powerpc allnoconfig clang-22
powerpc allnoconfig gcc-15.1.0
powerpc allyesconfig clang-22
powerpc randconfig-001-20251017 gcc-14.3.0
powerpc randconfig-002-20251017 clang-22
powerpc randconfig-003-20251017 gcc-11.5.0
powerpc64 randconfig-001-20251017 clang-20
powerpc64 randconfig-002-20251017 gcc-15.1.0
powerpc64 randconfig-003-20251017 gcc-15.1.0
riscv allmodconfig clang-22
riscv allnoconfig clang-22
riscv allnoconfig gcc-15.1.0
riscv allyesconfig clang-16
riscv randconfig-001-20251018 gcc-8.5.0
riscv randconfig-002-20251018 clang-22
s390 allmodconfig clang-18
s390 allnoconfig clang-22
s390 allyesconfig gcc-15.1.0
s390 randconfig-002-20251018 clang-20
sh allmodconfig gcc-15.1.0
sh allnoconfig gcc-15.1.0
sh allyesconfig gcc-15.1.0
sh randconfig-001-20251018 gcc-13.4.0
sh randconfig-002-20251018 gcc-14.3.0
sparc allmodconfig gcc-15.1.0
sparc allnoconfig gcc-15.1.0
sparc defconfig gcc-15.1.0
sparc randconfig-001-20251018 gcc-11.5.0
sparc randconfig-002-20251018 gcc-13.4.0
sparc64 randconfig-001-20251018 gcc-8.5.0
sparc64 randconfig-002-20251018 clang-22
um allmodconfig clang-19
um allnoconfig clang-22
um allyesconfig gcc-14
um randconfig-001-20251018 gcc-14
um randconfig-002-20251018 gcc-14
x86_64 allnoconfig clang-20
x86_64 allyesconfig clang-20
x86_64 buildonly-randconfig-001-20251017 gcc-14
x86_64 buildonly-randconfig-001-20251018 clang-20
x86_64 buildonly-randconfig-002-20251017 gcc-14
x86_64 buildonly-randconfig-002-20251018 clang-20
x86_64 buildonly-randconfig-003-20251017 clang-20
x86_64 buildonly-randconfig-003-20251018 clang-20
x86_64 buildonly-randconfig-004-20251017 gcc-14
x86_64 buildonly-randconfig-004-20251018 clang-20
x86_64 buildonly-randconfig-005-20251017 clang-20
x86_64 buildonly-randconfig-005-20251018 clang-20
x86_64 buildonly-randconfig-006-20251017 clang-20
x86_64 buildonly-randconfig-006-20251018 clang-20
x86_64 defconfig gcc-14
x86_64 kexec clang-20
x86_64 randconfig-001-20251018 gcc-14
x86_64 randconfig-002-20251018 gcc-14
x86_64 randconfig-003-20251018 gcc-14
x86_64 randconfig-004-20251018 gcc-14
x86_64 randconfig-005-20251018 gcc-14
x86_64 randconfig-006-20251018 gcc-14
x86_64 randconfig-007-20251018 gcc-14
x86_64 randconfig-008-20251018 gcc-14
x86_64 randconfig-071-20251018 clang-20
x86_64 randconfig-072-20251018 clang-20
x86_64 randconfig-073-20251018 clang-20
x86_64 randconfig-074-20251018 clang-20
x86_64 randconfig-075-20251018 clang-20
x86_64 randconfig-076-20251018 clang-20
x86_64 randconfig-077-20251018 clang-20
x86_64 randconfig-078-20251018 clang-20
x86_64 rhel-9.4 clang-20
x86_64 rhel-9.4-func clang-20
x86_64 rhel-9.4-kselftests clang-20
x86_64 rhel-9.4-rust clang-20
xtensa allnoconfig gcc-15.1.0
xtensa randconfig-001-20251018 gcc-13.4.0
xtensa randconfig-002-20251018 gcc-8.5.0
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply
* Re: [PATCH v2 0/2] Input: Remove dev_err_probe() if error is -ENOMEM
From: Dmitry Torokhov @ 2025-10-18 4:44 UTC (permalink / raw)
To: Xichao Zhao
Cc: Heiko Stuebner,
open list:INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN)...,
open list
In-Reply-To: <20250822034751.244248-1-zhao.xichao@vivo.com>
On Fri, Aug 22, 2025 at 11:47:47AM +0800, Xichao Zhao wrote:
> The dev_err_probe() doesn't do anything when error is '-ENOMEM'.
> Therefore, remove the useless call to dev_err_probe(), and just
> return the value instead.
Adjusted the subjects and applied the lot, thank you.
Thanks.
--
Dmitry
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox