* [PATCH 8/9] arm64: dts: mediatek: mt8395-genio-common: use MT6365 PMIC definitions
From: Louis-Alexis Eyraud @ 2026-04-29 9:44 UTC (permalink / raw)
To: Sen Chu, Sean Wang, Macpaul Lin, Lee Jones, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, Dmitry Torokhov, Chen Zhong,
Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko
Cc: kernel, linux-pm, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-input, linux-iio, Louis-Alexis Eyraud
In-Reply-To: <20260429-mediatek-genio-mt6365-cleanup-v1-0-6f43838be92f@collabora.com>
Mediatek Genio 1200 EVK board integrates a MT6365 PMIC, compatible
with MT6359, but the board common definition include file (for the eMMC
and UFS configurations) used the mt6359.dtsi to enable its support
since the board support was introduced.
Now that mt6365.dtsi has been created, include it instead of mt6359.dtsi
and use MT6365 labels and pmic key compatible too.
Signed-off-by: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>
---
arch/arm64/boot/dts/mediatek/mt8395-genio-common.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8395-genio-common.dtsi b/arch/arm64/boot/dts/mediatek/mt8395-genio-common.dtsi
index 62c336e21500..6df614c471fc 100644
--- a/arch/arm64/boot/dts/mediatek/mt8395-genio-common.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8395-genio-common.dtsi
@@ -7,7 +7,7 @@
/dts-v1/;
#include "mt8195.dtsi"
-#include "mt6359.dtsi"
+#include "mt6365.dtsi"
#include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/input/input.h>
#include <dt-bindings/interrupt-controller/irq.h>
@@ -728,7 +728,7 @@ &mt6359_vsram_others_ldo_reg {
regulator-max-microvolt = <750000>;
};
-&mt6359codec {
+&mt6365codec {
mediatek,mic-type-0 = <1>; /* ACC */
mediatek,mic-type-1 = <3>; /* DCC */
mediatek,mic-type-2 = <1>; /* ACC */
@@ -1151,8 +1151,8 @@ pins {
&pmic {
interrupts-extended = <&pio 222 IRQ_TYPE_LEVEL_HIGH>;
- mt6359keys: keys {
- compatible = "mediatek,mt6359-keys";
+ mt6365keys: keys {
+ compatible = "mediatek,mt6365-keys", "mediatek,mt6359-keys";
mediatek,long-press-mode = <1>;
power-off-time-sec = <0>;
--
2.54.0
^ permalink raw reply related
* [PATCH 7/9] arm64: dts: mediatek: mt8390-genio-common: use MT6365 PMIC definitions
From: Louis-Alexis Eyraud @ 2026-04-29 9:44 UTC (permalink / raw)
To: Sen Chu, Sean Wang, Macpaul Lin, Lee Jones, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, Dmitry Torokhov, Chen Zhong,
Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko
Cc: kernel, linux-pm, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-input, linux-iio, Louis-Alexis Eyraud
In-Reply-To: <20260429-mediatek-genio-mt6365-cleanup-v1-0-6f43838be92f@collabora.com>
Mediatek Genio 510 and 700 EVK boards integrate a MT6365 PMIC,
compatible with MT6359, but the board common definition include file
used the mt6359.dtsi to enable its support since the board support was
introduced.
Now that mt6365.dtsi has been created, include it instead of mt6359.dtsi
and use MT6365 labels and pmic key compatible too.
Signed-off-by: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>
---
arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi b/arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi
index 2062506f6cc5..5303add717bf 100644
--- a/arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi
@@ -10,7 +10,7 @@
* AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
*/
-#include "mt6359.dtsi"
+#include "mt6365.dtsi"
#include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/input/input.h>
#include <dt-bindings/interrupt-controller/irq.h>
@@ -695,7 +695,7 @@ &mt6359_vufs_ldo_reg {
regulator-always-on;
};
-&mt6359codec {
+&mt6365codec {
mediatek,mic-type-0 = <1>; /* ACC */
mediatek,mic-type-1 = <3>; /* DCC */
};
@@ -1281,8 +1281,8 @@ &pmic {
interrupt-parent = <&pio>;
interrupts = <222 IRQ_TYPE_LEVEL_HIGH>;
- mt6359keys: keys {
- compatible = "mediatek,mt6359-keys";
+ mt6365keys: keys {
+ compatible = "mediatek,mt6365-keys", "mediatek,mt6359-keys";
mediatek,long-press-mode = <1>;
power-off-time-sec = <0>;
--
2.54.0
^ permalink raw reply related
* [PATCH 6/9] arm64: dts: mediatek: add MT6365 PMIC include
From: Louis-Alexis Eyraud @ 2026-04-29 9:44 UTC (permalink / raw)
To: Sen Chu, Sean Wang, Macpaul Lin, Lee Jones, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, Dmitry Torokhov, Chen Zhong,
Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko
Cc: kernel, linux-pm, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-input, linux-iio, Louis-Alexis Eyraud
In-Reply-To: <20260429-mediatek-genio-mt6365-cleanup-v1-0-6f43838be92f@collabora.com>
The MT6365 PMIC, compatible with MT6359 PMIC, never had its own include
file so the boards that integrates this PMIC used mt6359.dtsi in their
devicetree to enable its support.
So, add the mt6365 include file for the MT6365 definitions and labels.
In order not to duplicate all of them, make it include mt6359.dtsi and
override the compatible strings for the MFD main and sub devices with
the MT6365 ones.
Signed-off-by: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>
---
arch/arm64/boot/dts/mediatek/mt6365.dtsi | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt6365.dtsi b/arch/arm64/boot/dts/mediatek/mt6365.dtsi
new file mode 100644
index 000000000000..ed4e349f63c9
--- /dev/null
+++ b/arch/arm64/boot/dts/mediatek/mt6365.dtsi
@@ -0,0 +1,26 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+/*
+ * Copyright (C) 2026 MediaTek Inc.
+ */
+
+#include "mt6359.dtsi"
+
+&pmic {
+ compatible = "mediatek,mt6365", "mediatek,mt6359";
+};
+
+&pmic_adc {
+ compatible = "mediatek,mt6365-auxadc", "mediatek,mt6359-auxadc";
+};
+
+mt6365codec: &mt6359codec {
+ compatible = "mediatek,mt6365-codec", "mediatek,mt6359-codec";
+};
+
+mt6365regulators: &mt6359regulators {
+ compatible = "mediatek,mt6365-regulator", "mediatek,mt6359-regulator";
+};
+
+mt6365rtc: &mt6359rtc{
+ compatible = "mediatek,mt6365-rtc", "mediatek,mt6358-rtc";
+};
--
2.54.0
^ permalink raw reply related
* [PATCH 5/9] arm64: dts: mediatek: mt6359: use proper compatible for rtc
From: Louis-Alexis Eyraud @ 2026-04-29 9:44 UTC (permalink / raw)
To: Sen Chu, Sean Wang, Macpaul Lin, Lee Jones, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, Dmitry Torokhov, Chen Zhong,
Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko
Cc: kernel, linux-pm, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-input, linux-iio, Louis-Alexis Eyraud
In-Reply-To: <20260429-mediatek-genio-mt6365-cleanup-v1-0-6f43838be92f@collabora.com>
The MT6359 PMIC include file uses directly "mediatek,mt6358-rtc"
compatible string for the rtc subnode, but not its own compatible
string.
Now that the "mediatek,mt6359-rtc" compatible is properly declared in
the dt-bindings, use it with "mediatek,mt6358-rtc" as fallback.
Signed-off-by: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>
---
arch/arm64/boot/dts/mediatek/mt6359.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt6359.dtsi b/arch/arm64/boot/dts/mediatek/mt6359.dtsi
index 45ad69ee49ed..c279b3372eda 100644
--- a/arch/arm64/boot/dts/mediatek/mt6359.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt6359.dtsi
@@ -19,7 +19,7 @@ mt6359codec: audio-codec {
compatible = "mediatek,mt6359-codec";
};
- regulators {
+ mt6359regulators: regulators {
compatible = "mediatek,mt6359-regulator";
mt6359_vs1_buck_reg: buck_vs1 {
@@ -301,7 +301,7 @@ mt6359_vsram_others_sshub_ldo: ldo_vsram_others_sshub {
};
mt6359rtc: rtc {
- compatible = "mediatek,mt6358-rtc";
+ compatible = "mediatek,mt6359-rtc", "mediatek,mt6358-rtc";
};
};
};
--
2.54.0
^ permalink raw reply related
* [PATCH 4/9] dt-bindings: iio: adc: mt6359: Add MT6365 PMIC AuxADC
From: Louis-Alexis Eyraud @ 2026-04-29 9:44 UTC (permalink / raw)
To: Sen Chu, Sean Wang, Macpaul Lin, Lee Jones, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, Dmitry Torokhov, Chen Zhong,
Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko
Cc: kernel, linux-pm, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-input, linux-iio, Louis-Alexis Eyraud
In-Reply-To: <20260429-mediatek-genio-mt6365-cleanup-v1-0-6f43838be92f@collabora.com>
Add compatible string for the AuxADC block found on the MT6365 PMIC,
that is compatible with the one found in MT6359.
Signed-off-by: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>
---
.../bindings/iio/adc/mediatek,mt6359-auxadc.yaml | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/iio/adc/mediatek,mt6359-auxadc.yaml b/Documentation/devicetree/bindings/iio/adc/mediatek,mt6359-auxadc.yaml
index 5d4ab701f51a..9936aa605c7b 100644
--- a/Documentation/devicetree/bindings/iio/adc/mediatek,mt6359-auxadc.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/mediatek,mt6359-auxadc.yaml
@@ -18,12 +18,17 @@ description:
properties:
compatible:
- enum:
- - mediatek,mt6357-auxadc
- - mediatek,mt6358-auxadc
- - mediatek,mt6359-auxadc
- - mediatek,mt6363-auxadc
- - mediatek,mt6373-auxadc
+ oneOf:
+ - enum:
+ - mediatek,mt6357-auxadc
+ - mediatek,mt6358-auxadc
+ - mediatek,mt6359-auxadc
+ - mediatek,mt6363-auxadc
+ - mediatek,mt6373-auxadc
+ - items:
+ - enum:
+ - mediatek,mt6365-auxadc
+ - const: mediatek,mt6359-auxadc
"#io-channel-cells":
const: 1
--
2.54.0
^ permalink raw reply related
* [PATCH 3/9] dt-bindings: input: mediatek,pmic-keys: Add MT6365 support
From: Louis-Alexis Eyraud @ 2026-04-29 9:44 UTC (permalink / raw)
To: Sen Chu, Sean Wang, Macpaul Lin, Lee Jones, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, Dmitry Torokhov, Chen Zhong,
Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko
Cc: kernel, linux-pm, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-input, linux-iio, Louis-Alexis Eyraud
In-Reply-To: <20260429-mediatek-genio-mt6365-cleanup-v1-0-6f43838be92f@collabora.com>
Add compatible string for the pmic keys block found on the MT6365 PMIC,
that is compatible with the one found in MT6359.
Signed-off-by: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>
---
.../bindings/input/mediatek,pmic-keys.yaml | 21 +++++++++++++--------
1 file changed, 13 insertions(+), 8 deletions(-)
diff --git a/Documentation/devicetree/bindings/input/mediatek,pmic-keys.yaml b/Documentation/devicetree/bindings/input/mediatek,pmic-keys.yaml
index b95435bd6a9b..140a862ecfbe 100644
--- a/Documentation/devicetree/bindings/input/mediatek,pmic-keys.yaml
+++ b/Documentation/devicetree/bindings/input/mediatek,pmic-keys.yaml
@@ -23,14 +23,19 @@ description: |
properties:
compatible:
- enum:
- - mediatek,mt6323-keys
- - mediatek,mt6328-keys
- - mediatek,mt6331-keys
- - mediatek,mt6357-keys
- - mediatek,mt6358-keys
- - mediatek,mt6359-keys
- - mediatek,mt6397-keys
+ oneOf:
+ - enum:
+ - mediatek,mt6323-keys
+ - mediatek,mt6328-keys
+ - mediatek,mt6331-keys
+ - mediatek,mt6357-keys
+ - mediatek,mt6358-keys
+ - mediatek,mt6359-keys
+ - mediatek,mt6397-keys
+ - items:
+ - enum:
+ - mediatek,mt6365-keys
+ - const: mediatek,mt6359-keys
power-off-time-sec: true
--
2.54.0
^ permalink raw reply related
* [PATCH 2/9] dt-bindings: mfd: mediatek: mt6397: Add MT6365 PMIC support
From: Louis-Alexis Eyraud @ 2026-04-29 9:44 UTC (permalink / raw)
To: Sen Chu, Sean Wang, Macpaul Lin, Lee Jones, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, Dmitry Torokhov, Chen Zhong,
Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko
Cc: kernel, linux-pm, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-input, linux-iio, Louis-Alexis Eyraud
In-Reply-To: <20260429-mediatek-genio-mt6365-cleanup-v1-0-6f43838be92f@collabora.com>
MT6365 PMIC is compatible with MT6359, so add the compatible strings
for the main and sub devices (regulator, rtc, audio codec).
Signed-off-by: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>
---
Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml b/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
index dc2b38cf285d..122aba7a54f8 100644
--- a/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
+++ b/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
@@ -44,6 +44,10 @@ properties:
- enum:
- mediatek,mt6366
- const: mediatek,mt6358
+ - items:
+ - enum:
+ - mediatek,mt6365
+ - const: mediatek,mt6359
interrupts:
maxItems: 1
@@ -71,6 +75,7 @@ properties:
- items:
- enum:
- mediatek,mt6359-rtc
+ - mediatek,mt6365-rtc
- mediatek,mt6366-rtc
- const: mediatek,mt6358-rtc
@@ -99,6 +104,10 @@ properties:
- enum:
- mediatek,mt6366-regulator
- const: mediatek,mt6358-regulator
+ - items:
+ - enum:
+ - mediatek,mt6365-regulator
+ - const: mediatek,mt6359-regulator
required:
- compatible
@@ -125,6 +134,10 @@ properties:
- enum:
- mediatek,mt6366-sound
- const: mediatek,mt6358-sound
+ - items:
+ - enum:
+ - mediatek,mt6365-codec
+ - const: mediatek,mt6359-codec
required:
- compatible
--
2.54.0
^ permalink raw reply related
* [PATCH 1/9] dt-bindings: mfd: mediatek: mt6397: Add rtc for MT6359
From: Louis-Alexis Eyraud @ 2026-04-29 9:44 UTC (permalink / raw)
To: Sen Chu, Sean Wang, Macpaul Lin, Lee Jones, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, Dmitry Torokhov, Chen Zhong,
Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko
Cc: kernel, linux-pm, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-input, linux-iio, Louis-Alexis Eyraud
In-Reply-To: <20260429-mediatek-genio-mt6365-cleanup-v1-0-6f43838be92f@collabora.com>
The rtc block of MT6359 PMIC is compatible with the one found in MT6358
but this compatibility was never expressed in the dt-bindings, so add
the missing compatible string for the rtc subnode.
Signed-off-by: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>
---
Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml b/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
index 05c121b0cb3d..dc2b38cf285d 100644
--- a/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
+++ b/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
@@ -70,6 +70,7 @@ properties:
- mediatek,mt6397-rtc
- items:
- enum:
+ - mediatek,mt6359-rtc
- mediatek,mt6366-rtc
- const: mediatek,mt6358-rtc
--
2.54.0
^ permalink raw reply related
* [PATCH 0/9] MT6365 PMIC support cleanup
From: Louis-Alexis Eyraud @ 2026-04-29 9:44 UTC (permalink / raw)
To: Sen Chu, Sean Wang, Macpaul Lin, Lee Jones, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, Dmitry Torokhov, Chen Zhong,
Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko
Cc: kernel, linux-pm, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-input, linux-iio, Louis-Alexis Eyraud
Several Mediatek and Radxa boards, based on MT8370, MT8390 or MT8395
SoC, integrate the MT6365 PMIC, that is a MT6359P variant:
- Mediatek Genio 1200-EVK
- Mediatek Genio 700-EVK
- Mediatek Genio 510-EVK
- Radxa NIO-12L
It is compatible with the MT6359 PMIC.
But both MT6365 PMIC support and compatibility were never expressed in
the dt-bindings and there is no MT6365 include file as well.
So, since these board support was introduced, their devicetrees use the
mt6359 include file to enable this PMIC support.
The goal of this series is to clean this support by adding the missing
compatible strings for this MFD main and subdevices in the dt-bindings,
and add a include for MT6365 definitions to replace the MT6359 include
in these board devicetrees and for future ones (like Genio 520/720
EVKs).
The series is based on linux-next tree (tag: next-20260428) and has
been tested on Mediatek Genio 510, 700 and 1200-EVK boards.
---
Louis-Alexis Eyraud (9):
dt-bindings: mfd: mediatek: mt6397: Add rtc for MT6359
dt-bindings: mfd: mediatek: mt6397: Add MT6365 PMIC support
dt-bindings: input: mediatek,pmic-keys: Add MT6365 support
dt-bindings: iio: adc: mt6359: Add MT6365 PMIC AuxADC
arm64: dts: mediatek: mt6359: use proper compatible for rtc
arm64: dts: mediatek: add MT6365 PMIC include
arm64: dts: mediatek: mt8390-genio-common: use MT6365 PMIC definitions
arm64: dts: mediatek: mt8395-genio-common: use MT6365 PMIC definitions
arm64: dts: mediatek: mt8395-radxa-nio-12l: use MT6365 PMIC definitions
.../bindings/iio/adc/mediatek,mt6359-auxadc.yaml | 17 +++++++++-----
.../bindings/input/mediatek,pmic-keys.yaml | 21 ++++++++++-------
.../devicetree/bindings/mfd/mediatek,mt6397.yaml | 14 ++++++++++++
arch/arm64/boot/dts/mediatek/mt6359.dtsi | 4 ++--
arch/arm64/boot/dts/mediatek/mt6365.dtsi | 26 ++++++++++++++++++++++
.../boot/dts/mediatek/mt8390-genio-common.dtsi | 8 +++----
.../boot/dts/mediatek/mt8395-genio-common.dtsi | 8 +++----
.../boot/dts/mediatek/mt8395-radxa-nio-12l.dts | 6 ++---
8 files changed, 77 insertions(+), 27 deletions(-)
---
base-commit: 0f3ef35b0747832b58b97171bad99011d084c6b1
change-id: 20260428-mediatek-genio-mt6365-cleanup-6cdd84c3f098
Best regards,
--
Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>
^ permalink raw reply
* [PATCH resend] xpad: Add "Nova 2 Lite" from GameSir
From: Qbeliw Tanaka @ 2026-04-29 7:20 UTC (permalink / raw)
To: dmitry.torokhov; +Cc: linux-input, q.tanaka
In-Reply-To: <20260211.101707.2126959894059795107.q.tanaka@gmx.com>
Add support for the gamepad "Nova 2 Lite" from GameSir, compatible with the Xbox 360 gamepad.
Signed-off-by: Qbeliw Tanaka <q.tanaka@gmx.com>
---
drivers/input/joystick/xpad.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
index 363d50949..8d96349c3 100644
--- a/drivers/input/joystick/xpad.c
+++ b/drivers/input/joystick/xpad.c
@@ -421,6 +421,7 @@ static const struct xpad_device {
{ 0x3285, 0x0662, "Nacon Revolution5 Pro", 0, XTYPE_XBOX360 },
{ 0x3285, 0x0663, "Nacon Evol-X", 0, XTYPE_XBOXONE },
{ 0x3537, 0x1004, "GameSir T4 Kaleid", 0, XTYPE_XBOX360 },
+ { 0x3537, 0x100f, "GameSir Nova 2 Lite", 0, XTYPE_XBOX360 },
{ 0x3537, 0x1010, "GameSir G7 SE", 0, XTYPE_XBOXONE },
{ 0x3651, 0x1000, "CRKD SG", 0, XTYPE_XBOX360 },
{ 0x366c, 0x0005, "ByoWave Proteus Controller", MAP_SHARE_BUTTON, XTYPE_XBOXONE, FLAG_DELAY_INIT },
--
2.52.0
^ permalink raw reply related
* Re: [PATCH] [v2] input: gpio-keys: make legacy gpiolib optional
From: Matti Vaittinen @ 2026-04-29 6:25 UTC (permalink / raw)
To: Dmitry Torokhov, Arnd Bergmann
Cc: Lee Jones, Arnd Bergmann, Gatien Chevallier, Marco Crivellari,
Fabrice Gasnier, Andreas Kemnade, Krzysztof Kozlowski,
Charles Keepax, Christophe JAILLET, linux-input, linux-kernel
In-Reply-To: <afAz-UQY0aCaThV3@google.com>
Hi deee Ho,
On 28/04/2026 07:14, Dmitry Torokhov wrote:
> On Mon, Apr 27, 2026 at 04:33:49PM +0200, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> Most users of gpio-keys and gpio-keys-polled use modern gpiolib
>> interfaces, but there are still number of ancient sh, arm32 and x86
>> machines that have never been converted.
>>
>> Add an #ifdef block for the parts of the driver that are only used on
>> those legacy machines.
>>
>> The two Rohm PMIC drivers use a gpio-keys device without an actual GPIO,
>> passing an IRQ number instead. In order to keep this working both with
>> and with CONFIG_GPIOLIB_LEGACY, change the gpio-keys driver to ignore
>> the gpio number if an IRQ is passed.
>>
>> Link: https://lore.kernel.org/all/b3c94552-c104-42e3-be15-7e8362e8039e@gmail.com/
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>> v2: skip the fake GPIO number passing from mfd
>> ---
>> drivers/input/keyboard/gpio_keys.c | 7 ++++---
>> drivers/input/keyboard/gpio_keys_polled.c | 2 ++
>> drivers/mfd/rohm-bd71828.c | 1 -
>> drivers/mfd/rohm-bd718x7.c | 1 -
>
> Let's see if my patches to rohm drivers will get accepted and then maybe
> we can remove legacy gpio API from gpio-keys altogether.
What comes to the ROHM drivers, I am ok with the "swnode stuff" proposed
by Dmitry (if it helps with cropping some legacy). Still, from the ROHM
driver POV, I sure have no problems with just simple zeroing the gpios
and providing the IRQ which in driver side is clean(ish) and simpl(ish) :)
So, in case someone opposes Dmitry's changes, for ROHM drivers:
Acked-by: Matti Vaittinen <mazziesaccount@gmail.com>
--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland
~~ When things go utterly wrong vim users can always type :help! ~~
^ permalink raw reply
* Re: [PATCH v2 2/7] iio: accel: HID: Replace method accel_3d_adjust_channel_bit_mask()
From: Jonathan Cameron @ 2026-04-28 18:12 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Natália Salvino André, andy, bentiss, dlechner, jikos,
nuno.sa, srinivas.pandruvada, Pietro Di Consolo Gregorio,
linux-iio, linux-input
In-Reply-To: <ae8upGN9ILmtCzeA@ashevche-desk.local>
On Mon, 27 Apr 2026 12:38:44 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Fri, Apr 24, 2026 at 08:08:47PM +0100, Jonathan Cameron wrote:
> > On Wed, 22 Apr 2026 12:07:07 +0300
> > Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> > > On Tue, Apr 21, 2026 at 07:20:34PM -0300, Natália Salvino André wrote:
>
> ...
>
> > > > - accel_3d_adjust_channel_bit_mask(channels,
> > > > - CHANNEL_SCAN_INDEX_X + i,
> > > > - st->accel[CHANNEL_SCAN_INDEX_X + i].size);
> > > > + hid_sensor_adjust_channel_bit_mask(channels,
> > > > + CHANNEL_SCAN_INDEX_X + i,
> > > > + st->accel[CHANNEL_SCAN_INDEX_X + i].size);
> > >
> > > Indentation is broken. Taking into account that the last line is too long when
> > > properly indented, perhaps
> > >
> > > hid_sensor_adjust_channel_bit_mask(channels,
> > > CHANNEL_SCAN_INDEX_X + i,
> > > st->accel[CHANNEL_SCAN_INDEX_X + i].size);
> > >
> > > Which makes it most right and under 80 limit.
>
> > Why the double tab? Maybe just go long on this one and align after the (
>
> I never know when you are strict about 80 limit :-)
>
I was meaning vs single tab really.
You are slowly wearing me down on the 80 limit by pointing out lots of
cases where going beyond it really helps! ;)
^ permalink raw reply
* Re: [PATCH v4 2/6 RESEND] dt-bindings: input: cpcap-pwrbutton: convert to DT schema
From: Rob Herring (Arm) @ 2026-04-28 17:15 UTC (permalink / raw)
To: Svyatoslav Ryhel
Cc: Conor Dooley, linux-leds, devicetree, linux-kernel, Tony Lindgren,
Krzysztof Kozlowski, David Lechner, Lee Jones, Dmitry Torokhov,
linux-input, Pavel Machek
In-Reply-To: <20260428153611.142816-3-clamor95@gmail.com>
On Tue, 28 Apr 2026 18:36:07 +0300, Svyatoslav Ryhel wrote:
> Convert power button devicetree bindings for the Motorola CPCAP MFD from
> TXT to YAML format. This patch does not change any functionality; the
> bindings remain the same.
>
> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> .../bindings/input/cpcap-pwrbutton.txt | 20 ------------
> .../input/motorola,cpcap-pwrbutton.yaml | 32 +++++++++++++++++++
> 2 files changed, 32 insertions(+), 20 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/input/cpcap-pwrbutton.txt
> create mode 100644 Documentation/devicetree/bindings/input/motorola,cpcap-pwrbutton.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
doc reference errors (make refcheckdocs):
Warning: Documentation/devicetree/bindings/input/motorola,cpcap-pwrbutton.yaml references a file that doesn't exist: Documentation/devicetree/bindings/mfd/motorola,cpcap.yaml
Warning: Documentation/devicetree/bindings/mfd/motorola-cpcap.txt references a file that doesn't exist: Documentation/devicetree/bindings/input/cpcap-pwrbutton.txt
Documentation/devicetree/bindings/input/motorola,cpcap-pwrbutton.yaml: Documentation/devicetree/bindings/mfd/motorola,cpcap.yaml
Documentation/devicetree/bindings/mfd/motorola-cpcap.txt: Documentation/devicetree/bindings/input/cpcap-pwrbutton.txt
See https://patchwork.kernel.org/project/devicetree/patch/20260428153611.142816-3-clamor95@gmail.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply
* Re: [PATCH v4 1/6 RESEND] dt-bindings: leds: leds-cpcap: convert to DT schema
From: Rob Herring (Arm) @ 2026-04-28 17:15 UTC (permalink / raw)
To: Svyatoslav Ryhel
Cc: Pavel Machek, Lee Jones, Dmitry Torokhov, linux-input,
Krzysztof Kozlowski, David Lechner, Conor Dooley, devicetree,
Tony Lindgren, linux-kernel, linux-leds
In-Reply-To: <20260428153611.142816-2-clamor95@gmail.com>
On Tue, 28 Apr 2026 18:36:06 +0300, Svyatoslav Ryhel wrote:
> Convert LEDs devicetree bindings for the Motorola CPCAP MFD from TXT to
> YAML format. This patch does not change any functionality; the bindings
> remain the same.
>
> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> .../devicetree/bindings/leds/leds-cpcap.txt | 29 -------------
> .../bindings/leds/motorola,cpcap-leds.yaml | 42 +++++++++++++++++++
> 2 files changed, 42 insertions(+), 29 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/leds/leds-cpcap.txt
> create mode 100644 Documentation/devicetree/bindings/leds/motorola,cpcap-leds.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
doc reference errors (make refcheckdocs):
Warning: Documentation/devicetree/bindings/leds/motorola,cpcap-leds.yaml references a file that doesn't exist: Documentation/devicetree/bindings/mfd/motorola,cpcap.yaml
Warning: Documentation/devicetree/bindings/mfd/motorola-cpcap.txt references a file that doesn't exist: Documentation/devicetree/bindings/leds/leds-cpcap.txt
Documentation/devicetree/bindings/leds/motorola,cpcap-leds.yaml: Documentation/devicetree/bindings/mfd/motorola,cpcap.yaml
Documentation/devicetree/bindings/mfd/motorola-cpcap.txt: Documentation/devicetree/bindings/leds/leds-cpcap.txt
See https://patchwork.kernel.org/project/devicetree/patch/20260428153611.142816-2-clamor95@gmail.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply
* Re: [PATCH 0/2] HID: appletb-kbd: fix UAF and mutex-in-atomic in inactivity timer
From: Aditya Garg @ 2026-04-28 16:44 UTC (permalink / raw)
To: Jiri Kosina; +Cc: Sangyun Kim, bentiss, qasdev00, linux-input, linux-kernel
In-Reply-To: <s3qr2s36-n156-4srp-771s-20130s13760r@xreary.bet>
On 28 April 2026 10:03:03 pm IST, Jiri Kosina <jikos@kernel.org> wrote:
>On Mon, 20 Apr 2026, Aditya Garg wrote:
>
>> > This series addresses two defects in hid-appletb-kbd's inactivity
>> > timer subsystem. The two patches target different bugs and are
>> > logically independent; they are sent together because they touch the
>> > same tear-down code and because the same maintainer will review both.
>> >
>> > Patch 1 fixes a slab use-after-free with two related tear-down windows
>> > introduced by commit 38224c472a03 ("HID: appletb-kbd: fix slab
>> > use-after-free bug in appletb_kbd_probe"):
>> >
>> > A) Within "if (kbd->backlight_dev)" the order was
>> > put_device() then timer_delete_sync(). A concurrent
>> > hid_appletb_bl unbind between those two calls can drop the last
>> > devm reference and free the backlight_device; the still-armed
>> > inactivity timer softirq then dereferences the freed object
>> > through backlight_device_set_brightness() -> mutex_lock(&ops_lock).
>> >
>> > B) The "if (kbd->backlight_dev)" block ran before
>> > hid_hw_close()/hid_hw_stop(), so even after window A is closed a
>> > late ".event" callback from the HID core (USB URB completion on
>> > real hardware) can arrive between timer_delete_sync() and
>> > put_device(), reach reset_inactivity_timer(), re-arm the timer
>> > via mod_timer(), and reopen the same UAF.
>> >
>> > Both windows produce the same KASAN slab-use-after-free on the object
>> > allocated by devm_backlight_device_register(). Patch 1 closes them
>> > together by moving hid_hw_close()/hid_hw_stop() before the backlight
>> > cleanup and, inside that cleanup block, calling timer_delete_sync()
>> > before put_device(). Shipping both as one commit avoids leaving
>> > stable kernels in a half-fixed state where only window A is closed.
>> >
>> > Patch 2 fixes a separate "sleeping function called from invalid
>> > context" bug in the same subsystem. The inactivity timer is a
>> > struct timer_list, so the callback runs in softirq context and calls
>> > backlight_device_set_brightness() -> mutex_lock() from atomic
>> > context; reset_inactivity_timer() has the same issue on the
>> > brightness-restore path (it is called from appletb_kbd_hid_event()
>> > and appletb_kbd_inp_event(), which run in softirq/IRQ context on
>> > real USB hardware). Convert the inactivity timer to a delayed_work
>> > and defer the brightness-restore call to a dedicated work_struct so
>> > both sleeping calls run in process context.
>> >
>> > Sangyun Kim (2):
>> > HID: appletb-kbd: fix UAF in inactivity-timer cleanup path
>> > HID: appletb-kbd: run inactivity autodim from workqueues
>> >
>> > drivers/hid/hid-appletb-kbd.c | 56 ++++++++++++++++++++++-------------
>> > 1 file changed, 36 insertions(+), 20 deletions(-)
>> >
>>
>> I had a very weird bug just once. And that was when I pressed fn key, upon
>> releasing, the touchbar mode did not restore to normal.
>
>You mean with this patch applied, correct?
Yes after applying that patch.
>
^ permalink raw reply
* Re: [PATCH] HID: uclogic: Fix regression of input name assignment
From: Jiri Kosina @ 2026-04-28 16:37 UTC (permalink / raw)
To: Takashi Iwai; +Cc: Benjamin Tissoires, Henry Martin, linux-input, linux-kernel
In-Reply-To: <20260428083321.126674-1-tiwai@suse.de>
On Tue, 28 Apr 2026, Takashi Iwai wrote:
> The previous fix for adding the devm_kasprintf() return check in the
> commit bd07f751208b ("HID: uclogic: Add NULL check in
> uclogic_input_configured()") changed the condition of hi->input->name
> assignment, and it resulted in missing the proper input device name
> when no custom suffix is defined.
>
> Restore the conditional to the original content to address the
> regression.
>
> Fixes: bd07f751208b ("HID: uclogic: Add NULL check in uclogic_input_configured()")
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Applied to hid.git#for-7.1/upstream-fixes, thanks Takashi.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply
* Re: [PATCH] HID: intel-thc-hid: Intel-quickspi: Fix some error codes
From: Jiri Kosina @ 2026-04-28 16:35 UTC (permalink / raw)
To: Dan Carpenter
Cc: Even Xu, Xinpeng Sun, Benjamin Tissoires, Mark Pearson,
Srinivas Pandruvada, linux-input, linux-kernel, kernel-janitors
In-Reply-To: <aenFyk36rTnrD9s3@stanley.mountain>
On Thu, 23 Apr 2026, Dan Carpenter wrote:
> If we have a partial read that is supposed to be treated as failure but
> in this code we forgot to set the error code. Return -EINVAL.
>
> Fixes: 9d8d51735a3a ("HID: intel-thc-hid: intel-quickspi: Add HIDSPI protocol implementation")
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Applied to hid.git#for-7.1/upstream-fixes, thanks Dan.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply
* Re: [PATCH] HID: hid-lenovo-go-s: restore OS_TYPE after resume from s2idle
From: Jiri Kosina @ 2026-04-28 16:34 UTC (permalink / raw)
To: Matthew Schwartz
Cc: derekjohn.clark, bentiss, mpearson-lenovo, linux-input,
linux-kernel
In-Reply-To: <20260420181522.521627-1-matthew.schwartz@linux.dev>
On Mon, 20 Apr 2026, Matthew Schwartz wrote:
> The controller MCU does not persist OS_TYPE across power cycles. During
> s2idle resume, the USB device may be power-cycled, causing the OS_TYPE
> setting to revert to the default Windows value.
>
> Add a reset_resume callback so that this is correctly restored after
> resume.
>
> Reviewed-by: Derek J. Clark <derekjohn.clark@gmail.com>
> Signed-off-by: Matthew Schwartz <matthew.schwartz@linux.dev>
Applied, thanks. Next time, please don't forget to add Fixes: tag as well.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply
* Re: [PATCH 0/2] HID: appletb-kbd: fix UAF and mutex-in-atomic in inactivity timer
From: Jiri Kosina @ 2026-04-28 16:33 UTC (permalink / raw)
To: Aditya Garg; +Cc: Sangyun Kim, bentiss, qasdev00, linux-input, linux-kernel
In-Reply-To: <MAUPR01MB115460F44776CC8E5E5EE7DC4B82F2@MAUPR01MB11546.INDPRD01.PROD.OUTLOOK.COM>
On Mon, 20 Apr 2026, Aditya Garg wrote:
> > This series addresses two defects in hid-appletb-kbd's inactivity
> > timer subsystem. The two patches target different bugs and are
> > logically independent; they are sent together because they touch the
> > same tear-down code and because the same maintainer will review both.
> >
> > Patch 1 fixes a slab use-after-free with two related tear-down windows
> > introduced by commit 38224c472a03 ("HID: appletb-kbd: fix slab
> > use-after-free bug in appletb_kbd_probe"):
> >
> > A) Within "if (kbd->backlight_dev)" the order was
> > put_device() then timer_delete_sync(). A concurrent
> > hid_appletb_bl unbind between those two calls can drop the last
> > devm reference and free the backlight_device; the still-armed
> > inactivity timer softirq then dereferences the freed object
> > through backlight_device_set_brightness() -> mutex_lock(&ops_lock).
> >
> > B) The "if (kbd->backlight_dev)" block ran before
> > hid_hw_close()/hid_hw_stop(), so even after window A is closed a
> > late ".event" callback from the HID core (USB URB completion on
> > real hardware) can arrive between timer_delete_sync() and
> > put_device(), reach reset_inactivity_timer(), re-arm the timer
> > via mod_timer(), and reopen the same UAF.
> >
> > Both windows produce the same KASAN slab-use-after-free on the object
> > allocated by devm_backlight_device_register(). Patch 1 closes them
> > together by moving hid_hw_close()/hid_hw_stop() before the backlight
> > cleanup and, inside that cleanup block, calling timer_delete_sync()
> > before put_device(). Shipping both as one commit avoids leaving
> > stable kernels in a half-fixed state where only window A is closed.
> >
> > Patch 2 fixes a separate "sleeping function called from invalid
> > context" bug in the same subsystem. The inactivity timer is a
> > struct timer_list, so the callback runs in softirq context and calls
> > backlight_device_set_brightness() -> mutex_lock() from atomic
> > context; reset_inactivity_timer() has the same issue on the
> > brightness-restore path (it is called from appletb_kbd_hid_event()
> > and appletb_kbd_inp_event(), which run in softirq/IRQ context on
> > real USB hardware). Convert the inactivity timer to a delayed_work
> > and defer the brightness-restore call to a dedicated work_struct so
> > both sleeping calls run in process context.
> >
> > Sangyun Kim (2):
> > HID: appletb-kbd: fix UAF in inactivity-timer cleanup path
> > HID: appletb-kbd: run inactivity autodim from workqueues
> >
> > drivers/hid/hid-appletb-kbd.c | 56 ++++++++++++++++++++++-------------
> > 1 file changed, 36 insertions(+), 20 deletions(-)
> >
>
> I had a very weird bug just once. And that was when I pressed fn key, upon
> releasing, the touchbar mode did not restore to normal.
You mean with this patch applied, correct?
--
Jiri Kosina
SUSE Labs
^ permalink raw reply
* Re: [PATCH] HID: elan: Add support for ELAN SB974D touchpad
From: Jiri Kosina @ 2026-04-28 16:30 UTC (permalink / raw)
To: Damien Dejean
Cc: Benjamin Tissoires, linux-input, linux-kernel, Kornel Dulęba
In-Reply-To: <20260414133858.3992799-1-damiendejean@google.com>
On Tue, 14 Apr 2026, Damien Dejean wrote:
> Elan SB974D touchpad uses ELAN_MT_I2C format to send HID reports. Add an
> entry to match for the device and parse its vendor specific format.
>
> Signed-off-by: Damien Dejean <damiendejean@google.com>
> Signed-off-by: Kornel Dulęba <korneld@google.com>
> ---
> drivers/hid/hid-elan.c | 1 +
> drivers/hid/hid-ids.h | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/hid/hid-elan.c b/drivers/hid/hid-elan.c
> index 76d93fc48f6a..0190ad567ce4 100644
> --- a/drivers/hid/hid-elan.c
> +++ b/drivers/hid/hid-elan.c
> @@ -513,6 +513,7 @@ static const struct hid_device_id elan_devices[] = {
> { HID_USB_DEVICE(USB_VENDOR_ID_ELAN, USB_DEVICE_ID_HP_X2_10_COVER),
> .driver_data = ELAN_HAS_LED },
> { HID_I2C_DEVICE(USB_VENDOR_ID_ELAN, USB_DEVICE_ID_TOSHIBA_CLICK_L9W) },
> + { HID_I2C_DEVICE(USB_VENDOR_ID_ELAN, USB_DEVICE_ID_SB974D) },
> { }
> };
> MODULE_DEVICE_TABLE(hid, elan_devices);
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index 0cf63742315b..8cfec7dced66 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -455,6 +455,7 @@
> #define USB_DEVICE_ID_EDIFIER_QR30 0xa101 /* EDIFIER Hal0 2.0 SE */
>
> #define USB_VENDOR_ID_ELAN 0x04f3
> +#define USB_DEVICE_ID_SB974D 0x0400
> #define USB_DEVICE_ID_TOSHIBA_CLICK_L9W 0x0401
> #define USB_DEVICE_ID_HP_X2 0x074d
> #define USB_DEVICE_ID_HP_X2_10_COVER 0x0755
Applied to hid.git#for-7.1/upstream-fixes, thanks.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply
* Re: [PATCH] HID: sony: add missing size validation for Rock Band 3 Pro instruments
From: Jiri Kosina @ 2026-04-28 16:29 UTC (permalink / raw)
To: Rosalie Wanders; +Cc: Benjamin Tissoires, linux-input, linux-kernel
In-Reply-To: <20260412011203.8921-1-rosalie@mailbox.org>
On Sun, 12 Apr 2026, Rosalie Wanders wrote:
> This commit adds the missing size validation for Rock Band 3 PS3 Pro
> instruments in sony_raw_event(), this prevents a malicious device from
> allowing hid-sony to read out of bounds of the provided buffer.
Applied to hid.git#for-7.1/upstream-fixes, thanks.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply
* Re: [PATCH] HID: sony: add missing size validation for SMK-Link remotes
From: Jiri Kosina @ 2026-04-28 16:27 UTC (permalink / raw)
To: Rosalie Wanders; +Cc: Benjamin Tissoires, linux-input, linux-kernel
In-Reply-To: <20260412010806.7997-2-rosalie@mailbox.org>
On Sun, 12 Apr 2026, Rosalie Wanders wrote:
> This commit adds the missing size validation for SMK-Link remotes in
> sony_raw_event(), this prevents a malicious device from allowing
> hid-sony to read out of bounds of the provided buffer.
>
> I do not own these devices so the size check only forces that the buffer
> is large enough for nsg_mrxu_parse_report().
Applied to hid.git#for-7.1/upstream-fixes, thanks.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply
* Re: [PATCH] HID: sony: remove unneeded WARN_ON() in sony_leds_init()
From: Jiri Kosina @ 2026-04-28 16:25 UTC (permalink / raw)
To: Rosalie Wanders; +Cc: Benjamin Tissoires, linux-input, linux-kernel
In-Reply-To: <20260411153247.5920-2-rosalie@mailbox.org>
On Sat, 11 Apr 2026, Rosalie Wanders wrote:
> This commit removes the unneeded WARN_ON() macro usage in
> sony_leds_init(), this is unneeded because the sony_leds_init() function
> call is already gated behind a SONY_LED_SUPPORT check in
> sony_input_configured()
>
> Signed-off-by: Rosalie Wanders <rosalie@mailbox.org>
Applied to hid.git#for-7.1/upstream-fixes, thanks.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply
* Re: [PATCH v2] HID: ft260: validate i2c input report length
From: Jiri Kosina @ 2026-04-28 16:25 UTC (permalink / raw)
To: Michael Zaidman
Cc: benjamin.tissoires, linux-input, linux-kernel, sebasjosue84
In-Reply-To: <20260411062437.279838-1-michael.zaidman@gmail.com>
On Sat, 11 Apr 2026, Michael Zaidman wrote:
> Add two checks to ft260_raw_event() to prevent out-of-bounds reads
> from malicious or malfunctioning devices:
>
> First, reject reports shorter than the 2-byte header (report ID +
> length fields). Without this, even accessing xfer->length on a
> 1-byte report is an OOB read.
>
> Second, validate xfer->length against the actual data capacity of
> the received HID report. Each I2C data report ID (0xD0 through
> 0xDE) defines a different report size in the HID descriptor, so the
> available payload varies per report. A corrupted length field could
> cause memcpy to read beyond the report buffer.
>
> Reported-by: Sebastián Josué Alba Vives <sebasjosue84@gmail.com>
> Signed-off-by: Michael Zaidman <michael.zaidman@gmail.com>
> ---
> Changes in v2:
> - Add minimum report size check before accessing header fields to
> prevent OOB read on truncated reports (size < 2)
>
> Tested on FT260 with I2C-attached EEPROM (24c02) behind PCA9548
> mux switches. Verified reads of various sizes (1-4 bytes using
> report ID 0xD0, and larger reads using higher report IDs) with
> debug tracing enabled, confirming xfer->length is correctly
> validated against the HID report size for each report ID.
Applied to hid.git#for-7.1/upstream-fixes, thanks Michael.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply
* Re: [PATCH] HID: sony: fix incorrect force-feedback check in sony_suspend()
From: Jiri Kosina @ 2026-04-28 16:23 UTC (permalink / raw)
To: Rosalie Wanders; +Cc: Benjamin Tissoires, linux-input, linux-kernel
In-Reply-To: <20260410195353.4321-2-rosalie@mailbox.org>
On Fri, 10 Apr 2026, Rosalie Wanders wrote:
> This commit fixes the incorrect force-feedback check in sony_suspend(),
> without this the check will always be true due to checking a constant
> define that is never 0.
>
> Signed-off-by: Rosalie Wanders <rosalie@mailbox.org>
> ---
> drivers/hid/hid-sony.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
> index 83e82a0a3327..9cfea6f40ec2 100644
> --- a/drivers/hid/hid-sony.c
> +++ b/drivers/hid/hid-sony.c
> @@ -2456,11 +2456,10 @@ static void sony_remove(struct hid_device *hdev)
> static int sony_suspend(struct hid_device *hdev, pm_message_t message)
> {
> #ifdef CONFIG_SONY_FF
> + struct sony_sc *sc = hid_get_drvdata(hdev);
>
> /* On suspend stop any running force-feedback events */
> - if (SONY_FF_SUPPORT) {
> - struct sony_sc *sc = hid_get_drvdata(hdev);
> -
> + if (sc->quirks & SONY_FF_SUPPORT) {
> sc->left = sc->right = 0;
> sony_send_output_report(sc);
Applied, thanks.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox