From: Jiri Kosina <jikos@kernel.org>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Stefan Achatz <erazor_de@users.sourceforge.net>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: roccat: Mark expected switch fall-through
Date: Tue, 17 Jul 2018 15:53:27 +0200 (CEST) [thread overview]
Message-ID: <nycvar.YFH.7.76.1807171553020.997@cbobk.fhfr.pm> (raw)
In-Reply-To: <20180702182907.GA22465@embeddedor.com>
On Mon, 2 Jul 2018, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/hid/hid-roccat-kone.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hid/hid-roccat-kone.c b/drivers/hid/hid-roccat-kone.c
> index bf4675a..c4dd616 100644
> --- a/drivers/hid/hid-roccat-kone.c
> +++ b/drivers/hid/hid-roccat-kone.c
> @@ -783,6 +783,7 @@ static void kone_keep_values_up_to_date(struct kone_device *kone,
> case kone_mouse_event_switch_profile:
> kone->actual_dpi = kone->profiles[event->value - 1].
> startup_dpi;
> + /* fall through */
> case kone_mouse_event_osd_profile:
> kone->actual_profile = event->value;
> break;
I *think* the fall-through is correct thing to do here, but I'd like to
get explicit Ack from Stefan. Stefan, please?
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2018-07-17 13:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 18:29 [PATCH] HID: roccat: Mark expected switch fall-through Gustavo A. R. Silva
2018-07-17 13:53 ` Jiri Kosina [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-02-11 21:53 Gustavo A. R. Silva
2019-02-19 13:16 ` Jiri Kosina
2019-02-20 8:15 ` Stefan Achatz
2019-02-20 8:40 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.1807171553020.997@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=erazor_de@users.sourceforge.net \
--cc=gustavo@embeddedor.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).